From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50B8F43E42; Thu, 11 Apr 2024 10:42:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAAFF40268; Thu, 11 Apr 2024 10:42:54 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 84E4740262 for ; Thu, 11 Apr 2024 10:42:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712824973; x=1744360973; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=oW+50LFfE3+Edt0Y1wSKzQJmqFtrbOb0WzQkWegN7iM=; b=i30FsKAfNKhckOUNMVn+gjTrsYoGSNhk+Te/iRRsr5i6FTcWMjN9K6ZS eMT18XhPfCUemVyhSJ7Zk94iqSv2fpdcMfG2VfdPfEEbeg83ZIJVqm0lE T6GqasEHG6p8A/BjFOMTdP9xqaxbBmx2wvhVt5JsGpj619FK4edob5Hww mh12pVbVB5zVWst7HR5lM6nkSwiWzLahqkNpqJsX2Fjasa2+fO+fI0PL+ knPbZilgTa6PN3a0ewMBGndzfnLVj5SWXD5YJiN1tHAJrK7kp7sHzOXzP Et/CdZtF6qu7Vf8qzyB0WSNxXwGp+gFqTaz/7X42DqbmB5LnjzG6Mp9+t g==; X-CSE-ConnectionGUID: EVFYAbo9RnGAEH0t1y59Xg== X-CSE-MsgGUID: BXX9zhTkTIm1GpxPecw3HQ== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="8075250" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8075250" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 01:42:51 -0700 X-CSE-ConnectionGUID: NnQ3rjWfRkisaJz1qGfGJA== X-CSE-MsgGUID: 1xMXvpQ3Qm6ucbLhzmbE3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="20734708" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Apr 2024 01:42:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Apr 2024 01:42:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Apr 2024 01:42:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 11 Apr 2024 01:42:50 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Apr 2024 01:42:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P1mM0VN8jcCI6l77DsNE1mvJYILm+jSlTuO1zpxH/h9LjVCVsMsv8E0JnZV1H3DDoGdnjDfLM/b4iXcvmTGVvdKQalWEaEmSkGa9nuYZkM6eDAuycXZEXTeO0vONsuiEshLGIyRg8J9vj8B6uILAjT+EL5R6VP9lRGz9bSkUsSHXHudXoJp866aPwJEHug+eYniejLd797uN8Q6NaJK1xpenRImLW/wQ+OsnWDSOWmObC0quW0EpmxNVhC3qy23o3mQFsCzSJwDxNJgePlb7+v7Qp/lBjnC6N7LrhSyh9shCxgUjl4gbG7Gcq4wVBFDB/bppGdbc7FuO4vT+48EorQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c+yg/imNNwpiGB77qPvLU3CoYuxwSRpXyxThSgYlHHA=; b=FHAvdla5hHy4UUNr1kMnrDeL+BVe5sP6kkNL6d2+tbAlCSeDdNKyYYzxW5Sx9UG/Gl/AwzYFvuvgkIk/6jE2ZpZiBSSPCwbD1B3Patc3AbO/httWT9LL6D5R1WsTscA5LCG0aOTnDUKgJi85QAExBNbE8eht8/+jeWoD9fxFkfsZGwx/A5R/MM2sCnlxqTn9b/tanTsH7I+MZ5Bn+NPvPzkebY/yKB6/UIzkSNteI5rivjMXRZvGd3gwtzx1CFvfDDqgVit9lnfn55KnMoRjveezItwoE0E+q23ppcbt5M+9OG4qyfisfgYbD/YOxNufommWSy1qqmrdid24i9thCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB6616.namprd11.prod.outlook.com (2603:10b6:806:257::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Thu, 11 Apr 2024 08:42:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Thu, 11 Apr 2024 08:42:47 +0000 Date: Thu, 11 Apr 2024 09:42:42 +0100 From: Bruce Richardson To: David Marchand CC: , , Subject: Re: [PATCH v2 2/8] net/ice: enhance debug when HW fails to transmit Message-ID: References: <20240405125039.897933-1-david.marchand@redhat.com> <20240405144604.906695-1-david.marchand@redhat.com> <20240405144604.906695-3-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0278.eurprd04.prod.outlook.com (2603:10a6:10:28c::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB6616:EE_ X-MS-Office365-Filtering-Correlation-Id: 052c6e92-d9f7-414d-64b0-08dc5a035cd1 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1RQEpi84pmJcTiM3XDo9BIDWXwR6BrqjY7nFTMlF227IgEoRkhAjHFEiLlrPJdGOVjyX5P/qPs9CHxapjG8cu6ibiubowmLLt54US/i0Q3/bbIJbJT1hkVWJwOQ8WZm0b+2wwKQZlGBpW3jpTpWTRivF1D6aKD2RZPgvabcD2ck/e2Wptrf+OfSaOfRYEb0MQyNCTdWcvk7LjgSDsiK2B0JIlXCGpoOxBrJ7YHdF7WU/VXg7UjEqCW7FTBfLY3KHY1eznom1q6mv9S2pUSjDcddK/0rBlJowUXYQkkyNqRsuZSimiTvqegyszH+D/1UjpIkOUja5pH975gdU+V+ts6pYnqlK+htOBuRzIOb3mGffA6KX5Ti4zYwFt6GhatYfjXV6aRFX6MTa0O8bxWoKV0v/2E+lUd7VVmWjvHiJyBCVJWkGUds4Pc0tEuwlrDtQ2mpBfmMNFUkKF9Xc90/jR3/Cz1SVqxCn3h6V2hPMSXO/kYzCQA7WsiDNNKEv6qtTcWHg2iI6TFHWP7PhEFPssF5gKbnkBScnSzef6w1JSv3L0QA8IeysMzxPb+fxm0OaDJzXXn+slOZHXAhRoaniMXxJYa1rEZ2jBzU52cho4gvDMSTgtoNa9mG1WOYP0LqynErOE+dMJAVM3a51/NOoykbCcUiy3XDjvETs6weCkXg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUFueGRMSFQxRkxMbXUxRmdlY3Bzb3pTNTZGV05OY3ZPVzhnZVRqQkthS01u?= =?utf-8?B?cEhqNXRKemk1UTdFYmxqUnBjWkNFY1RmcWVDQytjSHFKVWdPRHJFK0ZTcUxG?= =?utf-8?B?OGMzMnR2ZHNobjhQMXZ5RmV3bUNKRXRjYzdtbXZaTGhYUnNNN05iK1R1eEdx?= =?utf-8?B?M1F3ZG9nWnR2RXJXZVpQUCtCYWNkQk5iSXVYTnlONUtxOE4zaldLYzgvUm41?= =?utf-8?B?ZWYvVGszdjdFZlptN216YzRyUW5SZnhManNUU3pFUE93enBKakNTaUFUT0hL?= =?utf-8?B?dVVNNWNtVG1GeDAzT1pKRjNsczBmOHlrUmh4eVhtVkJqcEx1dUR3YlhIMTNM?= =?utf-8?B?Y1RucjBrb1djamQ3b21CVWltRzNBRFc3cklkUnR0clU1dkZleXFYZVZnUlpW?= =?utf-8?B?UGY3NlRVVVlWaWFDbXB3ckRJdUFHNE9vcldmSTlTdEZIMklMS2p1QWc0WmFD?= =?utf-8?B?RFVqcXV0WWtHWXN4ajVab3NlajJpelJSK2FlYlZESGMyVExqVm9oRWQrdHFo?= =?utf-8?B?Q2lMem1hZk0yYW0wOWYwMVFCRC9NdW85Ui8ybDByZXNSVHlBbjhCbHpZNE9T?= =?utf-8?B?N2dlSUhOaW8vb1gyNWJQUGdGM0NLWmRlTHRuUjR6WHlUUnVNMU9hNlAwdGFM?= =?utf-8?B?RlppVklZZTlRVnhGaERMTW9CaHo4NUgvOUdidWRCa2dEc2xxTkRRRGFjc000?= =?utf-8?B?amsreWZqWm5BTTcxWEZaVHBFdVNtM1pVVlBQK2piNXRObGNna0VoMFNCUFpJ?= =?utf-8?B?UUxKNHN2RXpoc2syQnVSRDdXeTh6Nm5kM05hSFc3ZHF0a2QrYlY0UzFzOUJC?= =?utf-8?B?Y0hUSE1tR2t1Q09NTkcyWU8vSGdxRUNVc0l1S0pPNUpaNVpQV2pBcXgwRmRT?= =?utf-8?B?MW5OYVZhdUExRjQ5dnRsTi93KzhvTG9lR3g1NmIzTk1uQUl6blgzSUdwaTE0?= =?utf-8?B?MXgrMThKWFI2ZWsrZFhRT3N5NHdCZERFeWdvMWw4TjNibmdhUmtIOWhQZFJN?= =?utf-8?B?ZE1uUW1hdU8vNmFtcnJDc1A0b2orQWRWa1BURXhKZW1lRXc5c1lXdEF4ekRR?= =?utf-8?B?VGtRWDk3cjF3YlBXNUsySW1Vdi9BbDNNbGJaUXdtQkdrNFZ6ai82cUo0ZURw?= =?utf-8?B?QS80WXk2U3lhcGdTSTVSc0lXTGdIbStQYVY4TXZOQ01CT0dCQWxBdUgvOUY5?= =?utf-8?B?VDFqYkVuVEpxSnhWbitvc0FXNnJRVzJQZVFNUWMyemZ6NHNyc0xSOHhOcWVj?= =?utf-8?B?RW9lcjZWTk1obDZQZHhxSzBMVmRsWVBRWVRqUGtLQXp4aFpGNzA4QWowNmZU?= =?utf-8?B?UmM5NW43aVI3aHlrbnRGY256a1g1b25NQWZ0SUkrcHYrSVQ3aTh2ZHl1NmJ5?= =?utf-8?B?bmJLaC9tQ3Q1citMRElEWUtSbzVzaml4dFFJMVdLeFNWajl3NnQ3dll5MUxr?= =?utf-8?B?R0ZJRE1Qd3pjanBUbitFUnB1eVZ6WHdNRFdxMWNuSnNuYVhzaGFRSWRXTy9S?= =?utf-8?B?NUp4WW80MmQza0ZpREZJUUhpdW4wTEJaWk1zLzJsc1ZkQkozQ3BVOXNYbXRR?= =?utf-8?B?bkdkZmg4L0h0NGQwd2pldlhiVkp4ODI1cisxUldjaGNwRDhxdFlxUmpScXA0?= =?utf-8?B?WnhaWUZMbzh0U0ZtMitUUEg3RzdGN25qSSt6RGc4U1hVdlIxcEZHdWd4ejMr?= =?utf-8?B?dU96Yyt6dXppYSt2MXhXQWV2QVY2Y3lYZXVKSmJQUHFFRE9GMzN1dDZtOFVJ?= =?utf-8?B?TkhuUlpjRG8zY1VHbmpVTlJIN3Y4NW5mWTMyR2tPcktZQUNEUU1OY0F1MEEz?= =?utf-8?B?aVo0Z3daZDFRUWpFSU0rZTNtc2tSNkF4RmtLU1hWZmZLbDRmaXJJU0NrMXFm?= =?utf-8?B?eW83amlTUkxRQWJwaWFIc05SbTM4eENVNzdWRDNwM1lVMEVMOTltNjd0Ri8y?= =?utf-8?B?QjhBbCttTUdyTzRWMCt3MzcxbmpjMTFqVWlmSFNmYTJWYngzRUVuc2R6bE5k?= =?utf-8?B?M2dDUmgyMWd2SzNOTW1tTlN4Qk44bGpHNnZVV1NiU083OG9iSGs3Nk5MWGxu?= =?utf-8?B?NGo2V3hXajRqWXFDUUc3cWZXNkhEd2RMWGRUNStxek1sTW04MXFjNXZBdzRo?= =?utf-8?B?NGdCVEpoR0o0L08yVHRXai9CY2lQMjljZU9RakxjZTNZcWxnSkJ2UFRzd3RC?= =?utf-8?B?RVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 052c6e92-d9f7-414d-64b0-08dc5a035cd1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 08:42:47.0180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sc9PYdrFNc6XrFaB2xkOus9c30rx1PG1jpd4ijVv42Z7T6b1MvT+OabsVbfISj+/EaQ7S8L+9ZFaLRjXHhxnZK+90IJV+tfJdilBpRjb7NE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6616 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 11, 2024 at 10:30:19AM +0200, David Marchand wrote: > On Mon, Apr 8, 2024 at 5:23 PM Bruce Richardson > wrote: > > > > On Fri, Apr 05, 2024 at 04:45:56PM +0200, David Marchand wrote: > > > At the moment, if the driver sets an incorrect Tx descriptor, the HW > > > will raise a MDD event reported as: > > > ice_interrupt_handler(): OICR: MDD event > > > > > > Add some debug info for this case and the VF index in all logs. > > > > > > Signed-off-by: David Marchand > > > --- > > > drivers/net/ice/ice_ethdev.c | 29 +++++++++++++++++++++++++---- > > > 1 file changed, 25 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > > > index 87385d2649..fd494e6b3b 100644 > > > --- a/drivers/net/ice/ice_ethdev.c > > > +++ b/drivers/net/ice/ice_ethdev.c > > > @@ -1389,6 +1389,7 @@ ice_interrupt_handler(void *param) > > > uint32_t oicr; > > > uint32_t reg; > > > uint8_t pf_num; > > > + uint16_t vf_num; > > > uint8_t event; > > > uint16_t queue; > > > int ret; > > > @@ -1432,28 +1433,48 @@ ice_interrupt_handler(void *param) > > > if (reg & GL_MDET_TX_PQM_VALID_M) { > > > pf_num = (reg & GL_MDET_TX_PQM_PF_NUM_M) >> > > > GL_MDET_TX_PQM_PF_NUM_S; > > > + vf_num = (reg & GL_MDET_TX_PQM_VF_NUM_M) >> > > > + GL_MDET_TX_PQM_VF_NUM_S; > > > event = (reg & GL_MDET_TX_PQM_MAL_TYPE_M) >> > > > GL_MDET_TX_PQM_MAL_TYPE_S; > > > queue = (reg & GL_MDET_TX_PQM_QNUM_M) >> > > > GL_MDET_TX_PQM_QNUM_S; > > > > > > PMD_DRV_LOG(WARNING, "Malicious Driver Detection event " > > > - "%d by PQM on TX queue %d PF# %d", > > > - event, queue, pf_num); > > > + "%d by PQM on TX queue %d PF# %d VF# %d", > > > + event, queue, pf_num, vf_num); > > > } > > > > > Would this output be misleading in the case where there is no VF involved > > and the actual MDD error comes from the PF? > > I will check, but IIRC, the queue here is an "absolute" queue number > that should help figure out whether it is the PF or a VF in the case > vf_num == 0. > Yes, that is my understanding too. Maybe in future we can use the queue number to identify if it's a VF of not. If the PF is the error cause, I think the VF details should be omitted. /Bruce