From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B00A043E53; Fri, 12 Apr 2024 16:09:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 563CC40DF5; Fri, 12 Apr 2024 16:09:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 027CB40295 for ; Fri, 12 Apr 2024 16:09:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712930962; x=1744466962; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=s8v+JVo2vxXHD0+71K8aoLHJuMe0gtcHm5kC3ISs8WI=; b=OXPlOyAQwspjGkrTow9mFmT9MCbp2Fs0jmWFOZ7e7ohD3LJOs8CAu+JJ tzle+AjqgNBb3fJfJ8PC/ZML8NJbrUi45XMvQsDZqsm197vYLtujOO+Ig doY3njSspfUQcVjUgEhQO8b6Ljtyf1jfijxAYZUBS2TEmOoS6eEJvG/0q ZmV7uqSXuiEf1aJGxM4Qr3gKDw/Edf+xxaB3u2cccEqs39KdyLnDK7F9f NhM2MfQtHchghXnkXhDUjq+H7AWAJrbqXLmPHVmNutGnqa5pgZAjB78nE TdxPxEOu2dHCKKzSjE0GvpG5CsPBGmF9dZnZK1vGh106yj3sXFx6tqFGY Q==; X-CSE-ConnectionGUID: QNpPByizR4qepiZDKgPdJw== X-CSE-MsgGUID: d5LeezigTDGlRnDKMCM9dg== X-IronPort-AV: E=McAfee;i="6600,9927,11042"; a="8554050" X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="8554050" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 07:09:21 -0700 X-CSE-ConnectionGUID: juin3RBqRQSxKFRmxLp+TA== X-CSE-MsgGUID: dyQoioo+QvSYkaword+WeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="25679162" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Apr 2024 07:09:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:09:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 12 Apr 2024 07:09:20 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 12 Apr 2024 07:09:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgkKqYXupSxuspQvuTWgzjQ3CgYJ4WMoUXqUCKbbkAY649WBPZ49u7ocux6MQWFVN1dRC1toyA8EAkfxMPSh51/QxFdVXAVQi1d+d9TxdygVgbLq8vywfITP91OLQe3ABnQHJSWjiIjCIKDHDuu1T9TdYjc3r2o7Z01R14/TJu+b89MYcncI1dRTZJ2srqTccuJO6jIUI+cscR+JS2c1ZqXSje9bnu3/tT8y/mKAV1eWDyiTlUaE5MbKD91EsPmhPCbHFxoaQAOfUgYGvbKF7EBD+uE3DLPJf9zLOykCDhEOygaZ+Htbtrzni5UfrrxZhk/3CyoiBdn1SyhtuCFkpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T4qj/pAfkenTPS+X0JzXjrmtyQqyAQKxumEFrMqZ/Rc=; b=CbeIJrCDyMdtLljcb4warhhVmQMA1y6hv4REDREXy4EyI9ju2+gc5zTxe5wD+l2N/vknJtWoVnrklSd8cHmUaxW3S0yAM9ArmiAg+qZv1FEUXftiR6Jbmwjxju8EOYr2JWLI/TnPIV43pMiFKDEy/7viltpxkfVQvcWBLbLEn11yX+p9qZ6ynx9KwAIb5sno1i6+vJ0s6n6bTLYBJ4yibRCvuDvLfJwVsYnslXfyP6FBHBJcUiScZxY4b83xPBcP7Us7Ufwzb5y7hna9ZHSJKnaEjUSjoE4zYQRB3Bn6OwlDKSHnwBBXB/lDUVRdWnI9wovlVzsBnt8PHWW5mU3CkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7902.namprd11.prod.outlook.com (2603:10b6:8:f6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.25; Fri, 12 Apr 2024 14:09:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Fri, 12 Apr 2024 14:09:17 +0000 Date: Fri, 12 Apr 2024 15:09:12 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Harman Kalra Subject: Re: [PATCH v2 2/2] buildtools: when building static library use static deps Message-ID: References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-3-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1710484222-17310-3-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DB8PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:10:100::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7902:EE_ X-MS-Office365-Filtering-Correlation-Id: 78aa7541-dfd3-430e-e199-08dc5afa242e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6QBNjKnPCap1BLmUIUtGlwMjMT5udLU7s9B4BDXg/omui1m6TxG8+20ngDn8TfYIlZ0Hd/D+lMjIhPkYDFR88yAbyoOmX3rTXlMCRaoR+YEQUsJ15fZEK7UHlwTkmlnWPBtU/8pLTIq48bw58LEXPzMa/XasdIa3PvoAymR8zBtJWxzR2ncDqBQUzPre5Y82UiU9VE2Ts5NA6YOg2NB+A5lVky5FS4quPcatFK6zfSL1dqOnIqvvGiUoSMFTh3pG5878fZJ2FVrMLhwLg5z6vyVcJ3LWHaLTVlvYEhYySs0o16yIq2pYPy+2R9UVNJ7QA/8DKOlAgdt8FvKdeOc8Pt632rMwm59D94PV0krnZg9yaKw2kPdhoLX4ZeA4P517NI2hNo/Fmzw6VMaqshdOz/CRzUupo/lgUp98gpu+gJtuqKNLZUHW8iN8qNRid8K59m3r4n3QntNRXqdiCsLMcnZGvLnaPZB9xF/vue2O4pD1mYyUXZnwZzZ+xldzPnRu8jKhKYlP8KpHmVqle0M5woWPbcq9BVxhj51LpGm1vzCnhBYv80vCp7Y3Vwe3Q49TJtOU5PpMFOXffnzs2Uh9M0Boo/SG8nKASXjVnDnW80u0rAPZvcAozvryeju6TTcHOb9m6wZ2tIhm0iXTQJ3DPpNuz5osrQfgYx7IxbbcrTI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?isI4ZR0CQC16HHUyPqY5K1DqNkRxUS+oQoVRJIqwmVdY/ziEjqPjQOTjmo+7?= =?us-ascii?Q?qkSet3bomcU/cFBtIIxf1+PKT0gQptoWMNaG2KokCKyN71ATIAIcEOvW5Sfs?= =?us-ascii?Q?WtxUfV0IwFFUrCqo0P3A3Fisw3yp1tUeB81NsdxjejdTHAc6ZIM5RvtLVNT1?= =?us-ascii?Q?wGCYHlJ7hQTJ/j5Yd32mUsA5wo8jxMF9OTqfFU/HIXC8p9h7lFajuE/eCmdM?= =?us-ascii?Q?X76jal+nhzpn4m0rkwGlsC7mAr1gUJtNBkgS2cXS1Tdeao5IpnKJb404CMyb?= =?us-ascii?Q?URSrnAJe97YKEA/EfrvTcdbYa5JLJN1O66l1xUKsSEfUmyLL3yo16dDTeF9z?= =?us-ascii?Q?ucwtjyJpzhBaW587vwZabUv+BYi4hUKJIJovBIdqOe0llvwCcM5APSKDq7tB?= =?us-ascii?Q?Hq4NZVYspoN6jvlT/zcIuWzcyLUbykEb9s5/29bknZtpjESZHjXeA/oZa7Yk?= =?us-ascii?Q?2oYBTKtP17Gdf5CDcfF4WXvIm05LsIL84mHmlCeXOHuL1gQ1Ln1NXhTn9LTj?= =?us-ascii?Q?yPFU2YSIPRbaTWwpaijSOUsUbxiptPLE7Nxo6R7aJOCHankEMR+ma/X1weAU?= =?us-ascii?Q?SO87x0oa0ONTOzumZ5Onoy0kpeeZumZEfNGVPw9uqcl2PXa4kESI9UIaRm+L?= =?us-ascii?Q?F6YVaI2e2Rc3kQJELPKiuZMOp25XvZ7eGVJku69zZSApIaVIJ2xO+w+F8BW9?= =?us-ascii?Q?SX4YCH2gquCS4wg6cT6fm4jBswlu4w7Ynv29p5Y8/lPoHlUppfXVt96khYtE?= =?us-ascii?Q?apX7bVsJWo/4IQ3qyFIbP4atreyW8U+qUsNCWA36I5YuMHvBV7w0SH86DH52?= =?us-ascii?Q?CNnMGQOB9FJZ88HQJRCOPYcpNDJNkxvhwx9qvJI/AFSGvZ8okXgVra0Y9qsq?= =?us-ascii?Q?vvYNZEBY7HGtH9iRcBmmE2YNxHoJgI1Y7e7ozM4tB3OrOiAEpVKbBLh6sksa?= =?us-ascii?Q?igWfq3jSB+LWAjeynMY4tk5x5WxuRpYYfc+cDajhTpIF5ixFBqq/gEL5t4rM?= =?us-ascii?Q?QIZKcUI/AuoIDWk0sooATwWQFaRQ2UaiAkpIjldMHUvor7ObLQ9ThsAl6qDR?= =?us-ascii?Q?xAzIEiBLb2Fs/BHrJCeXa0p6OXzO6WvdERNJ68Mxa2qEfmMze5kkLGu5f5wb?= =?us-ascii?Q?0Q+fpbM7tdrUzbUiMovIZoORHk3Y6kQ3ZPzWLpxkv3W0MQdZm5gvE1hTXLXn?= =?us-ascii?Q?51IxhCrEbt6T6bb+eI6DkiKQg/4AUy9Dk2VA8UNRYVIdbUVSt9BnGsD/3WKI?= =?us-ascii?Q?JsmwiunZ3lT3UYfI2+Y9e5erJ66WO6R9TMgx2DHB4nwdglRqIafYgsr9v8km?= =?us-ascii?Q?gCelZUnhQwzjCsXKgrRDAU3Ii/H2ypj0CVGw6gTtnhMvMNYe57aGkVgsKQ8o?= =?us-ascii?Q?Pvqq94gyS0739kGgIqva3YBxs0dR2bJ74tabEli8A0wjaO1mR6Xwd/9LPBPI?= =?us-ascii?Q?w4nCsdXxbeagtsLK2HOWPidERjSwU819AdT6z7X8ZziAK9z5/qJq0Os4w3Eq?= =?us-ascii?Q?W3ky61qw8qqhI6QZB7kTjoe4X3DigXGWcHEM/k9vZDY/RhvDdoTHLdfSqXiN?= =?us-ascii?Q?bOB113gmy47R3pQi+d/URHsHmK0CS172h6OyqU9GcZi787T4kVp15UfujsTP?= =?us-ascii?Q?wQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 78aa7541-dfd3-430e-e199-08dc5afa242e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 14:09:17.7815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5pe3sBKrt9sLgo+Ao1jauktzkAZL9Y2FEdOKxHDikOr1fUXi9rUkrQWfJQKKUa2e8Nsn4kEEnhljJz1o6+svO/FAkPLNJmfdVEJFecAjx24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7902 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 14, 2024 at 11:30:22PM -0700, Tyler Retzlaff wrote: > Use static deps when default_library=static and use shared deps when > using default_library=shared. > > Signed-off-by: Tyler Retzlaff > --- > buildtools/chkincs/meson.build | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > index f2dadca..66245a5 100644 > --- a/buildtools/chkincs/meson.build > +++ b/buildtools/chkincs/meson.build > @@ -20,11 +20,19 @@ sources += gen_c_files.process(dpdk_chkinc_headers) > > # some driver SDK headers depend on these two buses, which are mandatory in build > # so we always include them in deps list > -deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > -# add the rest of the libs to the dependencies > -foreach l:dpdk_libs_enabled > - deps += get_variable('shared_rte_' + l) > -endforeach shorter fix might be to use get_option('default_library') in place of the "shared" string, rather than using a condition. /Bruce > +if is_shared_enabled > + deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > + # add the rest of the libs to the dependencies > + foreach l:dpdk_libs_enabled > + deps += get_variable('shared_rte_' + l) > + endforeach > +else > + deps = [get_variable('static_rte_bus_vdev'), get_variable('static_rte_bus_pci')] > + # add the rest of the libs to the dependencies > + foreach l:dpdk_libs_enabled > + deps += get_variable('static_rte_' + l) > + endforeach > +endif > > executable('chkincs', sources, > c_args: cflags, > -- > 1.8.3.1 >