From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 866F943F5C; Wed, 1 May 2024 11:06:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 541A8402A7; Wed, 1 May 2024 11:06:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 16A304021E for ; Wed, 1 May 2024 11:06:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714554374; x=1746090374; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=SWjie7sYxWRQffef40uIvr/0rkSMHsAlCVOfnK5vU70=; b=NrGqax1ttjpqrhVwz63jX+bicYQzEXyY5x5mK1oIvbJIb5sPTeATPiQg 4yVP7BBCHIMzSD4wTRWYLAc8Jl+5lP/iyUaErZkr24fpP755evjjSSb3e L04LIWaJqz2Km3rgIsgmb1JaxLsoqJX9zLt3AM9U3ryz0ghdad8kMkCUq /wZORc2Zc1VB+kffQ0+yb+OESWUABeQvPi815mGst238YknSU450cB1PX KPJ3hN8vtUGvzAjW33tOeEATEEm+s+qlSDW+ZWMf6lbX4/wyuhqVKaA8W WRFTb+4x0I9N19YqnjFn41FhM0MYU8qU86QhETXcaFG4usrZ/Nk/+hzdy w==; X-CSE-ConnectionGUID: pfGnxQxpQA6xZUCSOMqPYw== X-CSE-MsgGUID: ZG+SGLIoS7+IbK3ZJwojSw== X-IronPort-AV: E=McAfee;i="6600,9927,11060"; a="14102358" X-IronPort-AV: E=Sophos;i="6.07,244,1708416000"; d="scan'208";a="14102358" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2024 02:06:13 -0700 X-CSE-ConnectionGUID: jYhkmAJMQCeYSw9QBLVSMQ== X-CSE-MsgGUID: kJdDZPtKT9KkncBQ52uYLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,244,1708416000"; d="scan'208";a="31525981" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 May 2024 02:06:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 02:06:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 02:06:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 1 May 2024 02:06:12 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 1 May 2024 02:06:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNQwcVDPoeIu94a5V1XCRfpz8yS4eqzIBzaW9WwBdPMERl6wpRbaM+N8uBDYtB+qj6lfLxvgiEGhTfIo56hSmkBMU+A2h+dsPCrTN83J9QJRsZmL0qZFnijTQ3DsaR6mo+nccOYS6xcjngeM6/ijfWpSluagICi7xdtmE/0Pz4n/Zfglx7M6ZP6eirVeDd0KBvswjFKvi85pWw6JWrXS8ZuSMem3nmsFN/demSZ7JEYvhszHvW64ZgsIZioqDKB7gwtp9doizrTZ676Oj5XskQVS30B7BemnujESvZX99pDuBCYNtt/DAN0t3ipW4y+ZLj4Rp74ODPLqTgOCS+RSZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BAwnDrhnS2DDgoYG0BVFQcVICUWzRvyrCaEaxtxdLb4=; b=msgsJFIcS71dwRMVbIrd9aqs8mtatHmMAu1sfL47wePN6ohU1KNnLlmORqw8S13QLsEpvc7oYilBXL3EjiP2qMA84bp+xytQfLpcT+C9baWH+0JtcYgh3fSAxzWaHvTREUA4Lxuz5GY3If1/5XsVsiV9x60xb4a4fFdF1iL84hWEr/ZrS7RTGqguj/x6lD/3Fd/dTFS+D0PLpbqnYYvbvIzybyZ33KbkM2OcfaiCrfLHwdsh6/IvwUlxMhw+DQxJcXRGExSq2m6iUZ7KJiMK6jZIa8yN+ZGGG8AVf7Z1YV1DXFiH2n9u1wCcbu/uKOmNZKzzY28VfbdnlH90fC1REg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4937.namprd11.prod.outlook.com (2603:10b6:806:118::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.36; Wed, 1 May 2024 09:06:10 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Wed, 1 May 2024 09:06:10 +0000 Date: Wed, 1 May 2024 10:06:06 +0100 From: Bruce Richardson To: Thomas Monjalon CC: Ian Stokes , Subject: Re: [RFC] net/ice: Update base code with latest snapshot. Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> <2203228.C4sosBPzcN@thomas> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2203228.C4sosBPzcN@thomas> X-ClientProxiedBy: DU7PR01CA0042.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4937:EE_ X-MS-Office365-Filtering-Correlation-Id: 02f55db3-75b9-409c-79e8-08dc69bdf1b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HDPRsJqdYmbkNPuP/5wVyCBbNtBWYc/z8/Bza6yQiFQWvwe34jcVrIsvBcz9?= =?us-ascii?Q?Jt4rB9Ce8t52OvIsuN4M13nbKpYbhQAOvTPOaVRAerySpxCjgGfTdvPsDWd0?= =?us-ascii?Q?Yz+0EYKw8zCbmuhQWvoEffdKUyZs7ekls3iF6vTOSm0HjFo0RkdXW2uX4/Pl?= =?us-ascii?Q?gecBSt1rSpQN7ndQRvNLGBI7yQv8Tu+BHgrkcxbYcWHC5/phnhnfGldW6Y9R?= =?us-ascii?Q?Z6HJ8kWrvYnLGsfQNpwsE90dASpewMxgVxTbcqaPZfNOhKoB9Gg/kSBvPYv3?= =?us-ascii?Q?128Ks/dmZmvLE1ogUpPW98XvEVZv1DBn9wjGIXfISeNorLkcayWCi9W8uaFh?= =?us-ascii?Q?3E8mCKiht3AaeT9T/SVSOi1K2CjBn93UyEGsZL1lRXMUPIBpMC5Ygj36gb1V?= =?us-ascii?Q?Pw0Obk9WA7TNb5rY6zLNw35iZpIQ0rLRHmVp/YdP361QjrY56N0BXFtxCvNI?= =?us-ascii?Q?Ji9DU9GKEYpDOZgNJF7lZZNOOHZWRwtMZhg/h/GlyA2q1rDdS9W3Y16+S7oo?= =?us-ascii?Q?9KmMO+E3/dXZFJbMsB3UPCf4OZ9PqEFYck0opvdNo6g7xRZwCczvkCaGkgOo?= =?us-ascii?Q?/WOD7r0aBupgplD/qdEDQMe12KcU1YzcBcIcvsItx8rjbt2/8mN9Pzc/lyVF?= =?us-ascii?Q?ZkF73RluhtwMvxoDEbs+hPLYN3/nIyFYQZQFBcrLsGQ16m1rvE/SUj88osxE?= =?us-ascii?Q?z42gia+Cf2HIdHLxPiRKrCxw37MXhzD+yzekNqCxHQ3lJlnV9Pfaqnw3IXuh?= =?us-ascii?Q?W795fTXiIVMtYsSYDo1DAzg9f4rrRhpJqhMLtqajdsG4mbKRvmSy4Ql4CA2v?= =?us-ascii?Q?HiVtpqxzHowA2J16HATfTjW9ahcEnRdZGtBf8FmLlGTgargBQBmesBvvb/uJ?= =?us-ascii?Q?I/34B55Oh8+nHnUeDwiF65xUldBiGcF015yvO3F/2eiM2r5WLTxDKE/TfZxj?= =?us-ascii?Q?9vRBbGixJ+LID0gFYkUBliPKtZMbsO8KpvBy3DT8h7S/cFpluy1eMdy8ZtHD?= =?us-ascii?Q?1hhjyzElBfVtcLk1+Mum/wr9V0jTerqCUjxjHa6KzdW7JnqsW5hsX4dRbxBE?= =?us-ascii?Q?TubakKA6KEHoIRfK0/y1W00zz3+ifrx1z5jZL2P11SklDQZ0NsxzKMlc3Dtv?= =?us-ascii?Q?JqThI1uOMSpmxs0qcLLnr1/16FlkaRDMHcZq/t+7P9h24cO0j8qYlDLS626m?= =?us-ascii?Q?HfY9qjMO5wG9x491vDwBwM7BR5lsmGr4UGU83ee/IFGfQZqCWoxYr9kha6J4?= =?us-ascii?Q?0Nq8fkrT2WYP3sEEHLcJ8Wln+/bTxAl4hGJxiUGvUQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EDWNer7abvbLHTwF/+roGpPJ6zFKFkZLHqEjtgrYAOAFqF+6znU8AmsrIotU?= =?us-ascii?Q?JMoylWwaNfe7gR+96E8nqEsa+F73lRyy6uUJhNt4BXf4ZKMmCMjQqM2rGXyU?= =?us-ascii?Q?akndFk9X9BiLrEdJ0gnwNXLinPEsLvaVlvCw2uRb0K6Q7VystMIRj4+z3+Ex?= =?us-ascii?Q?TCM6G5wusj92OiTQg05GjDU688e0i21RCiIi6YrtSAS3YxZagXb1Xdax2ncM?= =?us-ascii?Q?VUtoTLHpPcYU6APKpxQTM3bjUUNMYlf4ZtkEMWMmw5RrAQsSLGMPGu49Boq+?= =?us-ascii?Q?gdVERV5bhf7adsCmAQaRIdGdXIMYDiajcBTbqSpWhBhoQNr0m2z/rdVr6u6L?= =?us-ascii?Q?t4Pt6O32PQfvNeOmM/jeDeDpy6k+y4fCiDsy1Rr5oXMY0icuVFSi84U9sBw6?= =?us-ascii?Q?DeVYhSQmoNpauoaLyM8cejbAEceQnKNwwu2vhu0pOGupUetyDaqmwWvrDT4E?= =?us-ascii?Q?0t8naUnC0lLEZg/TaABTh58UP1vdiljfooUJ1gE9cN8gTbaHIwnILjeu19rL?= =?us-ascii?Q?bc3iukcx/L54n+7Eaz3UPRxqzhUwyCHNgdyOQy4Q1/7dCLfgTmj2iqqBgNRZ?= =?us-ascii?Q?Wg5qBxo3/CArwGDF5+G3iPHCz7CwTfjm86YnyZxu1FoSTb7Rc3qZKwwHPoC/?= =?us-ascii?Q?2pg2JOspBCPnLogJ/O+nVSSayqxnEBCRG+6ibiwMVNA52kO69+ujwDyY6FwZ?= =?us-ascii?Q?VAQhUxI0eaYPu6e4xlwWHr7FCwv7VqDbmSG7DfuiZQm6Msd66pc7ZwarNvRS?= =?us-ascii?Q?ucMXbYFQiMbfS+3g1BXwOY2rFXW9o4n8llERmNzqEPuNvzWU7p+tRep3wiEd?= =?us-ascii?Q?jF0DH9EiPAflB/z6j66sJEZSJJG1ILDuji+J1ZtMwzSWoj+NYGAz6JXKzFtw?= =?us-ascii?Q?ffkfMO+AkZs4VQdlHY+6veTqdvDCLUQZgNUza/0V5MwaNgvaQ0q2ZGGFz6UX?= =?us-ascii?Q?kbpZIOYg1dBkUwNV0GN7nLbEhSEMD3dF1onIcl4dk3cwB+kgRx8TnJWqZB0l?= =?us-ascii?Q?A9xyAGUYWnKLK/niYHfgzEcuGV6kLSpXoNYeYit5VJwr2SUe8vwmVxoH4LNK?= =?us-ascii?Q?nKjxyJRN10TdevUxFKtMfow8odo2Xtmhmw6Ts20AiCAPRZ8yYh2/55mSnxh5?= =?us-ascii?Q?hquse83rWA/VU9YtiCh2h3/PVOLbZNORwZ2b7OhUyFo7DgiwZViS4WLWt89N?= =?us-ascii?Q?NVqFMfFECcld/tbB+3yBq8XaojhameeMK+L4gSwAdxhtLZHCl8MIAvfytYwm?= =?us-ascii?Q?5lh+cekMO4WOhByGoYM9SxvkqK0Wgupppbi1j8P0wguZBCj1NIWFI3daROR5?= =?us-ascii?Q?QOhKuz30nYSUvYXN/S1PL7mlU0oeY812zHzI6/6MJNp52+s1Q/eVU+NV2Xi3?= =?us-ascii?Q?EDhWsICLzMWdk9vm/n4xoRV9bnXNXgr4qpq3e8+ZgQjePOfjUEXwCCqOzheD?= =?us-ascii?Q?GFU/Yu5+KZza/e1zBkf0VP/bz4km6do2g659oTTHids+R1tgGWiLoWHdwm3r?= =?us-ascii?Q?Z7hx2/JOFA3zUliyp8jBglVn6tdNGIQ1r/Ymn+UK2JmLurHzgcnh8H/fwGDR?= =?us-ascii?Q?1b1EFbW41SO3X6qF5d2/wQh+J1Nc9ViPpuJSADIIM9XSj6uhuhd8mvfIY+H/?= =?us-ascii?Q?1A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 02f55db3-75b9-409c-79e8-08dc69bdf1b2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 09:06:10.6328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PJXT9PejuxhmMRaIiRtyE9VtwdKrS4swTxWYgL/ENzg4Uz4tuiYtKHXYZn2f/1HDP7PrIUYH3j4ILDZylVgpS5p8Jkf3s4ZRN0ofSEwojhc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4937 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 01, 2024 at 10:19:54AM +0200, Thomas Monjalon wrote: > Hello Ian, > > In general, base drivers are updated with multiple commits, one per feature. > It helps tracking the changes. > > Please would it be possible to split? > Hi Thomas, yes, that is very much the intention. As Ian states in his last line, we sent this as an RFC to a) flag that the series is coming in future, and b) have an initial CI run done, while we work in parallel on splitting the code changes into a more meaningful series of commits. Given the scope of the changes we didn't have time to do the split yet, but wanted to get an inital RFC to the list. /Bruce > PS: look like you are not registered in the mailing list, > this patch was in the moderation queue. > > > 30/04/2024 17:40, Ian Stokes: > > The purpose of this patch is to update shared code for the ice driver. > > This patch not only contains the updated base code files but also the > > required changes within the DPDK code base to enable compilation and > > basic functionality. This is with a view to allow further regression > > testing while a final patch series is generated that correctly splits > > the code changes into an expected manner. > > > > Signed-off-by: Ian Stokes > > --- > > drivers/net/ice/base/ice_acl.c | 58 +- > > drivers/net/ice/base/ice_acl.h | 50 +- > > drivers/net/ice/base/ice_acl_ctrl.c | 45 +- > > drivers/net/ice/base/ice_adminq_cmd.h | 459 ++- > > drivers/net/ice/base/ice_bitops.h | 8 +- > > drivers/net/ice/base/ice_cgu_regs.h | 90 + > > drivers/net/ice/base/ice_common.c | 1621 +++++--- > > drivers/net/ice/base/ice_common.h | 189 +- > > drivers/net/ice/base/ice_controlq.c | 213 +- > > drivers/net/ice/base/ice_controlq.h | 28 +- > > drivers/net/ice/base/ice_dcb.c | 79 +- > > drivers/net/ice/base/ice_dcb.h | 32 +- > > drivers/net/ice/base/ice_ddp.c | 115 +- > > drivers/net/ice/base/ice_ddp.h | 18 +- > > drivers/net/ice/base/ice_devids.h | 39 +- > > drivers/net/ice/base/ice_fdir.c | 50 +- > > drivers/net/ice/base/ice_fdir.h | 18 +- > > drivers/net/ice/base/ice_flex_pipe.c | 385 +- > > drivers/net/ice/base/ice_flex_pipe.h | 32 +- > > drivers/net/ice/base/ice_flex_type.h | 41 +- > > drivers/net/ice/base/ice_flow.c | 337 +- > > drivers/net/ice/base/ice_flow.h | 52 +- > > drivers/net/ice/base/ice_fwlog.c | 5 + > > drivers/net/ice/base/ice_fwlog.h | 4 + > > drivers/net/ice/base/ice_hw_autogen.h | 2569 ++++++++++-- > > drivers/net/ice/base/ice_lan_tx_rx.h | 87 +- > > drivers/net/ice/base/ice_metainit.c | 2 +- > > drivers/net/ice/base/ice_nvm.c | 321 +- > > drivers/net/ice/base/ice_nvm.h | 36 +- > > drivers/net/ice/base/ice_parser.c | 57 +- > > drivers/net/ice/base/ice_parser.h | 30 +- > > drivers/net/ice/base/ice_parser_rt.c | 88 +- > > drivers/net/ice/base/ice_parser_rt.h | 23 +- > > drivers/net/ice/base/ice_phy_regs.h | 84 + > > drivers/net/ice/base/ice_protocol_type.h | 17 +- > > drivers/net/ice/base/ice_ptp_consts.h | 3 +- > > drivers/net/ice/base/ice_ptp_hw.c | 4593 ++++++++++------------ > > drivers/net/ice/base/ice_ptp_hw.h | 332 +- > > drivers/net/ice/base/ice_sbq_cmd.h | 1 - > > drivers/net/ice/base/ice_sched.c | 556 +-- > > drivers/net/ice/base/ice_sched.h | 130 +- > > drivers/net/ice/base/ice_switch.c | 1893 +++++---- > > drivers/net/ice/base/ice_switch.h | 241 +- > > drivers/net/ice/base/ice_type.h | 194 +- > > drivers/net/ice/base/ice_vf_mbx.c | 4 + > > drivers/net/ice/base/ice_vf_mbx.h | 4 + > > drivers/net/ice/base/ice_vlan_mode.c | 47 +- > > drivers/net/ice/base/ice_vlan_mode.h | 2 +- > > drivers/net/ice/base/ice_xlt_kb.c | 4 +- > > drivers/net/ice/base/meson.build | 2 + > > drivers/net/ice/ice_diagnose.c | 9 +- > > drivers/net/ice/ice_ethdev.c | 55 +- > > 52 files changed, 9105 insertions(+), 6247 deletions(-) > > create mode 100644 drivers/net/ice/base/ice_fwlog.c > > create mode 100644 drivers/net/ice/base/ice_fwlog.h > > create mode 100644 drivers/net/ice/base/ice_phy_regs.h > > create mode 100644 drivers/net/ice/base/ice_vf_mbx.c > > create mode 100644 drivers/net/ice/base/ice_vf_mbx.h > > > > > > >