From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0A3843F5D; Wed, 1 May 2024 18:30:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B70E5402A8; Wed, 1 May 2024 18:30:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 66C2B4027F for ; Wed, 1 May 2024 18:30:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714581049; x=1746117049; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=+LsL2Ra7JP4bt65vQr8oM0YQRIT8Nj1NUbE/m7kETJw=; b=TqckfQnj2R2HfDsMAkpuwPEQmz7RQAI+DGXVbLMaE8XO7TcUMvqCmcuR OszmfI/4RwAhPPTFzUY3F7J+v4S5OiLTBRKbFo5pbctwjWOfcpyMmikYo 9mnrkxT/ATeDT9o5WGc29a1w01+cHltwjaAStUEqIDakjRJXWrbO1I4ZC tQeigsu1MUjXr6is2JOSipBcdpsU3h2f8w62xdK35Pome51xzBp7/8KGB jRnggJcx1eMODqH3oNw6wwXTWE3iK05spqqio6DzaMPZDHsE2WIuf235Q b/AJO2aRyDLzlts5rle5tTkdeI98ZGIJTEu0jPgOTKUBllshTRoPbNBwC Q==; X-CSE-ConnectionGUID: jCU633BoROWnDvYniubYsg== X-CSE-MsgGUID: U7PVNKgrTWm+rObgmJu+oQ== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="10445992" X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="10445992" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2024 09:30:48 -0700 X-CSE-ConnectionGUID: b2RpUJOMSTuF61E+G6ca0Q== X-CSE-MsgGUID: XJQyfgNJTVWxoCplcu07BA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="26783914" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 May 2024 09:30:48 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 09:30:47 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 09:30:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 1 May 2024 09:30:47 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 1 May 2024 09:30:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N2qtX2O1BEMnFgG/ocNHEdl7QalgNrdtbuuOAaJ9o5t3Xktzz3Ymu4CpcljLNhAgfJuNownyCLhr7aAB/zA2foec2krMhH57JjYouAkjSzSPVIXkJeD/TCjgdpPvns8nBgHDADNczAEJyFBH4tj/def9Ot6ysYJbauCv3u2oexFOfofX/3xlAdv6ne1eMX+oy2wlHlpRqRwhd634U+FN+b3EppgprfGSV4iAPjnv5REPruvEF0msiDqTJqMzCcLXSeqG6aa2g0DU4O/y8CZ1PUxij3bv9+lkJT0d7lBRcDI0y8W+GFX1dEV0VUI7H6gxQDr85E1jmwJJ78uaQ+IM/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FSJon80kYR+8z6s7Gbt1yK+XsmUfc5L0tV4QMIgaucI=; b=oZuNUSBb7McnD7DpY2GeYYGtGXCst22s6w9fqMH7hut/GpXPI8fBua+jr8sV5h/EIVInuCMyp0OeCJ2oADGGlZ6ZJoo2+cBSpue+lnFoientXVqYa0KWTzzdibmw0VZnKjdcxcKHWUB/SyiHGVRu4GlC+dCLTA7Mxi5m+4jBYnRnw9TXrlLrty2YUZLLs/sr5L3hYVJLj89VwKZk+KQIkT1dtFq3apEFRdar41sEyhlJ/cm9PEjql6bC57M9L5QZDo30pqD5ea4EpZMyIQM+VBgLFBijUFPEqWwwCxWtBNpRCUfdsSeE7JKsopuyT67LwHZRmxSugsaKQ1Iv67Y2Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7186.namprd11.prod.outlook.com (2603:10b6:208:442::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Wed, 1 May 2024 16:30:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Wed, 1 May 2024 16:30:45 +0000 Date: Wed, 1 May 2024 17:30:40 +0100 From: Bruce Richardson To: "Etelson, Gregory" CC: Stephen Hemminger , , =?iso-8859-1?Q?=A0?= , , Subject: Re: [PATCH] cmdline: configure input buffer size Message-ID: References: <20240501052659.231457-1-getelson@nvidia.com> <96d1ac1-b2cf-f6db-1e24-aead628a9d16@nvidia.com> <20240501074238.0033d275@hermes.local> <3ee37b9c-25f-cf53-5b3-63b736327766@nvidia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3ee37b9c-25f-cf53-5b3-63b736327766@nvidia.com> X-ClientProxiedBy: DU6P191CA0035.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7186:EE_ X-MS-Office365-Filtering-Correlation-Id: 2520759a-5898-45dd-3281-08dc69fc0ce4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aWZwP+VmaK07dOT0wXk78amtqoGjZlc6friB3GNAIXFNgJXOeO/ILH/2FyEP?= =?us-ascii?Q?nxHjK6GrsHF1QLDu93rqBz7m4aMmmigKIT4ET2JnZjEuSy2Q43IALJKWOsE9?= =?us-ascii?Q?xBhyzEcTcHs/BosLJJwhPMMjfCHhIhrXiacmoZaSIGiV13i7WD+XRY3WP5LG?= =?us-ascii?Q?oqkCiiMGC/MqF9BSWxeeTTg5yJBbEAOt0i5OQLXPqLugHbA/Xj4qN45NvJBm?= =?us-ascii?Q?sEzoKr5mImChQYXdhyhtMUPfWgCxNsZPCDFFGpQs/YBMP9c2PKkKH3Fsl0Xa?= =?us-ascii?Q?JSXn4tOegaiowdYLymAW9FRcsSoS1/d/4INFrkFHe+sovObFs5DA46eztU4D?= =?us-ascii?Q?VWYNbqcPMCeg5QCve8Z0NgtfM6Er5BV6pKeH1B6FS5dJGURIIyACd7/aAA+M?= =?us-ascii?Q?nXY46NAjVrf9MIYFytBBnhW5dQS1CCdZ5gpSPptwwJp68nu1/ZZlSUUFBNsl?= =?us-ascii?Q?v/vHd9Rw0BXWcjildzL+cdDhGcAL7wJP0/j73DJMqTmzUViiu7VqdxRk5ZpW?= =?us-ascii?Q?0lbnBuwfBPev8JQnc/otgs1GHqBpjezrVDHlDM+guFfBBRerrX9+3HFwDeXD?= =?us-ascii?Q?kmzNs0eMoMsXuDvyrkIAZikJGk/1sDhfcZRDHObk6uiuPsw9xf1LagT/BXhb?= =?us-ascii?Q?xI6pD2XOwIoohjSpCjC0FN6XJ/bU70nkdS7vc5S2gd/05z4TMhhVctdPDhTc?= =?us-ascii?Q?K6jGQNADPwCYOGYcwohFUop1VrWmxwZYr2pT2tlsoYzm0KjlrNGFGfO0MZhO?= =?us-ascii?Q?PxgHfD7C2LMnS31Oc/Y2oUH6VkhvOMOHp9s/iVoFtENmbYSQ1IKrcdZWBim8?= =?us-ascii?Q?54AuyiWgdbkXLp1BsJ1DKOfn4jWA7uiZidBwe2e0TO2qMtLEU2tqRQYw1vff?= =?us-ascii?Q?CuKIJ0iVmYDrqzKD0uVlTTLDprErdS1LucWspZJcdNhRA5i1XSgG2jsisYoO?= =?us-ascii?Q?ImAdlnOcaEfFzOZg22VNvCHRbIg/5hD80j0bOIaAHkqz01tgYsxz0defKotF?= =?us-ascii?Q?v5x/KDPJNip3kiKSXTfRh09tc98/j9cap3XCRsoKZl4qqloe8qEpEumXpfEH?= =?us-ascii?Q?kMjDf+ULnWGa/HXbuYLS1V/je4S9lxY7YEj+FugaOSZyaMsjyu+hTDP/HkbT?= =?us-ascii?Q?irNeBuFp+tMuBGYwmtQ6bcA54i4SQJJkmwMFgHrjqX0OXBTMc60HzZHzyEle?= =?us-ascii?Q?/sqnu+FhouZ1pTHdvav/5CSfXDYZ8U/gHlS1TAtz57/yXzqHnivft9iWped0?= =?us-ascii?Q?DI/Hdr42ypo+UewWjjzh7IDX/zisxBb1iWZV/oA0aw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y4WG6u6xg4Jq5Q38wjmyKYgPp8J/5lAL2Zr1reKZoiKv0Umz7wIzxugoCNo6?= =?us-ascii?Q?qVy7pEZyCKuASdUGTPNhfB6nYif0ZURfhmcVHzzNNLq3CF6ZIb1HOJNKZ6nZ?= =?us-ascii?Q?nHsqk7YMhSiX7TN9309JwC+Dxlooyee41WKybmUVkLeKP6mXHoTjbMOGp1SR?= =?us-ascii?Q?Gpi0StqlYBi2VxiL4j+EP+qpCO3wptGj/uOznkf61bHp9uaCMOYO+tVgU4dS?= =?us-ascii?Q?hZhkWWaWzDsEilZ9F3VyA3mkNDhpQv169tJuicJVuvZOtiBesj4MtfbsZWpZ?= =?us-ascii?Q?G3IGS0hT7F933swXRgdvQB32msebFZwqKU0OdVL6S4gfkPAwM9ahJ4KhE7Ek?= =?us-ascii?Q?VwXFsfWJcV1/hIgj5QkoyaSvtxVsm7FB1ODtneW2xlisnZa+pG4gpGpEq9hp?= =?us-ascii?Q?ZPmEmUbmADI9glHKqY8YcSZPWBgq9Vz+oN8/PBHqd5gfh41LYW2aEN2gO5Hs?= =?us-ascii?Q?n92uY0ODjh6TCNhzlo2MyOkQo7I1hNHKuCLnv8klqbPteBEbfsvGD5Ij/v8n?= =?us-ascii?Q?wkRCuTHONIkQkGwqx8Ab7SuKhDZ+zsCJ3BF0i4NCQItpCh9aeOC8XoZzjBQ5?= =?us-ascii?Q?8eEQkF9B3U7QZyqnvKE3YTk+Jm4uoG0OS0j1bTHp7/u+Ll5NRX2M7rM55KAl?= =?us-ascii?Q?HAKGKFh328gqONhCxkC+LL1Su+Gs8xk+scU9wu0mTW8HkNVSh8kly3zF5L1G?= =?us-ascii?Q?0dF3R8XOoIVI5g7kXGjuXmzSS/TV+srCHs/4Dj2tE1HcUAxFYsUgqeqz5bUQ?= =?us-ascii?Q?wABre+wfBZkV+LiyrjvSipM2G5a30uF7QONXIIrcV2xcsYHXpraNuATUOoki?= =?us-ascii?Q?W7YStEcGoB4edxjpYLllFo56YDMdKH+UQVcLBmzwe/6lUbi2eqP5RFUQsRNR?= =?us-ascii?Q?LdhNAgB+amrVa5a/IWi4SqSn4Jo266PXPMfGNtxwOkL5laIxzzobGZsh31CY?= =?us-ascii?Q?7er+Qaa7e6ZL00xh11UkOm3/oLlp9zmsY1/R6oW2mQoWPjpm6EQ2v8bKZH2v?= =?us-ascii?Q?OErh19W5QDYW9MHTEkXEZD82sWga1Fu7IAt1YcUF9lzgIC5BvMrRKqCy7fT5?= =?us-ascii?Q?dBH1sxFS0Ob/ytrUOdaHnYjUnQ4LypHB7kS2B+oyYsU4UymcF79DenflSxmK?= =?us-ascii?Q?qCpFQ5HOOjmfEhNLrXgzLrIkmAB79TD389XdlWvG6MC+wwCyolIFmqfX1AbY?= =?us-ascii?Q?zWIds/+cz1xtk1jzHSUVvfjcHfiN9VvY1ZzAdGll36AJaKSQEc/SckFjcpGq?= =?us-ascii?Q?nLvucKJqBrt7j3jQduGMlrrP0TtHAih5pl/IuCYLX35D6OfZIKbk7AtxqJF9?= =?us-ascii?Q?HwdbbE7p1EYSGYAh0VD2h+7ZWTk8iRsQK2QwYHaYVJU+p3lZcOTeXl3VQc5Z?= =?us-ascii?Q?wO6kMD4reEsfb51ivAan5ok4sA+j3wUApkOBpjf9Ndu377/r3kv5WVkMXCB1?= =?us-ascii?Q?LagSE2qwdPwxIM4uOlQ5ld5u64U97vpfnR7clfxca5LMVga/Mu4gPZT0kKaV?= =?us-ascii?Q?5TPuO5wMVkIrn1l9W/mjt4JYjYcqF43yutWEBzXwJul5AeC8ue9wvxdQ6piK?= =?us-ascii?Q?YRKRdnBrHtaBDZWgQ04dvMl3Fjoou3w4+VC4dO1wb3+ub4u946SjRPOROdW0?= =?us-ascii?Q?AQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2520759a-5898-45dd-3281-08dc69fc0ce4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 16:30:44.9952 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hn+533BVg7eu1tmuzTCYeST8JNJhAi3FcFTslx7I8JgMWXtbxLsqZY+cqPidxxFr+FH05XRR43VGXRkE2Z3ksaE0pjbF9Ysm6ik2BH1TlIw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7186 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 01, 2024 at 06:56:37PM +0300, Etelson, Gregory wrote: > Hello Stephen, > > > > > Basic question, what would be the impact of increasing the default from 512 > > > > to 1k or 2k? Do we get a large memory footprint increase, or is it just an > > > > extra 1 or 2k of memory used? > > > > > > > > /Bruce > > > > > > > > > > Increasing the RDLINE_BUF_SIZE size will also increase application memory usage. > > > However, that memory increase was required, because application could not fit > > > it's command line into the default buffer. > > > > > > Applications that can run with the default RDLINE_BUF_SIZE are not affected by > > > that patch. > > > > > > Regards, > > > Gregory > > > > > > The buffer is transient so should have little impact. > > Why not just use LINE_MAX from limits.h? > > > > The LINE_MAX value will be enough even for the template API testpmd commands. > If there will be no objections, I'll set LINE_MAX as the new > RDLINE_BUF_SIZE. > +1 for just upping the size. Thanks.