From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECEE843F1C; Thu, 2 May 2024 09:27:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C31D640299; Thu, 2 May 2024 09:27:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id A67634026F for ; Thu, 2 May 2024 09:27:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714634855; x=1746170855; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Kt26hKFT/gratLmMHFTGXL+BFM2+7sd42XnuK3KD+S0=; b=DFKbE8fsQDyIoH56xy3Ms02Ada+cViF2IRX+HIuOqRVg0uGM00ooxqJg xvO8zOCfI1Qrp2MoyGiwWSXIEeQ8XzN7Sy1dBiaDLkB8yC30JfvAHK9Eb VT3++XsspLzdjca1G7J3TguiBE+bZW+jtXWfinXrNQE+1ayFPjeXV8gg2 mBZNOfUEC0+YZvZZr5Upr8iZNCs4NiJIo/0g317RSs0JnShRb0CqrvQ// 5ts8K1e2hIaYbmhm+KRxz3hKPMXHOMiT/mpndTjQ93caDT/bCVEldzfR5 cnYKTgduVbx4IGtSIy4VTqjCoKU6gzf1dmI0FQrpKzy4qJjD2Gm1hCIE+ A==; X-CSE-ConnectionGUID: O9xmsZnrQLaRfhIQrUW9Mw== X-CSE-MsgGUID: 7f4Ctu3mRVa4BnKP7HiuMA== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="10515063" X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="10515063" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 00:27:34 -0700 X-CSE-ConnectionGUID: 0Rfw3/z7So+crb1ZneWTHA== X-CSE-MsgGUID: Pr4Gr27CRwizAzcXP2Ritw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="27539326" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 May 2024 00:27:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 2 May 2024 00:27:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 2 May 2024 00:27:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 2 May 2024 00:27:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 2 May 2024 00:27:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7bXhGWFJC6HwXTn7u8LKK4URW82Qmc2ziqwIO7bIJMZv72gw/GbL6mbzMO0qKkVkqJoYP+ulKFqLD2D5Sh0F71VRJYSxtyll4jm6AMd0o9DIPRvFleLvtAZqmAvPOBVJJfLOx1ziX95bWWWc7Os9/qdjNI8dtfD8QN/61SoDSx2MDbsdd+053499CYBFKpfZNBXaPQAI1srUSPL3hnQ5ICyKAfkAwEScGDRifPWuynbul+wBuqwh5WMz1+vF5pnm3FGb7sDTAT9gOu0VkVyJSS3UYHd30HhcgmNGFZiU2+BbvZqa4qyi8SGbhCn1VD66L7iBa8lQQJ4UG2vermuGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBMe1Cq8GSCmudWsx7WFPtNGjjKe0SF3yo7JqfzrqsM=; b=cbFsWaNjltwrVfBHF+Rh87AmTTRJEzs5/p8ZskJWnOmwSvb6ByQMwnZ4GplVyEXRMveRATMtlGkGuGxoIELnYKmNGXyWi/RJ5O1QOYA+UIpAh/jN9nu/e5iWXRsgChWkRGLVpZqtQAQzxZfvDcXqVZuA1wvT0UqATQPgIft9ptvsBynjt+SYZQ0tds+raJsJe67efq5PN5ptu3H0+atMmG0Vid/KiiRG/t+97RED5NrAS1gQQ3LJRMzHRksJliQPweBdDHl4W2XL7ZySYprok6XpdPvTETb9p2/fi4R3c2issGfwAmF/Z/u+Q2Az0y/i7duXofqNp1odPJxoClUenw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7947.namprd11.prod.outlook.com (2603:10b6:930:7a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.40; Thu, 2 May 2024 07:27:30 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.023; Thu, 2 May 2024 07:27:30 +0000 Date: Thu, 2 May 2024 08:27:26 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Gregory Etelson , , , , , "Stephen Hemminger" Subject: Re: [PATCH v2] cmdline: increase input buffer size Message-ID: References: <20240501052659.231457-1-getelson@nvidia.com> <20240501171806.307533-1-getelson@nvidia.com> <98CBD80474FA8B44BF855DF32C47DC35E9F412@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F412@smartserver.smartshare.dk> X-ClientProxiedBy: DB6PR0301CA0098.eurprd03.prod.outlook.com (2603:10a6:6:30::45) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7947:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e4ab1e7-e59b-4ea9-37f1-08dc6a795352 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?XoON8F7YaNcmOI6EjdXsiB6H+OY/IZD9sgBf98Xb7DfcM0VUl2900O94bS?= =?iso-8859-1?Q?mpNN1F4o/PXGQ+nXeR6h0s0gvqKnUdanGVRESE7IdRxHP9BQt8peiFaiZT?= =?iso-8859-1?Q?SYBhg041KT7FgY2FczcbmpjXtJggFoUrjBvPbTZJcPNi2QHL6DVRtrFHuR?= =?iso-8859-1?Q?tKWyftKRo563sJStbkLgU+GT6+DU8YBYqt+YGAY893lq8RkSiwJ2sHVLrg?= =?iso-8859-1?Q?wzmPpPhHcjpUFN3tByzJ5ugJFbn6DLs15sUp9IhSs2UJyMjxSCrSLs+bmm?= =?iso-8859-1?Q?0qo0NGxJ4kUoLLeZ+ItHNTXCodoZVWq52ICUjSJ2mtvWaTqiY3/8eu5T2a?= =?iso-8859-1?Q?A3OEW2tlc8XaPJT9qiGu9RcYe/xbKy6qeBmeOettO5/MGXlTHlXzI6GyUP?= =?iso-8859-1?Q?TJQGDKhTQfDbbrShFox+wec6p+qa7brL0sRjqPubApBnGMHY6cfBfmucrJ?= =?iso-8859-1?Q?sfraEbNfazIUDKskGaZv6yNZ/frWatKN5AQNjkMastES+dKRI0Xh6GwAyL?= =?iso-8859-1?Q?gYNyzsHDd1AYEHDO1lkxsZMjyTiHyvQG0GfE7q0GHJfnrT2O58SjHKwGzg?= =?iso-8859-1?Q?UQJy96LqWCtZLhwDujgHbYLU3E40cAxdITzNbcjG/m9XPIEt1vysimZ3G/?= =?iso-8859-1?Q?EMvJ4xZTDWpvkHtP7BuxvtiybYd1lqnm244FeqPBME+e5wtNeK7CurufgX?= =?iso-8859-1?Q?hmZZ06GjrG2YgqiNZ3cbDh4ch4tDB1Y4bp2zfZtfkscg0PI9Lt5wqyUrbk?= =?iso-8859-1?Q?ywj6VyH/+XpWOD4G014lnBUeC1Mq5ue5a17vEEdtFQ7fsTFLFtFOJG+7u4?= =?iso-8859-1?Q?b5myACqSxgHyGUaNMEu0vk6MXP5FUn/xd2X8JlGUXZ11u/ZrBtl37WOl0i?= =?iso-8859-1?Q?9xJRsqo7MYqSsbw6z1fbhEvDowVMgP/QZpYL3kUvaOzeyPwJLDLsjoHIjz?= =?iso-8859-1?Q?JFHRn9h4qhsjk5AUNQuufjOAQI31Bxu14T6sO6Sn7bnZvtF62T2n5XIt18?= =?iso-8859-1?Q?M6i4UOBwYMWw2U8X7o/1wjRJKs4MeR773o5f2pkLjEcGFTrB76MXW5aKqh?= =?iso-8859-1?Q?dFFrTV5e20JanEstDQbNH5/xHVDfVVsP55QGmJ0L8+N3FSSadHpUcSPR/B?= =?iso-8859-1?Q?Av82Kwhf9DMM+L8jfZ1XdZICn/JqJFlFVTRIVX21TM4xE+kuz9QFwubc/Z?= =?iso-8859-1?Q?9jcKMxnTXTosm1rCZnjkFMoXTyH+dX9cP+ywinPN2fTN/Jl3BpG+Ce770O?= =?iso-8859-1?Q?MOchOACuOxyNPhNfjR4V0RtOdAhiJyvtb+zon9Sm77uuAHm1Qqib5T73Fs?= =?iso-8859-1?Q?povJFDMooWhAQRzlj7u2/fWs9A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?YjVsBtt6BG9VGAW9Q6dUnS3eDXva85xMEvIqQz5UVWfvZmNKpmCpqRd0Ea?= =?iso-8859-1?Q?m/INXKS05HqGw53tjXfeSTzHmcSTcKoCK+9eqPkhEyJ9BrsLSXHMtJZy42?= =?iso-8859-1?Q?j6/S71V+k583PU27B6sSnO5/NVRKraHC50xqSzKf4PK1kVtkiNWMK9QlkM?= =?iso-8859-1?Q?epTGzgIkHxZqtpARmFnVxV9AR0ZumlZnKFm1YKLnPKaSVcgQQ/l9664vmJ?= =?iso-8859-1?Q?IU5QHrItruM+S9pLSZ6MZi08APAWBzdIEZ3B2HDnHg79ebXSOsu2oqSJSe?= =?iso-8859-1?Q?C+wi07b+UIOLzaENRf+DqWFB4Ngix3lckZ4pUhB6ZCE10Zbx29y6SUv0Lz?= =?iso-8859-1?Q?iyw1mswzOh0HLDDTxbHP6RDNouwfR2tD/kEYqH/xd1MS0z5+YTnpFprZ9H?= =?iso-8859-1?Q?7/IprLLUiLlrSbxwEl0MFhI3Qb5l7JAKXbVMxO9rEWMBwBNmSxLEhLudWJ?= =?iso-8859-1?Q?3csTMWEFWQpkU7ad2+oCb62LWCyNZDD408GUKZWz6JT682p8LS3+h5Ax7c?= =?iso-8859-1?Q?vJG5qjA6LH0KtOkhmZ05s998HF/2ezTR5EowaRM3hU9Q+M33sRhRgLnaiO?= =?iso-8859-1?Q?vuShc0m3k6lLDCZxVk9pdtTzFlXEQbLTLBk+XWsg84iQ1uG4xnbm4jJRGR?= =?iso-8859-1?Q?qMsRexH6GEclSSLw43yR5N/v+npkPr6aqLvOjUessNcqwxrJkA5jytc0xc?= =?iso-8859-1?Q?ykJZ/b06q0PdgCOkR2Gu6fMJi2z8giQrf/ZJqYnhhhacvqZPY0GUNLA3jq?= =?iso-8859-1?Q?t8qRtDWYJ2L18OR9XJ2zs/HavOhM2ieUa7gAV+8/QtH+aOaDmZzRwwRxP0?= =?iso-8859-1?Q?TSh6t8aTFChvUvDKCABxLg/oI2Xw1mMhBCXO7AL/ZhLOhZrip2zdel3fWN?= =?iso-8859-1?Q?VIxteT/zrETaEKqo6k9x9HvpZWep4mrTejMKbBcSZ+JhA6NQe+iBzkDS5w?= =?iso-8859-1?Q?Hc2Vu87uIdPiaJzE3gUNKPjjLMsbJcFuVbcy4ptOTv7DwO7p/gOp7OIKOh?= =?iso-8859-1?Q?5brb0QBVgPvRm+v33N5XWlnYZbYC7Af2AWdRLHiNsWSnjSKodDK76cHPkT?= =?iso-8859-1?Q?PMmTIVHkkXaWcyAvV5CtFhN1nA6YPpRq5lCBGqaJBXTqqA7WXjzJIy4roV?= =?iso-8859-1?Q?WsoYf3p1Q/KIIYUIy7rp6soObMk9YTSYVAzQscI+OW1stVaQzjionhSL9j?= =?iso-8859-1?Q?i6FuHtXW0pSj8ZISX6uw0m3EHpi8NnTClGd9tXlfqOO9mBcrddUQracIlS?= =?iso-8859-1?Q?uyaq8VmPk0zy/CLtLlB5qu3MZYOfD6nTA5KitbYpmNkRmmiaUmTH+JSw/0?= =?iso-8859-1?Q?d3gLJAJao2lb3/+sn3EXDRoIijCg5tHSq2tvSGOmcqRF46QNo8c2EKTO1H?= =?iso-8859-1?Q?nRtTcv5rO2SXSzqsC6Y0YlClkJco5abmlE6IPORXk7/fGbq6FaHKQwpbfN?= =?iso-8859-1?Q?3oQR0xfEtCdNk73X48AEnXFvfX41ZJcNoaAr1KjTY9RFcd36L+EZ6XebVy?= =?iso-8859-1?Q?GtWcnCF20UDW6GQYarfyWwnjmBySlr262Ds0jcUldM2islHsvMFlgg27ad?= =?iso-8859-1?Q?a1aDGrH6auMwIXkLVSX6qyehOsuUgd4nOhXOYNqbKKveCNUe7WacZEziJe?= =?iso-8859-1?Q?4kEcrNXoO0qOPF75REntHyzKoOpg5iQM0jpZ9eYHW9E7tPwB2kd6ARwg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4ab1e7-e59b-4ea9-37f1-08dc6a795352 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 07:27:30.2940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BhClpqx9RnfaoqrPX24ZNykcxqinNiVlMeu6kPxYwdEWvpdP9TzPI773cqcRsr3BC/nfNmhGC7wa6wATxU9ObTWvn0SBI2rdSMJ2+keWpAM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7947 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 01, 2024 at 08:26:54PM +0200, Morten Brørup wrote: > +CC: Bruce, Stephen > > > From: Gregory Etelson [mailto:getelson@nvidia.com] > > Sent: Wednesday, 1 May 2024 19.18 > > > > DPDK defines cmdline input buffer size to 512 characters. > > That buffer size can be too small for long application input. > > For example, the following flow template API testpmd command is 444 > > bytes long: > > ``` > > flow queue 0 create 0 template_table 1000 \ > > pattern_template 0 actions_template 0 postpone no \ > > pattern eth / ipv4 / udp / end \ > > actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \ > > src_type value src_value 0x31 width 32 / \ > > modify_field op set dst_type ipv4_src src_type value \ > > src_value 10101010 width 32 / modify_field op add dst_type \ > > ipv4_ttl dst_level 0 dst_offset 0 src_type value \ > > src_value ff width 8 / count / jump group 100 / end > > ``` > > > > The patch increases cmdline input buffer size to the LINE_MAX value. > > + ... , which typically is 2048. > > > > > Signed-off-by: Gregory Etelson > > --- > > With or without suggested patch description change, > Reviewed-by: Morten Brørup > Acked-by: Bruce Richardson