From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5091C43FE3; Wed, 8 May 2024 17:01:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE483436CD; Wed, 8 May 2024 17:01:31 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 0156B436AB for ; Wed, 8 May 2024 17:01:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715180490; x=1746716490; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=+EEy8ZI7sM1VSbS11JhQpX3tgBmYoNUF69A9QDRv0Qw=; b=EwNzCwcYvw7xOlK57I/nOJ/iiwsFL7IsBPWHWF+roxspLNDq7DVgwU6T RrUhGmIDzVLMtedmHTPG49P1Cb9Xe2LtX8m9we4qDrj7rHEOlyrYiFbYb YBGGhahPOBJEo15a+CbYZsn8rbYdw9wGYXg/Yoa6rglr+DJGkMofpXCEQ +pEqfF8mogZW+TgXAIpSmciz75secWm11XCq7otfmVyoQQNRzcQKiRnTM JowyjUrRv2h1IeNLyuqQcISqkck/JuYqSXOsxm6gFz6WneyQoARGfiYvN EeyGqrF1vHURlNUyMrBESKeBQnTusdhVDPTDy9XEtrhjInGNDWwuR+EHw A==; X-CSE-ConnectionGUID: tNDcsxvRS8+RCsfxJx485w== X-CSE-MsgGUID: Im73wPLlRwCoiSPwQRDcxQ== X-IronPort-AV: E=McAfee;i="6600,9927,11067"; a="14865009" X-IronPort-AV: E=Sophos;i="6.08,145,1712646000"; d="scan'208";a="14865009" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2024 08:01:29 -0700 X-CSE-ConnectionGUID: HCzGfGhrRUSrKOWkdDm3OA== X-CSE-MsgGUID: FVn5kRBxTWSSm6BQQOB1Rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,145,1712646000"; d="scan'208";a="29489548" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 May 2024 08:01:29 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 8 May 2024 08:01:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 8 May 2024 08:01:28 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 8 May 2024 08:01:28 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 8 May 2024 08:01:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kmuYASzf/PHhQit7PE9pukzdQAYtoCrDuU6N933gSEHsWn3b2Pa8Jw8dmUX/x2v6SmwO0f0kqvjdLDyVs0I3GnxJZeM91ZrIXMM+cX8N/alUPK9Lx5/2m2J/Vi+mrAUJiIsKGg2f+p+v8uazIvEeTVwqhL8rQfE76DhIC+Sj4oyA1KZOzc9P9/89eKwVIRIkraiSxiU01gz8/a16hMZdmBYPic8PPUmJBCvf1WSbWG6poTyl3zt/Oll9iFZXHoj/LySL5AIdAUyMP7w7+v44XHTk7HfZv/yMbbre6NawTLWVKypIECND0PTjd3mXZ9qwAjWm/GSVNVpT3uC+dKNWXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NOY+LTSz73XqwaISKckERv+xPSbWz9J5IsT8MtyZxlk=; b=hTiH9VtdulzJEMm+cLaegE5S4WaiyAPu6OqwjivUfQdO6EEybJ0/2u8Vr7ysNEyNmS0E9xyZqth00SZClSD6xsqHHytP05CvvppcpzI7V1rIFQGyDoSm4aHcNRA+1qEXkg/PSr6rWsi4vcCk5wfNy7BHFth+fznxhmrBNsTOoyBxBYQkLZk1p5VSCzbfNW3vmbA36P9AUsyIXX9YVZ3HuILHRjGC0+vPnCjZLmIL2JLR9eG9+cOBuNPchx21LAc6EeY8vgOeHlXzeL7XKQf/MGD+pOu7T+Csyh5MRdnMWq4SSsa2kgGi24V9icmjJ1w7SxM2eiwKHF5Oom9evIqrqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6536.namprd11.prod.outlook.com (2603:10b6:930:40::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.46; Wed, 8 May 2024 15:01:25 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.041; Wed, 8 May 2024 15:01:25 +0000 Date: Wed, 8 May 2024 16:01:20 +0100 From: Bruce Richardson To: David Marchand CC: , Yu Jiang Subject: Re: [PATCH] eal/unix: support ZSTD compression for firmwares Message-ID: References: <20240508095214.2541115-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU7P194CA0019.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::34) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6536:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c1bc084-1d9a-4bbf-7055-08dc6f6fbaf5 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0BM2TUL0lwVsHVnGhVU/ScJTjC3J+dmTBU56GUOaUcpsjAHy8uAuLIlMPWfB?= =?us-ascii?Q?ST6CH8CH8Zw99eETR3pzGEA+NsiwplYMyCyZ2EdfUBKZvuRYxIi7HT/Z09fp?= =?us-ascii?Q?0t9AfMQmxJxrpndkr+a4DCeia8nu3VnmFW/gJ7PIhPwHVQu3Od7qxJqZ9B+n?= =?us-ascii?Q?uArMHnZO2OiPbvOl+m3rNdsITO1pcgocIDD2aZWnPyHdboyrtOH/JkxtBuKI?= =?us-ascii?Q?Imxr+/s89YV6ix2iCPxHJ+7mNKOdlxATGfJmzqaJqiiX8jNvWSCCfAFyR8hS?= =?us-ascii?Q?MViRUkb9gfLk67JtaUjKvsItpRGLZlGkOzdKajz05Lmur66zoITrg/Ov84ji?= =?us-ascii?Q?XA8s/oNIjFMywy2GC2bc9nE36YjERt3anAstPv5DQTQ1e/xP9bnwlpt3i55n?= =?us-ascii?Q?qOi99z1mPD6P+d3wpRYYPjbfHIhtlDqcUZ+qNwbZxbGvjHhuoGoCXBIArM5o?= =?us-ascii?Q?nIvlEZDOcsKCkKnYUvruR8CoruJvXXQ0kDfkHNeKYmONmvwors4ULgS0gDXS?= =?us-ascii?Q?wVhO4bDabi/ElR7qXAy1tnOVS2iWZ5/G7OKstIHO4AsAN7dPG/9XwrpYpiUH?= =?us-ascii?Q?PsGTvEu0OQmG0RlOEzTY1Vxxy2iTb4HqWMSyg/T+g72syRrnmAB/dqkMqICh?= =?us-ascii?Q?PMfr3y84bp2VQwvnswsvYlhynyr5mNMO/VMxzQh5oBPvduLvYJw4EdwIMjgH?= =?us-ascii?Q?Vr/p8l8oYP9uC3qUmwGyaI/sUI44pqYA4hFZwaM0nuWLbCmW9GNSEhzzfxvF?= =?us-ascii?Q?hmOHUhW50d+7vFWN0AhUK1mcL3AHtvisd6KCXDDg3wZySAh7yg6HxlNuqL7/?= =?us-ascii?Q?6/bZNhYq4r5LHgIhus6Cpro7jUu82spwwXbM/UTzahp3b0ooOElJa9vLOgsu?= =?us-ascii?Q?8iPnLQh9wS/hyhjnOphXQgdC0A35rDT04mvT10Kxu6drg5yTIcTdbG5zTIN0?= =?us-ascii?Q?qTGZyEBDaB3UFiiKbUQTw0RoiXQyCoB/UrvBt2Vk8CUIDhH/367+aQPeGh88?= =?us-ascii?Q?b9x1xZOVsmD++5rjaHSOspeVcmIyHec1laBOXi26rOGXaDkFVuto4/vAfbci?= =?us-ascii?Q?X/VW/QCDzPY00jFzaQL7OOAGrx3v5mttSfLPP69ZyVuK9JuBg2cSEc9TOjXh?= =?us-ascii?Q?kmgK4R5HkAeWNdXppBB34/hGh2/Iew2H2aBiRg1YKWWmAdCTKMx8IajOPC7a?= =?us-ascii?Q?azuYMi/92nL8V5R/EftSKKo3vCff79qX0gqRHetx0+L9snhoSrMe4uJWfSEW?= =?us-ascii?Q?CfqGokNxs+Jsai+Bg+Oq6vtYCNlFSqwkWf5trTW4PA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vxsjRctL7rvOztjNeQKYm347UVnaWl2ASADEol9nEElKAL5Vxl+hqxuLhhRt?= =?us-ascii?Q?8RkH/LOotXD2zG3PtgqSxFK+rg2SeRVroRLF/B0F+lDYnniTQDkWQ3mqdCDX?= =?us-ascii?Q?Ab++ymfvV1fRNjetwzna+wb7L0TNJdCUuZxCVLmWFP6gHL2YKn4PIqaZJQJv?= =?us-ascii?Q?jdqnK4HjIZx/BGbvoOEfHdV8s601UQeJPoMr/Zcd1h36LN8993szGE8HpxL6?= =?us-ascii?Q?7kpT2lME0g+VUkwikYSVOrEhhXYVB5tQ0g1PaHvJmSq1WJW95XT758PlRCGu?= =?us-ascii?Q?AAylLn+HNcgxdGQeG+77lDvf84RLAU4xtkO50I1I89S7DU2EranleAhWKA9E?= =?us-ascii?Q?QybZkvz8bhZD9M4RViSd4ZXiwXoEHQITIVmqhVlryzM5mSS0IhFMfIUmT9iF?= =?us-ascii?Q?CkvI1sqyiiyGVc8plUpJBUCzq3sDuDo+gw+TzANY3pMYrrxT1UKg6BQB8LeZ?= =?us-ascii?Q?VymfXlZA04N+EZnzJwfU+VGtizUrmGTkRf1pEe7gFuUAbWbDVdf9cBxfW+lc?= =?us-ascii?Q?RmQXxUYsWs3UK/Ro11xbWuOgcSK6R3F88zR3+5JXuF3bRDVs5Vo7Uqu8kBt7?= =?us-ascii?Q?1nwqKZWqE9TTMG87fumxw1prxKvvPnEHytUX750xl7u8tve+A17Wn7CnljNe?= =?us-ascii?Q?UMYnhYAKZEqYWRPAol79TkXDby/2h86HRcdE76cHBtavCfj5i61++5bbbbRZ?= =?us-ascii?Q?9BTPp5lVtsoA9FoQm+ra/XvxEkk1H5QVql57hnPMqUo+7PXPFB0JFKjAY0W5?= =?us-ascii?Q?oeq+Fz05IBQIa/uqOAW0ti96scZshqLWVtrTEnqD+Ekt6U/XH1NEMnTkgPHv?= =?us-ascii?Q?7XFAMGBWohq1CZwVEN2P8ri3PH9+DsQjX3liUjxvUAl9Zht+TMJDYoO5EG9X?= =?us-ascii?Q?yHS1AlSE1oCUbQp//FwgMTzfsSkPQ1govaXkTXcXHrygdzTv0shD6Fm73pSe?= =?us-ascii?Q?c5jzUfSZy52kh+f9kfzO66mDmbij/AC/Fvx6JBuYp/S5qqL61rFGPAc4Nwjj?= =?us-ascii?Q?OPdM1HT69RJf9NFDnkt/VsIMN/OUewajTRK48JwMPT4T45g487YC0I5wgt9T?= =?us-ascii?Q?pxIZnJV0xAcFIN9xj5mC7iracBlmPPF4+0dL0BDXSJ0g1dkKQCpWYiRZaROc?= =?us-ascii?Q?osgMmxOuGPX+zvAkiqeEPYifw/+ny88C6ybO8M431ZettMo8i4fDF0LSUd2q?= =?us-ascii?Q?9tJVqs6TvLiMrY//w/Tg8kgbpSrQnhSfAvEezfw7WReYPGIJiNDUTPrLuPQB?= =?us-ascii?Q?Xt7MKCJhk+irWamYvqMVyq5eiV640Pq2rK7J2JK1PK6JAdeVTMkjiIrqRs46?= =?us-ascii?Q?02Vx5rM2dMWCAFbccVMV5XBbQ2VZFdQAu2Fisn11A9X+nfa4+BvXJ+PhPPUN?= =?us-ascii?Q?Ld11Zv1wVXGO2dsRCih/Uwdjy1nmZFaYgxUwjmRO2VYtyb7tn3uNAUY62NX+?= =?us-ascii?Q?8aMpngS50ZrwTPZKmUDhXNbMY15zygqr4h6xY64gBrsw1YUxt2YrZQjkeY63?= =?us-ascii?Q?F1AjJvvESWRVUEI751r1j6uoiHeyJvAHu5yzBAYbjc5i6tEFzzCkMKrlNXE3?= =?us-ascii?Q?c2w3iG4qey4e2x+ojKI0zGQdxBKYx77RhxCNfUjlhGxzBiAyfM75xH8xt630?= =?us-ascii?Q?AA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7c1bc084-1d9a-4bbf-7055-08dc6f6fbaf5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 15:01:25.0609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lQ2vrKBc7rUHweYeS3qWylSQGMuQAd37QYW2oZdCrCK8HGrm5BmBnkGHXZl8pjpBvSscUvkEiFie1ojC37T+nNKyA8v9DOVLs6zTyJa6Qrk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6536 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 08, 2024 at 11:50:02AM +0100, Bruce Richardson wrote: > On Wed, May 08, 2024 at 11:52:14AM +0200, David Marchand wrote: > > Ubuntu 24.04 started to compress firmwares with ZSTD compression. > > Minor nit, "firmware" doesn't really have a plural in English. I'd suggest using "firmware files" here rather than "firmwares". > > Bugzilla ID: 1437 > > > > Signed-off-by: David Marchand > > --- > > lib/eal/unix/eal_firmware.c | 42 +++++++++++++++++++++++++++++-------- > > 1 file changed, 33 insertions(+), 9 deletions(-) > > > > diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c > > index 1d47e879c8..065e251f9d 100644 > > --- a/lib/eal/unix/eal_firmware.c > > +++ b/lib/eal/unix/eal_firmware.c > > @@ -16,6 +16,21 @@ > > #include "eal_firmware.h" > > #include "eal_private.h" > > > > +#ifndef RTE_HAS_LIBARCHIVE > > +/* Fake definitions for the compression_algorithms array below. */ > > +struct archive; > > +extern int archive_read_support_filter_xz(struct archive *a); > > +extern int archive_read_support_filter_zstd(struct archive *a); > > +#endif > > + > > Do these not lead to unresolved symbols on link? > Confirmed; in my tests, I do get unresolved symbols on linking without libarchive. On the plus side, this does fix the issues when libarchive-dev package is installed. /Bruce