From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DADB344019; Mon, 13 May 2024 13:37:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A215D402D1; Mon, 13 May 2024 13:37:43 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 4D46C4003C; Mon, 13 May 2024 13:37:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715600261; x=1747136261; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=n4zf9CHx1af3F36FULfd5k4A4eUjTz0m4gVjVDIdBYY=; b=RKSoEV4fmMhyqAwufbXA81oaDPdYCTO2+ubI4GWJH6VE9m7VH7EOa3qH G88GAZ0o5JWxi4PsKJmWW8Q+D2KuYT1KxzvsIbzxVrqDdfdjf38U7vxvb 1k+KropCCQfdCAf22m/51Omi6qrdbv0APkOaLRHynkSkddURsjuNoe95z TGvZrOJnEzIHPEHXwe2+t0SaL3B/dxj3bqXHHmgJk5WuqlBzmaZAr9W9K KPfysweh2lxXC4PJmLR8rLgjz+eo4zvv44B9pb8TKE1m12SpIfc5yulT6 lZZRdo9v3+Ohx72qsUXzn0r5czn9uE/z89q3RE+gU7nnYjNAN84U9KhIG w==; X-CSE-ConnectionGUID: +iNm7fGIS9S1IczkeYMV6g== X-CSE-MsgGUID: 5N3TygNZQCqrXPpcIRAaaA== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="29020106" X-IronPort-AV: E=Sophos;i="6.08,158,1712646000"; d="scan'208";a="29020106" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2024 04:37:40 -0700 X-CSE-ConnectionGUID: +TxYtUAYSsmNGPPLT+UtNQ== X-CSE-MsgGUID: OraDwP7tQzSV9dAvBg1ptQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,158,1712646000"; d="scan'208";a="30869394" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 May 2024 04:37:40 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 13 May 2024 04:37:40 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 13 May 2024 04:37:39 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 13 May 2024 04:37:39 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 13 May 2024 04:37:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkM50NmyZ4I9Yig2K4+ja+zSgKKi65+pHUzY1E5PhmMvlLWRLgO4UQIoP773NLRC2A50Nm5nb1GH6URiF45YBZBgOETezFaK1t3kyvJpThQmUd/u2SMkarzaS8zjApA+yiTXwnVIojHdsvdkx84rO4kXl1Vq+rM8n4dZevjOFm3HExoXJtT4Sw8KjDrEZ/qzkjvwbccjAxezxpuLE7zaB2ZztVxcdfOseBLVV6luOJEROvGUVQeJMSpxrGl0oYWewbK8N+k4L8Cq549Zx90sE6n+Su6JKk9gicTV7Jxld0TqODMqb5SdVaTfzZ+ffCvopc/CxRyWzv5bHz2W2zdWGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J5mbkKlGtmVdFwZ5262kfR4xwB45kfOoVxuVMAi4SWs=; b=WsVm5JZ8cyyYsZxmKHxv8GuFmCyoSym3HUYrQHWYr1xEE0BgcvQVjSQ/DIwNXA1Xp/BRSNV0BCbdJPTGPtQg3NEsQZlddIi1ah5ngiDI/9+y7Uqae2ayeGWJfJd/Jw7gMyZveAZFMElAThtTMvqMf0ppXg1c2q7mSrKom6mDLENqkG0tI/T42S2udcIzXEAZ6Oh20+Mgx9WyF7a1jMFU5JKGPjOPQNM1/HOpgSefbJKPknt0aembBOFZdAzkFWDC2XD83sWcA5EVy/AX4/00Gut355Q6Ar6mEtYC/yBruudkCYjhAVv+kzgVeYpsOSNVHH5SjIuDkURnubR5P2aAvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV2PR11MB6021.namprd11.prod.outlook.com (2603:10b6:408:17e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 11:37:35 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.052; Mon, 13 May 2024 11:37:34 +0000 Date: Mon, 13 May 2024 12:37:31 +0100 From: Bruce Richardson To: David Marchand CC: , Yu Jiang , Subject: Re: [PATCH v2] eal/unix: support ZSTD compression for firmware Message-ID: References: <20240508095214.2541115-1-david.marchand@redhat.com> <20240513111204.3120460-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240513111204.3120460-1-david.marchand@redhat.com> X-ClientProxiedBy: DU2PR04CA0223.eurprd04.prod.outlook.com (2603:10a6:10:2b1::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV2PR11MB6021:EE_ X-MS-Office365-Filtering-Correlation-Id: a4706ec1-1128-4d0c-0156-08dc73411546 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JtrZdojE4ej1UlBBIu1tS8MlJerXFT/IunsB/+/ujmvFxVzn3TD0UBzUONm8?= =?us-ascii?Q?Oi0V0MdLkikNjf5tS3tBBQj3iAkcJHOtC79QYGcnBCGb3uroAhc7/tkiHIFe?= =?us-ascii?Q?cFLR1Uc3j0cFt429x60rM1ROEo4KcuoYeJxUMnEgych+2nRvL8zZ/ObwEtOk?= =?us-ascii?Q?BIYHOWMcNPkCw8Ls9tiYxdDEhrd9UTpEdzFplo7j8WQKJ1Qy321P8sDdBhWm?= =?us-ascii?Q?Ca6Xh+3z9B7wTsqqoHraOiOtdRoTMmdsrpmLOYdwOoBou7QRDJALT9Y5tcdZ?= =?us-ascii?Q?GjuhdVb/YeF2ynA3dCNTRRzpgDfyk+sROSJ3lW++Q2UIiRhiAabGWoCi3N/9?= =?us-ascii?Q?vq9JLPJn5YsJxI+Y7nqk1qyxBhQUimJZ/axELvh3kpeCpJpUp4TR1a7lVGN0?= =?us-ascii?Q?QzZPxuwmcjqI67qjTO2KcsOPAjXbOR3X5Yl7IKXLXIwDhWHh9y14dbIj4Igz?= =?us-ascii?Q?NJEZF15Huah5gNlcFVyNjN6UQWe+5n4ALb4u1sfmhR4ZY0wrKeZD7LTwHIcS?= =?us-ascii?Q?3l9Lx2Onb8DMWdm3aig+O93SxJkWPbEyG79A7Wf/I1lmdzIeJjNtOnqyAAv/?= =?us-ascii?Q?xs3o+cslZi4j5DERuOJwVw7ZQFC14vqiwRmv6znpRvK4pmO95Ab9XjAK44+B?= =?us-ascii?Q?5L4oiAmaK70d9SJPUyz389DA+P9uF0IzUcogzKqb/Grxjnxa0jPAM1Wr1+Md?= =?us-ascii?Q?nQsOXI2eYOCX4oE9LjS+jL+Mu2TxsUrqBPD8o34IlZy14XWvhYMOf+5aOdKc?= =?us-ascii?Q?oQUG+FYGwm+7AMeCi27b968hsSPlFzma/X4TIHvr+/YsI7W9hMlNWDnyMBl7?= =?us-ascii?Q?z37m+hEOjtjf6EYX1L0CXEnqCwMfaDaP4otxXjKZWspt+Rf6axkttq4dlstL?= =?us-ascii?Q?UxRg/1PXWBPgPP0O6E0TDnUIOr9flqxn0nslcesN51OWkuH7u61nHco/9Cz5?= =?us-ascii?Q?utoOUO7LPBu5dahrzgNO5kmvZiAg3VfoDzMWUjOKx+KNJlRUpAHkPLGPVnW1?= =?us-ascii?Q?gn6GQFY5jVQMoQ1aeOMk0/FlRxBZlWfe7zVX+FRSnyOz76rJhjqX5YyLiDMG?= =?us-ascii?Q?iWU/GZo+8dr1W7CkMfRAchHAaOeIRCCwjsK8Leh2mqob5rv7NdbK/MDCPEgJ?= =?us-ascii?Q?JdKJYkudvhC+5bdJ1EamZjuKTEvn2HEV/+FMlTlTgVVzKbc7+mwrW4KD+mub?= =?us-ascii?Q?jsVbzTRwDo5XRDr5ipGlp6UZgBIwITyFfo9KPOPIk91Ms1LPABySlDeA6C25?= =?us-ascii?Q?mTqTwMMlPtZ4SktPMXWTk5L0THA7oUPs9v/awuDauw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dOReGjBuymOVhV0LrkSlxNVJf5VQhIXCnjcmfv8QgqXqfU3ogtl/p3VnQ7s3?= =?us-ascii?Q?+yixR2oiRPa624yKuMxWabEgkEUvTwdxBrp415q+XteBN6Wwq88TaRVyjZxG?= =?us-ascii?Q?eADfms08l1hUQyKuPnMsc3w+UU22D69daWcpl3eVr1+WpApvPxy9PSC9oQ54?= =?us-ascii?Q?95eLwy3Gp6KdGgXIJBgcl3kqkdlM+yhzKmwE/k9qLI0gqrF6JiM0iBHEP3ME?= =?us-ascii?Q?JCZi2LXbJCyQY70ouFIlZ0ZEJ7bLxbJyUjtWi6wNCvaauLIuvlxh2ISs/sL2?= =?us-ascii?Q?33cTCffhepCNwUtGfUzLy3fWCuEmaA/wU+6MWC6Z0BqPQfnr9vaB3SeJU+MD?= =?us-ascii?Q?+QM38CGu9lgcNNRKOZaPqYZBcxkaw87y3qmYtf35KtYoGPYhLICQreClAk21?= =?us-ascii?Q?oVc7Rinc1oxR0SovcvAewi0hjq9oSOed+SkZfR7IJywVccLGfZ5GaH5CoRyR?= =?us-ascii?Q?zDnC82UKSh6mSCXNkF06reP+QwnthSZKSe/V/beHJxMg0Pk8k1zi//PzBVcX?= =?us-ascii?Q?mehS2MAqXC6bjx/jnGywjNyf7PRop7ZRr78SYnziVQqiPLdHDDMXj891OAHT?= =?us-ascii?Q?8f0uKIFZoQ9awpKYp//0xTEdb8h/tQj77mpvL2pQqK2c7GH9dY2YEllUImwd?= =?us-ascii?Q?KKBslK0U/MFX8ttXD/4Un4HL1M08wt3nZYwxRQqB432Y0mAvYPo9mCAY2ayz?= =?us-ascii?Q?NBvpS/OwBNOSvI7gH8ZrTB1dwVVzKB6TkTYeZ603imFCBHl/FdrYo5CeRQZN?= =?us-ascii?Q?cehNSVizQqe0kSkJ6SjoaK2XbxUrfdlQSgDSbqCSO4RgH+e3YMywFw9NS4bY?= =?us-ascii?Q?VlgCvU34M10sGCCnYta/0VZEy/OKV7CZfdAiLC3s9IE7RWGP3qVIGJtOW6fJ?= =?us-ascii?Q?dOI3w0irYINYy9Ey9eHzK6HRVd1pFgOo80KYsAHwK7HGZcKb9QgGqZFsv+85?= =?us-ascii?Q?M3IwzV7yQAoeQS26JqjKsZG9i73L4So1k+It9ip8kV+5GBzSNFlnh8W3SuPc?= =?us-ascii?Q?Hwi3lQDiHyFAw10q0no5eSG7Cgd9O3FT6IKpBKOwqk2icwXhuzK2q0bcdIRM?= =?us-ascii?Q?sWc+obOKnpGPe82b5AZJuxSksjth9XeqQ7/T0XJF3XFUUtPPq7WguiRBHJFw?= =?us-ascii?Q?KHGMyZi5oHB/8NwaynXND2R3PDj4C40ojGzCYjiFH2Zht3jx6ZOR5Sz19KNs?= =?us-ascii?Q?fJA194sOD/KQIjzxvfyteLcmWC21iHlaFwhsQ/7fmSNi8BB1bW0zDZE4K70m?= =?us-ascii?Q?Go9o7VtVFl8mDaBD2SSrJDHoCxNGHVjv7iKDhsihcTlGvzphHmQmtlPRF2fS?= =?us-ascii?Q?8o8yL425KrGHxOCSfHhIGqNmlkY+WGO5ZnstrFcqGv+8IUUzbBiNlFcxgMGj?= =?us-ascii?Q?xYyzt4GiUtZDFtqLl9oTy4Wt73ILTOjaebgzNTXERXAEfp3FQidFCWdorNac?= =?us-ascii?Q?CWQWY4KL9zm6MPOF9ya3AX4SOkFrBgiOlIgkbAjwWys4Vopn4WAknl6tJ3g2?= =?us-ascii?Q?LsGyoBpWQrB/Vpt10w1ghDrmyzc+ZSi7ToBVXpey5jHdG5QYaKQ2kkQ3EwFi?= =?us-ascii?Q?fElfWJTy2US+/72XEaK+MJtDDvkteN6OsGKg47mN7jJkbzwnIA+ZCJHFxI2D?= =?us-ascii?Q?HQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a4706ec1-1128-4d0c-0156-08dc73411546 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 11:37:34.8858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IgMBYmq8d0u5dvGFejJvt/DaZt9gVoIopPlQhLJTj64pdmUuAOunJnnv8AT4ZvTjGTFMZPazReHGH5qZAxpsZGw3dEXjV7GzHbstSQcnGE0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6021 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 13, 2024 at 01:12:04PM +0200, David Marchand wrote: > Ubuntu 24.04 started to compress firmware files with ZSTD compression. > > Bugzilla ID: 1437 > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > Chances since v1: > - fixed link issue when libarchive is not available, > - Cc'd stable@dpdk.org, > > --- > lib/eal/unix/eal_firmware.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > Acked-by: Bruce Richardson Verified that port initializes ok with zstd compressed firmware, and we get suitable error if libarchive is not installed. Tested-by: Bruce Richardson One minor suggestion below. > diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c > index 1d47e879c8..31de027598 100644 > --- a/lib/eal/unix/eal_firmware.c > +++ b/lib/eal/unix/eal_firmware.c > @@ -16,6 +16,8 @@ > #include "eal_firmware.h" > #include "eal_private.h" > > +static const char * const compression_algorithms[] = { "xz", "zst" }; Very minor nit: these are the suffixes used to find the files, more than they are the compression algorithms. There I'd suggest renaming to "compression_suffixes". [Perhaps just fix on apply if taking this suggestion] > + > #ifdef RTE_HAS_LIBARCHIVE > > struct firmware_read_ctx {