From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0AD644034; Wed, 15 May 2024 10:43:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9A52402E9; Wed, 15 May 2024 10:43:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 91FF44021D for ; Wed, 15 May 2024 10:43:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715762611; x=1747298611; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=lhAv/7cI+ZZFXoWL5lUcBav2Z0i5sOUEwULGknhKPSE=; b=kJqZ82q4QvFxqi2UWZ1CN4SZoxwaHyba4W5dIqpTxoixZQAk8gMPm6Ma OtYzWRzWzrf4BxlV8hHb5UGpZIe+BakdlgtdiQem+v50ILGyWbz9s4Rut q521gIXyCMmbrsS1fs5puhf9ykk+gNLKXG5riGwGIl9EUwMBaVsWjlZ5m aXzBhTRargN7CZQ1TGSHjef54pWNSYE/UrTWUFFmO/lW7thQXfv01caI3 iinceDK7mo5WAISLatnmI16wqhGV9p9SArdA+hSfJy/v3M0rAR9qXHH0x 2h+jq3LZSqEQ/qSD2T6b1Y4jRgcjP8Z7lf2pEEMuqiguCUxpUTb3sL8DW A==; X-CSE-ConnectionGUID: aZc4rmfEQBeu1iPf+GCbWQ== X-CSE-MsgGUID: V90BU/WFTt2U0pCPwidIPw== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="29317252" X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="29317252" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 01:43:29 -0700 X-CSE-ConnectionGUID: LNO+PX+IQ6KWQkp84U3RVA== X-CSE-MsgGUID: w8O2ZEs4Roq3pjSSrAuAbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="30918460" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 May 2024 01:43:30 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 15 May 2024 01:43:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 15 May 2024 01:43:29 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 01:43:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nor2TwCJq6oXKgBaDGGkFQjco2xuXrjqHe9AbBXzD7Os47UCeCWjkTKNMHS3J4fgzrUkusMccDBO+pZHsZm5G3iI6LVQ374Zd80v4FxErmf/M09lv7j5mUWYnxYgqtZ2moZJF39YXJFIgBaSf1sAWRt9ZRxpDH3aUsLdZmtAXUmk9wNhc/THq2kRwEHsWZjt/R5GwzVVqknKg9lY4OB7IzuVnCUvyG1FpKdHRYvpvZ7jM2BsQ/VvVREywlF0Ar4lii2mt5vbLf1fuBGMobT+m39u7PL8kgKKxe7UeOKNJ5Dm1/TVg6/58caUGl0sMlA9MEVNUvObCsz5YN085j269Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cnQgaj9iasdgIb26bVYMeSLMyIofl1FKWZEmgD9ZJGc=; b=LAHIzUoiVBH++x12idv9jzecawLRoZYngftsuqKv7lVHonuWQA08WYy6ljvMLMY+6q+Swcsvq5j8g8P+k/shZwq5s13chcjc/cIJRB6XPRHaOfDzZgDuTb+kvxIS2WnUDg/jJoL8K854ZokhFH3mv/bgKzZYvuy2hMBd3gBrEsDa7co2FoMfs7Yl02xBdv1w8FS0WOhysAXRctP4QDvfu/UPVwVT/HTi6wvsCzyNTHXPDZgaSG6NXZXmBK6jwtTO1+Iz8E3XAWuBlpk18H4jgQibBwqpjUHU5Lb0Z1OpzuO5dNEGdMp0cjpjnZ7HRWNqpwST3E4xSB9P/KI+VxiXAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB7703.namprd11.prod.outlook.com (2603:10b6:a03:4e6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Wed, 15 May 2024 08:43:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::69f8:59bf:3efd:9ee6]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::69f8:59bf:3efd:9ee6%3]) with mapi id 15.20.7587.025; Wed, 15 May 2024 08:43:27 +0000 Date: Wed, 15 May 2024 09:43:22 +0100 From: Bruce Richardson To: Abdullah =?iso-8859-1?Q?=D6mer_Yama=E7?= CC: Ferruh Yigit , , Subject: Re: [PATCH v4] devtools: add .clang-format file Message-ID: References: <20240508211934.1143124-1-aomeryamac@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0232.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB7703:EE_ X-MS-Office365-Filtering-Correlation-Id: 288dcb46-0229-47f9-975d-08dc74bb16ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|366007|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NFN2UUd0SWNxY2NZbVBmT0RFem93cEhVaWdFQ2FBU205LzJxenoyVWt3YjRj?= =?utf-8?B?TTRNcU1tWHlaMlpIWm9uRno4bnFBODR0KzhrakJSSUtTSDQzNmJKZVMxZndl?= =?utf-8?B?T2ZSN0pOMjQ4M1JFeVJnRi9ZNFFTK1NmcmN6TVdxNi8xRnlrRkd0U2JGRUoz?= =?utf-8?B?Ym5RTEZvNXRoNlBCcy9pWHBQRXZncHZDUlJUc1BQMUxvYW56NXFFVXp3ZUpl?= =?utf-8?B?elMyWE1hWFdmdk1XNW9KbUt3V2VUS1lWZGI4L3NvRUhyRlA1T291VnRIbXdH?= =?utf-8?B?elQ1blhKSFdWeU9ZNE9yYnhKa1E1NWpCd3lRT0pvK0o4a2pHYk5vMVJXUFZV?= =?utf-8?B?ZzhjanN5c0piTGhUTmtCaEttcHV6RXIyQktEbkdQMlZ1aUwxVjJZMUhyZkZB?= =?utf-8?B?NHJ5WVVabURlbUFmVlpDQm1nemZjUkRoYTNVUlJocExDUWlxc1hjQmtzRnJY?= =?utf-8?B?d3NlSDFrSTdzdmdKWVZHYjl1SzNZU1ZlUkxpOTlqdWhoUVRlZEhMVTg0Qndp?= =?utf-8?B?ODJxcWFSeEVseE1xeVd3eFJBNWVYWXFvcjQxVHByTEtISVVoVDJGV1dtTEFp?= =?utf-8?B?dEJ6UUh6TlNGVnFqdmMzbHVNTDlkR2hMSVlBSHFueWpkRWU0Q2JhOW9wYTFJ?= =?utf-8?B?aWJReFRvNlN1cmpab1ZuYnVTUUdwUVJQdVlpd3grM3FmYXovR0NmcTlWdFVB?= =?utf-8?B?V2gwOUc1b1NUSXRPOWdBV1NjWEdGR0h3MDdQTjBOcVZibTRuS1pucHRwK1NL?= =?utf-8?B?NmcyODRxZnFaaDJKWUprWDVQNEcycUpWSkJJaXhTeUkydDY0dkx1RXNvZm1v?= =?utf-8?B?Y05iUzIrKzVKVHdWaVJsME9YNEIrbVYvM1dFc1oxY2NxWXZSWVRYbUR1TTZX?= =?utf-8?B?RG1weWxoMW5HZDNDVzBEMmE5OTJzTXV4Z01KeG9MRVh0NDZhOHJUNE1NWGRn?= =?utf-8?B?OXZkd0RrNE9xRVRmSTcrSXNPbnh4TW9FeEZsRFVQbzlCb29TalV5UTRCZEYr?= =?utf-8?B?ZjYyVDg3MytqY3F5SEZrQ3dVVDZQMU1CVWZiVXVWUEx6cUZaeURyenhRMitm?= =?utf-8?B?U1pwNTc5YU1ubm5RY08vSkpxUTdwM0x1eFdYK1dOTitiRGhpTDVXR3JBOFEz?= =?utf-8?B?ZFpZQUhPa0VNQjlubTZabDRiZHZkRUFQSlZhV0dVUzk0RXhJTEJ0bHRzcFdK?= =?utf-8?B?M1dEVS9GV0RPd1grZVZMcDJqNU9vSUlLNlA0WGQ0Q1hYNUZEUGhKcmwyaFRR?= =?utf-8?B?QlQwYUEzNkdlMk5TKzNtRlozZm85V0swSlU2enZacExFSFI1SDdkZEkycEtC?= =?utf-8?B?K2JMalJlRUZOdUdFQVpSSUl2THk0V2hEWXRmMUI5K21rdk0yN1FleWdwdEUw?= =?utf-8?B?c2gvTGpDWTJsUHBZaXo0d2E0TXNBbFYycjdDbk5ESG1qM0VIVXNPOEExYzlz?= =?utf-8?B?d2pxN09kSUVRUU9Yd3owLytkNmFnUGFaRkE3YXRZZmpZODZINlErUGk0ZlFZ?= =?utf-8?B?b3d5bnEycmJLTlcxWklsNUYwa21LUEtSSGZsZ2xsNm8vRFJNb3RDZTFMc29M?= =?utf-8?B?eENLMDZ5YnZWSUV1NzhGNHV3akJoMjExRFo1OGg2Z0N6anc1WllPMnVJS2xI?= =?utf-8?B?bXBIaDF1TjAvRTV3MDJSNlNwbW4yM3Q2WnUxZ0NNekVldjRWdHVLZHVRYSs4?= =?utf-8?B?eWhxMkowaEczais5WC9BZnMvaVZSdHE1QTF4aU5SNkExeGJwdGtnMXlnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU9vNU5UZm1aWHlLMElVR29NaGJSUXBwOHVIdnlwRWpnQUxub0EwK1AxeFRu?= =?utf-8?B?dXU2ZFltTGM2Zi9aa3NSTlZBSmNaQ29UeEhOZ0p0TGVBc0pCQi9kTk1BS3pt?= =?utf-8?B?RTdQbDZLOUViZWtuZkRqNmpWVmJDUFNkNnNVNVVSVFZZMnh1UEFEMzBsZ2hz?= =?utf-8?B?alpUYWlTbnlBSVRlVU1iMjEydVBzMXAvaXp3VWtReEVvSElmZS92RmFBczdG?= =?utf-8?B?Y3UxR3hzbE1IalBxWGRmTlJQZkxoNlNjNVd6WFU2elh2UkNPc1B1NHFpbm0v?= =?utf-8?B?M251dDcvblVJOUphSGx4Z3c1QlhnQUNNMFBhUTl1OUkrTDE1b2lDZGQ2cGp5?= =?utf-8?B?VEUrOE5LWU1YNmFZMzQrejZZektkWGVScGc4azdKbnRWL0gwRHl5YWNGWGY3?= =?utf-8?B?eThod1hVUDYxdDZOZlg2c3UvbVN4Ym8vRWRUbE5DbG9qakI3U1N0cWZlWnFv?= =?utf-8?B?ZEYvWEJVeXhCc1NoRkl5ZXVyNFdOaHFmTXFaeG1KOVhKRWtZZnNGZ2YzclUz?= =?utf-8?B?c1N3VE5EaytWYXJxVXpRQ1pYV0ZqQ1cycDhxY0R5R3V5d0tIOWlnNmFHekVv?= =?utf-8?B?WHFXMDc4VUV4ekhYZXIrbjBFT3lqZ0Z6UHEwUG52aWdFZThOZkdpUElXTlBV?= =?utf-8?B?OGl2SUNKcHBaa1k2N0F1MFJPcVZab2FDWTJ1MUpQWk9qbHZFQTMzYkJxcW9a?= =?utf-8?B?QUdTWFR6THdYZ0N4UTNTek1MaWt5VTYxVWkvUkhIN3ptNGh2RlQ2UGlhMGg3?= =?utf-8?B?Z0JMS2gxMUJnTDBtRWhjeFJrQ2JTL2t4Q0lwVG5sZlBJaXZoNERzd3hJODE0?= =?utf-8?B?a2lkbUZLblh0WHRyU0s2bUlpVEI4MjZwOTZMR2FKVXpFbExtM090eCtUSHFW?= =?utf-8?B?OFE5WmRXczBMY2pUVzJXQnhPRXFzSUZxMGFnbVpzUGx0Skg5WncvTGx0UElB?= =?utf-8?B?NEpkSGc2V3IzV1ptUWZ4Ym1vWis0K1RDQ3padnBPZ0NmLzBld1AxNjBqVEZp?= =?utf-8?B?dTZvTnFISzdjalNzRnVMSHdoVlFOdjVMSUpCdmkveTBYaVltZThnOW9DZzNx?= =?utf-8?B?cE8zd1pEbEs5djZOZC96czNXMDU0Y2tYNEg4TThkVmN2aTRyZ3l0SThwTTl1?= =?utf-8?B?OGRHdXJFdEJmTEZ6NWE2NjVHUnN2d2dKeXA5OXR4L081TXNLSWpCYVY3U1dr?= =?utf-8?B?QTNTOUN5R3h1TVRld1lHTm1ENXpwZG0zeFg5dldob0FiemVjTTdGdXBkMVow?= =?utf-8?B?c21ORjdXeEg5VWpaV2xmWUFSbTBWZVRpRW1RNWZ4V3dQM2ZvKzVQbEdqWFo4?= =?utf-8?B?d2l1bisxcFR5RkJzSCtGd0FKY212VXNzVmZQUUNsRVN5eGYyYURlZVIxQ0Q1?= =?utf-8?B?L29JTXZxK2xQOWFja1I0ZTUvbysxVUI1QTRVRzVnTE5QNWhKTXRIdlJYTnhZ?= =?utf-8?B?Q25uM2tLVzJzWUZzV09PclVaeXY1a1lBWEJQdGFNdjNhV1c5WWsrV0VUWDFl?= =?utf-8?B?L0lCUTdsVXBLYitPem9NRDVCOVdiL1BvMWV1eGlGRFN2MGVKNVVCQ1J3Q0dh?= =?utf-8?B?WUNobnNmMXJIYXByVktxWVQ1aWxvS1daTTRRVytVUEtncWVEMHRRdmdVRHE1?= =?utf-8?B?WXhucUVNdzIvMGtqZWVxNkZKUFdQa2VVNFBDQ1lvWS9UWHlVUVRuWmx6WUdU?= =?utf-8?B?R1pLUlh0MTJkLzV1dnB4MlFPK3VnUTBSZUR4WlFqVnFFNEd5UG40ejZnRTVn?= =?utf-8?B?T1pETExmUklPR2lpT0M2bmVSdVFHbVBrQ0M3S3Fxa25RNHZOVTdKODRhajVu?= =?utf-8?B?bFJkOGoySjViOGIxRmwrbDRDaVpmdEVxLzQxazN4VTNSQnpUbmU5NGxGcXcv?= =?utf-8?B?K1ZPYUlrL0pVOUNKcFJRbERjWkxxbzc5ODc5MnpUcXZZaisxWUVZS2l0UVM0?= =?utf-8?B?Q2F3TTZ3ZGRqaEpLYTU4WGxuQk5yclI3UkdZTUlvd0s5Z0EvcllETlZvVVlO?= =?utf-8?B?bzhURVZ5WGFyNUFPTWUyaHE1WHhYM3VXTGUrY3FibEVOVjFEZjl3NVVWTVUr?= =?utf-8?B?Q1FweUNiZDFrREZ4ZElmZ2hSNXRvRFl1VjJHb3RDcDdrVXJpWDA0SmN2NFBO?= =?utf-8?B?bm9XSEwzRW1LVW9TenZpckRLZnd1ME5PY2h4OVU3aUw4NGc4OTY3UWFaMGZN?= =?utf-8?B?Z3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 288dcb46-0229-47f9-975d-08dc74bb16ce X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 08:43:27.1938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZOwhCsA/2wBpQwpssQMwatWBMMmV7FD+0ReM9DLlN//E0LUGzdeqfQ8iO4x5vtWozrP6cwayndvUF0p6jAXna85SxvGsC4RoEGLiT13Y1uE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7703 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 15, 2024 at 11:28:33AM +0300, Abdullah Ömer Yamaç wrote: > I want to update you. > On Mon, May 13, 2024 at 4:08 PM Ferruh Yigit <[1]ferruh.yigit@amd.com> > wrote: > > On 5/8/2024 10:19 PM, Abdullah Ömer Yamaç wrote: > > clang-format is a tool to format C/C++/Objective-C code. It can be > used > > to reformat code to match a given coding style, or to ensure that > code > > adheres to a specific coding style. It helps to maintain a > consistent > > coding style across the DPDK codebase. > > > > .clang-format file overrides the default style options provided by > > clang-format and large set of IDEs and text editors support it. > > > > Signed-off-by: Abdullah Ömer Yamaç <[2]aomeryamac@gmail.com> > > > Hi Omer, > I tried on ethdev.c (clang-format -i ./lib/ethdev/rte_ethdev.c), I > will > highlight a few issues below (not all of them), I hope it is OK to > continue step by step, fixing these issues. > 1. clang format failed for following options, not sure why, am I > using a > wrong version: > LineEnding: LF > InsertNewlineAtEOF: true > I commented them out to continue the test. > And for 'ColumnLimit', I prefer default 80 with the flexibility to > go > 100 when makes sense, so I will got with 'ColumnLimit: 80'; but I > don't > want to start this discussion. > > In the .editorconfig file, 100 is stated as a max_line_length. That's > why I prefer 100. > +1 for keeping as 100 > 2. Double tab indentation vs parenthesis align > if (iter->bus != NULL && > - /* not in middle of rte_eth_dev iteration, > */ > - iter->class_device == NULL) { > + /* not in middle of rte_eth_dev iteration, */ > + iter->class_device == NULL) { > DPDK coding guide suggests double tab, but also accepts alignment by > spaces. But as far as I can see most of code has double tab. > Majority of the diff caused because of this rule. > > Still, some discussions are going on > This is one where I don't think we will were reach a consensus, and even if we did, it would mean massive churn to DPDK. Can we have clang-format NOT adjust line-continuations in a file? Thanks, /Bruce