From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96C5E44035; Wed, 15 May 2024 13:41:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D8CC402BE; Wed, 15 May 2024 13:41:16 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 3A0514021D for ; Wed, 15 May 2024 13:41:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715773274; x=1747309274; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=dreht9/mFDBb7XeRCiljojNujZVW4AKm0NXZv4Vwcls=; b=XyvvSSlugA703Pk/vZ29hh29VM28CDPXTYWYuGNyCi0AdYM7ztoIKJun 2IBS99cQAl2w6k3Y5ZUv9ZgOiwmhnHp5ZhvsNVKV9a33KYw5ANUJhb8zQ BwVDykAa9VkQhohCB9iOGiz8W7VysDz4H9w4dguwqoTSfxwmY71rbcu5t ERnr+xD1z00e1yDiutJj3neY0SExRk7iuYfG5n8zwFU1QgpqGhQIhrNRT lw+vE9VB9vQ/PbcAPdct1Kb1Pntvx6KUy4Se8b0SJFNlpKcFw+md6sJPI R58Y3ANMU8xcUMJwNQcd9NvCOhzYYuo3eHAalX4aRuRmvDcGddbWFGCTV g==; X-CSE-ConnectionGUID: R+CVSGl3SWKpe/4CIqP4qQ== X-CSE-MsgGUID: jtJ2iBUiRcqyNP56lC6LEw== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="29307086" X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="29307086" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 04:41:13 -0700 X-CSE-ConnectionGUID: ajGlgtG4RmKROAy13y50Dw== X-CSE-MsgGUID: mBzGPyt7R7uaqIppGN/J4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="35905750" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 May 2024 04:41:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 15 May 2024 04:41:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 15 May 2024 04:41:12 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 15 May 2024 04:41:12 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 04:41:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jIQe3jkQVpn7muULAqSakt7aVDpO9KhR0giGAYfrStfG7ZEiaJXRe2ntIV1u4Z5qDc8SsZBcOypia4Pkohnog9BbO8SeRLeDU2de1WAVkEhlf1tqwzZg9YRH/QC+lvoOSAcyiA9syz+aAMRMkJ1Js0sEZKzOJ1ay/xtgzrVzDvu5SENDGWCdUnroJDuIkdP6sNn/GZMN+F4JT68X/t8sU4/12V6PQySgcRfXYEo+jgQYU+we+UrCTzU/uKH0Lw8PWXfRf36tDtRogTQxBJaTGpQ9Hi0QkzYyDHQr+vbGshnAAqaKMkCF/4tUK9Mt13U6Kh0dzuVKe0TnU4nwmPWS4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G6zVi22bjOCHrD+wb1flnOK4uYV92U6fjOyYqBWsCRk=; b=T1GQq8EpjKUo20zddY9N8jIJleCpVY19Xf1imArv/F46rEPXfz7bXuDANAlaS27FsL1yRcg+kCE92SSHW0XbPOVqjbArS+mBmE1Hq28NnJFwmVUgl+2HjSH/ca5/IOiPi8MDoxjnM5VIfyHxDX7LIPhaFY8kJe4Fei40gwf7SDmPjgHkRlgMvYPtoloftMlY4Q6xYzX2pWcQX89cIG8QKx4M5kJTVXJwn4n15ViitEoSW0f56hIj9sBMCO2kEjjGNMyMiSzu6VPhmJhKG+hCHgAD9dCC44OGrfR6H2J0PzNX8C297fNPJTTlJz1h9Q5pQ8GARS7zo47r2M8WL9KQxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4770.namprd11.prod.outlook.com (2603:10b6:303:94::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28; Wed, 15 May 2024 11:41:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::69f8:59bf:3efd:9ee6]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::69f8:59bf:3efd:9ee6%3]) with mapi id 15.20.7587.025; Wed, 15 May 2024 11:41:09 +0000 Date: Wed, 15 May 2024 12:41:05 +0100 From: Bruce Richardson To: Abdullah =?iso-8859-1?Q?=D6mer_Yama=E7?= CC: Ferruh Yigit , , Subject: Re: [PATCH v4] devtools: add .clang-format file Message-ID: References: <20240508211934.1143124-1-aomeryamac@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0029.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4770:EE_ X-MS-Office365-Filtering-Correlation-Id: 004083aa-066c-4df0-8975-08dc74d3ea33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V0NkMjhOQUNGajNJZS9xdFhQbURnWTFVWGpNQXZsZVA4dmd2M050Mml4L0ow?= =?utf-8?B?SlhuaWxnZ2ZCTCtWejJUOUhTdGJUTDBCMVNQdTFLYmpEYmhENnp2Z1JGQWZp?= =?utf-8?B?eGYrN1NzeXVJQm1Eb3ZRd1NmUWYyTFBwSnBzVTV1REhVcmJYa0l4T1FQMXQ0?= =?utf-8?B?TmhHMGRyNHZzRHNNU1VGeU1kSnVtQkF6WEFNV2EzcVlDb0Ruem5VSTBQcEtZ?= =?utf-8?B?cjR5WTRhcFlLODNUWXJDWHIxTkJBeEh5Snh4cWdsckIxWE9zQjRqSzc3NkpW?= =?utf-8?B?QTJiUVNZTGQxZUQySTBudWNTVEFybjZsNGd4N3ZZVGVCcG9zZ1p1VzhzRFNO?= =?utf-8?B?bGhHQWVIeE5ITGV0ZElZRmUrRjlPODQvb1QyV01QamJpdUFvWi9NU0JmQkZK?= =?utf-8?B?ZWpocXR1bU4yK2JCTXdCVnBzWU1JWU1NNDNvY0wwWUtVMXJ5KzBGM253TEwy?= =?utf-8?B?YjBBSUhZeFdmYlRtUVVwdVhwSzdEMnN3MEZKMGRkNzBSMEJpVVhJSjlOTkp0?= =?utf-8?B?TWFxdXEzaEtjWXNBUlYxYlArQ1N5K1hYdE1WVkdJUndNd3EveVY0anZndy9X?= =?utf-8?B?WTRQZTdmRFRUMEZPUkFzdXBjK3JVS2tUaVYyQXJKV1d2UnAyZkJSSXpNSEo2?= =?utf-8?B?SkRYNWZDd1FtVlBZTjhuT01jU1lNeTdFRWxnRmNDdkVsdFhZUmovYzB3eXBD?= =?utf-8?B?U01WOU1ZY1NDUzFKU1FUZUJLWXpyVzVSZElXbEhTamlCbThPWVc1Q0hhaXRq?= =?utf-8?B?SDVVeUVmT2FCa0pONDMzOS96RFptc2NFb2F2amF2c25mcGo0TlE2YUE3MGxr?= =?utf-8?B?bjdtQzhEQU8rVHJHRjQ4dVBnWHZrSDRpK2lsV0Jtd3FJdEV0UjgvaFhWQWZj?= =?utf-8?B?L0wrUy8xWlBpMVRsazRLRG13OVo5MWVwRG53eGZtbVVJZm4rQjNleHBjT3V3?= =?utf-8?B?bDdwNWFUTFE0ZDFCVExwMDJFamZDblFwUWNycTZja2YvWktBaG1nN1AvNVVU?= =?utf-8?B?WWc2WCtERmR2YXoxYldHMGVuQkY0NFhuNkRTYUlMNEZFUmV5a1U1allBczFB?= =?utf-8?B?RjZTaWRQcklFZmcwcEQ0RXVoQy9kWHRBWlI4dG16c0dabGE0TVVrUTJTSCt6?= =?utf-8?B?ZS84MlJUVlRVUk4vNE05QXN5c1hGNm5VMDJaNEQzZWNVMjUrVnFMVGR6dXF3?= =?utf-8?B?cXFZYlFPVzhleVFkeGRybW9CSGtPRU9BVCtQWVV6cHRFd3MvRjBNVEtlR2hW?= =?utf-8?B?Uzh1dmlZS2tTUVk1dit2eXhyTGp4U2ZMRG9NRC8yVmpKR0N0Vkx6S1lhTkJD?= =?utf-8?B?TDJ3N0tVSjByR3RQU0JweGZWMzFHUWZGSTdmelloSjdHTHZscERQaVpvT3BD?= =?utf-8?B?dGNybThISmJqVE9vdmFSOUU2Rm5sUE5wdnY2L1EwQkNEL0V4elRrTkNPVHk2?= =?utf-8?B?QUpqNzFwV3pISVJwMzVtMnNBNkZQM2RHWWF4QytnNmFoaVpHTDdOcUhMSVlu?= =?utf-8?B?T1dBUi9xZlB5Z2lCNHRmSVhzODgvMEc3ckVvekxTSFl3TUNiYkhUZ251eXo3?= =?utf-8?B?Z3NuNm8vOUhaRDBhNnFIUEU5TFdWS0tPbTVjUVdGaE8vTmFUdlF4VVhxNWZS?= =?utf-8?B?U2d1TnZYSnN4amJ4RGxtTjl1MXFKOUFZRGF4NFptUEQ5TXYyMlhwbWgzQVU0?= =?utf-8?B?Ynl2SlZZZ0x6aFI2akdGSEFzTDB3TmxJSDJPZXh5YTBjVU5ZelFhM0tBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3VnZEw5OTNvRXNSajhGbE1LNzhVbE1lbVI4R1liWTlFOW5rd3pHc0pBbGZj?= =?utf-8?B?OXNpNTZhVStDdExRbjNhSFlCRnJqM3ZGYTlzdytSVWRXek4yMDJUTVVoZUZD?= =?utf-8?B?d21NTTBiQW9id0RmUDlHQVlrU2E5RUNhRkExaUtSUXVaRnFDRS9ZRnowMVVN?= =?utf-8?B?WmhzQUJwUWlJM0ZRSTgvM1BGWElsSEErSnlvd3pUa0IxSWI2N1N6MkwvSW53?= =?utf-8?B?bGhyUTBLMVBucGpXcThSWThLYWxFY1FSM0pQcFAvT010NlA4SUtuSEtmMXR2?= =?utf-8?B?WjdYUzlMdWdOalFwZWt1TUJ1M3BIMTVrZmpzSUR3UTVTb1VxdVpjR0tmcVdP?= =?utf-8?B?VGFLOThRK1RlaUQxRk02WjlDemg3NXgxL1g0eVJiRXM2OWdjbnEzbnVUOU4v?= =?utf-8?B?KzQwVktDNm5NMnpxNDdWc3V0d2U0QWVWdFhtbURnL1hZbWxqYjNQbEsvZzZq?= =?utf-8?B?cWd1WXRMRjBlSXFaU1hMWWhkUlR2bDF0TmJZbTdtUVpCdFFPaVhpSnJXTmln?= =?utf-8?B?SG1xVTR1SUV4NGRTWXR0Uml3eElNeXdraHJFeG9WMDNHOEdDSG5SMjNkaHp3?= =?utf-8?B?RWpxdlJRY01BRFlTUHBjZTVralFmSG9mY25HNmUrSVVwR1kzS1E0QmI4TWd4?= =?utf-8?B?UUg4bHhpZllMYVlpMzNDUlhGRDZLNkJPeUtQQWpOVXU5S253WnY3NTRtQ2pq?= =?utf-8?B?cUxZbDBHZ0QxcjQ1ZTBrT3JaL2FGMmFrdTI5RUJxZHVaL0pZVGZlaFVjU2l6?= =?utf-8?B?OHY2QmZ1WUh2QlJsVDhlc01hei9KRzdLbUx1Sy9lSFJ3NWR2dWJIYzdjTDlI?= =?utf-8?B?S2dDWEIzcTE2NTZ6elA3ZllNTGVnYjhyUmY5RkNPaWZ2QzltYVRueks0dkFh?= =?utf-8?B?elJTNGZxdTZWYklSQU10bGZ1dDZyWFF1cVZITTdYTjJoakg0NXF6NFpiVXlk?= =?utf-8?B?aG5JWFg5dTI4MGpscm02d3NrUW1jbEJqekwrWjM4dWtndVpJSkh2YlFoRlJh?= =?utf-8?B?NXI0UXdscVY1SjhrcWhMZVJIcERBS3dJNVN3d1Y4U3ZtM0xZVHBqbUczK0hv?= =?utf-8?B?cnNhTWZIZlA0SkJtczdtUmJTTVVzWmx2ckVyajhBT2lRNitrSnFXbm14ZGVG?= =?utf-8?B?STVQN3FzRDhjTzVCa214eHVqbkUrOHNTcm9hcXZLTVBxZ3o4eE0zWmJxMzdv?= =?utf-8?B?L0ZaSzd0RmlsWWQwN0ppOHJjeTdaUVdVazNsTzJyei9kYnducDJ3MkNHNUJN?= =?utf-8?B?TWFJNlFibG5keXZxNm1uOUtBVDBHSEJHN2Q2YVR6NE9NWDcvL3BMakZHQ2dV?= =?utf-8?B?WlNuYjhiV2NMUndPdXVSZmE4bVN5aHI5TktHODJ5RVVzWVVJQ2t3N3g5TnlR?= =?utf-8?B?aDhUaTFrWXVwNkY4RHZOcnRucnhZcTc1c095dXJpa0RXb2NuRE9FM2d4YWVs?= =?utf-8?B?Uml4bnlyUVpLbXZCTi9aYmYvcEdta0hYVGtHdCsyZzVFcGpjOFRVMDVDTk5s?= =?utf-8?B?SU5zditUbzlBYmluSHFQTmFpNHNkMUxJb0pEQVgvNWtVblF4WUZQMjJ4YU45?= =?utf-8?B?dHFvT2hRRVl6STBRQzkzQUtoQ3FWdGFmTGpEME9CL1ZOTGRxc1ZMRnMyL1J5?= =?utf-8?B?b2g1aitUNUhvdlRYRk9NLysxbDBDZzVUNDhjaDNhb3VodU5JVnYxYy9teHY2?= =?utf-8?B?RjBvbVVLbWRrdDc1SFBoczd1NUpybDhwNWNRNG1wQjVZSkRLUVB4bDRub00x?= =?utf-8?B?a2JsVm1xc3gzRFYxaWFlSlMwZHRZUGVPTldIZ3lLVWVLYnE5N2psWVpZWXQy?= =?utf-8?B?Z2JJMUVHaEFubmdaakdxTk9RM1IvT1U1VnR0WXRRQURzaVI0MjVZQWRlNkFa?= =?utf-8?B?Rm4wN0creXo2OHFjYmN1QjZpZ0NEQXQyazhvV0R0ZGNIZld2NG1SUE10OUtW?= =?utf-8?B?N0h2Sm15L3RJN3lZZXRHMXEySnN2T1p1RTJiTWVnN1JkYjM4V3dZZUd1VjFD?= =?utf-8?B?bkFYT3k4N3Rjc2I4T1ZOQzlJaC9aOURxQ0hHcFdRdC9pbUdTMjRsVEltWUdE?= =?utf-8?B?WnZVUDY5dVdTdk56NlpXQkc0dGd0c3A2R2VNdDVWRzhFalJXUjJFOElZSHJP?= =?utf-8?B?N2RGRzAwZnpwSGFGQnVDUTM1SXJPLy9iKzZBTGFzblhrQzQ5d3hVQWNnUS9q?= =?utf-8?B?Y0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 004083aa-066c-4df0-8975-08dc74d3ea33 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 11:41:09.7854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xmUw43VR9w0ah/PGnhJ29dznWn8JW1RxeOP3DbImgSY4atpn45W1DELhJ3T3K0nTxCzgaJBiXhsd4GjaDaSpThSQaLofdzuHEVDb4iBwDEg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4770 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 15, 2024 at 01:19:50PM +0300, Abdullah Ömer Yamaç wrote: > On Wed, May 15, 2024 at 11:43 AM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Wed, May 15, 2024 at 11:28:33AM +0300, Abdullah Ömer Yamaç wrote: > > I want to update you. > > On Mon, May 13, 2024 at 4:08 PM Ferruh Yigit > <[1][2]ferruh.yigit@amd.com> > > wrote: > > > > On 5/8/2024 10:19 PM, Abdullah Ömer Yamaç wrote: > > > clang-format is a tool to format C/C++/Objective-C code. It > can be > > used > > > to reformat code to match a given coding style, or to > ensure that > > code > > > adheres to a specific coding style. It helps to maintain a > > consistent > > > coding style across the DPDK codebase. > > > > > > .clang-format file overrides the default style options > provided by > > > clang-format and large set of IDEs and text editors support > it. > > > > > > Signed-off-by: Abdullah Ömer Yamaç > <[2][3]aomeryamac@gmail.com> > > > > > Hi Omer, > > I tried on ethdev.c (clang-format -i > ./lib/ethdev/rte_ethdev.c), I > > will > > highlight a few issues below (not all of them), I hope it is > OK to > > continue step by step, fixing these issues. > > 1. clang format failed for following options, not sure why, > am I > > using a > > wrong version: > > LineEnding: LF > > InsertNewlineAtEOF: true > > I commented them out to continue the test. > > And for 'ColumnLimit', I prefer default 80 with the > flexibility to > > go > > 100 when makes sense, so I will got with 'ColumnLimit: 80'; > but I > > don't > > want to start this discussion. > > > > In the .editorconfig file, 100 is stated as a max_line_length. > That's > > why I prefer 100. > > > +1 for keeping as 100 > > 2. Double tab indentation vs parenthesis align > > if (iter->bus != NULL && > > - /* not in middle of rte_eth_dev > iteration, > > */ > > - iter->class_device == NULL) { > > + /* not in middle of rte_eth_dev iteration, */ > > + iter->class_device == NULL) { > > DPDK coding guide suggests double tab, but also accepts > alignment by > > spaces. But as far as I can see most of code has double tab. > > Majority of the diff caused because of this rule. > > > > Still, some discussions are going on > > > This is one where I don't think we will were reach a consensus, and > even if > we did, it would mean massive churn to DPDK. Can we have > clang-format NOT > adjust line-continuations in a file? > > I am not an expert on clang, but it seems we don't have such a > configuration. > There is an option called "AlignAfterOpenBracket" which horizontally > aligns arguments after an open bracket. > if I set it to "DontAlign" then "ContinuationIndentWidth" will be > active. Depending on the value of ContinuationIndentWidth, two tabs, > single tabs, or spaces will be acceptable. > Is there any way to specify per-file the style to be used, e.g. via a header in the file or a macro to override? While the whole DPDK project is inconsistent, we should look for consistency within files. In the absence of that, given the number of strong opinions already expressed, I'd suggest defaulting the align value to DontAlign for now. /Bruce