From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C98D440F2; Tue, 28 May 2024 10:20:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54D2B40DCA; Tue, 28 May 2024 10:20:57 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id DEAF8402E4 for ; Tue, 28 May 2024 10:20:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716884452; x=1748420452; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6JiMd4QYZrZM2atQ2+AdMY/9HCiqctpAW8c3/3XQvDU=; b=Lg4X2J6D/SyPHH0BnNaZfUdCHEJMa0MCs0R9lxH/1KD6ZhA3mjn/hjwX prIELC2OI/ed20FEIAgvskydAycMKiGo/u7o/H6vWtsC82KG5hX0LzXKZ 0ZmhKoY32Fysfcx6CNkHS1ztDcdzvamWLzp0YuQLS9/TssI2BB+bE6LkF DkZS1iGck/t/8E7VFttZ0D4hG91hWWlpYh8B/G4l8b+7rp4K0+l5a6ymG Y1u3jzHwH1tPa544X5w1uCMqso3KFf4e9gdMq8NW5IzZrguSLo+hxc1CL XjvFthceyslC1k93XchQmF7MVvvSOc2NPc8FfRIgSA+1NUOi/1BSyfKFq Q==; X-CSE-ConnectionGUID: uf26pT30R1ORxroxfoAU0Q== X-CSE-MsgGUID: 38ByyYcKRES6zrhNDpjGgQ== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="12986920" X-IronPort-AV: E=Sophos;i="6.08,194,1712646000"; d="scan'208";a="12986920" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 01:20:51 -0700 X-CSE-ConnectionGUID: 32b4IIiKRkiJnodqQklLGA== X-CSE-MsgGUID: VMVx9ZnWQ8Sc4h8tS4HiCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,194,1712646000"; d="scan'208";a="35598613" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 May 2024 01:20:51 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 28 May 2024 01:20:51 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 28 May 2024 01:20:51 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 28 May 2024 01:20:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kwp2DYNgCYTWcAjMsaFoKRbASzZDcYvReDDvWDixi/srNbw+Vp4GxPMp0ggLq2jLzQDjTQpxW7WmPXK752aRB0tzcP7OsHz0F9lQ1pnyfk66FP5ygUUA1rshpu4cMgsuMS//UrSKAoyQzWoawgLESzMHChyvE8pasr7T4VuupI5xsjE2qcf+102ow+8VeTtVYo+MQv1EybxaUTWUQOnYFJwMR4Wyh7uU7rbE0rHxX3/ZomACH/5HmtTcoQ8UY4hHXrmbISB4hfjGhZ18ypy4QMsesm3O5p/0W9d4lh3XWo2Msq3rMczkhiJYX6SjwnQc+0HpfGW6Z37pN0TYDZG3XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KryiLaWkTrowt2dow4siFr+OxtzefJkyBY75Ek26+D8=; b=oKl4PG0PYtzJ9OjX28edReN8Zps+aMWd79kUB70zv5c0mk8ncGcLQdCRKRPvxTjX5EIoyalj3dPsE1IH0OQF4VBTkn3E9a/EmIDfc14Nv+yFXMLoPTQxc0F65qxQZoEI+kn8uggG+NVjM9T5ln4xAqDmYkBWU08kHuKqsf5xPstB8mJHZP9ignUOgB+AruVdqaJiNabjGXX4Tj8WLjgT5Zt6mcpAT1vdvI5OY8G+/BH7Axvdn7zuvvECrUCm2Vp+IZXapXxrUpfai+0yjAaFEi1SUrxapxKBupfP18h9Wq8XxrnBM+5TxMr40NEDJkT/PHiU+kG9swe7cCaZahhwCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB4829.namprd11.prod.outlook.com (2603:10b6:a03:2d3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.31; Tue, 28 May 2024 08:20:49 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%6]) with mapi id 15.20.7611.025; Tue, 28 May 2024 08:20:49 +0000 Date: Tue, 28 May 2024 09:20:45 +0100 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , , Morten =?iso-8859-1?Q?Br=F8rup?= , Stephen Hemminger Subject: Re: [RFC v2] eal: provide option to use compiler memcpy instead of RTE Message-ID: References: <20240527111151.188607-1-mattias.ronnblom@ericsson.com> <20240528074354.190779-1-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240528074354.190779-1-mattias.ronnblom@ericsson.com> X-ClientProxiedBy: DB7PR05CA0063.eurprd05.prod.outlook.com (2603:10a6:10:2e::40) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB4829:EE_ X-MS-Office365-Filtering-Correlation-Id: 96a12296-b8d8-499c-ad84-08dc7eef14a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?u/yh77pIqnIjRaWbjyZu09QdbEzOEjxkmfDbyktNbgbBjJz6nF/S6MpECd?= =?iso-8859-1?Q?R/o4e9QViOpQRBxwNJ8hOR34bswzqj65KYdvHdjnR7DwTtDfR4yEFX2H2j?= =?iso-8859-1?Q?DYAmm1bKe7rx2G+5xlGTuzAn6xmufaNUCGl/K5I7TJw9iO65AzXXsytGB5?= =?iso-8859-1?Q?EDDT2KxNYS/x677+uKNUi2fQy4j2dQHWtmZLvOU6ad74ZYQ+gMb6dIMIWe?= =?iso-8859-1?Q?A/ldwprpNl91tOGXuDoyHTY3N2UjuQg2YYpwmSP9vQIHa6UsigeGwZ3jcb?= =?iso-8859-1?Q?K6SiRYcQ3Re6BGUah+wN4zBkWn4xgHSFCP1ItBNUar9r033j8ix0M6TvXm?= =?iso-8859-1?Q?N6RQl/M8j92blU4HMqDcH9y7XPIy7EZTBpuGw6fYD1FlNJdJM+g4ACoJgm?= =?iso-8859-1?Q?OzVa4mbXc+ozViavk/p8MSn4tbWUXduQE2jgaBtbJ6AhrI6spt4Y6C9y4T?= =?iso-8859-1?Q?w+b4NzJTlSz93/RtvM4WmbsXMjWT105cyJ9RgUurA3mgoPe3JahvgSKj4/?= =?iso-8859-1?Q?/59pDpVqj2iEDU91SbSwWeqOpGHPWYU4D8ACyflzO+6pMq9swRIo81g1ai?= =?iso-8859-1?Q?m5Il7BGPS2YV0ZYqC72AXwM7MCbiW8cCnmLEO6/vrKCVKX5rHmXYNQdfCc?= =?iso-8859-1?Q?B61AH+r6VGVJbWRBrMbTGgfYVgpqfL6rOmNELD+YXR5RS/ewolBp997tXO?= =?iso-8859-1?Q?6sBvL5bPLVG9N1nMoU3+o3W/4sL1aGDaphSmn12Ocpnl46cLN1ZroBsoGI?= =?iso-8859-1?Q?ABMcRRi2qzywMVlyRiPJlvtn4VztTns/NGWlOlroNVD9rG15pA/I/LqvBB?= =?iso-8859-1?Q?sJE8yRXM1GeucSEK/am8V7jBqTAdwVq3eyInOqx+ilmeKSaVz6rEKzTDNd?= =?iso-8859-1?Q?hsbEAzv9YatMOGo9XHCAsoTKzBfTH21wr50T+7bT6Kb7rJpxffAYpnBdwI?= =?iso-8859-1?Q?FS4yss5+/ChcrM1y9mWsXShTcRxCy5J3Snyns9CBuh4WMKnKR1z9gMleT3?= =?iso-8859-1?Q?d6Pfoc2kGwHDIyxYjggsqKJd+2v12AMmktMVATGJdFAFWntXDgu9zfCVGf?= =?iso-8859-1?Q?1cx46VYCWu3wI4zO8/WGRVsUaxsci/4rJwOMLL4+QOrMqPUmHrKAakrw6z?= =?iso-8859-1?Q?u9DJgh1hIa/RQRHcd32T07m+pos4P0Bk04wZPy/l/yvyqhiG5oSG7mrbhR?= =?iso-8859-1?Q?7UQe0AeoAcev0Y1+C8+zH8H7hT/ZengoceIjZLw7eh8O8tcdFFHyDL1znE?= =?iso-8859-1?Q?PQcbYQJ2f0SNBFSZzaj5W6SfllgN6tnBYB3nnMjpJtFI9bjQM2I2nDlJw+?= =?iso-8859-1?Q?mdh71dnWu4y9cBsgybavn76EDA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?r0k8k3To5YbbQNSKmoI1KJDV/2lt8EZjqOj4Y1YQ/fF+ReVL0E1FSQGDCC?= =?iso-8859-1?Q?DVIomrYppMDjEADJ3cHaVsSdHhghZe/yBHSR8NfRPztW9vDZiHeQWjQEpO?= =?iso-8859-1?Q?GogaGolPlt/LXcAbEos1NZ7CRsUo5BGymztM9Z/Bervk4hFQBT3Rc+dYEy?= =?iso-8859-1?Q?U+gEN9JC2/ErHzUFKdqb6P2hnUZ0Mu503MRJRtVOW6LHUmgpoq8KfTFtjY?= =?iso-8859-1?Q?pn9Eeh+d4+ZPLmWNKMp2A+Z7OFsOqVLadkRefyvGESthCVckl3gsaRl5bu?= =?iso-8859-1?Q?oS29aclqVgR4aEPLRSs5C3sLhDGw8BTpWRzdUXCgI4PK80VJ9PDDuu434l?= =?iso-8859-1?Q?kDSuT2NNojE30rD8L2GydDvwhnta/uIWSbe73GCofPgo2CVx9rKyM3wuZo?= =?iso-8859-1?Q?esML0ilFXvQ8T+4/LYI3I/CR/UXTeyWtY7kYdQucehz7C2O2sUa+LF4fh7?= =?iso-8859-1?Q?68d1EzB5oAraYg2Vs1qrHfvirSEoOZBMiGj1sO18D78tzT8JFldl/dVD6Q?= =?iso-8859-1?Q?7GJENsIpVny2pWY18pylka0zNf3Ote1D/o3FG4dfc5mQPuDS5Apm0VpaAi?= =?iso-8859-1?Q?DajjXrTP7eUfQZdso5uMMWaLExU/PMSxifVknq8hec96P9WS5UHhXoHiSe?= =?iso-8859-1?Q?9IeeZaESBBVEN4xXUh4qs52LvLe0OmcSUfbK84G7p2HVp9borHi2SkEVq0?= =?iso-8859-1?Q?zSaSwQid6WUls4i5aW92HUwExYk3v0DA4QCQ7UgajyCQQtZGlj8awZtrLO?= =?iso-8859-1?Q?B/ibVpYkStA3FSV/xuPAvazQlwmgdoihG4FGLf62Td5wgO0ldi69TYmHTD?= =?iso-8859-1?Q?iBDnStmccrG6qAt0JBJnMa7ozHWFSg2D3FD8aYApzKAUMQ79G+Yzw8M0ek?= =?iso-8859-1?Q?ADMLVTHIm3y+YI+4mhyJFGaX9vnjgWI+nXWizOG6Pr1h8Af74EL6c0qR0I?= =?iso-8859-1?Q?LFEIoVQrmxdaBk3x2LbZO1ISvw0U3xbSRu4NZ+3ZZNy/xe+vo5ls/XESTw?= =?iso-8859-1?Q?0tUEBSK6j1qNiUUxt1O159AMrY0yabnUwATuR/y1DialLByszqq7ZGHz8h?= =?iso-8859-1?Q?/Bp/ho/dnjonQVsXmr0UDPNYWn2Kyl4JcocL/X0HE8VkwsMeEHNxn2JmEZ?= =?iso-8859-1?Q?wbJYoJ5L2LM5/bo1REagTnMDHDKzVASmkUjBXb8Vg+9fHBlwqPhn21jewR?= =?iso-8859-1?Q?W3gTn9QempGljsrVleOzUW2jtjrxJdHOnXIWBn8BFECN8YJFv2LyjU+wEM?= =?iso-8859-1?Q?P0JGchhENgVjOfHvTv2WnXorn8+BsHwWkZDVqCE16IRVz++TwKsVVCUkHJ?= =?iso-8859-1?Q?nh0xmpplFTyCPGE+MQwRXh9/IghplaD7t9moM60BPvcatajPfeqlJ4ss2c?= =?iso-8859-1?Q?CSGkJWZpin09Yly/EvW2kaxsAPrdAddWNRdD08hcMlC92O6ZjxgxdpnMj6?= =?iso-8859-1?Q?AcnIZ38BMiO+l5OUrSG98iERw9LsRfkLmg9FuyBY4pOdxQLOs8lEUP78PT?= =?iso-8859-1?Q?kqcszzAff/p9XzG1lSaiDe0XrJcd4dvdGnQNDWUjr/dNKZMa+hzcW+G69/?= =?iso-8859-1?Q?aQjAdqdgzpv5i2VpLM8w8V4aHKiH5jos/eVTUjv4954yZFacxbvGuWe7zY?= =?iso-8859-1?Q?422Q0zngTBhUgoeq6E5XWuOGsNbkCt+YqCd3ewGQ8kkPwXJ5KQRDTYwA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 96a12296-b8d8-499c-ad84-08dc7eef14a5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 08:20:49.0280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A/xCUhvEEaBeRKoG0a2+JBJ8MOQu3iwKIhSVwSgFeI4fdbJ07/sh/UyRlFRjiGlRFLz3SrZMjfa8gPWasRuzzEArXJzxMNsdv0CR30RlvuM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4829 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 28, 2024 at 09:43:54AM +0200, Mattias Rönnblom wrote: > Provide build option to have functions in delegate to > the standard compiler/libc memcpy(), instead of using the various > traditional, handcrafted, per-architecture rte_memcpy() > implementations. > > A new meson build option 'use_cc_memcpy' is added. The default is > true. It's not obvious what should be the default, but compiler > memcpy() is enabled by default in this RFC so any tests run with this > patch use the new approach. > > One purpose of this RFC is to make it easy to evaluate the costs and > benefits of a switch. > > Only Loongarch, ARM and x86 is implemented. Only x86 is tested. > > RFC v2: > * Fix bug where rte_memcpy.h was not installed on x86. > * Made attempt to make Loongarch compile. > > Signed-off-by: Mattias Rönnblom > --- > config/meson.build | 1 + > lib/eal/arm/include/rte_memcpy.h | 10 +++++ > lib/eal/include/generic/rte_memcpy.h | 62 +++++++++++++++++++++++--- > lib/eal/loongarch/include/rte_memcpy.h | 52 ++------------------- > lib/eal/x86/include/meson.build | 1 + > lib/eal/x86/include/rte_memcpy.h | 11 ++++- > meson_options.txt | 2 + > 7 files changed, 82 insertions(+), 57 deletions(-) > I really support the long-term goal here of eliminating the need for us to maintain our own memcpy. This looks a good idea to see how things perform. If we do decide to take this patch, having the default be regular memcpy should help with static analysis and other tooling, which would be aware of memcpy but not rte_memcpy. /Bruce