From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D768440E3; Tue, 28 May 2024 17:12:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 358F2402E8; Tue, 28 May 2024 17:12:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 8657C402E4 for <dev@dpdk.org>; Tue, 28 May 2024 17:12:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716909169; x=1748445169; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=AUee1ickI0Lqp+su939Bnj26GHAHAL6hnUb82Rnihq8=; b=RiuY+gZi9toDdMe494+RuR9w+38epXFctrbsDF3SYn8Tlr6T2FooENjN gDTi2GNNBFm05BVDkBEeFscLf9j8D8HBL7/C9YRXqPhIRL4s/GgEV/KGH c1375rGPybe7Ibdn0QCp+ir4HRO2WDXxrO5yNyIsYula64lmM668qnG1o EG79JTdwe+jOMUakNwWvMbNzN9OUECpZYniPi0azAvW4PHFypUnNk0Psx BE9UW7JxOWOzZxcGTBcCyWsGm8gKeYzRyRidus38Y/DZPhN7+NnvfhLQd oDZWLupBltxLFGfAmtW1aslSbNbt8c0qHGFqQedxo0UqZ+T+qwPZYvcM8 Q==; X-CSE-ConnectionGUID: 4sV1/LDKQcihmv1mzwdLcA== X-CSE-MsgGUID: fV/1WVAkTnmPT8NKsSptqw== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="11729438" X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="11729438" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa110.fm.intel.com with ESMTP; 28 May 2024 08:12:48 -0700 X-CSE-ConnectionGUID: O7kdEu3IR8O19Md1UJMKUQ== X-CSE-MsgGUID: Pqk9G7grRXWTJbbO+of5HQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="72543433" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 May 2024 08:12:48 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 28 May 2024 08:11:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 28 May 2024 08:11:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 28 May 2024 08:09:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dFNv25EBkKPPiePYYSlGMk2rhvUMDafFTG0FFo9pDsEPj3hS7+1C0K8V2g4aXwjhZZ6LBXx2Y2FsARtIgi+jwRb6T7jFFlaP+I2X91oYFCSqbpRF/19lzTOE1aNrxpQNIh+8wLMznBEr1rN9ov/HFVyW7IcCfutRfEdfNNQqM/nikOEmjuVG45gFEOBJ4U2XJ1HqIEOv+d0N00VHtorDw9ztBTsx0yHsvjNOGQxtZ1a8PjsqQDnb8+FyXYMVEdMemaoj1UvOP5OweNKAm2/UtKCIuXy6fRiZZZuM6Qd1yGBkoFdvjyy8ZNcGneXFzBneftjjr4PzeGAv01b0/2UiZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k7InHM6Soabnnd3XtvizxwKWMZsCFT7YAUbXeWS/u0g=; b=YtiGkFPZZ5RmWVO8yXwGv3XpfTlkPMOFr6So8MGJTtdzWPGSi/C/dyYOlM3HdzFMWVxYRZmehKi/wNly74IAnMS37KwL807HB/6/nZCYd/CHwzW7gV8Iyp3V4Kmm9ogm3cnm3BtMqYbsYfj8UVGkw7FtjLv1q34myolOPqyztqelF4Q0u7AY0BXKeGZ/hG1/N8UzAGhs3GRsX56TfCk9iCObMm6i4eoUbYSDE2a9t2SHgnEJxHv+/alcbglxGtHkil5fav6TXBdQrbBbgYEqMn6OtpIrCdyEYziHOJAP8chEbMweG8wQfDb+SgjUsvnofzOZ2NmfewRJSEWZ8Jynng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB5058.namprd11.prod.outlook.com (2603:10b6:303:99::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Tue, 28 May 2024 15:09:14 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7633.017; Tue, 28 May 2024 15:09:14 +0000 Date: Tue, 28 May 2024 16:09:10 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Stephen Hemminger <stephen@networkplumber.org> CC: Mattias =?iso-8859-1?Q?R=F6nnblom?= <hofors@lysator.liu.se>, Mattias =?iso-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>, <dev@dpdk.org>, Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com> Subject: Re: [RFC v2] eal: provide option to use compiler memcpy instead of RTE Message-ID: <ZlXzllT_Bgvwf2NF@bricha3-mobl1.ger.corp.intel.com> References: <20240527111151.188607-1-mattias.ronnblom@ericsson.com> <20240528074354.190779-1-mattias.ronnblom@ericsson.com> <738e376c-c5b6-44dc-ad51-00f40d2ea6b5@lysator.liu.se> <20240528075936.2110c31c@hermes.local> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240528075936.2110c31c@hermes.local> X-ClientProxiedBy: DB8P191CA0008.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB5058:EE_ X-MS-Office365-Filtering-Correlation-Id: e54a1f59-ec73-4b6e-3d7f-08dc7f2822ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?Ox13slBvkDx8GQ0paiK7E1U4vxcNzbEYVKmgIBJLYCJJo83KJwFrv+hWgc?= =?iso-8859-1?Q?0LPDmNPS2reLTzj/oEM0jYE/4iHLlfs9t3UIBiYd3JsnHZTWHsFVjP9KyO?= =?iso-8859-1?Q?CMHSIimyU40kfvXuMHrKW40Au56wz0RYibSwOhujOwkJsWgDXPvyTXAb6V?= =?iso-8859-1?Q?hokw8jRNxy3ZdeJmL4ow2++gBof9NpTwTfD5K1chm6r2rEvQu9TznGJuv7?= =?iso-8859-1?Q?YDLiBzWaotcAEiFMRM4CXdkUfCoWHL4EbVAaSU31iYa46QWSeMI7/itbVU?= =?iso-8859-1?Q?I4KGluyN74Mzzxgb7jFtE3DezDvy+BzHnr07HlYCSltAXJNur4hsdiJ3Mq?= =?iso-8859-1?Q?yKsPxJqddqX74cJC7HAIfDLnS42HPHIsCR4GRek0whU6aOmarWj0r2BB8i?= =?iso-8859-1?Q?JELW7MFvhSQwa6E2vva1B5GUWB1639hRbAz8reuItigu4yHtJyKp0BqKLU?= =?iso-8859-1?Q?V9wTo4Dms934ouA+sYCLn+B+Q9qOBewPlU3qFVPee1lJLVuEw+jaUMd0bo?= =?iso-8859-1?Q?u9eXWIKEOyS+M2rq036fQ4soj3jmPdwPSp46Rx67P29M1lHOX/FuvE0Da5?= =?iso-8859-1?Q?HHr2BwsOTsDfOfCmiTJWq2TOlnkKTyyC7cfMlniTNqJb/XzM9Y0gtgT8qk?= =?iso-8859-1?Q?d47pu61wKKrcGm8ZSiWFchPknaNC5nU+xZJnzaZoQBGAKCIgpVoHU1eDNg?= =?iso-8859-1?Q?3WUza8DKlvV7Ax754PEv1fdkfn7f+XjVVFROpVW7oTXKdGUNbXtn2sCvip?= =?iso-8859-1?Q?CHDI+BOESovsc6gBVR2WXMrXrnpon0ioWuuEuY5OY8CGtUUyRCSLJEV3+H?= =?iso-8859-1?Q?BQaNwWWRiA2k4DKXSHYxnjZQq2SRvji8ZjG0E5wKezMQ4802dKkW50EDM3?= =?iso-8859-1?Q?8YH/ZO2FRyGuKdJVs2v/2CNtYK/YyGoHAjDuiWwNyXKKbkHsx0mwkDQu+y?= =?iso-8859-1?Q?WHviB6lMpDEdpOqhjDX7aFIt70PHX+J+w01oIpjR7XjFRUvFGT3kOt1gaD?= =?iso-8859-1?Q?PXe5MdRcQpJFctnQxzcXai8Uh0j6g0DDr+L5dqEykWY4Liml2uXAAFtA9q?= =?iso-8859-1?Q?ol85gaNj2NUnDne2kIzq6A8xq/FFZIGQAN2Wlk0nzrDoQdrwyzcvtVtaCJ?= =?iso-8859-1?Q?0tBRCJhdP0CG5SbAHuAIYr5+kwV0fnINVxRayyVccJRXIJ8angG5nlPpkt?= =?iso-8859-1?Q?t1WFKRIWUfqPdWgUTQPgs0Xoey7SN9T3ImOrWqGyQX41WpcWkJYAs0A4SD?= =?iso-8859-1?Q?tlwzpgcADkGv1aT/+ZIMgVPGjTckHg6m87cwY6dDQtmBPij7nzOQPl7Gge?= =?iso-8859-1?Q?PoOirg19/hLIy7lmFrQqDR8Muw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?wHW1zKnh2Wd910X/rWkfMIMbNjOL57Imf8/FKGFJtO3DQmXCHV3skqSUk/?= =?iso-8859-1?Q?LndF2rLUugOFyNNHNxI1I97bSS/OxZODv3MnBETlhaB1/0QWqQ4gVt8Clj?= =?iso-8859-1?Q?oEvUDhLPGb8LBOsGOk48At3+AxGI08u1PulQWSeLJf/KWlB0NW7mE36aPv?= =?iso-8859-1?Q?/O24daHr28izV1AosA9H+oDfuyyVifvERPLZZeWXjMqbsuuGOXUsEwwHrA?= =?iso-8859-1?Q?ehpaullpy5cUjRn+GECBHFFJSTcXIEOsHd61flCapDBXqQTn+x99ms8dET?= =?iso-8859-1?Q?5wyqKVTHPh9GHRwazs8z6Y72Pe0KdSYBxFUZ57TwZNKrvgVhqwFrU4TLe5?= =?iso-8859-1?Q?DDg/c3tWw75RLqI47jh6Gu3z/jKmUuW2JyE8FiYGdqSP3bY3Byew1CFQ1q?= =?iso-8859-1?Q?Hnlb//KrPagUGCaSXbpEcmPhz/xe8dD9+O5S5pRU0kl/zDoNpmXJA/1g8W?= =?iso-8859-1?Q?9GaYvSu97Vlyif1pGuuStAM8gB2QVIdR5MIxwiqNLU0GrrbnmG5N/8IuP4?= =?iso-8859-1?Q?v8dKZ97AOiCcrCyXaEThsNSwArmqD1WZ7OPh8n090nbm94NyJnVwpXsYZq?= =?iso-8859-1?Q?hra3J4EshmyAonxSsVxGmhsoqbKhhdaUsWvKlNnF3VjcSCjvIirbXYozDm?= =?iso-8859-1?Q?kaSWkNd2Sf7AsQSLXSZiAWDB5tzzf6Omc5vWFKC4FLjMduWyWMkhw+Qv/l?= =?iso-8859-1?Q?TFUtHKIb6Luit/tkUe4K6UmCU/zmO3TsUQk40iDowZaMIYBiGsPdqJVTWs?= =?iso-8859-1?Q?cYeHpH7a6NA80R5lNWT8vxkdsLE8UUhjQ5+RF6CMCmrfK4OIueXQFJw+xW?= =?iso-8859-1?Q?2E/HHab1fDKBbgKVEuP1soOjobHFS4VI0x059AQ0OXuXoDIpQJRjqPbU5b?= =?iso-8859-1?Q?YZZD7Eyh5n8xyTEBd/EdYyN5CYGXZrOs6nuVZ/HSeSJi8udf+2ixZPZaVi?= =?iso-8859-1?Q?mkyEEIjoRzd2vcxXwtQ8zlsEKdDEfstXylwiE8652hgI+kgBJ0u6z7SRKn?= =?iso-8859-1?Q?SEnEO+9tZreBneJcevIoOsu9qSAx2RmcUYCFnv92vPoxMfHrqAA93kllv4?= =?iso-8859-1?Q?MAPazcEDNibFbtej2outaf3IUYIUixpVSQmGJLAs/kLseVVGvbwHeVrkkN?= =?iso-8859-1?Q?TVCs7Xk1m4xJXhP/6YyYMoqjRv6OeoR/El55Fub0YO7Wp4rUzvFEc95yHa?= =?iso-8859-1?Q?gcseEXv2BatqFR0ntrCQ6alGAZMHqv/PvpXWgPitxexiW6C5Nkl7ikgp2U?= =?iso-8859-1?Q?37cROxwi7BZfZOvGkLi/rNqazYWtbBfvFJMqlC+M24jlJ2e+QMTiPKeibg?= =?iso-8859-1?Q?8deTg+j+L8Vam4o8Gq0zSF1xNvM61Qx+vYTl92FOMNGo6vcsfXWUE77YWa?= =?iso-8859-1?Q?PGLjAlOY8x54iF9PUeWBVtslxtF5AFvTrhxR6/swIPWqoGM8or7EUosQei?= =?iso-8859-1?Q?3EqRTo/s80uzQUqDpLIUnpSDemQafCzKbPAIOCt8lgnBMe2avFVWlDHFDl?= =?iso-8859-1?Q?gIdYMdhH05QaqQJHwB2yaoOMbX/Sn/nlF9SbNmHk5HPZhKw9ACw276yB3F?= =?iso-8859-1?Q?Nur/aR3XEsCb0Dvn7FVGd1lkCA99zIxamFYrzXbpIvDstPg9xVCBRRCe/H?= =?iso-8859-1?Q?2g3Xyr8wWG2+p0/hbdGlaItBJUwLI0FvV1ZGuwoxGMPPqSZUn2kuHc/A?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e54a1f59-ec73-4b6e-3d7f-08dc7f2822ec X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 15:09:14.3542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gnhe4q6azKVd3bPa5ms/IBOOjkWK050bYAPr6E+vlrco7UNGKxL0A/se8PlPgadJ6rgzpLR+V6c8eK7KnePOCWUBqrmCGMQeTqEeHirP0RY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5058 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, May 28, 2024 at 07:59:36AM -0700, Stephen Hemminger wrote: > On Tue, 28 May 2024 10:19:15 +0200 > Mattias Rönnblom <hofors@lysator.liu.se> wrote: > > > > > > > > I've tested this patch some with DSW micro benchmarks, and the result is > > a 2.5% reduction of the DSW+testapp overhead with cc/libc memcpy. GCC 11.4. > > > > We've also run characteristic test suite of a large, real world app. > > Here, we saw no effect. GCC 10.5. > > > > x86_64 in both cases (Skylake and Raptor Lake). > > > > Last time we did the same, there were a noticeable performance > > degradation in both the above cases. > > > > This is not a lot of data points, but I think it we should consider > > making the custom RTE memcpy() implementations optional in the next > > release, and if no-one complains, remove the implementations in the next > > release. > > Lets go farther. > > 1. Announce that rte_memcpy will be marked deprecated in 24.11 release > > 2. In 24.11 do a global replace of rte_memcpy on the tree. > And mark rte_memcpy as deprecated. > > 3. In 25.11 it can go away. While I'd like us to be able to do so, I believe that to be premature. We need to see where/if there are regressions first, and see about fixing them. /Bruce