From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 057B244102; Wed, 29 May 2024 14:38:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 817FC402CD; Wed, 29 May 2024 14:38:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 21A14402B9 for ; Wed, 29 May 2024 14:38:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716986316; x=1748522316; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=c+tkumV5/QrfBLmki86F1dtaky8hBcn+0hAVxcFr+/M=; b=hC+R2KKXkL/zXP7ULR101J4GYo1cXIMWsmMpmR8Tk46t/8ueP9MtLKE6 cSbfMzvKhQZL1dCqgivOTtF0BthZXAVxf9GdtfY01otoYUYqeZKyEbCjp EHkhXmfWfXg1C5hgXzKLbNoA5MbQLPYR3KriEos6wwweX8juYs83HMCwy +sy3OYyor9SlaQ6cMQUkfSkhinkia5ZmE7EW8sHry2etrLfpaUb7i8pFt 88vOOJ5VjN90b9ifQtrPkFFzmG8E60wFrgvZrq7THmq9n+wBWqx+2k7u+ H3sHbULUHcwkJR8p8bEmWNfG60t2XDqPK7jqTOYbnZCkULlTwYrmHImWP A==; X-CSE-ConnectionGUID: 3Tb3oRyLSniTPJKIqbndQA== X-CSE-MsgGUID: 4sY7wAh3T8qd8U+Dx5Bdaw== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="30909790" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="30909790" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 05:38:34 -0700 X-CSE-ConnectionGUID: Un58iqD7QRC7bWhyPcFtEA== X-CSE-MsgGUID: bJofDYHiRw2ty3lec4JdnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="39870779" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 May 2024 05:38:34 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 05:38:33 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 05:38:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 29 May 2024 05:38:33 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 29 May 2024 05:38:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UHgXoPS001JyG7PeRTYUH+2wSfBYDbXnUBdJEE3qUYdFV2qPUurKvAMc2bVZ2a2LapLsZ5IvTFPYhGWvNyq/Ax84id6eTdcXMy2P+1NhptraQj3sF4SlcfxRS8iXmiV2FDbBlAKnjetcqOxpkNOo3gGPo9ttqlzGS4igtEsVea8QK9AQfs6R3l+d13YAKb4FJ4Ecg1rE9xbyDoUD5i3bHIx+RqAWVjYYx1WfG2na3MO5dKAb/NBRVEzG/12lbFSmsRy2F2FdDRq0NUP1qscrGHSwj/kNdlJK+DzrC4ZL8aS5rHn8h0PTdaJgo+djH8/g5UkP+esPjsR/OlWxupqFGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hoDjLfGrcEWsKNJGfgNkRYVIhXxDyIaNeK7Y66synVs=; b=dw7exufI7gPXI5IMmT8Lmpj2rZUvTFcGsZORbHvhMvAP+iWEMO3NFZ4PMBYPaGFZJm2ys27vOC5sZ5Iojidosgio6AQ6rmGCMhahxnct+H+noDdkAgmGmER7clymtrqX46CbXQbkoOpBCbUetLdq0RAEQxEWw88UK1eYNIpFjKtdesGdl/aEuT0RBfDKUguT1plZq/IawXqCwKRcfJUjCJQsz7IylQbhF8qJMdJxRr9Z+3T+OqoCACd/Ix/0Lgn1lcoxxX1o3iFwI2ARho1jSYf6DyOOiSmGIW577/sq8NIsTPPcUnvDbw8eiSG0dsYeB3qxrP1882X3MG/p8mc6GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5143.namprd11.prod.outlook.com (2603:10b6:510:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.17; Wed, 29 May 2024 12:38:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7633.017; Wed, 29 May 2024 12:38:31 +0000 Date: Wed, 29 May 2024 13:38:25 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , , Subject: Re: [PATCH 03/25] common/idpf: update ADD QUEUE GROUPS offset Message-ID: References: <20240528072839.867100-1-soumyadeep.hore@intel.com> <20240528072839.867100-4-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240528072839.867100-4-soumyadeep.hore@intel.com> X-ClientProxiedBy: DB9PR01CA0011.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5143:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d820511-4e98-4450-e66e-08dc7fdc3f44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|366007|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xW+D6Tl+YfSfrwRQ4de84vhU/KqJcZIz628n3yBgddKunupPy0NDT5caQqO8?= =?us-ascii?Q?4V0ehkkYzg9JOwf7SPkj/3LkEpTk5Do/s4kMh5pIYJM+fxlfMmXlrPLUxExq?= =?us-ascii?Q?n6nQ7ymB4+IwzkHrymebpXehTUPSbzlDN5YubbHsvFWCpx2LiVVd0Gu8gl3r?= =?us-ascii?Q?xjcWPa1BmZdsHVNPf9rx63p73qNJ8L8VpWKxcyWieR06p2Ao0ufS2rhcZXjs?= =?us-ascii?Q?l9uyPskLT+QJKaq6Eo5Q4nkojek/g4wJun/rHaK8/RgeI4dpw/4U5U992RIE?= =?us-ascii?Q?5ushijICLrS6l2pa/KLWv502BCUQHj7fKGO94hsb9LaRhcQPU5cy7ZELhtFT?= =?us-ascii?Q?41TTd9Hk0NLEbE3UeKCxf3Vjsxda5Wmsty/85TjY0aHEkmm8g7xJjscgg2qH?= =?us-ascii?Q?75q0V/EYjWGLW0IuDf5H//F0MxAmyapJuhsgRjo04AId+KLvQS1RDy4ScyrE?= =?us-ascii?Q?aWa5M48ByyZvtYOMPQQFS+1TQKlsu40Rjal8HkkkOBiN9j+xFFGwNOOBXzbf?= =?us-ascii?Q?eEQlDgdRjlUSg11MEk4IqFn+bN4qKCmILpSkVdt+bBq55XOReTmO2RPTlSs6?= =?us-ascii?Q?nd0oHXwoAh35xjc6ExMFyEYA3auNAzqEAGhirScz21jm9dhJcvmlhYRZnFyv?= =?us-ascii?Q?wy3hjRfKATQAh/XRGg1V4Qb1eT6NU3oTCosCyiIDwE9a2Ve3NWJz3hzqXT1m?= =?us-ascii?Q?vaSNojbiHq/MVhvNHfgnOwZ4YW4aMUISRK8k12+H6oAsre74U7Osh9N4+iLx?= =?us-ascii?Q?9gDHF1cNLjAYoSOnTM+u+lQmpYhqRMQr/OiLXtkYz3NjJOccOQsQpAe3KHTn?= =?us-ascii?Q?BZ09JpKuBsurCjYt0kI8+yEA0DHLuyHWqC+KjPr1KWWsOB/LZxkp3Q8o08mz?= =?us-ascii?Q?H3cGuKXkbslT6/B+PC99Zrl7XB4NL60G0sEx5h4N3lfm36LNUfpuJPDmgQIn?= =?us-ascii?Q?rici3rPwiyo54nQkR2VjPIN6CefzeICMbM98LuwnnMxyjNnFMvp530Ag9Qa5?= =?us-ascii?Q?/selEJbD2q+hmyW927iAOQz9kTqfYmG8VS+6WKldpHBFRbNrzCbC3jqxP4FQ?= =?us-ascii?Q?yGYeM+cf4hszr4VXZHOoaKRb/oGEvRsCQifJnZP4QBuSDSB1vCWzqwhQLgYp?= =?us-ascii?Q?vLDAlXTwUCmoHnPVEEq/43yUvuLxhY8lhSy4JL8rowStlkeheddByww8mzM+?= =?us-ascii?Q?R9HIooErCYxeBoadheAPdV7XYmX0uDE2T5fc3BkRCQMkQcZXKRJbX/xJ0IUH?= =?us-ascii?Q?C0z2gThb2ChSb2V3dISB+jg9t9D5wNXl3QuO5QDToA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?domGS9zxPOEkqzVQNmXLtx+9l5WPSl5kG3TZFvbb0qXXsT9RUMsx/nEQp4lX?= =?us-ascii?Q?Q6b7FPolHkvtcffzwEzXUoPki/bawRpx7IHsUyrBw3qSviwm4Us8RqWZDbmL?= =?us-ascii?Q?MlVUe1u3h4xz7975IlpIHSO6mkDUWtj7IcDVUWCGF/naAyCAsDZhwFT3VSX6?= =?us-ascii?Q?O4r6MGJPtiOTkOHUp3DpJ6qfgMYsZtgNQiyOqedW+q9TsbyVkchIG10kDk1q?= =?us-ascii?Q?0gC6/aGnziGXcafU6JPIciDCqz6hegcnsJbr0RD0D17+qzW2JAsPpyKEz5MA?= =?us-ascii?Q?y9GCSsxl6K9cyugVishwmBEDIXmVQQKb14+YxnnyyiwR3OuOK8PrcEGdDPnF?= =?us-ascii?Q?Ne6wO+vfo2a3bFmbjOZp3faG8CFVBDL3fVrj2UIVAHmMdbOL48EM8h97dWBL?= =?us-ascii?Q?mq4Gzpjf/hg8IdskiE5FrDq2By+/FZOo4I8sViNDPcnfKm3ShdJ5APxnpsc1?= =?us-ascii?Q?G/j3IVatxHQiQdlBuaJyqpI1DK+Sb6SzNzdbzeP/P2vfW7hGZZ6L6Em8ITN4?= =?us-ascii?Q?EZjYQkWfDrDwcpXNXtmD1C+F6NgJvl0o8Q/vgUXwAdgm1fuOQK1hLSB2Egtj?= =?us-ascii?Q?eo4JGxwrzD3F0dsq/vHUG1nszR7Tp6ZYABu8NDIh0UpsF85G6vidQ2TK3Q/S?= =?us-ascii?Q?RZy/r99BkArLFUdZT93ltxz0p43JoM5t8KV+Bqd9/36clOKOraLhd+cLYLlq?= =?us-ascii?Q?fnJG10ZL1dGYnxZP009Du4YW+jR16QrM2clhevTlMMIE74Y0GY3Z0AEkqbnN?= =?us-ascii?Q?XxmJy/R6tm92W0GlTp3f2kbYIJdJ+Ekszo04s9C1u66mVtEQaLPQ27/swh3H?= =?us-ascii?Q?g/DezJ5QtWFuYnJ3pNlvxEmCR0g3SyIXXlxbINo5qgXUm07r2D2EbXhvB6jx?= =?us-ascii?Q?wczgCuxVeLP8G7vI0oJJokhRQQJbihcqDDWJL4DGVYJTWMGdenMzMzgWODxz?= =?us-ascii?Q?ZgMcFwfzz2VKP327CrV7v/y4vSX3pOBNwIoFaEXuHnAC7mMsMiS06kXanSe1?= =?us-ascii?Q?hTnpZj7eBTw3qHhngzsobUF6wguX3ifNj5t1hMM41Cw25FAtf+b4snxxxGwQ?= =?us-ascii?Q?CNsDMHVflkNiM5B3fvo2XDDLfPFUFULSlYSgnQZkwkPRn9v6vaMvIDjvAlTt?= =?us-ascii?Q?xVwDqPzrl+aKs6rH1T3aByLRYJnlzUQLikvGxNkyQ+3W8D/gyCEvPSjY5ztw?= =?us-ascii?Q?7fH9f72etvIz+BbN1hi1lQvV6fD1iPWWmsZdtqq5J9P/qz2asrQQtGyQ6dEP?= =?us-ascii?Q?5cWyftRJYU0TLSQrvmus5XgPI/o9kqzmUERNRrdRRvzfZpFT/ONsZ2YipNYX?= =?us-ascii?Q?gZwV9Qg4uwzkgHXUY2HUjrvA1+hZdwxDleXrZ8yR1020ygMBdm0w0bYjFepq?= =?us-ascii?Q?hAMqCyNYmjNOkP828g0eJR4Gr4gmI9RQiqpre8IG5tcBdE5Vsk21HtGBTTap?= =?us-ascii?Q?v2bjC2LCmlgLTDeRmJhF5wrfGuzjk6QFM14/hHHQ36LdG2i2LyknntDJzxUw?= =?us-ascii?Q?6Y+gRSUCqCXEy2QmBKFJkAuLGeEPyBS6v+x3N7hELV5fOH13MwNnR319+nr5?= =?us-ascii?Q?ZYNGMKkK54cqUAX/d6ECz2/INR9kHu0ZHhzvL3Ks59zA+pF8MpbWK1bUeYwi?= =?us-ascii?Q?WQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7d820511-4e98-4450-e66e-08dc7fdc3f44 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 12:38:31.2672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q/FN2T2fGJ9NCAWkTn1C7SrrmbghspkUjZm4jB5BeJDA3cjT3ZnaUSAxLjaJ0uPMeqNzThAuxkMRlN77/7L9f+mMH0Bq21SJtwFCgPShjIM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5143 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 28, 2024 at 07:28:33AM +0000, Soumyadeep Hore wrote: > Some compilers will use 64-bit addressing and compiler will detect > such loss of data > > virtchnl2.h(1890,40): warning C4244: '=': conversion from '__int64' to > '__le32', possible loss of data > > on line 1890 > offset = (u8 *)(&groups->groups[0]) - (u8 *)groups; > > Removed unnecessary zero init > > Signed-off-by: Soumyadeep Hore There seems to be lots of whitespace changes here unrelated to the actual change in the patch description. Please try and keep the patches "clean" with only changes described in the commit log present, as far as is possible. Thanks, /Bruce > --- > drivers/common/idpf/base/virtchnl2.h | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h > index 3900b784d0..f44c0965b4 100644 > --- a/drivers/common/idpf/base/virtchnl2.h > +++ b/drivers/common/idpf/base/virtchnl2.h > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: BSD-3-Clause > - * Copyright(c) 2001-2023 Intel Corporation > + * Copyright(c) 2001-2024 Intel Corporation > */ > > #ifndef _VIRTCHNL2_H_ > @@ -47,9 +47,9 @@ > * that is never used. > */ > #define VIRTCHNL2_CHECK_STRUCT_LEN(n, X) enum virtchnl2_static_assert_enum_##X \ > - { virtchnl2_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } > + { virtchnl2_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } > #define VIRTCHNL2_CHECK_UNION_LEN(n, X) enum virtchnl2_static_asset_enum_##X \ > - { virtchnl2_static_assert_##X = (n)/((sizeof(union X) == (n)) ? 1 : 0) } > + { virtchnl2_static_assert_##X = (n)/((sizeof(union X) == (n)) ? 1 : 0) } > > /* New major set of opcodes introduced and so leaving room for > * old misc opcodes to be added in future. Also these opcodes may only > @@ -471,8 +471,8 @@ > * error regardless of version mismatch. > */ > struct virtchnl2_version_info { > - u32 major; > - u32 minor; > + u32 major; > + u32 minor; > }; > > VIRTCHNL2_CHECK_STRUCT_LEN(8, virtchnl2_version_info); > @@ -1414,9 +1414,9 @@ VIRTCHNL2_CHECK_STRUCT_LEN(16, virtchnl2_mac_addr_list); > * and returns the status. > */ > struct virtchnl2_promisc_info { > - __le32 vport_id; > + __le32 vport_id; > /* see VIRTCHNL2_PROMISC_FLAGS definitions */ > - __le16 flags; > + __le16 flags; > u8 pad[2]; > }; > > @@ -1733,7 +1733,8 @@ virtchnl2_vc_validate_vf_msg(__rte_unused struct virtchnl2_version_info *ver, u3 > case VIRTCHNL2_OP_ADD_QUEUE_GROUPS: > valid_len = sizeof(struct virtchnl2_add_queue_groups); > if (msglen != valid_len) { > - __le32 i = 0, offset = 0; > + __le64 offset; > + __le32 i; > struct virtchnl2_add_queue_groups *add_queue_grp = > (struct virtchnl2_add_queue_groups *)msg; > struct virtchnl2_queue_groups *groups = &(add_queue_grp->qg_info); > @@ -1904,8 +1905,8 @@ virtchnl2_vc_validate_vf_msg(__rte_unused struct virtchnl2_version_info *ver, u3 > /* These are always errors coming from the VF. */ > case VIRTCHNL2_OP_EVENT: > case VIRTCHNL2_OP_UNKNOWN: > - default: > - return VIRTCHNL2_STATUS_ERR_ESRCH; > + default: > + return VIRTCHNL2_STATUS_ERR_ESRCH; > } > /* few more checks */ > if (err_msg_format || valid_len != msglen) > -- > 2.43.0 >