From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, Sasha Neftin <sasha.neftin@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Guinan Sun <guinanx.sun@intel.com>,
Wei Zhao <wei.zhao1@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH v1 1/1] net/e1000/base: fix link power down
Date: Wed, 29 May 2024 14:34:16 +0100 [thread overview]
Message-ID: <Zlcu2LNJKt1pqFqM@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com>
On Tue, May 14, 2024 at 04:17:16PM +0100, Anatoly Burakov wrote:
> Current code is a result of work to reduce duplication between various
> device models. However, the logic that was replaced did not exactly
> match the new logic, and as a result the link power down was not
> working correctly for some NICs, and the link remained up even when
> the interface is down.
>
> Fix it to correctly power down the link under all circumstances that
> were supported by old logic.
>
> Fixes: 44dddd14059f ("net/e1000/base: remove duplicated codes")
> Cc: guinanx.sun@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2024-05-29 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 15:17 Anatoly Burakov
2024-05-29 13:34 ` Bruce Richardson [this message]
2024-05-29 13:35 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zlcu2LNJKt1pqFqM@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=guinanx.sun@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=sasha.neftin@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).