From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CAAE44102; Wed, 29 May 2024 15:34:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E706D402CD; Wed, 29 May 2024 15:34:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 4F583402B9; Wed, 29 May 2024 15:34:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716989666; x=1748525666; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=44kGP4mJGcA38NJTOIyl8AsudWPxFVkyo9TzfFaYppo=; b=Pu7MmRLXkNnHEC9VoCDWfV4O33iQUWYyM8nZNN65tQl1sfhCdJDkS9EM xWj3XX9bswLsbSv0akvC3fKCly5jmZjcq5Qgl3K74REOA6m/YUjA3fOfD +6Sj8TSUJnqktWjsOz/22qkofc25QL9Hqit1hLoIYCUhzUqXAgyUTVnr7 XH8TcnwEouY8RExBB4jVipMGMIh0E7T3l6tp8YogQHS3rwRwVxZEBhzGP Lm1/fSWXKVL/saUxWJ4KYoi0A+RAh5hkOJ+x+ZbtMlFNhSN3leA93HDay ba87MxnPOCST8t9o7gxGQQ0mJFKdJVZohuZdHhqUVxStZWKnpH7JNY2/j g==; X-CSE-ConnectionGUID: KWT2R+NqTDmfHeE9O6aiHA== X-CSE-MsgGUID: dIPm9M++Q8uovSUQYZB+kw== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="17225534" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="17225534" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 06:34:24 -0700 X-CSE-ConnectionGUID: ygyqK3jFS86gCSjFpJQXWg== X-CSE-MsgGUID: xyzvTLPJQ66BfqKWRepBXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="35390428" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 May 2024 06:34:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 06:34:23 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 06:34:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 29 May 2024 06:34:23 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 29 May 2024 06:34:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzKpHlWQv9THDFl33Vle34VU2FUYAfEE0L/qGmnVUe0aXWKScnUwAo3JV0wCp881yWSeZ7CplRVd7NR9Xo9IhKMClayWX6VG+zU841DZgAuFG6Lmsg9aGp1Nw6URpXKLW0RiuKrt5H/tNZKeiOBSP+/C0RF/H54/ZD9tRItamSb+saM2/zMjgmS0aVE5nSa9iRsaftfz80Y8GhBRhz7p8A+UwF6+S9tOb57q4VygrbYh78C3RiYMBDYdCe2rS2yoop6Znhxvvk6VW68MLzC6UslZsnZxKvWDa3XkuDk0icKjt5dTKC/dzmnW+qsRAde8bG/4vnEm4zspeNOR95gLPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gbmjhS3knTMb3moSXe9U8A3iLNLnkHDp6wPeBJRB9Wc=; b=Ut+laJYDdeqvwJ8NTklkE8LdKFoRHixEIn+Z1sTL++s1nbP9mfw5arhNfU9vo146AZjB/wj+1U5tAxe4wJ9Pa+yzPCjaBM01faO1OzrQ4/BFcZ+/OOmJsaeOO3XYgQe0UJ2hIKJM77tQHVatQl/cwXFHCpyNUF1wLQk3VRphd9CmrdbM0O2rDH3DibEgWIjLMBqj/rsZo7bAMJP0m1mhfOFwWzE9BPK46d9V1GWVvYqYilwXx0m3O9ypNWGVB0e4giZ3ERjaaR+S7xrnbv1d/a8bTqDbLjY+X87oWom107gOxst4BXPXH4GKpzKMJsTH1TP/lZytiNJthjdTPSM/iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7361.namprd11.prod.outlook.com (2603:10b6:930:84::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Wed, 29 May 2024 13:34:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7633.017; Wed, 29 May 2024 13:34:20 +0000 Date: Wed, 29 May 2024 14:34:16 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Sasha Neftin , Jeff Kirsher , Guinan Sun , Wei Zhao , Subject: Re: [PATCH v1 1/1] net/e1000/base: fix link power down Message-ID: References: <5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com> X-ClientProxiedBy: DUZPR01CA0291.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7361:EE_ X-MS-Office365-Filtering-Correlation-Id: d090bd18-b2a6-4f37-d851-08dc7fe40b8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1q8L1jg01LEh66rRXOBpnOtifjnBFq1pe3CyZvI7nkvN0vteCG3uXXV7UNS0?= =?us-ascii?Q?/Y5ZAtYjYbZCZVpTI1RiyQUcM9GypLUrHKrecOBATxDExKGgoLbhGsmHeRqe?= =?us-ascii?Q?gOxZyYk1Y6B6VvDl0QS2Jsu2CbAbnSSUhz78jgbo48qsAnv6ss65P0P11w1g?= =?us-ascii?Q?iudvT8GbfsdfcKveJ7cvDa/L+v+qdounta0tmRqFiG9QdaiAqTa05tL2TZ0L?= =?us-ascii?Q?0FBDl9IqMngOixClnmvl6c22s4XJzgme4y2rudc4vUpzP+T4x0LUScSi+jhL?= =?us-ascii?Q?Gdx8W1Wiwi//gj2jtjlmu1ExBj+O382UUn55DqLnlzPlQlX5cw0/cdDrUfeN?= =?us-ascii?Q?VcOYAdwgqC44YUe4BGMJwOAAK6iH1qe8naleD1qv/55WzNwTwZYkj4BRpL3Z?= =?us-ascii?Q?VHWC1IZO3ETOuJt6NjAbk7mC+DHDzvdrZdF0EdDD+nTyRLGS9R3xloclNjdS?= =?us-ascii?Q?yWMaTiNxt0CTNEhTtDEUzG6ngKHXjWFxP4QHAKkosPw681Xjtr6YzHM/XI3Q?= =?us-ascii?Q?7MHI0PJRR/tCnGh64nfcYB2WTNimebP3riwVhQUywrBXdRpewp/KBUJz1Pqf?= =?us-ascii?Q?YnPhmsPQ0ikM8ptcpJp6jD5SRX6a9CCr0vG7cxLev6zbELqnz6GUyTqCCyBB?= =?us-ascii?Q?3epvbLX75r2BTUHELnDt8+tH2ULOcTpgJIm96eH76RetEUGzGFbj9fDzjQE6?= =?us-ascii?Q?l/D9rXyeAwrO5JfMIv+4TLjuYuXLm1GM085Pps/3LKAdhn0MMJwEVDpiZ9lv?= =?us-ascii?Q?xrriUJ89H2WQc+7Gnl9i0L1ria8GIeix5zbtKNkNdp/11jX1l/t/WcD3vzve?= =?us-ascii?Q?RhtvhfTEkBD72pXQv/jocuGNeFgwDbT9QPiOTdNwnf/jnYlhKfcP2TdZDOnM?= =?us-ascii?Q?P4NEi8IDSmp4RHiN3BBHX0rlb22BaHbJ6HaKfLc4YSlr/UwtrRyzhLgi+4jb?= =?us-ascii?Q?eLXfoFBvycbDqyUaq1gFcFCUiDbW6FO/uFJLWDO08e1EFAubdsIPAqQ0n/7S?= =?us-ascii?Q?McFb8lczW8pHz6MsIyIwoHGKtEgCXJrd2IR4snXyp9KUEXTooWFV9460/X4R?= =?us-ascii?Q?sffAn9qRSWIkDsMfrRGRrhyS2pb7Am+HToxgOGF6GGjzsRVPBmRCKoYYoXv0?= =?us-ascii?Q?SFKYMlrcZMdR3btCHbs44WkpXLHrbqubSRMUwBy7YhXU3JZ+QyVL8NiNJMre?= =?us-ascii?Q?Sbnd0zLBRsJO9MtlwGntFMbGy5UcDrbmz604qyJgYNtBlxMLynu+sMHLvUFo?= =?us-ascii?Q?N4JE3DKifbvnZHYM3/L6TbMUn5D3a7MvYDlnb8+/7A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gR+gci0CxVzvflfJICcx7qLhkE5mLuAss0VvwLlYKj1mPT2OOj/UApmpHiOU?= =?us-ascii?Q?8TYULB4z9PtmmLC5fnt1McJAe80niz4RewPREi4oNGwcvgJtceycg1MOJFb2?= =?us-ascii?Q?poayanxWFqd3yZVeXiAFxIDyYZ9e/TpiipYk8lQd8yY3QtTzj68vxAtjWPj7?= =?us-ascii?Q?nreA5HE1XMcJ0kUb8lXJe2SaIkoaVELRlDdWEEf8CRyv7p6k6rF52YfRl1/4?= =?us-ascii?Q?ykX8QxxxDzZDRhE0HJftICO9kgFv4jyKWY7lZuHTAxq3BNjHmbVCpzSJziZO?= =?us-ascii?Q?Co/zvbOPBJGI+g9GPccktkPRqypENpiDjrRryBq5Bj/txKXruQTw4Gana45N?= =?us-ascii?Q?Qa9gf5r83ysyxsVHdZ6cRxQzK/2F8kqtmDSgCZLiUiLxdlqzC+WrspJib8vY?= =?us-ascii?Q?ZS8EZuo94utjAYFvl7Tl8Onl4tcJLuhcfbV2HNv3NeP2e5d4yQCvaOkwZxSK?= =?us-ascii?Q?TX/E3MJdFheVE1sP4C05hVhiy1jvoZ+bN5/FIIVMIWsCzPrafzhqm+wIyfh4?= =?us-ascii?Q?/zvfuM4XjspGX5J6A9+olHe8e7vLeunJF7yJXXNVks20L7dQyexa6e4rKh/p?= =?us-ascii?Q?d3QB2GLLktqlZUgbffq7N3NxXD409s8ZOW6awUqfoPAq3TpFUWYZUITXVjSy?= =?us-ascii?Q?FJotcXc5Wg3+JL5wvriFMaFriwmpPolpwMa7gMKA/7VRG0SF+H1aVkATFriR?= =?us-ascii?Q?pv5wnJCtVM58Oi6zNRcHvzQXEfljacwRSUCQaHtajvNRxh+SdKe9v2QMN0tu?= =?us-ascii?Q?/BYT78cRb6P0J9fGlHuYKPMdji/UIfgvuwMeTKKPQ86PCelamNx19jkOW/Jk?= =?us-ascii?Q?p1M4WRjr/BqhU+zuecZux8J1/wpvnAhPTo6GpKoy+gNrJWZwXh26Gt+R9foN?= =?us-ascii?Q?EDdeyi7cMhVCFtJyTKSkWZuc/eNQjA/pmAcPIcP5BYxHREWC8y/bI7izPpZm?= =?us-ascii?Q?lHEqIXMXxBTeZjyLqr/fZO5or56Nw7xhcKf5i18btS8arrJdyads7Ol/Xm6o?= =?us-ascii?Q?0I5gZGUzbeg41pO7ijwaemxKahNbpiJHXD9kiQNcOtKt0sXp2nj1Ba3U3Vk2?= =?us-ascii?Q?K9TsoJMv6Pmf3CSHoyKfNYEBRYS6Wn6pIojf5FvSDCcrbT8e/yo0+NbBYhk4?= =?us-ascii?Q?ugW011lrfPDMGzH/s1LQaFnkOb4TpNCdGNheEpmyXqN5Lepbq9MrauTIm/Au?= =?us-ascii?Q?9/dbGXMDoIsY2w7UfKHxhvtxNoZFP+dWg9BKMNNSEzma5RIL52FIUjC4IWWB?= =?us-ascii?Q?tme67j5rlkdVphrRR5TMZyFMZOg8GRSQHmF0B0zWmU7Vvz0eHJMyEaFe3EgH?= =?us-ascii?Q?KuG6aCPo1qlzRoKuVh1WaUPzrygwg4TAl4YcLEw2z7UWy4m6/FU3/I/buthi?= =?us-ascii?Q?1I6Se6hmZeZuOQlEpvw5UJBIzTCSoVKro+21O6gIaWfDiE6ZY3Glpvkb8SRp?= =?us-ascii?Q?H9e+z0+LCS9hCMSwpRRM1syONM+CjrfJIj6a8Xxpl3ySkZns3NIatnc9lT8h?= =?us-ascii?Q?RDSZHsA6WgvuxLknjF9xKtoewkOLrOE36viqM7LKsfsyzg3rpaPKz9ZyE+Mb?= =?us-ascii?Q?uCXZJA7juSVRjAi70JdLrRD0l6Jx0IKCkmR3vdERRQIo5df9uNpAeKSDjQ9o?= =?us-ascii?Q?SA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d090bd18-b2a6-4f37-d851-08dc7fe40b8e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 13:34:20.4069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 69NAirrV2KOc0JxCbl35KK1b62+KumNDzLxRRhp0mXNWR+xwwn/3rZzGcMdMN7rVF9VSiU8LkQ0Mqa0f2/qz/jkhCCwCFlW0OJMIX3eTpPc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7361 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 14, 2024 at 04:17:16PM +0100, Anatoly Burakov wrote: > Current code is a result of work to reduce duplication between various > device models. However, the logic that was replaced did not exactly > match the new logic, and as a result the link power down was not > working correctly for some NICs, and the link remained up even when > the interface is down. > > Fix it to correctly power down the link under all circumstances that > were supported by old logic. > > Fixes: 44dddd14059f ("net/e1000/base: remove duplicated codes") > Cc: guinanx.sun@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson