From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AE0745523; Fri, 28 Jun 2024 14:28:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CB6D410EE; Fri, 28 Jun 2024 14:28:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 4907E410D0 for ; Fri, 28 Jun 2024 14:28:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719577706; x=1751113706; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Kms637vnz5kQ/sqVEq6wJjHBaJfey00+pLZbXPm/+Bs=; b=O+6pYsXFPXYijTunE5W2rnyTdhhLxGNSJuJyy1x5JasZC9khpXWJ+7nf jysjvoDu/J/GYzIcTS3oDNQgO5uixMBXSxI3L4w9liWbbRRXLSLBpFgnW qz2YgVtgtD0Pfkn6CBpfCz3vUtMGI3VIOmwngGEqeWxlI9I0EEn6PWsQh ispVQeadACXdQuUuRL+nt2YLM23B5ZsN4iDGk+pdl8d9WKiUz+opOEH5D yvIzcZUKdPnrQLKt0DsFHFaIxsS08c6J58rK/n1ubnZ0Qf0FvSi9OOA16 Bn/r/ibUB2dQ08BBCiTb1sx926iKKZIfJHPCqxoi0+aRcwTZr3OLHrSJe w==; X-CSE-ConnectionGUID: S5bzLfU+RHOb1Yzr8NUEyw== X-CSE-MsgGUID: 8EOXFYP4StK99SYLmUs8Ig== X-IronPort-AV: E=McAfee;i="6700,10204,11116"; a="16713367" X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="16713367" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 05:28:25 -0700 X-CSE-ConnectionGUID: Itd6UoOITSqGyxBF5BYLsw== X-CSE-MsgGUID: lhd/Zdh8QsuHyHEjxRJQVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="49202036" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 05:28:25 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 05:28:24 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 05:28:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 05:28:24 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 05:28:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5D2X/s3q17mzM0DSTSGYQxJ6W+ZZTz1qOm0TorK5IRCvNDOcOmG+GIWOSynis+Cr/JOGBcgFS12kUk0H9bFcXA8b2Sr2UBPTCPkc38UpS3n/FpmUVbBMyMwW6jSdP4QzIQKSaA9S4cNmNrQGc9E02f9u46r0jEE/+n+5H68lBlQF55P7nDDRiMHOz/4yioocit7Hf57a3VyyMeT6C0Prlj3g9H27p+IhRm4Hi/Fw5gTJc8uYwSlw81xVLaAF7MtNZSY6WKxwt7SZXrfoatLIFHkXyio5cW+63YOCa/eiPLsjJoL3hxC9TUdHTrwrsUAKUng7Ja9qr4JXyQN6UdL1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P27ZpK8jDT/pkhfqaacjIoXv3eQ3vG8ID1OtM+40pHE=; b=J2cqkEHciPHWpj6dDm5KPTccJpW6ZHUnpruQQU4i2zhNcjxnJ10weANe5wJvBiFJwLAQ2XT1vxWmUJDtUYoxz7ATt4LM8mWEHzZ22g8qfWMSV3gG73D/kLjQwtjVQDBSaTPId4SKsl4KPzxa8+GVlmwohbhfHSdFPd/NxajvY+IcBnNjIxJ+5gUCg7ZwjailtEd9pAM3oUHbcX7UC7PAdmaSDmv38UrpC9FSHrXBWA7Gxs2vPP9ajzEio+dGe9mMSVCychWB9dievFhIht8njhocg6GaVELPurQ/CNZT7F5awXBSegNkVr10KhJIpGBQ8OQQOSvOU24O67+neiDCKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.35; Fri, 28 Jun 2024 12:28:22 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Fri, 28 Jun 2024 12:28:22 +0000 Date: Fri, 28 Jun 2024 13:28:17 +0100 From: Bruce Richardson To: Igor Gutorov CC: Subject: Re: [PATCH] net/i40e: increase descriptor queue length to 8160 Message-ID: References: <20240527161921.183866-1-igootorov@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU6P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5277:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e7f6f0f-b9ad-4675-9d83-08dc976dccab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fLaVffLAMqplFexOShl1WkSaiPl3BNYAmICWrU8fIqda4jfLWJ20WDpzHVba?= =?us-ascii?Q?P2dIi/nDPDgS458lO0K6W+I4tfgvP1DE/HB0IZ+H/BVX4tjvuczSQddWTUKN?= =?us-ascii?Q?PZ+anugIBN4CvJiGaOGljaiE1a6RbFdTVQBwK1mLBdLXsvilKyJoxqOJKWq8?= =?us-ascii?Q?kx7szEoPs7qba47JcQ9rupgQ3iP5JGG9UVmijD4yWsArkNGaUvObWvnwER9O?= =?us-ascii?Q?sReae+1hUHUWQN24adlc5ktHmEBGAq6+fIV8YJzW2FiRozQJNmk0bULb+nHW?= =?us-ascii?Q?icaqYymbigBqBdtk/NanGtNgJMdzxW38s2Xq5S3tVdY91wXXRK+5+HpMZWZB?= =?us-ascii?Q?T+9uq4kmvl7pvzOc7RoSRWSs9qgl/xXD1QowDYCDv0WcTOYtJSj/oDtbouok?= =?us-ascii?Q?FYxt1m6fdto5IGb0agb4WLF6pmn7N4aZj4aX2mjLtG5IXBs9dF5XLBxZDXfL?= =?us-ascii?Q?P08EYvkHbmZYQj4Dd8A3q1spdN3L+qibdcdXdZacklJOFb+Owy/pndDJThQY?= =?us-ascii?Q?2GVGflnLBba7weecvJXxdzmFGrnC8l8XQF5leMPudZWFG4UOEXYpt+S0+Jdy?= =?us-ascii?Q?xEUnJa6U1d6jVyPA8LPma9KvADdYhgpxGF+gUWjdrZtfrsfLbz6+IVyrf1J4?= =?us-ascii?Q?gWMUg+nUmhmLntw95sZEYcDQoKwfGCEQ8qWlmLCvOpQEY6b9gF3pKI/VjD34?= =?us-ascii?Q?Ytj04L4XujM9FUMyZ4UEwmD9iY0pKGdwi9Ikm92FU+0oLTfKny9h4ib8sfFi?= =?us-ascii?Q?FWDs7kggelzQah5brFeTOAtsp0vS0ReW14+kI6iDehhsVHFya28Z13PP07K5?= =?us-ascii?Q?WguOgOMp17uUAJqy6JeDwAqVPGxsSXYldbjUFw9eIGNR34S8lFficxVoQubt?= =?us-ascii?Q?F8fHu8GuHJt6uuUNxTpp6gG8w/U6uKArwhpLGRWaNfcHyQuMR7NPlsNRCKq5?= =?us-ascii?Q?NFh6xGerlo39LOo1Hif3W5tBn8iUOTphQKaxTRIeQo8nEeOfBW2CGNWs+7R3?= =?us-ascii?Q?B8HcD/09Ljs3MTv1vFkOdkJgkhnorFbDpRDBA0e0SRY11Ab7N45DCEST6BYs?= =?us-ascii?Q?Kale++AgD8W+W+O0hlkf/lFfb4PgKQ6mJE72gKs2/jpVP0IEyhTlPywneJpz?= =?us-ascii?Q?hIlfdxsZbMEtYGqz4xR0P5YrKO+EXhzcMF32gqmGm0ZhzzogpJvgdIPq1n9t?= =?us-ascii?Q?odREZ1bd70gcdUeN8sK5Xn5qL9vHiUgB9LIB7De16botYjqRH6lwYW+LpgRo?= =?us-ascii?Q?hpS+4r3CBo56YWwYzdrbaMaCMaixbirPIk9ydpilCOBVshJaD3y8hLnRR9uW?= =?us-ascii?Q?ogLQDesl6dtGW2Hw8mj5SmjU23uE3hEORJIU7+Jr30cUOg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RX7Gt2N7eDU0FAGG4YXaFCrfvvP4XWS9rRywj5CoURMI47WiSYf/5ipxQa6x?= =?us-ascii?Q?a7KukZGOX85XdclO772LZcUcBdy327V0ZwaCbJF8D3Jn6UTnkVEKSrK7np8T?= =?us-ascii?Q?J7+pgDl1GbvxTjUG/T4sKxxnqU1ry/Yf2mPyw30pH0vyem3SMOzlHZg6Tos9?= =?us-ascii?Q?RG/Q/3ncxF6tGspBFCE32G5i2vnF1zqDjmtTuZAyRQfX+CRl6Eqy9XIK4mPV?= =?us-ascii?Q?HghdjK2gXU7UsPTghXr6y2kk0PKwlLhOHyrBJUnomel3pCC8cy8iH+bPPgNl?= =?us-ascii?Q?zR8C3AqN88sj9nZBIfCqvcdKZrfMy5sxjHvx/JbIoUFKxOyZ4HoUuGKLv0o+?= =?us-ascii?Q?snzZ6itLjDdmHijgxPsm3nGq1bV/Pnu3tl4/tBg4zGVb0xzbDJLkKOj0MsaU?= =?us-ascii?Q?Vt2ACFD8uUSjE6F6gQMe7V6QuoLApFgJ22BP6dh8QUDTdwji5bLSlUrDw5JY?= =?us-ascii?Q?0jC5vovuitwIsPbwxSloA98TT1TCRL74M4sTrgfVBI5TK0ACwFLe6aHfLsRN?= =?us-ascii?Q?8X6nUB9Uf3BaxJ8I/ujCJsEPV4RqFRBWXnVyKxRWkW+zTEK9g4SaSvrSCv4M?= =?us-ascii?Q?piaswU0Pwp9HK3IhLT0LYxJD2zTi1qhSg4tjoOu/sO3+b/xvVN3pLhEBxVd8?= =?us-ascii?Q?PZnT9OdPKUm1mUCw0HBMeY/hJWQ03SsQlEUck8CsEVWU9DGbefn8IMuxl5/i?= =?us-ascii?Q?k/wC29u5YPfm1tLnvUiciYh0gyojA9/o69rzHm3b2uxxdbD2s5i3wxz1B83F?= =?us-ascii?Q?7zT5nLImUQGHaXNrlPHSeFBJyjnajxXh/v9cs17dEOJdK+KKYgMs5g1ZEHTO?= =?us-ascii?Q?OLXfhGZ3vX7NszuYBBQVHCyDrCTnAajYK8MIZ27xXsyI6yoyXeiBWZNnX05B?= =?us-ascii?Q?oWoWRVZ+Gr6pUkLiPGrW2Rtm2xEbO5XR58l9J/WNHHuKRcnPPsASRO9C1edU?= =?us-ascii?Q?M6yPq/0G5qE4BvKMM6vFE4jIq8apPwiQnFzvIoHVeSD3adbNZtw77gBMAg8P?= =?us-ascii?Q?lGaNDX1kmFzG60fCES3nriNKFJOtHF1zoHXly28E59fZ9m0oxPWgENOB86v7?= =?us-ascii?Q?X/ve/qf9eAtMeG1SnFtJRCu44Mkl6EwLxQhT5aZwnJDV01CEAHwgl3yexDUY?= =?us-ascii?Q?16XENL8hkRXYeivZIaoPpFPFgk/UnWDwf0DTTmJAQ/UYmF/a6II8ZGlYhUS6?= =?us-ascii?Q?7nyBlS8Ii+rtlNoGwXlZPIr4Pdr2sczmtF9mKi3vJIYbVuAl9mB2Ol3LNWXk?= =?us-ascii?Q?dDQX5RXCk2isCXMgLIPcgkdEeTsH7pvKZrKQWLlJjRzP5kzgLtTWd53iG/Hz?= =?us-ascii?Q?gjvC9aD2aRpYnrhJfYI/pKPX6nSNlWwn7Qn2+SKSnzxbILoJoI+ZcazNYgqR?= =?us-ascii?Q?uZuTzGEtbHoP2pyeeBj+ZWxgLmG4a3lN6xOXZBLb72qM3mhaNWTBWW92IaW8?= =?us-ascii?Q?3KpOL+3Q8QeXjvbqq6H8c/MxiKiZhUDJHcdPj3q1ewPsb/02QDWXokeHCT9B?= =?us-ascii?Q?9VxJW1bCs26fFuPd8grK1RT7N2j6YCeAAYr0bQX9sfQzV0lIPG9s5GtnTKve?= =?us-ascii?Q?V+d/wnl3fqECqriP/VR7oO0OGV61uoLSjamwLeP8s7eWsahpPPzp7btpBY8N?= =?us-ascii?Q?kw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0e7f6f0f-b9ad-4675-9d83-08dc976dccab X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2024 12:28:22.2942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yjwi6sd7CTSmqQ55UXyJwVvYpg82qJFF/WA1MkYwvcF35GTI7vFgzeGCZ/sRZxl0e16PDDiVmQnDO8rPQACNBA042nlIPaZjz9+Uzl7JMbA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5277 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 18, 2024 at 01:12:13PM +0100, Bruce Richardson wrote: > On Mon, May 27, 2024 at 07:19:21PM +0300, Igor Gutorov wrote: > > According to the Intel X710/XXV710/XL710 Datasheet, the maximum receive > > queue descriptor length is 0x1FE0 (8160 in base 10). This is specified > > as QLEN in table 8-12, page 1083. > > > > I've tested this change with an XXV710 NIC and it has positive effect on > > performance under high load scenarios. Where previously I'd get > > ~2000 packets/sec miss rate, now I get only ~40 packets/sec miss rate. > > > > Signed-off-by: Igor Gutorov > > --- > > drivers/net/i40e/i40e_rxtx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h > > index 2f2f890855..33fc9770d9 100644 > > --- a/drivers/net/i40e/i40e_rxtx.h > > +++ b/drivers/net/i40e/i40e_rxtx.h > > @@ -25,7 +25,7 @@ > > #define I40E_RX_MAX_DATA_BUF_SIZE (16 * 1024 - 128) > > > > #define I40E_MIN_RING_DESC 64 > > -#define I40E_MAX_RING_DESC 4096 > > +#define I40E_MAX_RING_DESC 8160 > > > > since the ring memory allocation in the driver always seems to allocate > space for up to the max number of descriptors, this will lead to an > increase of memory footprint of ~128k per Rx Q, and ~64k per Tx Q. However, > I'd view this as relatively harmless given what we have now. If it is an > issue, we should look to fix it in a separate patch, rather than blocking > this simple change. > > Acked-by: Bruce Richardson Patch applied to dpdk-next-net-intel, Thanks, /Bruce