From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7CA145523; Fri, 28 Jun 2024 14:39:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96F82410D0; Fri, 28 Jun 2024 14:39:11 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 98B6C40F16 for ; Fri, 28 Jun 2024 14:39:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719578350; x=1751114350; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=nJkZRTxbtyAp4Wn9BagfAsZl0lHPEltgpnRsYoYrXH8=; b=eQQky3UGN2x7A9jLNb9Z66mhiWYOxXo0uUl9xWZlKnQR2/iBYfpgpyAr vow+MI6zdLjLV96NvTkDlmAXZcStOpEve0DhacFaBQPEu41ew8XFkyhoh Z2JS1akK5J51VowPNzwiMF3zvb23C1LJWeOGxAM0nwN6o7Mx97oBPKEe8 eukhpMr2b4QpBP1ZzrQvyCL5aR6TtpfSsypDhdJXKZ/m0q3RHPvU3FxRN VBo5bu1fq3Wu2qPUgLhKL0rNp0un5TPEwqdYQD+vEHyPJ2uP5w1OWtrQa 1FIfcyDN5F6laClOIkdR2nxTCr/6iPr3G96Jzb9/5cRYvJar+ATHLZLly A==; X-CSE-ConnectionGUID: BaR52qk0TQOiphrbrwwzBQ== X-CSE-MsgGUID: naGQTs/TRgaGto4iimb5ZQ== X-IronPort-AV: E=McAfee;i="6700,10204,11116"; a="42179684" X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="42179684" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 05:39:09 -0700 X-CSE-ConnectionGUID: G4bB8sSuRAqHx7XSxSUcGg== X-CSE-MsgGUID: w8Kz2T5HStyMZewC+N/rGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="44785752" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 05:39:08 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 05:39:08 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 05:39:08 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.45) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 05:39:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZ379QA85JdPiLG2cXih+Iw0BKw0N4eGNlrA/AB3XYQXphHLgRYz5TGH/Ap+ddQ7myYGXVj+9Wh9W8EtJ+xKNHtL3xy2sQ4jWVH9fqTlZImAzb1pGf9CWabvidRaNJuV2kTEcGV2u2E9/DLsyP7jiQ7qLyJke675Vd0CnxNfLxpVntbqzS8HRMXw0L7RjM70clwD9otF2QDcJ4Ji4swvTC7whLlSEwtm10H58YakiE/ywJFK/5Lv4TcnxcW73cVPMpmjPvebNSSDeigBSdq+7WBgI7HjwTeoqFl8+xZc8hb06Hefz2ECmV7XEw38UO0Ailk7/XqVBrHxPqZsINhDIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/p/Cc3FOwGZTi0AtFsdnOdWuaBZx+aIEpQEYajjOCs=; b=WtUU4V7XsTce1DpBNnzCJ0tmUSXj7053K2qXQL1P259QhNMhZvPbxYexm3kCI4h0+IfVXnSCUV94CruLCTNmupRbdvZBi2eG4+SBpMBWuvvldAysL4doVLIaVj9wjrG4Qo3/eBxjiD0Kg4bKD8d8qS8R/xSUQOBo+ZuKMWIT1XPG8BE2+h/Qzkb0VNQy6Cc7zT0qoZMJZf9bZRmzfd2EEo174H264M8si22VnHKob7sOoMh40u+AqrRzEh+czAbr2qyDCN7Fj6Bj1OwNw+LDCbnJJtGwEzkc04VR9A6SyAD37WV30PkC41DzLfWgn4VAw1OKOKzs0JgmjTSDtb6L6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM6PR11MB4530.namprd11.prod.outlook.com (2603:10b6:5:2a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Fri, 28 Jun 2024 12:39:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Fri, 28 Jun 2024 12:39:06 +0000 Date: Fri, 28 Jun 2024 13:38:59 +0100 From: Bruce Richardson To: Vladimir Medvedkin CC: Subject: Re: [PATCH] net/ice: use a different method to filter LLDP packets Message-ID: References: <20240626173155.2177002-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240626173155.2177002-1-vladimir.medvedkin@intel.com> X-ClientProxiedBy: ZR2P278CA0024.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM6PR11MB4530:EE_ X-MS-Office365-Filtering-Correlation-Id: 895eb595-c141-4e83-6edd-08dc976f4c7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7ZSl27+spkT/tIok4zGUKbQfYsMKginZaTN1DjOtlSmECz9wTFkNt2S7C18T?= =?us-ascii?Q?PaHJMbPQfZIjJy8umL6rbHG6sE/V4srgaqXwUFBuPdolrlFYAH+CvKP4eAB/?= =?us-ascii?Q?Bu8I7ti38ym/KvSHBFs2jN3H4jnJQxN5632diQqoY9MlCfBYDej2D0kUgE5q?= =?us-ascii?Q?8WhIEBQ2OQqi/q8YXLfycZzuNJJcNLBLuKkS3gYoJrrtDlfxZbqmTS59bctD?= =?us-ascii?Q?AAOd+wfTJ0lB8vgtxXgoQRP4Fm3yC1EvBebreuLWZa4Uuvn6x/AP8Ovv4kYn?= =?us-ascii?Q?MGAchn7HpCUvUwnbyxVpY1J93cUIA3QBe3DOqDS2F4ZTKIp2IqdyqZ5dXqTq?= =?us-ascii?Q?zHqLaeAlPx/w3ks9Z5hZWcg3O0s+iufyjJlumrBLrKjKyrofujT5zi+aiqUN?= =?us-ascii?Q?xvQ2kgODbUjhD34xWl1dWoxx/TlpTZXnSFimVPLjF4vuNf53uYeyEgE3NVaO?= =?us-ascii?Q?I5zvL64M9g38DhbGPWYgF6o6aVn55DwJLJEupZtr626bquJsPvpsL24s3cxg?= =?us-ascii?Q?ZnpqMOvc7jHxYrCxPZ1UTJPlEVYDmDJJtE4Umvc0QYkSaWcfG4Gm1rrCle+L?= =?us-ascii?Q?UsnoFCMWnSIPkPv5m/TjzFvg7LwwUBY2B6qYkpioQdlqLlUtZ9o1puYKVzvB?= =?us-ascii?Q?pBa0HGVZ4VnnjeAI71OCw/DX3f/rmeoxwuBWQympVT6+Kv3oOP6G+6SvRrcY?= =?us-ascii?Q?ZxJAeqPwKsEbrUkfnuYtBQR2ZaVOlXJDwIXmBc2rbsDmeMXHR7r4rT3wHpZD?= =?us-ascii?Q?17UA2zMIobVUvklpmSd4hb25jbVNEKQAykKJKDuWTn3fQ3WuQPh6f3g/Tj1e?= =?us-ascii?Q?6aEtt6ZrMwOqXwBxZbywVh4NCaZB0qha+TEZB5UMa4URk37RK+UcAo+78nDN?= =?us-ascii?Q?IPXSV7NENp7jrrkjRQKnb5hiE+167d/qGMSlUa+3E9nyrAWUJ3rm/A6ldBDb?= =?us-ascii?Q?I5ZqLz5Zb6qnnvs7+FfB3UiWJUCCwaLgu2jumT/yg7E80b+p65jcLSFLAWad?= =?us-ascii?Q?EnKg0HHiSkoat6CarR3lwKal36GrtvkHfAObX4tYyPIAsW4nXPNzkBBlGHrS?= =?us-ascii?Q?GUqZErVSmRsyd0JHFv1E7Y7WlHdfRERBthks3gDEOaXq4LKMKbADbk2ZfCPR?= =?us-ascii?Q?QWhDj6yR89vRenvSguOroXwxKxR922BYhcmop6eQpbUV7xx9Wh4HGdMtFdpc?= =?us-ascii?Q?ntEzSPMNA14G/1H+LnKh+A4BkuaX3BVDGaHtog1D1gc/bYi1kilYcuAqic6o?= =?us-ascii?Q?H4Q/5+o96jCsE/u2ktm8YiDuagmxw8C0HFMccYYuE+OdTFL9Oal+WAe3WSz1?= =?us-ascii?Q?hYx8SEqpUdo1IxxUNEX9Ul89qu/NdiWEb9vBL6Ld0Ue0Og=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RCdUnpfUbX8wIWdQjR6l8abJ4Sh3SV50nQWD+k0EwsU5T5hgnI9U7Vg8HW1L?= =?us-ascii?Q?+u58uraJrqYs/aopqo4MvEhQtP8EHocPjujCE4dNTDeEnzFGAPMfUPDTppCe?= =?us-ascii?Q?kz4Bh/oCNSJyydu5h/UKYecBBIZPOlyTTKiwR/Uu74o+Fs8xpcGs2nv1HSvb?= =?us-ascii?Q?TvKQjyUuz2RtVUgDVU7/NRr8H4MxsuwWLffb5nu/npLvYoDp6Pvh0W4jZliS?= =?us-ascii?Q?fXpJoFXAyjh2wT3xTD9ZdD3doAT658O7w4HCgI8hkHyN1o0ZeJrIl7XwDBxD?= =?us-ascii?Q?rX3ky4T4kIb0DuKSEMPBQEbrrSUqqzMsL+z8GsRK7yVnCWaGbTerQL7FVxu1?= =?us-ascii?Q?xY/p8pxmUX9bvOddNtMY60Fu8rLSiD1bQDz8hUXpGmYU8xeuKqmbNA2zv1Ji?= =?us-ascii?Q?cyS0x8huug3PH5T2KCccbrUO4QGqH2smMYPBlxL2wV5lCSYhenfqGbALhWPm?= =?us-ascii?Q?g1TKZhzLJbQrBhe3pfJTwL8hg2hqg0PSfw2W9mltOa1Df2s9JaGnQTSYJxkr?= =?us-ascii?Q?cD5YxiT2aOersY3FJzkbk6k9n29ozi+ppAuMW0B/vY60GAPLdQNBLCjzjx0I?= =?us-ascii?Q?lrWOCp3KhM5Y7+cxkBxv+8cL+EfLR2yB9+NCFA6wObtnEbo8Pb/88EV7dxIe?= =?us-ascii?Q?MB8WIg/gRG1to9ksnDBG85NjZn/L4iTTY4ME96AV3O/8vgeNvt46PYYxucmO?= =?us-ascii?Q?7MI9dpHjNZvrvBdxza0udXkfsWfeIgrygqnsHKr7cp+4Mk5H+3bpoqeWRisU?= =?us-ascii?Q?J6b4/tatJFfeNZcaWCmhtX7fUoHC+o1YSOb6cwwb3UufH9Dpg6BacP60KDic?= =?us-ascii?Q?+WwvpcUkAy1TEOPE+xqhevCxY7VuIAKnW2UG1o9uJn2HtNGTQZJyCWqRW+JM?= =?us-ascii?Q?dmsg63T5ru7jiaSNdJuNlv+CwMT+UKjBNsi9bfiWt7D2CPzjxEWp8YYYKpBV?= =?us-ascii?Q?CAhYJXEi34PsDG2lL/9pVgp6YedlH4dsWLjas9XfAjf6Uk3bw5mPjWFfLwPo?= =?us-ascii?Q?asJFrRIofme3Rj2t3b+mw/sIjdTx6GnXn1yWD3ee2K9UedBS0Z4ITa6qt7Jr?= =?us-ascii?Q?ODj84m1eIBhHlmBcw7GGg4irB3qX4q5fL6fpnE70BwfXAuLHK07rIn7mAF5J?= =?us-ascii?Q?nfR8CJlMIYpJWmhc5bSBUKUL5vr1wj5SjWBfQPmUOFzjyzouce+FqTQfX6j/?= =?us-ascii?Q?MTYvjdmUXvPBngvSCEnD2A1mZFQQBQliXPGSuQ8fhfC4CxvDXrqyPHkW60rF?= =?us-ascii?Q?EWAhFCqwddhuqJ5tgYFnykQeA6aamaJXcDHmh0jWfuZENleKkikMANCdFjcZ?= =?us-ascii?Q?UdMGvfOPz/gb6vavBJ5+TVf8HpshGD1DTEgT8/AM7qOzuS13ZqaSTSR4cAqs?= =?us-ascii?Q?hbjcbXY2AtFiduvv4ausjm+Bkd1QS+Xvrxo5R+HfNpoL5NlMNNww+2H+xTGX?= =?us-ascii?Q?DCSPX3FZeeRolY5urVdsA90E+hxKnvuOw1xek1iXGncqjVsBF2QdkTUZQf1C?= =?us-ascii?Q?YbO5rHpdiTQ2K6FnX96P2vYZpvQl09yFLFHFazxu2QNPKJzPAbI5be7EvDbd?= =?us-ascii?Q?yxq6nQJdTWrl98wyQ8cXqrvAHOl8ZqCFQxHmswix+7rfaa/Zxn3bRtxyRCoM?= =?us-ascii?Q?LQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 895eb595-c141-4e83-6edd-08dc976f4c7e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2024 12:39:06.1327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FiEjqb9ZfcMv3EWTG6UIlAHgkB9AFwhI0ESNnhasEHzCQrEacKBE16EjF0WvWLTdpkl3LpoM0ZoJsfH71Mg/1b5EtQoMmnO8vSsbH5MFxBE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4530 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 26, 2024 at 05:31:55PM +0000, Vladimir Medvedkin wrote: > Currently, ice_dev_init() calls ice_vsi_config_sw_lldp(), which uses > switch filters to match packets ethertype to redirect LLDP packets > to the default VSI. However, some NVMs have an issue creating such a rule. > > This patch changes the method from using LLDP ethertyple switch filter > to utilizing a special AQ command (LLDP filter control). > > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Bruce Richardson