From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7687E45523; Fri, 28 Jun 2024 14:49:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5540B410D0; Fri, 28 Jun 2024 14:49:31 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 544DC40F16 for ; Fri, 28 Jun 2024 14:49:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719578969; x=1751114969; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=LnTALHTR9/aZ3DR2ST8NKdQHTo53ZvpTWqUUP6Bd2IE=; b=D5bXu+kU/XsYlluZO0RGsuRVuTNcr+KpCPZGppEwxWnbYnTHsVqDVyHc uJFORUnNtpCtoZVkFupPPFrYwIy+acIRu84155MOcMNoFCMUrMGt8Jw+q FD1kYK8zNb0cGm5y20dGVMAQ6/D4HEEklEiGpZFbva1Bu12gwFqe7hXjY UGu3cP72OHMmQCm7JmqriHNl+TRRpzu+R9Y7HV3MgVXXyLi5QrkypYAW4 E6cIYpLh/eDAK6qPAbDj9ixiK87BqlJ+Hq3sSLmcY2dcP3wmasnYyWu3m 7f8qrOQ6qTqe4TESYd+995vTin5MraEf+EujXLhddtzodJxyfK40q/QQo Q==; X-CSE-ConnectionGUID: K3koPqJPTTue1C+Rmsmrdg== X-CSE-MsgGUID: V8zf2uHYSYS0/+AzENn5tw== X-IronPort-AV: E=McAfee;i="6700,10204,11116"; a="27380722" X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="27380722" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 05:49:28 -0700 X-CSE-ConnectionGUID: Va+sNX6YREa+FE/YNB8yCA== X-CSE-MsgGUID: qGXp6/2nSQ6U7FyfYZGYPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="44565334" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 05:49:28 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 05:49:28 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 05:49:27 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 05:49:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aLlKQjmf7nN3yRDEMQjoeKO9C/sOMCHp2ncwMFiYkRIvLO858AOrqr0Z/7rUPCxos0JUV1ELAj77aHnM5UWm7nYe+NNOwYtpye712+0nKBjKsJsNjVN+1tzF4x4xmte6OD6+usts4kJcO0mMApcnPRBQ8y3z1G/RTXlApgy//BvhX6sc5cjcyq0KDfVzCST6FNPFWd/zwAzS8ETdGxGgt76j/nI41LxmqPBmWkooRCw/3ZYyfLbnD4DNmNJ12ZjdW4Nog7vj5/bjGcLvapF8rxrthfs+UpQ2Txss5M59sx3TQDfZWfxrIeJL+pmF5nSyQY69AF1p8B5HOV5RCflfDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+v+PvqyHJtvnjfLRuN5hBhhQm8En5yNckKKJ+XLl5rs=; b=TEmms8dSkYr8//qnqUlnlWeS2ola+Bzz56xQbf4o6hDx2cD0CtBv6iPOY2hLcdHNtjvz8+DK8Znwvei1D72tYZXs2dNk+x0PNRdIafYoAtZOO2o7nrrVvwZunlv3FDmL8E8WUCk5YC+BmhmjZ0vOMz0Og0d5gsPAkofMtcj5a7Mg2ziBHy70yb03QqQpNdfAxX9Z6u9OtL3mGgwA+QqE77YlmVQc0XRlPaFIqzXBAlE0rGrVSL0ekHEctu+ngumM4CQGuomjWKn7ti2gFB8WveHjEA3Co+l2fK9RdnHbbqLDQk+/npUrMeZtY0TvZ3uGraw/rFh05Lf5WOrn7LCajA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB5076.namprd11.prod.outlook.com (2603:10b6:303:90::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Fri, 28 Jun 2024 12:49:26 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Fri, 28 Jun 2024 12:49:26 +0000 Date: Fri, 28 Jun 2024 13:49:20 +0100 From: Bruce Richardson To: Vladimir Medvedkin CC: Subject: Re: [PATCH] net/ice: use a different method to filter LLDP packets Message-ID: References: <20240626173155.2177002-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI0P293CA0009.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:44::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB5076:EE_ X-MS-Office365-Filtering-Correlation-Id: 480c020b-07da-42d4-4c87-08dc9770bde6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0wpkOQYOSyLPO4px9e4iObL4/k7DHVuP3ZtJJVzYcUk012VNrHdd34U/S50t?= =?us-ascii?Q?n6G5Fqsq7hpZBda3naFyahzlT39J4JVm2czoey8uqMqrROpapi623tcsvUKE?= =?us-ascii?Q?j52NQMLuUaVxiUF1DEQ53WSHO9tZiiE/oTLP6ehwRib1rTjwmzwf/2J1PRSQ?= =?us-ascii?Q?4C0vdmuNBTRG58ns9TjQW/AT2Y2xP/0RPNzgIy9HelKi3apOZZe4LMwKz+F+?= =?us-ascii?Q?aIeiVwErpVGlC/yGIhIZiakSpSmGFZW/hWzX6bam+xb3+SZ0wLzfT4FQzwbK?= =?us-ascii?Q?pOFeHyUQyqQJZJZh4xygFzeljWmjiXMhXNaw//7A0gcVZJPzZXooXgNHSHLy?= =?us-ascii?Q?cBgycZUE0TzvcdraQbiC76hRP7zSZ/+ZJwlTC2WqLVziKDSqivcn7mJoRzdE?= =?us-ascii?Q?ajj0+98+SVmTYXAfT9epoJM5PEeIsOZuZPZy4K8AEeowYApa3mAzxquKoXUp?= =?us-ascii?Q?8UNs9BjgidzcdEAEN3ySbby65FHdyz77F6sPeTpsTdnzXkQHePbuMj9UMcNN?= =?us-ascii?Q?pqWkN5BdtuiK+cMgcyHOn03dGd0WA8ma2Tfuq+RqWzsIECPlq7qSAiOAJCak?= =?us-ascii?Q?4iu7ylIf36jI1popwZfTHfmMbqUEPpg658DEF9D6KTCAo4OOIfCtPib0IB5i?= =?us-ascii?Q?DV8qgNiuwTwDwoWkVVfuyLYjDNKvFoztSMSV8gtFI+RrBegXx3VcQbXFRFSm?= =?us-ascii?Q?OSc3EJUlhzmvtPJTsumL9809PwNGxttRI/E9YggzegWOFq5YrEy7at/Xp9kI?= =?us-ascii?Q?mTqlRhek0s+zRe7+MCTPh9jpAdFgqb94MlBBT8osjRcEg8bOozLc22myThxN?= =?us-ascii?Q?hFmQ1CLBY/cSi1djaLBsjvrmVxOWX1mSL9dbof0vfTpRi3umGO3R4KlRA66E?= =?us-ascii?Q?osD0di7NjTbAw/snCuj7hDzD+rAeo40C6XvDbIs6ShUIpgMLE2VSvgVQPilq?= =?us-ascii?Q?Mm/rQ6SOpXFcXNzgFlljCp+gfJo0C68+n7/irX87GvV08t22d1L8TYFXDLWo?= =?us-ascii?Q?JERKcST3U99T6mKGw1suxOoiHDbdeiNB5poDYYkn+KpP0PaVu5mdEiamMVtQ?= =?us-ascii?Q?4R/ktMir/VGwFTFL6d40ZrMqabMaaGM2AVtl6nqX3/xY2UgnjVEFeFHnU+TD?= =?us-ascii?Q?rPy0h4KUtHiHn+NEiesz28f2Hl2srBD17LV9JtwUm4J29oaj9fZDxDw8r0+F?= =?us-ascii?Q?J/rk5l9Sw75f7jB/nqdKcU+TDrEesUt7j7NZGcgdPXU047pqY9UmJ5KHIGKy?= =?us-ascii?Q?K2tgyUxHwZ62wuDNeqASqsVvtj80to6Y9Fxev0ObN8Nwc8FkcHmpotNuXVHU?= =?us-ascii?Q?R/i42s3kzMD44v3Li4SKyqUJYdhx7Sl4n0GXh9hcoVAnnw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kNF/2aGgD34X8dUD69v7MB/JXVi0oYTClqr4/eyAdEazDMrpFfMUtoI0+KzN?= =?us-ascii?Q?qGgoQhV2z4YMUYwBDlC1pqODRfLa8j4mIInKVyKRJCErKjdfeUcA9tMjIFL9?= =?us-ascii?Q?z9+Hq989bYGme1Gkee6Q4gf22eT07bXo84uAvwvFIWl00pOZUqrx/o7ae9Uw?= =?us-ascii?Q?O3s7UuJKO82BKX0bJhSKxy6L7tVd+kMZw4nYm4/HPICVbncSl/e77vtl/V/z?= =?us-ascii?Q?P7YTKIMUUFirM+B9QA6ee0Nbg7CMKpa1xNcqgV31eCQK4gV4WZdcdrQ8g9km?= =?us-ascii?Q?tw/Ag4iixI0jQSvCqHVU4LWpnSoRViQ9vMkFcTu4BlpMWe1pIeNz8GhZPLDK?= =?us-ascii?Q?AgdHE+B2stmX7RcIl5PNSsNyotdiYo4AZWjOqspbDFUeGvK1IBzu1iRpp0pT?= =?us-ascii?Q?lNrdPZQBwkkmIOF4hJkT+GqDbdzG+W3TuW77jYZf3ef1dSj81Yp3IumpePFL?= =?us-ascii?Q?3trezLXoAEEqwzf5KxR/tSKc3eJVt5iI/OYosiSSzQzBlig0ngZBQ+zH0lxP?= =?us-ascii?Q?JlMFKBKdUXkR1hByjILQZwJ1MVGVrNZEi+XBPt0NT/krtme1QsgdkTTE8or0?= =?us-ascii?Q?0I1InvawAf7UlRr8Cvr1g6S28UllBnjjYsms4hsikBvCt7GdjhaoMbmct6pX?= =?us-ascii?Q?LclS2U6YePq6Sk6mcjLFi+qafA9gYO0ge4j0NBQg3vUh+y8UME0x5oYwYmux?= =?us-ascii?Q?kM808Unb5Js1EhX4vjUQ2WHHNmppHjpk/TddE0cOXbzbwp5CblZMiOGfigZr?= =?us-ascii?Q?0pcRGwtqRzdChJW4863Lam1DAsjVpMP2Db9BuLWdvb9BZZVLFyoosSb5Mt4D?= =?us-ascii?Q?GosQBHRpXMWq3MOGByAhnB1R3/HNi17mZD7FQwjHDP/cUjjm8KW/RLRS5rGn?= =?us-ascii?Q?iK33fQEgcWY3+UNMkjODKMm55oOq2caxCPwAzJ7xx/lWiE6fevHsLAM/z3PE?= =?us-ascii?Q?AoaRd1xtQhNetWrkzLUDLGw6fJukqPEkb9TDf43PICqc/EDcPOdQwAieBRC+?= =?us-ascii?Q?rlc6ACve0jAFDiGS1632ZSqXB4aN1oR0AnVM+dsdu6BaRRFwCjKPzluk/kLf?= =?us-ascii?Q?qq6qMBF7EqPAvmok+g/Ly/aPCXnjlcXPgYd0rbBvT5jmCMxNRchFbcEXsYB7?= =?us-ascii?Q?MMC2K4RLan8MFiv2FuGz238yuc3G/821XuW1U0qayGUGtLu3w9QVigJMi8wV?= =?us-ascii?Q?xM5u3DNjLlxpmILI4I2PkETDhksQcz5Vl3LBvrVMAj8g1a7U0BcjMBA6CVVT?= =?us-ascii?Q?yRhWX1UNlq1W9+5btHWCJBZ501665EodEDb+ypUmz3tVLd+UamPjuFA4oCfd?= =?us-ascii?Q?4IYcPjam3bHP0Uo11mXpDcDxD1C7t28NUyajXDgzUhwS1VQVEMkkICsFPpI2?= =?us-ascii?Q?mgMkVr3K2kqGEa+5K9wGSkYOyVFo72UC/3BQm5JaEAPchpbWBwNWV8QmG/1f?= =?us-ascii?Q?sGb8eOcc9kAadFnJqaWN6DPtmBJfB+q86lS2v3sEPxRRG+hRhoQBUtqIACkN?= =?us-ascii?Q?42rPZ6dtXiXs/CkWQ5p+kFAAEpEDgPbu6Fedtz7094kRKl12tBLxnFQoIxRY?= =?us-ascii?Q?qc6KlO0/OiYlBMfWUzNj+aZ3tEZu+9TWed1LNije/i00nZ3HhcgAej27Zxdj?= =?us-ascii?Q?nA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 480c020b-07da-42d4-4c87-08dc9770bde6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2024 12:49:25.9192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W9BXBnvDoFOodNVr195PNYSJXSwCjwjwtXm68mLKxjCpUJmIRwrhz1DTZ91OQCt79iL8kwzdMtuicGYjK4OFwEt5JBsxb5PnfqYmr/mD7YU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5076 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 28, 2024 at 01:38:59PM +0100, Bruce Richardson wrote: > On Wed, Jun 26, 2024 at 05:31:55PM +0000, Vladimir Medvedkin wrote: > > Currently, ice_dev_init() calls ice_vsi_config_sw_lldp(), which uses > > switch filters to match packets ethertype to redirect LLDP packets > > to the default VSI. However, some NVMs have an issue creating such a rule. > > > > This patch changes the method from using LLDP ethertyple switch filter > > to utilizing a special AQ command (LLDP filter control). > > > > Signed-off-by: Vladimir Medvedkin > > --- > Acked-by: Bruce Richardson > Patch applied to dpdk-next-net-intel. Thanks, /Bruce