From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9157F45523; Fri, 28 Jun 2024 16:33:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 604F940F16; Fri, 28 Jun 2024 16:33:29 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id C65D540A71 for ; Fri, 28 Jun 2024 16:33:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719585208; x=1751121208; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6jNCJaHxO2ciJulV8R3mhT/SRU3wwR15JYlZ8cU6NQw=; b=UsRbv0j7AwUv0ZyZVPbsfp+SRVWE+St+or/T/ks2aNfWHEQUZQq01bTW QzXfPfYVlgqTsMoRnwodZNP8BUoeqAr8SnnE1XuoWx0ASxVp3r7HmHBwA Or5z85ShOCeAyGqqLFZkxTMkIuYi71sRRzwdeZZX5NpwMi0uqDcddM/EY CIbd6epwt5uyYedzGfuD7MymTIf3gqXGrih0f+p4wznD+WUTC6PY6ZtFS VNfcLmuwNPX8QPIDbkPn9iTZffJPnQ+ij888z9iKWBY1lrGivUJznSs8e zSzbaK1icNtPoHk7uF/0h+XZ0kQ5TTzExSbjk9VtWSH4KEZSBXHk7+1KO w==; X-CSE-ConnectionGUID: 5+Z98CGTTf+YlmSUeKNg2w== X-CSE-MsgGUID: /SZ3GF9MSpapCykaDt7KoA== X-IronPort-AV: E=McAfee;i="6700,10204,11117"; a="27455723" X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="27455723" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 07:33:27 -0700 X-CSE-ConnectionGUID: 0oMlB/BOQIuYR23XSZvNjA== X-CSE-MsgGUID: /cbNvkqWQl6jzu4H9VU/ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="49931304" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 07:33:27 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 07:33:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 07:33:26 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 07:33:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSTWn+fM/uHKOKspXVtJdN2YRPw8jxD5QfbCoHLG6TMTLQcaocfEnT11adbvgbepd76tMPzjKz7mHyN/fca6MJ++ZZGr1ZVVyvxNpdZzGHpl9yRhtAsf1dKx9EEzx5AID2wd6h9GgvoFisU+lOVjHpRuk1oI9OGd78TNAurLDVBRIcIJBnDCsSO9X0tr3aJSNvOScMKJa2loST8J4nCLRZuCr0CGCF33QnPt9aWIJPRhIoJHs4T8ZZmMiY/xbPu6vQDsNv3LtVxMsRY+s2R0o0RqNKTglTqAQcwZKo5XKTb+Md0XAKBsBhM5W51PaQZ9mjsy5praI5MnOw06aHkS+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bC9iv6vRCdF/aILtP9XPkkEEZd9S0V/FHD47Djb6i7A=; b=UWGuQ7Fh9dvBTlo9PrDgSRdRUZ2ljoAnWdSenRlAPNmyI/Jt8oQmbiMvuUxX+NI3qaIwN2chlxnokx90rso1Z8Opvj+hGF8E9+cg0EtNcrqfq8KqN7W9aTjoZJHbOkc9b49NpfgdU+3LubYkOE1wF+wOZ/58qa4U+gU2fc0Deui3887HTnIV5oQgFj5RnqVV8W+ZH0WX0ljrh39IGjfLDofV72rBVnZ/Sti1zqX38Zhn9G371pbuLRyt2ilNpt4G8/H1avXRsVQQJdnT70Q5n7Dt6wgeerIviJLOywIMo4ORwWz33Prwr/5nhucivkmuRCWp2HHhg2vltQYGi5Et6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CYYPR11MB8359.namprd11.prod.outlook.com (2603:10b6:930:ca::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.34; Fri, 28 Jun 2024 14:33:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Fri, 28 Jun 2024 14:33:23 +0000 Date: Fri, 28 Jun 2024 15:33:15 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , Subject: Re: [PATCH v5 13/21] common/idpf: update in PTP message validation Message-ID: References: <20240618105722.2326987-22-soumyadeep.hore@intel.com> <20240624091644.2404658-1-soumyadeep.hore@intel.com> <20240624091644.2404658-14-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240624091644.2404658-14-soumyadeep.hore@intel.com> X-ClientProxiedBy: MI2P293CA0002.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:45::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CYYPR11MB8359:EE_ X-MS-Office365-Filtering-Correlation-Id: c39466e4-d37c-43fa-d674-08dc977f43d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FZFYukFDUMGt/ylC/39VHD0vU42KEmPi8dBI4jsmooOe2VMbeGBvV+XQZOu5?= =?us-ascii?Q?octfvSYaD1Mq56LGVYQAzDXsthD9zfXhxxr74QlRGoE+ci4oRdXmnOFZyB62?= =?us-ascii?Q?OR/vrcL+B8W7QcNUsPyZdCCBYitlHX8gpAcD15EbofUOHDQWxBoHj6CzcsFU?= =?us-ascii?Q?QhbtTB22HMdzp9AbaMgkKgrZaX57qx683tpFO3RUmNt6dYfZ2csKQxzNAwRJ?= =?us-ascii?Q?/b1R1ocHv4jiBzQ3DeCsPXlOGAML6nIsE7QMWVx4vu1F3UmYLpJ6RwhzLyIL?= =?us-ascii?Q?Mt7hQFNz1ivBZtHsfejE7GKJb8gu6kzi4PWfP2M52LuH3rawoGYA0mOnZLhq?= =?us-ascii?Q?cx8Cpu4AH9mYBG7DfwLur3ZuGUnGFBQyNOeP9JQKxiC+rkEnNIq88r2IQ3Bk?= =?us-ascii?Q?FQS0vde/JNHXhNbCDBh4MhM1adSVIPYzd9e20IuaaWh53nnWlfx5WRq744hf?= =?us-ascii?Q?8dNjl5VzxcM2I1EbyMDZG0MQ6ub9zqhv2PLdgdc4NQrbrOQFqyzOclslaI+6?= =?us-ascii?Q?VRqb52RO0vfNxqXln21Ol4hSN3l+v1bIUcIPhOZpjapXRYYwBj4E+STfho2Q?= =?us-ascii?Q?nV9Bo9hvhPl0x5C8bwyFFbl07LprlkkruHcvShALR2I+y6PsLvGK44/7bLw3?= =?us-ascii?Q?dPOxYylDwbRidRkOrKw4UGMEPKpmvItvRfTUMdFEMK/xFIzCjLbdAhX2mU0t?= =?us-ascii?Q?ojimfyYyHxf9QN7Up++WK3MmRrSpqvPxPV+85r7i4LZfQhEgceDGcD7ugUf0?= =?us-ascii?Q?y2yuRrI4UKxB+qK6XZCeHOqIu0R1u+xAV9AgdAViq6i/5wgFB1W1M+KxxHLD?= =?us-ascii?Q?nec43zyuWAURpKOTOuRPeTZZJTCmYi7KKpYwLQwlPH83/79xG4hg7LMtKu0s?= =?us-ascii?Q?OtCmI47J/ffwcKaA8QRx7zVjgwUoVD61uRWdBdECp1EpTeY2ow0RpGDaNlP8?= =?us-ascii?Q?zmICpUts6PH2mfAVL5C8Yz0Y7ra1ZiMMzYefzphwrYpztExfJatjnIid2byS?= =?us-ascii?Q?hl1bGq4KPaYI6ag4O+lvr1ejZzxWov6ZVNqjaxDtpy9yqTlQ4fq3tXLV95Lb?= =?us-ascii?Q?z5vf5EYnHAezRZJ8NQlPXydKycTXBFQSdP8RjL+Z/DRdMC9KJZKeo7vAGmRA?= =?us-ascii?Q?lxaZi5MaTFyHayjV5UmsMOJDSmPm2h5nzpf03EUoxyBAVP/TaNw4R7lWjydk?= =?us-ascii?Q?EHyjdK5JWp0mCSUDnT/SV9dW5kDdZ+9ao/yU/+aHtn/F+4v9zTHiEPn+BU2g?= =?us-ascii?Q?Qg63UCglLeFSICMViBzn4Pgx0IzO+G0RSCIYybygCW2g+yLnUSf1IDL67U9E?= =?us-ascii?Q?gj/4Sdut+A5gI7tAYB4CcUUU7LqifnH88QI8dyWBfl8nhw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ciKxmob4ZIjDlbmdkefAcbi0kzyRHVwtB+/QQXcM5etTzbAXUCHne/z9/17G?= =?us-ascii?Q?7ZFXpsui3GAI+kFWoIoNN1TgoixRs2BSRwlJbOlxhcfK3QC60RpcDiBGsgJm?= =?us-ascii?Q?NUz8ZRb+dgu2Mb3TtTJOAfwxWcnMC+XRYgSfoOBzhH1QdJfGExTHsWuZ9XfC?= =?us-ascii?Q?PzKqwsXKI8bkOjw9T3q2QVmtNuschf6kIxiGbeA8o0KBJXLd1TcEWPG7odCy?= =?us-ascii?Q?VtOBUWNY7SPpoEciCs3+KzQUcs2WEM6I/hyIEuW4TMCcxu4iivFpWGryyGCx?= =?us-ascii?Q?IdHXWUXkvyLgdg4iwMALVqd/mOCd9V9pp85tq+pmOi1c9R9LG6TLZCSgJwfR?= =?us-ascii?Q?czxhV12ZZr/ZyWrQHjo2qJHpw0qMlZpjXXpXAwTz5Jwh80Xcah80RteDJq80?= =?us-ascii?Q?pyONKTm8sWQ0j9DKuotUhIRidV1vcur4iisP3vnPW3mA4Hsp5J7Nv4/R8w5f?= =?us-ascii?Q?nPg0i6oo25KPgVQZNkwnfliB6lp2hlDQ37bXKIbsBrDivi4IiOfh4bAKNDfl?= =?us-ascii?Q?y0U3jmbOMljsDM3WhF+S9VlDDoEfHAKSYgk0UWQ6Lje/uCBgvc3cXvZuqa4M?= =?us-ascii?Q?mSzVlc1MSn33lGGCnU0qw7ottXKICV3PEAULUbe3S2wBqX7nHcoJvy0pj2ta?= =?us-ascii?Q?erecg0+phFhG93fgs0MRfKR8Apyuk5RUWgp9TKQYWbdo/DY0lnfGVy2LrhuQ?= =?us-ascii?Q?ImcZdYY0khd8G+EU5lvbM6phM4ZVEcOZCutlx5C3T93eSgOkd+2ZL7+KLIVv?= =?us-ascii?Q?RNuYlpIriyQbr+iSOFJuK5g6qQjNYnmTzMSjG9mjbXGEi9l2EZvzt+f/agjL?= =?us-ascii?Q?pQRDnREPS6Tbd5oHOM1dGq5OX0KnuNILJjGIbwRHQgI+UQZIRtWKK7aURIHM?= =?us-ascii?Q?B6YSjFzdNDv2wEAHBnrmPr2cPc5GHSxYtgyrevy4WBcvKel6W8708GOKeKPZ?= =?us-ascii?Q?w7detFUW8hpOSx2/IBb4JJYPrmRz6qiLlzOsCeNnoKjDptPxZMQU62XXIESO?= =?us-ascii?Q?bDT7qSbLqQDTXab8QkajlC7I3HUBI+/KvafLxllpICP9LDaOk0Zaz0ryPOXj?= =?us-ascii?Q?TcozDuipjx/yacEmPwpLuIEukAq7MEzXOFLgLcpr56FPLuulOSwMpdJMepqp?= =?us-ascii?Q?bz2Oi3LydFi/7WU03fgeW3DNrWTUDP5sWy5cjpHsEu5VwgBJ3JZdVh6z3E8W?= =?us-ascii?Q?2Kzc/BmilE8HIxT/jeOGNZSY02RTCuSUonqIp3nbICA5RQDK153cJs2ma5EB?= =?us-ascii?Q?Ca94segyZXav/ydIdcyFKlts5uL39dczDi0t//cdvxIDxmy/XGAzLoTyAkky?= =?us-ascii?Q?QcsNh3OASrrGdVVcnlE9Vs3EgsN7Ocf90z5FeypRJwtbpg8uqlEQntQJIigw?= =?us-ascii?Q?S74ibbicyy9ZLUyHwXiMYQybMxuhwyZd6XH2K7YOzBtaAEOs2d0mNXnxaqOn?= =?us-ascii?Q?Dg/GmkfUA8jp7tphEtLJORtbgC5t24DfpIHMeQ1lQLH4eJMzc3tmTlrEgP9S?= =?us-ascii?Q?66n177fbsD6FkwTV16wT4IERojeQvyeJAKg1eOjJZogKe2ttTvO4lmItO8Jr?= =?us-ascii?Q?ae0rZoWkISFI42WG6UqRBQxb0wACR7pEX8cX5tk1ipzwnWccTvEK/hZdsXID?= =?us-ascii?Q?RA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c39466e4-d37c-43fa-d674-08dc977f43d2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2024 14:33:23.5514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tP/cA+I3Gz1agtZTLUWp2NL3ABN4A1akmoplMvgfO5aaGaijsEVxZ4HqhdUWjcTlDmEiyVfaxyAPgCM0wTrhnarG/InueAQeTWgAysr/xeo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8359 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 24, 2024 at 09:16:36AM +0000, Soumyadeep Hore wrote: > When the message for getting timestamp latches is sent by the driver, > number of latches is equal to 0. Current implementation of message > validation function incorrectly notifies this kind of message length as > invalid. > > Signed-off-by: Soumyadeep Hore > --- Fixes: 3f72f4472b57 ("common/idpf/base: initialize PTP support") Will add on apply.