From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE83E45523; Fri, 28 Jun 2024 16:46:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7987642D89; Fri, 28 Jun 2024 16:46:02 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 97AB940F16 for ; Fri, 28 Jun 2024 16:46:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719585961; x=1751121961; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=VxyXyzRV8TccfKu0XHqrVL92Fehd9M2SQqdFTwCSEt8=; b=PKSuj0PEGw/4mSXsC7QTvWiFNFXivqllJf8oVhdCvyCsQySknTxabqbP 5tcpOHkdOeTB6qjl9EREI75HAf6x4HASlO3NxAEmZS/45ZDoR7QmxnV5R Fj6IgCkL7TEiA2XBQ24Ls49NILcBb35XmZCyQl5XSVQdng4N9tz0Z4OAy tn23w4m1YcnyjQ3pX58wLag/GpYCmnNyKuO3gQqxwgq0m/I7w/BOoH905 /b4JTRKe0heCxQZWQJRllLNffXhnQymAKM6Dy3lSh/LQ41SzvqtCz6Yby 4Le1sUEuHrBFFA4uX+HOX6V2wKguH4/xHqtslOrRPlYnvRGkujUzEMH+B A==; X-CSE-ConnectionGUID: az2b4mazQGqF1+wEjEcvAw== X-CSE-MsgGUID: iWk1oolMRge8jBQ2du8Bxw== X-IronPort-AV: E=McAfee;i="6700,10204,11117"; a="42191202" X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="42191202" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 07:45:59 -0700 X-CSE-ConnectionGUID: 2kgUc1ozRG+bYIViWnWcVg== X-CSE-MsgGUID: L3ZTM6h9R8q2ljdCRKoFRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="44871164" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 07:45:59 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 07:45:58 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 07:45:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 07:45:58 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 07:45:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJ0sqzWOO9WzGIEpSvuXX15yONTmtQXF4aqyEvca4p0QWX2+c5TszPIqC5VBYBKPan98aE8Wc01jeOBnNQwj0I7cj9J887ov49g+vsIpG8q/dTpWQ0uvzfy+AIqfmyUwQHYG2jWEpRVfDhMJaTOMCifvmqN+zwZC324SwyKMWXpfSmYBxfxueFLjGPsE7toc4rY4gzbdNmmULvcU2vqvKoJ01iFLmhy+3TiHG1ht5ej4qUiROuUw3nJL+wCUhERFBGzFq3LvDrKCQIKLIZdAFoNLTbXj7Djyb5Ke8CjrDncm9CM5YIgfcGMIgSJQP8R7WNnfEOgZzjSdoJwSRReA+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/29/tPX7usgdr71gAuJHzGbJWlT8uwNydi0d2qsTo7Q=; b=YKSO8/Ez2rWnAY77tQ7J/VvyojSxySs0nl/hcr3cmem6/lfohiGDCdX6FrZr+FaJbQHhh1/VDy/lDRnS6/hHiquNw8LoPD4d9lYUq7a8MUi0zzmnypY1SYmKV1N8AYCTVhm5mvf779VNJlaQJkzSjnoMhtgLDCZRDIYq+SHD0a08a1/IWnkcFAWxkZ1F3ye8OH4QrzD1CLbSV3HUEMIAfYAoBZx1kv/WWCRgWes0Tz31cF2sTdBo6GOvms/d1r8+kuO+uaonz62VCp8yl1JJ6lHNQlDH1+YUAJGP+A0DkYA4QcJkEzFbG6rbt5Fe1gsVMIhFDR2jvMxgZcA9KDZLDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6282.namprd11.prod.outlook.com (2603:10b6:930:22::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.36; Fri, 28 Jun 2024 14:45:55 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Fri, 28 Jun 2024 14:45:54 +0000 Date: Fri, 28 Jun 2024 15:45:49 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , Subject: Re: [PATCH v5 15/21] common/idpf: add wmb before tail Message-ID: References: <20240618105722.2326987-22-soumyadeep.hore@intel.com> <20240624091644.2404658-1-soumyadeep.hore@intel.com> <20240624091644.2404658-16-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240624091644.2404658-16-soumyadeep.hore@intel.com> X-ClientProxiedBy: DUZPR01CA0167.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6282:EE_ X-MS-Office365-Filtering-Correlation-Id: 39634692-119a-4259-f1e0-08dc9781039a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GUy1iCjvizHlJ1hTpbN9NfBErYFR4D98yNQPijlHatiA5spHW/56HE0BwcVv?= =?us-ascii?Q?912X8MQAvyK6l6L1QAHkQ7S7mBpkM9i+yuL677lI+JlEBfBBfLS5ZoR44C1g?= =?us-ascii?Q?pxHX5vhSmlAO7tZe55+ZIxyu+ypd+Ck2SWDL/LIATOh9byM1BqopA+U1Khfv?= =?us-ascii?Q?k7naY+ECadz6ynoB8OoI5z1AaGce7ydHO1inTTid8I1ID5KiX5ECXkRpUKxp?= =?us-ascii?Q?plBiKmqj2iQK1TqUmHmZjTO3IAex0kbzSuLwUgQNHjeKlWz+Gx3O5Vet7kRo?= =?us-ascii?Q?rL+2dTu4qvFJjqcYXvmxyQOef8SZOvGSav1sYl1A7JSO1uHwe16AaJY2VbwK?= =?us-ascii?Q?G+R7CUEbP9HC13g3Je4BzbydtvsRxiMJs93FD2vkHiu8j58+aezRFdJPkAAp?= =?us-ascii?Q?TOx2lfHDvpRF6x6a+MefsAUssWVfY1vUnZpJCxXhtddPqjBC+p0npW515gWI?= =?us-ascii?Q?5z6NpH9yR25MrKquaxWB/joQpSQwvCRIBVpDfVzMA8c95ZGYDFe9RlK25rQS?= =?us-ascii?Q?LWfSiDoC0SmIIESrk1fwzp4zoWRuMilu2YY4uG3PGDsagahPubikUHOcmoqV?= =?us-ascii?Q?dpKmnvJjptzOtTU3EHrtG5+nvMB6uEiCfkLBi4Xofg2gDh3ZMZ43BDWLxITC?= =?us-ascii?Q?dlx1L11Gv7mJTpifYnlVDMyx7DKyG3C5W0h/qeKIsuPrmX8tvWtb0Rj7KCqf?= =?us-ascii?Q?ZTEu5LAOdrC7CN0h2sM9314PL2/OgsVAdj17za3O12KMCC9CeyvGdaHb2UBk?= =?us-ascii?Q?CMvBhytGtKtcip7xgo/u81quNcKFXSXKgiwNanwuOKstIMEv4qxAIWMRkX6N?= =?us-ascii?Q?wqkGmOoZ/fSYKbNaZwWGrxeVP32OetUPJY423IH3DSfeXWrDNiA7hs+Oc4Ti?= =?us-ascii?Q?0CYrQOCE1ekXxKpINHZhdM+mpTdUUX7Vv8JQd4liO+YzZMzK5yBtn7eMnGn1?= =?us-ascii?Q?iCQlQH2m7jFjywc5rbFS0WwuQBiMYzdZOsJe+eLfid8O6zItLDnNmjWi5x9a?= =?us-ascii?Q?5VuD8J5mG7THDKiAIMespXzFMWmTi2jXsX4y0oD0EfCQiVjSq/e+haFefvbv?= =?us-ascii?Q?mYneyLb2xNHKRZvgwz4ma4epaALOoAysnYSX1bE5YDoLYAhXjliOkQe8hVNR?= =?us-ascii?Q?4sluxg2rCm+BH0tNpfxDmdCjGYVtx5z5lI/26PsI7kxtdfwZVdfIqhw/uFRS?= =?us-ascii?Q?7YncyvR/E2jTzaCwuIzjByTpMdzT5Z0psJ1GXYo+MUE9hWDWcydYxF72SeyU?= =?us-ascii?Q?MCfpZ72tiIbEy0OkYWwxYfPeENjrh438Q2PVkh9bstnF3RvvRCLRqAyslY/J?= =?us-ascii?Q?6w7d0gHZ0uS4f+yqp/jetvte1gioFnIR+YmVDfiaV5n2Ew=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZUzyw3x1bZSy6YMe7CZxbMuoj268edXMoeZ2HNR++e2B2Fv1ktbYxG721xOX?= =?us-ascii?Q?1iVk9hLOzrLImZJu5FRb/8ugIsxp93+QgKxZEHna7JZJM0lzwYrmPXgPd08y?= =?us-ascii?Q?6vkgp3rRKcc/LqNu9Zk8g4Voy0pH2RNZwjPa42e/OAqT3xbqGrE1c0Vw3iL1?= =?us-ascii?Q?CnwfqhvFh9ae4hpC6996+QqygxoJ72MluHTetsJ0FbW8jI+3kfwrpzUb/cRX?= =?us-ascii?Q?0YT2JpdkZwofYj0W6wj8yVkj6ksrUV1BgSYs1FpI6HOtGxiYPRsP+fwyQ/53?= =?us-ascii?Q?4FP7w616QIe8MTiL6v2YHkzlu4rurobdqoPgrwJSBHVtmhLTxEFADkGs8Qmc?= =?us-ascii?Q?xowUrZOgCLoI4sJjCvsYtOPBTX9MxDUPiduAnCMSOSF3HIJAKdcxNIOAqNEz?= =?us-ascii?Q?B55Bfrp9McQRcqCUFS3wbM5NKWh/T0G14onWZsUwQFuizDY0dr1iSqRng31W?= =?us-ascii?Q?i4Fngic88S3r58V1uvONgxy5vuS47rb4wxcoAXOsyZYwH285x3HfqoSOJr3o?= =?us-ascii?Q?yljGKNMa9MewuOv0sux6mk+bQi5XCtt/eLnYvXPAIg/mTvGRyDqNi7L5pYk8?= =?us-ascii?Q?3UdpiaPY6zZK3+hTw+IzdHps5S23My+HvYizz82N9/Np+lzITNIyoHTftzpX?= =?us-ascii?Q?NbtthGZeEQnqpBHQKLpcjMSqvoLsAqJaQFpT9wUXv+Gs8y3KB8UZISEqaY5p?= =?us-ascii?Q?6pMwma59yHtUa94vtSd0Tt+RCMJqdAdMvRQ/hqC35VoHm1ZrnLWj5OId0Xft?= =?us-ascii?Q?uSnFiJpJRWFRyw9OS/PxlwOKDEUjsTCnCMV1UbJuN8VMc2mHCmUFKkuAnaAM?= =?us-ascii?Q?obKLQpn3T3gML1s8N05AQgB8ksOLs7GKOMd3cxtXPanMGYJf4szq2DRNkMbf?= =?us-ascii?Q?tC80UKw0OykWm7jQWusOsBrn0iS9FwUUe+AZMAtr8JhSAV3wpZkRnPYY2zNN?= =?us-ascii?Q?PI9ldRQqd7O8kguvFdkDLcJYWO8fSk5EPXaxeZVF0sNqtGak1OWHp1DuStjy?= =?us-ascii?Q?krSLm/3K+cLpoDFFJK734mVAK5VOwqg9+4gu8F4qjLC7Ms+pfviJkwJzwFoa?= =?us-ascii?Q?KIzAMY3FQcLSkq6YfNF9UaBlOQvx7foJOI4Bl0qigeAJMUUlEZsRnySYkgej?= =?us-ascii?Q?jRKOtO7lIb/opDw9G1wdGPRUmQRtwjUyrvH6X/u4rxic53U1MglJXISK+iVT?= =?us-ascii?Q?zikOFtY/4Qd72RoICM1dcRwpwU96o5Re2Cuw5mYiRQ8Xkp0yEPtgTehrqBAL?= =?us-ascii?Q?Cga7ddmdaEme/8KnBK5TPlSt7mSRxezYBtFD9bNIuAJ2Zlv0XAKbR+uPawVv?= =?us-ascii?Q?h22jcNog7jO9j0/7AgvIOSzFfrS+8djFIxvKC/mwtr2j7hnBFY1pRFpe6QRA?= =?us-ascii?Q?QnejC346BpfYYzBQ1TGO8yUSDGhAefkzLvpgUMLRp4nJhILJORIAMIdDSQXl?= =?us-ascii?Q?EdzaO7KVFb1XHkgz8mfyY2cR543aza8T+emgZ+gXXyuL5igAmE56J1CkCzvC?= =?us-ascii?Q?1RAklpEQPOEkVaCAY1I3EtlzAsxuA6pTqkYe7P5VpdHo3Z325bY2N9XS0HZY?= =?us-ascii?Q?OPFVqMqALsBxW/GJmR88Kbjr0N2LUnIpZzfWmNRR8Odp5MpqhEBAHEWTMoTG?= =?us-ascii?Q?ww=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 39634692-119a-4259-f1e0-08dc9781039a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2024 14:45:54.9061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tt9Pq9xNeT5PyYdyyO/70oXwd0dSKA/NCZQVP+UhA0f2o+UdgtvjO6XjZo9+xR0bCSCEB6OZeSEkncSwdM6WZJDuRQeLNR0+gPJ+yRxUL6M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6282 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 24, 2024 at 09:16:38AM +0000, Soumyadeep Hore wrote: > Introduced through customer's feedback in their attempt to address some > bugs this introduces a memory barrier before posting ctlq tail. This > makes sure memory writes have a chance to take place before HW starts > messing with the descriptors. > > Signed-off-by: Soumyadeep Hore > --- >From the description, it seems that this may be a bugfix patch. Can you confirm this and whether it should be backported or not. Also, provide a fixes tag for this. Thanks, /Bruce > drivers/common/idpf/base/idpf_controlq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c > index 65e5599614..4f47759a4f 100644 > --- a/drivers/common/idpf/base/idpf_controlq.c > +++ b/drivers/common/idpf/base/idpf_controlq.c > @@ -604,6 +604,8 @@ int idpf_ctlq_post_rx_buffs(struct idpf_hw *hw, struct idpf_ctlq_info *cq, > /* Wrap to end of end ring since current ntp is 0 */ > cq->next_to_post = cq->ring_size - 1; > > + idpf_wmb(); > + > wr32(hw, cq->reg.tail, cq->next_to_post); > } > > -- > 2.43.0 >