From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93A9445523; Fri, 28 Jun 2024 16:50:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CDF9427D8; Fri, 28 Jun 2024 16:50:53 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 8E76F40A71 for ; Fri, 28 Jun 2024 16:50:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719586252; x=1751122252; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=RFvgExGPmHMTCQeN/+YnyRUsyYhs69o22J6zXrqmIgs=; b=TxatyfiVZrqeWCvP/GjyRcxX6f4r3EFfxfgBW3RLfWGiZ5h7TsEP4eFC VTC53NL+6pbH8sIIHFnWga1VSC6RwKNAr2l7H0TWb5MFN6gHdEfp25GZT yslds5albm/4nT+M/YKZwmxu4n99SOVFy3YuCjf+1PwObQpBvHh4qHS2a 7ZhgbQsmVJPVEWEWdtDgExQHDtLO2IGlNZIu2S4L9SCWTuo1rMLADBbio 9lYAi3DMtgc2w5NpGF0e2AutmJivc1p2VP+S7Ow7mosSLFQDYIQ6dwTHS L+3R8mqyV6MdxvSYcsehK0sE/MxGGTMNYH3uLmMHedCpt+3KR1yhYYrQi g==; X-CSE-ConnectionGUID: G0q4Ms6FSUaPUZ6/JiELmQ== X-CSE-MsgGUID: OmvGfgflT9CjzsC1S02vkQ== X-IronPort-AV: E=McAfee;i="6700,10204,11117"; a="16592342" X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="16592342" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 07:50:50 -0700 X-CSE-ConnectionGUID: snmUCEi2SRSSc1A7pgYlBQ== X-CSE-MsgGUID: YL8+cGOOQ3ybztA09IArvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="49102393" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 07:50:50 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 07:50:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 07:50:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 07:50:49 -0700 Received: from outbound.mail.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 07:50:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFjrS1N5C7onBJmffP/JY3nUMXbxHQmuHBsOOw+5w6/O43eHo9kaw5yer+JZpR/KQu7IDLEEnqpt8PfgG4KRztenYFlHRiqyTgAJxwxFGthaUJEOM/EZjQPTTFaw+3GjFAMy3SVQCe87zYgnFKZG1wpQEZG7YuYJPA10dajzukBPpm/iEhnYgRS9c5Ev+Nkm15rVWuXTbwezyo3NDJ6zXxZ4Ttr8uRvRWo/KnrwD8FLrT+jby0TfVH2ix8k+ICzJ6KlT8PRoXgr3AVcMn//XSAqVtbXn0RBca0PqbcjMa5UoVxa5eQ2bBYhTAuy+gz1rmNQKJjupPTa7DMWwszC6Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P64F7Te+/kq/hlRqbo7ZKBdbHO19fQnEGtyAWR/rEX0=; b=CRVs8kY2xgTU6OAmAvFYZNls+jhabcSL2gE3Dh0pP7ATiIdvSENs0yHfHGAIxJBacylQ2V19DqRi+/HfN4g++NYFzkdfXk7PkibvgtQF/UEdQf0KBuMBgAt+ue0xqAC5RORXc8BctEaHvd46ihub9qHIw3mO/NTKglCqsax+U6pRj3GLfKOVZsCjWBijTgUy9jR2Skz1yzRoCcYx1KxZ5glv8smyg59694WIjbZSGZfcVTPaMMpNHR00AN+EtzZsIqVqo4tplZqsTNJiRXoLG04uc2zxc+ivXHl99s9yh31701PlU0ubVWajQJd39M3iI7BDHjG+KcRfeEjfetSqzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6427.namprd11.prod.outlook.com (2603:10b6:510:1f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.34; Fri, 28 Jun 2024 14:50:46 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Fri, 28 Jun 2024 14:50:46 +0000 Date: Fri, 28 Jun 2024 15:50:27 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , Subject: Re: [PATCH v5 16/21] drivers: add flex array support and fix issues Message-ID: References: <20240618105722.2326987-22-soumyadeep.hore@intel.com> <20240624091644.2404658-1-soumyadeep.hore@intel.com> <20240624091644.2404658-17-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240624091644.2404658-17-soumyadeep.hore@intel.com> X-ClientProxiedBy: MI2P293CA0009.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:45::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6427:EE_ X-MS-Office365-Filtering-Correlation-Id: f0744df7-6d30-439c-5499-08dc9781b165 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tfxxbbyiRWWavaidisA6454UUCTtgFafE+SN2GrOJKSG7fUluy9BHz89nJYj?= =?us-ascii?Q?8yPGt2sSH4hwEleRd8Ak5dTEbwoRkqh3xBD/JGihOnVGMaKewcXR0ckrh4mc?= =?us-ascii?Q?dYua1y+wXwtDQ/5tcBd4MijtyW5JEPbYJFOyvTCkCFLl8UamAkzGRyWE27bN?= =?us-ascii?Q?pzICDV9L5WewoloV2+Z4u2aQh+P1uebd7uuTzM9g2VeZeBrhV6JaOjz4ZLyH?= =?us-ascii?Q?l3mfX9XonK/SxFO6A4VFixrKIsgMtmUElhSdwbtRy3vodEVl69730Cp/Dw6g?= =?us-ascii?Q?HsOw4WBsY8knI8TNPPOiQlbCZsODuBjqM9zHgil0LfzJ2hXsO+LEx2MeOx3O?= =?us-ascii?Q?mMffZ8xDCpUGkkHwotXl245i/8V3zSbqK7FG8C0WwkWJPSYthNcDONdgKUl7?= =?us-ascii?Q?HA8D/cWTN1Q7iV12W941lpyhDddJ4dWrahT5FwahaokNyeIIJxgTwF1wqQff?= =?us-ascii?Q?Mv8l8RMT8hgr9y20Jj1hiECTN0PdIQ904V5ZmLmagA1Z8hn2x4tl8g5BkhTo?= =?us-ascii?Q?t1kGGfZ9IX5AqX5SjRmgPWklIBxvI3gcLQ/L47fVlTLCfyqj15wCRb9P5Cl6?= =?us-ascii?Q?GSHHrpHNqw6Sqsl6LwNxAzwX4MTZiARbZfeV3Qo4CcVGBU3YZkdsWSDtwDcy?= =?us-ascii?Q?mJpIPfgx5QR7+ww7j709mKvy7tK1CwVTsH6RkqK389QbnoxxXp6+WP8yTbkq?= =?us-ascii?Q?NkJZcckAQj4YnLh8Zi4JeZFz1X1DSrmfc0W+FoQHQ0X7/0VC2xr8cdxO5it2?= =?us-ascii?Q?C1p15DobXRG8E6loTHiw72+1xz7GFY4Mf30NydH/VwaznX/EnMWGtkDxjBqr?= =?us-ascii?Q?UCk0s5sQWA0jDLKph0Hwr38e9PnSYPdi+iZfSuCcMMjUvb03+9pjoZpIfIgB?= =?us-ascii?Q?wa186ceBZc9AIy90guBn9s7wXwIocJXhZNTpdPrLcYcCkllKdFu1bj2K01oK?= =?us-ascii?Q?VPMDG7bMARIpa0tFejtK0jdDffmORltnQiwszs1tKxE01oH3JhUrdmsX2JfB?= =?us-ascii?Q?bhcBMvqhHEl/rBo7XIp+xm3wXNlNvQzByWzE5d4XdM7tR7grUV2XPrdnTNI7?= =?us-ascii?Q?RIXuiUX3U2eoSIgjkEVIV4jGr9kBeJJrYDyVw3teVLIKCibpBpKSh6jrBR6g?= =?us-ascii?Q?jK9vPIuAXSJTu1ClFnGRpICzGchzF+Q2pNwwoMxbsUN3+UfMl7E+YhiG3d8K?= =?us-ascii?Q?TILoEEMmAJApCL75QYTH8V0eKuhtFjJABRjmcXT838FQiocXa/+1cFr3fjdf?= =?us-ascii?Q?8cndbijou5GvDZlXf8qEIs1QVyBzdvlD0L4bQil+FjZjyBxm/kZFPHl72Pvq?= =?us-ascii?Q?HY7iX5eAnrzl9qzG6xSUMGL3jp1j42v5o4CLikJsc6TQrg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w0UmRnz2eMYckSBDdiIaRmu5n6XKKyP8WXLA2NO5Jr4qCKl8W3/V0vFeA/3q?= =?us-ascii?Q?ZYuOMlKI96uysB4EGPcSSmFXHnazfl0FcNiPLZYppkXD5GrEiHVYUOZlWT6n?= =?us-ascii?Q?/Xvmu4uVCqBtk1iZ7QDSqlFOa/5jByjXreYdMWxsaZPa1iI1DJAY3/i0uv4l?= =?us-ascii?Q?Odg0XPBJFcxnmQQH/+G+xN7m6q0g0BWAs4kshItkB+bnA3POYN0LES19MzXg?= =?us-ascii?Q?CtYRr4d73xw1EREGmXuOBaynZesjO8fGsjfv4uUuBS0SXyjrS3z6vR5miCFb?= =?us-ascii?Q?l9Kmj1g1JgVINpjyb0lcqxRNzH2maY+k7W5W2JnOO14We1tDsrNtiCs0Qbtm?= =?us-ascii?Q?N+xKK4Nk2ADzik9Eh772mVNySTLmuutRtF/cJIXohSsdtgkEJGns0IWDv8o5?= =?us-ascii?Q?gu8JPB+zp27VpBavHc7Zx5kr5/qZ4tQj+SEFJMeUIvNg8aoFqv2XNc3vGr6X?= =?us-ascii?Q?MQ75ZROqNDlSA0D+a9ViU9w7G32+Wzw+Q+tY/6bVnOExTJFb40KPGD6AJ1sw?= =?us-ascii?Q?43VLngA/xOqWdd4pIxDwumOFj/PWEjGLjuCcUIJRc2KsvHad5yDiDouidDbK?= =?us-ascii?Q?DyheoweLYGJmvjAfFgUHaaS7Qi5RpbSvkkF2YlfXSeGS0DG2hm7EPYQF1nMs?= =?us-ascii?Q?eOOZizFEGf96nGtBmecJHfvZvIgMelJjs2ArXRM052j7eDYRjk+vtUm6SXkh?= =?us-ascii?Q?Ys/etf655lM3Oa6WkU8otVGxskE2UJUaMIodDISZZ8M9BvYn3wlkV4WiLzo7?= =?us-ascii?Q?cUL07OkjK4oGw41qXFvoZmDJSTfXTK0G0Vm45yr/9ie6hmXTBOsY4bP7RbXn?= =?us-ascii?Q?DpXEWGdi056Ew5q7opdT/aRE8BSPa+/7QzJTuPxoJ/UigWLoD+OD5mRfZ4K4?= =?us-ascii?Q?jhxwEpgKBIYFgLBn8fGrodGtEElnz+zGgv9d62TyGWU8VMtl+lmHsiUw7+o6?= =?us-ascii?Q?MgQ2L0p50bikOc/X6VVbzL/W9Fpp4YAd6Jbo18GDfL1LV6LhvD1YNkHhzm4a?= =?us-ascii?Q?QDhXN/G9lvqR+n5zuUwTMu0+OHBVsCb7NHxJR7HacuJJPEaZMwyG3VX1gGCo?= =?us-ascii?Q?bSWY1gwdjgDwbxlh7iGkEiLKTxGvA6759WfQiMB8fzGteicEmm52DhAbyA17?= =?us-ascii?Q?4jYFcdN+mboqF+j/DT+w8NcB7g907BW+dVWmErJLTehpvnQnXi14jDQsE7sX?= =?us-ascii?Q?1C8wsmWsaj9ax0t9U0Z++Ine+xSx9JTjzdPwcvl2mbn61bhW8dMJvCGsffOn?= =?us-ascii?Q?8JEh2BQnqpg+Vt+RdM+qvQteskRlBsT1Oz9j3Vq4hUOoUAS5TD+q+7xCk/bP?= =?us-ascii?Q?zlHwNW9IgceKs1ejHpXH3gbUOFlaV9hPT70Lp0NeGLv+6RS11lpgY0ydIyZ4?= =?us-ascii?Q?JZ6QPzcALpbxD5SZZ85j9Ah2vgoP6DPQ8au/n53H2S5/hZaF6HHoKZq8JI6Z?= =?us-ascii?Q?XF/MCeBUjBi/sIpOC1t8JdhLrhF0ogs7XuQyxyLRsy5w2Vwb881fQw9wrw/l?= =?us-ascii?Q?c5Gh4MlvYMoJZ/5XSy7g1upx0JvJHYUEOm7uPqH3m9Xpxgz/L4dk73jXZC+F?= =?us-ascii?Q?agSD8aIvhJoW2lmiQP4NIdXk3IdiFLMQjyXn2irKtQeeYgqSfggBvYbMPGYU?= =?us-ascii?Q?xw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f0744df7-6d30-439c-5499-08dc9781b165 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2024 14:50:46.5253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wGOzGjJZlk6SZysmehC8jgxoAPiQu7W8a7HYgATEYqi+d81tbW2RfJ4rRGKrKTDTPXw3c5KCTRgvEYRj5Q1vk7zquoGQ1JbQgcLlaVYw6H0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6427 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 24, 2024 at 09:16:39AM +0000, Soumyadeep Hore wrote: > With the internal Linux upstream feedback that is received on > IDPF driver and also some references available online, it > is discouraged to use 1-sized array fields in the structures, > especially in the new Linux drivers that are going to be > upstreamed. Instead, it is recommended to use flex array fields > for the dynamic sized structures. > > Some fixes based on code change is introduced to compile dpdk. > > Signed-off-by: Soumyadeep Hore > --- > drivers/common/idpf/base/virtchnl2.h | 466 ++++----------------- > drivers/common/idpf/idpf_common_virtchnl.c | 2 +- > drivers/net/cpfl/cpfl_ethdev.c | 28 +- > 3 files changed, 86 insertions(+), 410 deletions(-) > > diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h > index 9dd5191c0e..317bd06c0f 100644 > --- a/drivers/common/idpf/base/virtchnl2.h > +++ b/drivers/common/idpf/base/virtchnl2.h > @@ -63,6 +63,10 @@ enum virtchnl2_status { > #define VIRTCHNL2_CHECK_STRUCT_LEN(n, X) \ > static_assert((n) == sizeof(struct X), \ > "Structure length does not match with the expected value") > +#define VIRTCHNL2_CHECK_STRUCT_VAR_LEN(n, X, T) \ > + VIRTCHNL2_CHECK_STRUCT_LEN(n, X) > + > +#define STRUCT_VAR_LEN 1 > > /** > * New major set of opcodes introduced and so leaving room for > @@ -696,10 +700,9 @@ VIRTCHNL2_CHECK_STRUCT_LEN(32, virtchnl2_queue_reg_chunk); > struct virtchnl2_queue_reg_chunks { > __le16 num_chunks; > u8 pad[6]; > - struct virtchnl2_queue_reg_chunk chunks[1]; > + struct virtchnl2_queue_reg_chunk chunks[STRUCT_VAR_LEN]; > }; This patch doesn't actually seem to be using flexible array members. Instead I see a macro with value "1" being used in place of a hard-coded "1". Can you please check that commit message matches what's actually happening, and that changes in the patch are correct. Thanks, /Bruce