From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8F4D45523; Fri, 28 Jun 2024 16:54:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B84A0427B4; Fri, 28 Jun 2024 16:54:06 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 2FA2A40A71 for ; Fri, 28 Jun 2024 16:54:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719586445; x=1751122445; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=rH+mnCXTx5s6gypfHCMtL2i3/nl8utl4iZ3cfnhxDvM=; b=cFAeQoqQatAvuRWOAypJO6jJZ4MZ0t2A+Bf5QdvC3NeVkzgZ6X6jL/6h 3Mc4xhT18OxZLWH9cDrQuJ4Nd1aNColMi7Om3tVvgfNvOvBT+mTot5TVj 4Kn9gKwa6dj3edBuKYpcaZZq3nRVhJj2jB+pTj7dcxpIx6lPy5C45PVpk Km33BltmYPheCPFNzYI1DhWdVHzyzWdur+5oa2yEgkcKi/oNuEig5YcMK w5ueAV6samEFSv6OJ7Cne08UQ7mTnt0UApI3PZ+1b72uCjYzHzZ8BZ75j zxbm/YO+dqdtnWUhd7rl93W8FwyKBEnt9fH0qMWRbXk/H7QvdWPkYg/GI Q==; X-CSE-ConnectionGUID: u6XtC5OZSqu9pMT4ZdVMTw== X-CSE-MsgGUID: Eo3Hyy6ORqqvLGTD7orCgQ== X-IronPort-AV: E=McAfee;i="6700,10204,11117"; a="27458399" X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="27458399" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 07:54:03 -0700 X-CSE-ConnectionGUID: GuNZZg0TQPWm4uVLVRkYwg== X-CSE-MsgGUID: iM/oUIFQQHyfr4KohrsWtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,169,1716274800"; d="scan'208";a="44843816" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 07:53:46 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 07:53:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 07:53:45 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 07:53:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLMalWwzVzkEvTY+dX7by3Fqn6fBr7cjGebxYU7Y3QLiEvhjEd78jGeXAN6hWnEkyKcBt46It+8UUZSDWHoSholQ7e67mDazPWPtcegFSo/eUtdwbHONRwiremAzZ4lprvRZmbH1jV1IDnWY2EMnPRytSVBFwZkbj0BGwc+SqpJv+2PLXatTWV624FS1xqEx19AIosyqEOhewMOkNO00OdIuUfTDPEZkdi/ZsFTUoXc49WfZjaoJ0VN9y+ggxhPBlV04sJKGzenHk6NHiWUcQH+DO3mXt8dtDh6tAMgPaECrnJjEHxtccXt8V++zVVU7JdnV72OJA8257vlwR0IkWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5gSFdxsysuqQhlZ02UiQhqhaqiWHta2j16tF28p/+2M=; b=b634ZYQH0tNU7owW4g6+ND3EftZ2rorhSa/3AEWH3+zLT70aMhuTuGMUw+H17R2KhhAyYKcKi7PD3gLyMaxiQtDwe9gIyq+kSWwCZYrOroi6CQA6l1zahC9+1izEOpKWxQkXofYd7a1GVrWWoEVc04gzchGxcOxRmBzo2oX4zg9beEyeoT7PzKQLwqQVILQbnTQui7I9FUrQk+9hJl+qzCw3RRqpK7oSqEck/D7e9zhYEKxg7uDHem7SCusLerJgl86CvzCYY3CrTRxKk+tJFgMBqduxiwzAO8W01YaYuGztWPlK/1JyJk4mX1OxCWFJaCrAwqbGlp4fI+Sh5AyX2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ1PR11MB6081.namprd11.prod.outlook.com (2603:10b6:a03:48c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Fri, 28 Jun 2024 14:53:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Fri, 28 Jun 2024 14:53:42 +0000 Date: Fri, 28 Jun 2024 15:53:36 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , Subject: Re: [PATCH v5 20/21] drivers: adding type to idpf vc queue switch Message-ID: References: <20240618105722.2326987-22-soumyadeep.hore@intel.com> <20240624091644.2404658-1-soumyadeep.hore@intel.com> <20240624091644.2404658-21-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240624091644.2404658-21-soumyadeep.hore@intel.com> X-ClientProxiedBy: MI2P293CA0014.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:45::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ1PR11MB6081:EE_ X-MS-Office365-Filtering-Correlation-Id: e1aca412-9bbd-44ba-b8bf-08dc97821a21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?t59H4ui/ZwsdyLd7pnyuZDqj7NzQI17w3FkPjp5X7kQxiecP/m5WcRTAjIgR?= =?us-ascii?Q?5ckl1hLe0Hq8BHKTuWzvSxeGVvV/r0GUgIoEavjd2AxGTD2Fp4aA6Sy/97o8?= =?us-ascii?Q?vwN/3o6hL89qvAQecSpKeyMTw68BLXtN+hD6JTYglmM9Dzc3MfgraO5TJLtq?= =?us-ascii?Q?d3Abn6vfqVo4U6GWtsdbcFL6Am3nrcsd8EBSI7IyqYq5gDLXL2FPl85THG5T?= =?us-ascii?Q?3svrGv8C12aFEh+tRcUTsRy8D5LwjCq9mJ3hupPsDAVAZJax6rk1mbt1PlZi?= =?us-ascii?Q?yN1YjfrKX7Q5V1aDq8rxmXjjQr0ZnOJHecT1HEzLBhZnIk+K0roBHuWbTgb2?= =?us-ascii?Q?ylequEi8vLtG+oXQyPsZlCqkhdhaeBJOBbD15X3+zhaDapM4Hf3UGwHJPj05?= =?us-ascii?Q?JHBOLVco+xHg1NShNHxm5hejJYDf4xMs8lJ34tc0mB2Nq1BxNOYaMw2X3Z5b?= =?us-ascii?Q?hz1gQnVFbqys4iXN3Tcyh5jMvRdPNv0HmrAK1HVtA/OU81X8vuMPMnG2eTN/?= =?us-ascii?Q?bjz4CBKn5boUrTcjbyQUJXDS1Fcica8XZVciCTSnP/eof8fRNQnmFcACXiiq?= =?us-ascii?Q?EEtQ3Mi3eCCS3bR7ehgWmofNq03WnuNqL1LSiDthjwl7GD1ycRupSqOnwd7m?= =?us-ascii?Q?m2HRfHvG9vDaopYTm6okCOLXS0KKhPZEx2VUYti2iGXQzcL60SC4E6ACG2Ay?= =?us-ascii?Q?QgoPeTq1DXb+pWh9STAXwPuWYPKiVKxKbkQa73ec1yRMPv29o1tb+0BagA2C?= =?us-ascii?Q?haSs5mGfgalTegDG0Rb4jERzFasMvU01OEMfVRMpWzgXY54cUhNiJUNXgkdo?= =?us-ascii?Q?fS24ODrCQ1PuJZ+pjsNndycqx8LLFAW4lqI2Wk2k8WsV6TuVguqhNYybAs35?= =?us-ascii?Q?OXpVaySRfV00d9k9Xnuwq/uNV+8kFULwkJoU8vxv3XLsuNLCDxMhVV1Fl3g/?= =?us-ascii?Q?XIGfchN1LGAR1R+TedejkNoWj9sfod1OCpC+t9z8tEffltkKbtz3clIxXqI7?= =?us-ascii?Q?9o50P+u1iVx3+DmQnsMZBvNUz39oIlme5hxzBFz00+e8vbMU75DmdSjDbrVR?= =?us-ascii?Q?ulwL2BNZ72UxWGRi2dX6cURRDoh9CuuJlgpYv7X+GcW8eBXtpMT65QmutN4w?= =?us-ascii?Q?WEa3aauOk62fD5E0qgBz3XwufFY+zVBFUVN0c3eP0VqQsXNsK9iA0tc6uRmi?= =?us-ascii?Q?djtkSNKPg47XUmNxcAR8E4fDkYaRB7eZNDFAiS/lA12alaAx2eD5/itlyPSl?= =?us-ascii?Q?MYycmcMnuhQqQH+ngljd7DUQKlm1wuu1HV2c7wepEHz36vivhdk/OWkIzS1a?= =?us-ascii?Q?tZ59qr3Jt2Yr/mbAzHo9I0T7mvOdsiXUbsE7nF5vmXwRqw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZEE55nqzxdIrK7w0c9EjLMy1FJSoSptGfc6k1lSfhXClyhEp+of1D/ZbNdlz?= =?us-ascii?Q?DW+pOqB2uneDnIw6i+jaKNOdJ/HR5SinpOAugH0+NRMocKndPHhLVwG8G8VY?= =?us-ascii?Q?Hj5GTc+PD+3hd3oAz3kCi6NqfbhzzIRJUfjv/z6/QrlNBS0qv0FLUGD+hdjw?= =?us-ascii?Q?10ZdwUDwTocXf0+unzTjAL57jA1FRUKxUMjebssXgmcOPcuv0u8wLkBR/Zeo?= =?us-ascii?Q?pHSPalhKJuRw0jNUKKlm3AATTRD9MKbqqlsjtyriXJ4MI4ivxt7GHtnyAb9X?= =?us-ascii?Q?OQ9qEaM3r/Iyld9h4hndfVx7/trLC6twB18L3zqR/hw4fubc4Cg3GVU/WcW8?= =?us-ascii?Q?dumSfuF6jt5lGhcTT/CS8kNPpQLnWTs3x/IUhgBVQbkfWDCG+0y03hQGexir?= =?us-ascii?Q?W5xgpLtJM9XRHcTzFYR2otWqNmYKAhJlv/zrRPRuOEDlTO6orraY/+T/rSax?= =?us-ascii?Q?Q7jN7yW/KPNpgJ13brfdrT3Yo/+uvbw+G7Qm3DJeTayHsjVN7+9R9piOzmYB?= =?us-ascii?Q?nGhE5HLZmYEWsyZHFiuC1cpOQI5V6EsK4iYnb510otmvXRUIlwIH4WdMvbqM?= =?us-ascii?Q?2LFCwI943Pm5M6iadCcnXezKb8MX9LLJnrYdgDwiNeWZB5zQ0p1oaTvDq+SU?= =?us-ascii?Q?1kh7n7bsfXFxCK+iTxmc8lS52oG6r+irPirj+IEjJ42hu0IfAKiRxWbBvvws?= =?us-ascii?Q?gisAvHOv+m/OwytdJLck8BDJs54000sa7KPA3a/CaW430ND5Fq96avBjHB1x?= =?us-ascii?Q?qrnUYj/Mb+rbeN2zDhtLuggaEWfnVZk86ghtOFDeMuxdgagw+wiG+c2tANyX?= =?us-ascii?Q?A0TGzXszXYYOzEhMqNwDA6AjOKIkAUJOma43ZTMmkZYWBAB0thnnuIhm2l3c?= =?us-ascii?Q?mwakG0E++pQdL6Ci7B+4KqDYziwxPaoptE2k+mkh4nJiMJZAHjEvdpna+2fN?= =?us-ascii?Q?QrnImQb5H+psUkQizQ3q3PivCNqgAcKQHoopifYH5WajUSShZIMvJ8yNapi+?= =?us-ascii?Q?8/A62xme3RY8RearPKa1OWmE8zYjtNNoGdoDLAh+4puHh1vEjkBHYI+lmKge?= =?us-ascii?Q?tBn2iH37XTPxx6Ao8+VGCLwOyHueB3fzgu4/LZsVSn0Zt6Y2+JAhpQ36EqYH?= =?us-ascii?Q?+8cs3wjJEKXckuz48pm9OS/a0yG97gu/BUALf7hdh6SJsapxtYu4pNfQOS39?= =?us-ascii?Q?JlP5Yo8jAw7loXtKGSv4sWfQCVDDMxJx9JyF8KATZVaHJWvF+P7cVzLS4xmN?= =?us-ascii?Q?LaG+ag3RPuxHu4TSq+2t8WDP/2Lan2vHfoplnq2i9nXUqfmo9371aArn/sja?= =?us-ascii?Q?QcQ+yWq7u8/+YMr1XFfakFP/IRWXiVQto/w4JGrsvAFrWsc21ELsthm7GgVw?= =?us-ascii?Q?6vlyBIZCsh/9ev3fMQ19ZDWGzKivbXYMmd6S3brkCRr0e6RHgTzlLnP4kZD4?= =?us-ascii?Q?rDYsmP2JzwrJwCxAC0JnmlzO2nbXu+xUSrfWHxsafT7i41uyq+2Jjlh/YTph?= =?us-ascii?Q?AZDyrsEZ1TLG6kWGOCHMwcfeQWPvn33AMAL1kh8ruOuO9e7sR3pd7aS0tMXR?= =?us-ascii?Q?XJczEwm5dSWHixA+tWy0EBluIrlswNJjQrEUOuApw8GJBVXVP5vG8/dKdBqG?= =?us-ascii?Q?hA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e1aca412-9bbd-44ba-b8bf-08dc97821a21 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2024 14:53:42.5449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RPXep/aOw6Rraja+1vTOe8lJlm/56Vf+1UhI0jyDSqkGcXfrdkhqbvRtSLuU6L8xjvpoIiRyJVP7LT54Jks0lTWHz6EOCvjT/5W6WVSA/Nc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6081 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, When putting commit titles, checkpatch will complain if you use function names, or macro/variable names. It does this by checking for underscores. When this gets flagged, please rewrite the commit title to be more generic, don't just remove the underscores from the function names! I've fixed this on the patches already applied to next-net-intel. Thanks, /Bruce On Mon, Jun 24, 2024 at 09:16:43AM +0000, Soumyadeep Hore wrote: > Adding an argument named type to define queue type > in idpf_vc_queue_switch(). This solves the issue of > improper queue type in virtchnl2 message. > > Signed-off-by: Soumyadeep Hore > --- > drivers/common/idpf/idpf_common_virtchnl.c | 8 ++------ > drivers/common/idpf/idpf_common_virtchnl.h | 2 +- > drivers/net/cpfl/cpfl_ethdev.c | 12 ++++++++---- > drivers/net/cpfl/cpfl_rxtx.c | 12 ++++++++---- > drivers/net/idpf/idpf_rxtx.c | 12 ++++++++---- > 5 files changed, 27 insertions(+), 19 deletions(-) > > diff --git a/drivers/common/idpf/idpf_common_virtchnl.c b/drivers/common/idpf/idpf_common_virtchnl.c > index f00202f43c..de511da788 100644 > --- a/drivers/common/idpf/idpf_common_virtchnl.c > +++ b/drivers/common/idpf/idpf_common_virtchnl.c > @@ -769,15 +769,11 @@ idpf_vc_ena_dis_one_queue(struct idpf_vport *vport, uint16_t qid, > > int > idpf_vc_queue_switch(struct idpf_vport *vport, uint16_t qid, > - bool rx, bool on) > + bool rx, bool on, uint32_t type) > { > - uint32_t type; > int err, queue_id; > > - /* switch txq/rxq */ > - type = rx ? VIRTCHNL2_QUEUE_TYPE_RX : VIRTCHNL2_QUEUE_TYPE_TX; > - > - if (type == VIRTCHNL2_QUEUE_TYPE_RX) > + if (rx) > queue_id = vport->chunks_info.rx_start_qid + qid; > else > queue_id = vport->chunks_info.tx_start_qid + qid; > diff --git a/drivers/common/idpf/idpf_common_virtchnl.h b/drivers/common/idpf/idpf_common_virtchnl.h > index 73446ded86..d6555978d5 100644 > --- a/drivers/common/idpf/idpf_common_virtchnl.h > +++ b/drivers/common/idpf/idpf_common_virtchnl.h > @@ -31,7 +31,7 @@ int idpf_vc_cmd_execute(struct idpf_adapter *adapter, > struct idpf_cmd_info *args); > __rte_internal > int idpf_vc_queue_switch(struct idpf_vport *vport, uint16_t qid, > - bool rx, bool on); > + bool rx, bool on, uint32_t type); > __rte_internal > int idpf_vc_queues_ena_dis(struct idpf_vport *vport, bool enable); > __rte_internal > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c > index e707043bf7..9e2a74371e 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -1907,7 +1907,8 @@ cpfl_stop_cfgqs(struct cpfl_adapter_ext *adapter) > int i, ret; > > for (i = 0; i < CPFL_TX_CFGQ_NUM; i++) { > - ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, false, false); > + ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, false, false, > + VIRTCHNL2_QUEUE_TYPE_CONFIG_TX); > if (ret) { > PMD_DRV_LOG(ERR, "Fail to disable Tx config queue."); > return ret; > @@ -1915,7 +1916,8 @@ cpfl_stop_cfgqs(struct cpfl_adapter_ext *adapter) > } > > for (i = 0; i < CPFL_RX_CFGQ_NUM; i++) { > - ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, true, false); > + ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, true, false, > + VIRTCHNL2_QUEUE_TYPE_CONFIG_RX); > if (ret) { > PMD_DRV_LOG(ERR, "Fail to disable Rx config queue."); > return ret; > @@ -1943,7 +1945,8 @@ cpfl_start_cfgqs(struct cpfl_adapter_ext *adapter) > } > > for (i = 0; i < CPFL_TX_CFGQ_NUM; i++) { > - ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, false, true); > + ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, false, true, > + VIRTCHNL2_QUEUE_TYPE_CONFIG_TX); > if (ret) { > PMD_DRV_LOG(ERR, "Fail to enable Tx config queue."); > return ret; > @@ -1951,7 +1954,8 @@ cpfl_start_cfgqs(struct cpfl_adapter_ext *adapter) > } > > for (i = 0; i < CPFL_RX_CFGQ_NUM; i++) { > - ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, true, true); > + ret = idpf_vc_queue_switch(&adapter->ctrl_vport.base, i, true, true, > + VIRTCHNL2_QUEUE_TYPE_CONFIG_RX); > if (ret) { > PMD_DRV_LOG(ERR, "Fail to enable Rx config queue."); > return ret; > diff --git a/drivers/net/cpfl/cpfl_rxtx.c b/drivers/net/cpfl/cpfl_rxtx.c > index ab8bec4645..47351ca102 100644 > --- a/drivers/net/cpfl/cpfl_rxtx.c > +++ b/drivers/net/cpfl/cpfl_rxtx.c > @@ -1200,7 +1200,8 @@ cpfl_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) > } > > /* Ready to switch the queue on */ > - err = idpf_vc_queue_switch(vport, rx_queue_id, true, true); > + err = idpf_vc_queue_switch(vport, rx_queue_id, true, true, > + VIRTCHNL2_QUEUE_TYPE_RX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u on", > rx_queue_id); > @@ -1252,7 +1253,8 @@ cpfl_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) > } > > /* Ready to switch the queue on */ > - err = idpf_vc_queue_switch(vport, tx_queue_id, false, true); > + err = idpf_vc_queue_switch(vport, tx_queue_id, false, true, > + VIRTCHNL2_QUEUE_TYPE_TX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch TX queue %u on", > tx_queue_id); > @@ -1283,7 +1285,8 @@ cpfl_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id) > rx_queue_id - cpfl_vport->nb_data_txq, > true, false); > else > - err = idpf_vc_queue_switch(vport, rx_queue_id, true, false); > + err = idpf_vc_queue_switch(vport, rx_queue_id, true, false, > + VIRTCHNL2_QUEUE_TYPE_RX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u off", > rx_queue_id); > @@ -1331,7 +1334,8 @@ cpfl_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id) > tx_queue_id - cpfl_vport->nb_data_txq, > false, false); > else > - err = idpf_vc_queue_switch(vport, tx_queue_id, false, false); > + err = idpf_vc_queue_switch(vport, tx_queue_id, false, false, > + VIRTCHNL2_QUEUE_TYPE_TX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch TX queue %u off", > tx_queue_id); > diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c > index 64f2235580..858bbefe3b 100644 > --- a/drivers/net/idpf/idpf_rxtx.c > +++ b/drivers/net/idpf/idpf_rxtx.c > @@ -595,7 +595,8 @@ idpf_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) > } > > /* Ready to switch the queue on */ > - err = idpf_vc_queue_switch(vport, rx_queue_id, true, true); > + err = idpf_vc_queue_switch(vport, rx_queue_id, true, true, > + VIRTCHNL2_QUEUE_TYPE_RX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u on", > rx_queue_id); > @@ -646,7 +647,8 @@ idpf_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) > } > > /* Ready to switch the queue on */ > - err = idpf_vc_queue_switch(vport, tx_queue_id, false, true); > + err = idpf_vc_queue_switch(vport, tx_queue_id, false, true, > + VIRTCHNL2_QUEUE_TYPE_TX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch TX queue %u on", > tx_queue_id); > @@ -669,7 +671,8 @@ idpf_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id) > if (rx_queue_id >= dev->data->nb_rx_queues) > return -EINVAL; > > - err = idpf_vc_queue_switch(vport, rx_queue_id, true, false); > + err = idpf_vc_queue_switch(vport, rx_queue_id, true, false, > + VIRTCHNL2_QUEUE_TYPE_RX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u off", > rx_queue_id); > @@ -701,7 +704,8 @@ idpf_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id) > if (tx_queue_id >= dev->data->nb_tx_queues) > return -EINVAL; > > - err = idpf_vc_queue_switch(vport, tx_queue_id, false, false); > + err = idpf_vc_queue_switch(vport, tx_queue_id, false, false, > + VIRTCHNL2_QUEUE_TYPE_TX); > if (err != 0) { > PMD_DRV_LOG(ERR, "Failed to switch TX queue %u off", > tx_queue_id); > -- > 2.43.0 >