From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B90945482; Mon, 17 Jun 2024 16:28:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EC144028B; Mon, 17 Jun 2024 16:28:30 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id B51704028A; Mon, 17 Jun 2024 16:28:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718634508; x=1750170508; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tgJVWohLzzFJBYy6XCqxcC1Z9AR3EahiGPXnv9CkmdY=; b=C2MybBrvR+wSKZyd2Oj2ksjfM8dEESf5LbcrIsWbCU7dgVqBNl+3hBOo mjRcOgnqubJS9JePJOhvbgc0QVKmh+0H66P56FS1ZI+f7OiarCXZFq1T1 t2K3mFJ3kEU1fPMVD1hB5svSPngsN0AvNj0Qi1y8RMM4lkIzButowxXud y+x7RpBAPcFup+w8DBgWMT4TDQUA/fWMTG8NjF9+Lh1PgGRwjRjwFGEgd fv2ltP9LH/WBS7r8c85xEerwzDiDz8hoiD6zQqXhxdGhDxF5Dy/7KCKN+ SVhzDVGoz5Dec0Pps6uvWL4qW7hwOkGUWh/BLVmbVPbA3TSW6eOs6j3eG A==; X-CSE-ConnectionGUID: tCo2O9ZZSOC6GrANNrtSsA== X-CSE-MsgGUID: Fe6BXVeST8yEO8DnXF2PTA== X-IronPort-AV: E=McAfee;i="6700,10204,11106"; a="15587324" X-IronPort-AV: E=Sophos;i="6.08,244,1712646000"; d="scan'208";a="15587324" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 07:28:26 -0700 X-CSE-ConnectionGUID: GMf6QcZlSyilNJ5iMfHXgA== X-CSE-MsgGUID: 9X0EwDyeTOiVsPd8Yn0dsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,244,1712646000"; d="scan'208";a="41308888" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Jun 2024 07:28:26 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Jun 2024 07:28:26 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Jun 2024 07:28:25 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 17 Jun 2024 07:28:25 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 17 Jun 2024 07:28:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=devuAet7Y3zx1ULsNKJltEEJsvALVAGnz60RgJ83A5mUeLSOoXZy5VplfszOIP3QMah5bpWJT3gSOFaklCs+abZYutZTHnSZ7VnSra0DWFBD71A2aQYO95/CA7N3U3HMGNqkpu+jr5dtzP6+al2UGNyHNFXjoXteT6WAu/RQifw/m/tplzoJTzOU+qtq7rX9w81K8C0udGFwFm8U6LwXpnvTm/OcDRdYc8GOLhS3P8T4gKDY5UuE3FxKBxiUGhrF7iXxnIZFzQfu+zq+vy53k6vL948dc8xrvPfi1QN8oslUch600SWYgPUjn9aoHxEI+w/0fy2sT74dn+HSdFGClA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E6/v61rPMuAXkVx8rMVc4ApZSwFw2l0AyODiPKrPYh8=; b=Gfe+jyjGuNmKaOIKKClTwOnJMQrlaV35JUXt88mPlbl/zr3Ig8k/rWnDcwiGjH8TfVgJK7L8sF81bOWSPdk9LmpL08ED4HGf8V0sa0S40MjR8OdjHNqaVp9A27F3yWnZWnVVjZDigL8GU9i78bHCApQc/YAIvcSLhWQpEnf1ecJR3X3zJBzrjpLeDy+1mmG0R43Bw3pfDud6zyskd9Yqis/Q+I++gvOIB9GBKmuX3n/4QGSYeJjJlsnexXzlUw1qhfw5VYhabVlGUD3Uv/bCHKWTrgLQc44ApFlQ0+hOImP65cI1Da7bAJ7qNd44GnKVyXXhei088NUj7OQvpOWj0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB7182.namprd11.prod.outlook.com (2603:10b6:8:112::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.29; Mon, 17 Jun 2024 14:28:22 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7677.030; Mon, 17 Jun 2024 14:28:22 +0000 Date: Mon, 17 Jun 2024 15:28:17 +0100 From: Bruce Richardson To: David Marchand CC: , , Ciara Power , Chengwen Feng , Shaowei Sun <1819846787@qq.com> Subject: Re: [PATCH] telemetry: lower log level on socket error Message-ID: References: <20240606122654.2889214-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240606122654.2889214-1-david.marchand@redhat.com> X-ClientProxiedBy: DU2PR04CA0263.eurprd04.prod.outlook.com (2603:10a6:10:28e::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB7182:EE_ X-MS-Office365-Filtering-Correlation-Id: bffceb15-b58e-4bf6-d508-08dc8ed9bda8 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|1800799021|376011; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rXnLj+2BSZqY+LxEPxPSr6lt+EIYJ1ckRAnyOdfh25/ABDKIv4t0JQ4d89+f?= =?us-ascii?Q?EeG2PCKQ2ALQ10rtFB0mxnWOdhqp2u/Y8pkByeDekn4mJJeXuvRrYXAhgJeh?= =?us-ascii?Q?HpMWCNMnjEy3hznWM+mWJd1SuneCKYh1IvEhSvUiNyDEO5FRW4VKJGFNc1sZ?= =?us-ascii?Q?kl5K+saC0TJ97+nMsOBwu+hJvIGSQjaOIy5Brzv6fvSyavulNxdVNcq0Dpbg?= =?us-ascii?Q?lNLpnyg11RSd93uDYxiJMeXyPJgwUgBUFSCSWVYE94xYtyfHiF1P84U/K7sY?= =?us-ascii?Q?iZJywz9E+3yCehQIoA+XuNngqnMUwET2geUMHKjdeFUIAdxip+nZM78n7qOJ?= =?us-ascii?Q?h2Bj+uTD3ejtuGtGlNeINhD57yuAYUgdc/Z+NCMFu8Wu1IqRoNqXomUIiFeZ?= =?us-ascii?Q?xpaETHoVwQCZL8IQ1H8DyL3TaXx5SHdi3X8Sb4Gtcdn82okAhuyq1+poovaL?= =?us-ascii?Q?Gdj2IbsJ3vkdtI3zZkwcW8Kt6vZIcpEMteFpMvjVqf0cYlHmL363UIE2rqaX?= =?us-ascii?Q?MaRhKrX8HdMIEfYxbq8lz0DDynRcxKFYRtC2rGqKVGRNnjNbpIxh+do5gDQL?= =?us-ascii?Q?1pbKA+YF7qGuQT15dMjwGcFBse6aEvBKYIoFg8jOAt1fqYbAjEcoc/YsfdeD?= =?us-ascii?Q?dzQl8LrEhIszk9/DGKbyhkXr6O3oZFWwvoIrw3sCMX9qEdC78BYjyh4lOhSD?= =?us-ascii?Q?qGKybs6qjtrdfbs1hh/jgrVmhzP9VcdgVF/lU6lbOnM2pOJ8R3JJ4FPmVasr?= =?us-ascii?Q?S0PQ9HLrjS30PbsTU+yX+GTYwprvGfjPbRBKQ94cWcnBplJRl+FAwbmOIl9L?= =?us-ascii?Q?968BuMdNztAi1oV0uVFLs2jA5oCUIQ1UOKGOHdE0hnkw4HuN30LFAlIZuKRZ?= =?us-ascii?Q?mKVe1qbN0YRETV/hvSCbzgD2RoyGLgNO4SEoocUCn8168PJ0dnVt8m4/ZOBq?= =?us-ascii?Q?bXcsB5/qKc4xcGwYKr2QsC9A9qejLjKm8scN/I7cHfk67IAoWOI3Pp1zIP3f?= =?us-ascii?Q?zwwiyWnY+TuH7zqjQFQ/gLNk6Ew/MW6Cm8qB2+KJwq9i5WL/MhYwBiFsJpIJ?= =?us-ascii?Q?XMyknsJ6Z9NhMm42KNd14+f6XTJ8kga7MYI0lSyi4gSgqBSbpkQZ+LZsIs9R?= =?us-ascii?Q?Ntf9H5C+l5LqeJnIDYwcb1+UaDr5TBE6fMFzq9u67rHUARSriUXNspGG5UaT?= =?us-ascii?Q?cMkEkiOb6C+ALN9KVoiH7pMy4qR+HX5jx3C4rnXpkj7UcUJXtKj4sTpuYcp3?= =?us-ascii?Q?fOXY9dduoXyrEPZzo4Nxln1B4AJVea3ZoQms3y6oyTMLdPh1fUrUPLqbkqd1?= =?us-ascii?Q?7xvKMHO3uUp2RkZRWhWUgejp?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(1800799021)(376011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FYAqkipdD6sxrhBwa5/mNC0vBXwzxSzoU4xBbJNtl/k53TvgS/BQdHowpOKT?= =?us-ascii?Q?RRnH0noqJsiuOOau5dpwOw1nEdOknDzislzQS4KtscjZdj3NGITE5bp8FMvt?= =?us-ascii?Q?aTXngZGf27+dT/MnI8+XHWPpy3jsUyPpwrlpeKbkWRdVb9ybxVtTU5I7lEWC?= =?us-ascii?Q?3zx8fEToKO+K7d+rHVgBtSZQU8pRBjjM1ieMI4XcSZj00COgqYQ5MwVHmKZL?= =?us-ascii?Q?VnKv/Zcf4R460iOa9zUS+MxdI/7jronQmnJJYfY/8B9FAFdapoy9zHIPMK6v?= =?us-ascii?Q?paRdaxWAnwCAyms8jTDcfidqm8lDp5JLFqOH2PotAtT8cU6sLdIV6N1+dfzx?= =?us-ascii?Q?P07Sr+9/LxWwgAk31GYV72j8B1nERzd4dOiLh1EK/S7S+OYXkHu8GkWJ7NKg?= =?us-ascii?Q?Tyu7LHOyR9sAcmaNtLXWIvGYUOjLs6Q/JmYqmbgvCi4gxW/0Q+fzGUnczGEA?= =?us-ascii?Q?DJ281bRzYnivukxDAUq5Yk4Fh8jQ3S0ga1JdhV0HnVPEbQyn+6yU3zFu9Mm9?= =?us-ascii?Q?SK63V1Q1C9gWrxZHvCukvyaBjLBlAz3OZDMMAEoyVf33AamurPt2dWoPEE4X?= =?us-ascii?Q?Y5HzY5I8TOVdTNtxnffHuCtubVf40ssBiZqZoKMCpgEcUW2aXGlezqwVMRuO?= =?us-ascii?Q?fp+42U9BQgYAjDjxO/ksRklNp1r6eRgsoDxkgWtzlRGSy3u+F14xjpOmWuJM?= =?us-ascii?Q?vgu7mFfAKD1nWM9+FTCJvXYmm1Pfz4jrD+dSSlLLB3j9qeGm1MhrFVlhwNHV?= =?us-ascii?Q?oy6JbAUEBFEtBaDPETTHNrWLIy9GP5lBwRbpJxkYg0Rmir7FVkHOecuqL71B?= =?us-ascii?Q?mTopUBJ8rViS7nPfEI5WKT+UoxwC+86zUsNLAFxQE6Z8OtezVodIxUC5/nQK?= =?us-ascii?Q?KfBI6XiiOlNonXNpHaRft/W87U0dumVMo3enj+V9URxskqKr8vWyOPDCDyAC?= =?us-ascii?Q?ZnWylzZIrv/IPIbaliXvCSlegPe8EhLzzVMOSRIXRQtXPUDT/ExGaZs0i6ne?= =?us-ascii?Q?rEsyDPiBpc+HjPYw3N0NN+Hn9nc1k/QFHOpWaMPaMYm2eFS3WjbGMH3//o8j?= =?us-ascii?Q?1l/K2Wcxdr9F6J3k7AXv3zPNAhmGlSo/+4MkVX14smNn6LiofS9ZKmabm3lk?= =?us-ascii?Q?83i/lgPsAq4fiZNwSEeJ6ph922qHQHGJ+ItruuQaUN01h95KgGd1AMCcNu5x?= =?us-ascii?Q?ZaE79xJoImMuVxKN36eyw040jJhMbGKTG0/r3e0QmtpixFNmYD83EuPHIods?= =?us-ascii?Q?npwkxCloWvEqoaCaLNoqe0pdxS9cgviiDwwznxiwNXh9Sb2XXbZPbOG/U6BI?= =?us-ascii?Q?GZCJbXKogXRRntkJXraU7BUbOCmNM//ssLwYC+ClgRpPwkEiN6KYbTWmAnW7?= =?us-ascii?Q?pZxwfaiCLZhoaP7TAYIBbZhdeW3xwRQ4lvrWKBTuaqF9iHUAy+IF4/uAg3b5?= =?us-ascii?Q?x5lgqJlnSPStbYsBSnxs/z48HyhAyl/emETyBpoVT8ZOigW7Qd8EDzrAgbUX?= =?us-ascii?Q?9dPE9T15RE8FWR7YS5zuw690CjI445rvKEs9dT4YE4IP822PQ3bXZy9VBr/d?= =?us-ascii?Q?i19PgQaPuI/Y4y2qKXMWr4KLIqwvqtsuw389OOpc7cUGKc/6YgbFV+48R8U6?= =?us-ascii?Q?eg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bffceb15-b58e-4bf6-d508-08dc8ed9bda8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2024 14:28:22.3301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YVdT3FLdRdW7bYctzcH8ZedlRpSDkzm9WitCjml2qvE5fk3JUJrolocYukGK8TLY0GM8YrO82FC8KStxAe7eVRyHZoClLWjF+YVvgDMha1I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7182 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote: > When starting two DPDK programs using the same DPDK prefix (like for > example OVS and testpmd, both running as primary processes in > --in-memory mode), the first DPDK process of the two spews some error > log when the second starts: > > TELEMETRY: Socket write base info to client failed > > This is because telemetry init involves trying to connect on existing > sockets to check if it can take over an existing socket file. > > On the other hand, this error log provides no helpful information. > Lower this log to debug level. > > Fixes: e14bb5f10509 ("telemetry: fix connected clients count") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Acked-by: Bruce Richardson Would it be also worthwhile having the probing process wait a small amount of time or check for an input string before closing the socket? That should avoid the error message being necessary at all for the case described. > --- > lib/telemetry/telemetry.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c > index 1663bd8c68..509fae76ec 100644 > --- a/lib/telemetry/telemetry.c > +++ b/lib/telemetry/telemetry.c > @@ -382,7 +382,7 @@ client_handler(void *sock_id) > "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}", > telemetry_version, getpid(), MAX_OUTPUT_LEN); > if (write(s, info_str, strlen(info_str)) < 0) { > - TMTY_LOG_LINE(ERR, "Socket write base info to client failed"); > + TMTY_LOG_LINE(DEBUG, "Socket write base info to client failed"); > goto exit; > } > > -- > 2.44.0 >