From: Bruce Richardson <bruce.richardson@intel.com>
To: Igor Gutorov <igootorov@gmail.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] net/i40e: increase descriptor queue length to 8160
Date: Tue, 18 Jun 2024 13:12:13 +0100 [thread overview]
Message-ID: <ZnF5ndp1WSZxc5ci@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240527161921.183866-1-igootorov@gmail.com>
On Mon, May 27, 2024 at 07:19:21PM +0300, Igor Gutorov wrote:
> According to the Intel X710/XXV710/XL710 Datasheet, the maximum receive
> queue descriptor length is 0x1FE0 (8160 in base 10). This is specified
> as QLEN in table 8-12, page 1083.
>
> I've tested this change with an XXV710 NIC and it has positive effect on
> performance under high load scenarios. Where previously I'd get
> ~2000 packets/sec miss rate, now I get only ~40 packets/sec miss rate.
>
> Signed-off-by: Igor Gutorov <igootorov@gmail.com>
> ---
> drivers/net/i40e/i40e_rxtx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h
> index 2f2f890855..33fc9770d9 100644
> --- a/drivers/net/i40e/i40e_rxtx.h
> +++ b/drivers/net/i40e/i40e_rxtx.h
> @@ -25,7 +25,7 @@
> #define I40E_RX_MAX_DATA_BUF_SIZE (16 * 1024 - 128)
>
> #define I40E_MIN_RING_DESC 64
> -#define I40E_MAX_RING_DESC 4096
> +#define I40E_MAX_RING_DESC 8160
>
since the ring memory allocation in the driver always seems to allocate
space for up to the max number of descriptors, this will lead to an
increase of memory footprint of ~128k per Rx Q, and ~64k per Tx Q. However,
I'd view this as relatively harmless given what we have now. If it is an
issue, we should look to fix it in a separate patch, rather than blocking
this simple change.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2024-06-18 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 16:19 Igor Gutorov
2024-06-03 10:41 ` Igor Gutorov
2024-06-05 10:47 ` Igor Gutorov
2024-06-06 9:18 ` Morten Brørup
2024-06-18 12:12 ` Bruce Richardson [this message]
2024-06-28 12:28 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnF5ndp1WSZxc5ci@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=igootorov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).