From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57BCA4548D; Tue, 18 Jun 2024 15:21:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3032B4064A; Tue, 18 Jun 2024 15:21:53 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 1DD72402B4 for ; Tue, 18 Jun 2024 15:21:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718716911; x=1750252911; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=miq5Dycy+II0Mr0u9YidkUxQxInxFw0hbHv2FHenak8=; b=PH7u6nFRMue/nEyQaauoqnMf0VKD9aEPm4LXLGHm6qpQ9z4hs9DECqRF wJJR1OLgEO1vbFoG1zpeyPZzITlYZwpVaK8qzDf9VMLf5vDhCvYHgI3lg GVgouJ0jQJ9+lU3q7JlaVm+Q0ahioq4MJPTdxtMXd8pCb7UWB8eZ2FBHf kRkVT8zAwy+l9PQccyGqaWbzUCk5pcFw6PrM/eKZLMSMoLhjRGX3rl8eO lFiEhf5QEEM+OAcoaI6dbvDBK7j+6cv8/e9gPS2AUcGDYAYc4qOQVcUTz ViUiqLgbWKPTcByrslWpHmBhz+QZzKsE5lQGQ9dvsRs0paxa6V+XdbCYl Q==; X-CSE-ConnectionGUID: BkvBI5YWTMiQid1lT7oRjA== X-CSE-MsgGUID: UgGpCKYPTOuDcu67+2F+ww== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="41002161" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="41002161" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 06:21:44 -0700 X-CSE-ConnectionGUID: vb5mG06GQkGIj1tVPlUJgw== X-CSE-MsgGUID: lo0zSZbuSaCpmHJvQdvbqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="41500979" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jun 2024 06:21:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 06:21:43 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 18 Jun 2024 06:21:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 18 Jun 2024 06:21:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJ6VNA4vf37rGuvmZAMdOP+a9jZ22lZDw0q78Rr9Y4us9cw1wHS1DC7jtAdaHmwPLGSSYz8iTQXdJLa3P8OSTtqhtuOlwJmrBVOPGwqGPpBBmhgu0D6/Huhnseskxzxtsn+/nF9tpNTXOqxYysjaRrIfz1AXCCa7FVi1ZAlCnwXwZWE/+Bm+yXcmHkJYGuyNCIZRgAvCxtPYfsSee45U4T00/Nhaaq8L/zaVR1bPeGJZhkqDjqq18cIiUTIPA8WZxpvQgip5w5QTi9awbWu3F84NHNONGuBW8cPchF4GPmJJe/zb3+Ue3kZDA/EJpI+QgGrUGLEsj+KT9BiSRmobAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AOjnDb9SLtCAdWnJOsm71mfXPLbLHAMM3kQIwnOInAY=; b=CXBilAmQQsnhgGDI+kk4Rm6CjtxBxudHf4y7m5blT2jdBUknrNCMew1/CP1qBWMBc73vTDkeyzL9SuJqzwAY7ZF95GoRnX0p9BOXt1QZRKr7BklKpcexkayUQX6mc43oK/thz6AKBVxTWVGYtfNfeChezBZajlbHHYioFJ0R8N5Nz1sLay/+zYgMcmgIQYqGWA5EE8jqPuxEKrUYo0h9ytuXV0bSApdP/VRaiQecSBVjmuk56cRJ0SHthHQIpmImvrvhTO82KX/l5Wl4O0OUPB0HLSCA9E9xPgBYacq+4xnxorbN1n48JvDyLQOkzp0MnI4yKmJ858O0Uf1yFfZTLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5782.namprd11.prod.outlook.com (2603:10b6:510:147::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 13:21:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7677.030; Tue, 18 Jun 2024 13:21:40 +0000 Date: Tue, 18 Jun 2024 14:21:34 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , , , Subject: Re: [PATCH v7] mempool: test performance with larger bursts Message-ID: References: <20240121045249.22465-1-mb@smartsharesystems.com> <20240302200408.6419-1-mb@smartsharesystems.com> <98CBD80474FA8B44BF855DF32C47DC35E9F359@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F50B@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F50B@smartserver.smartshare.dk> X-ClientProxiedBy: DUZP191CA0064.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4fa::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5782:EE_ X-MS-Office365-Filtering-Correlation-Id: ad66315b-3705-4acb-c253-08dc8f9996b2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|1800799021|376011; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?NyBRUOil2HUqWyGsLcJ6NhMrneTHeP1hRkD6s7B9xBDCCHCIiLRTDhX9tu?= =?iso-8859-1?Q?bS7DhEIW7jPcBSp+sRAltNTbL7EyB65Fd1cCQEScdrrdXwcV0i/dyz8hIc?= =?iso-8859-1?Q?brJZFK6uAzjdUsHF3SuNUBvOH954esxXfrMZkKu1QSUINW0OCYKH7hEaNO?= =?iso-8859-1?Q?kU0JTUQp4Wxd9QvyQrBGRykEP06kjdaQDSpadaNLyU4ZZpCvkbURWbHe+E?= =?iso-8859-1?Q?ZY2DiMWU2cdZeRXGaRcsHq2wb9l127aVFK/ea26wBZswDAZpFcRi8toTIS?= =?iso-8859-1?Q?gaN68o5lfdE/LIl1tMsV+8+JAY/F3a9Xbv0kNYPgCAuD7K7VNgNXf7FLjx?= =?iso-8859-1?Q?hg1IAQMGplBp0tMmj+DU14CIMTGcsJSJx4NGutbMTipQi8fSsq0JlrXYu0?= =?iso-8859-1?Q?pgrjVSMuya9Q0chahqdrrmcEdpxl6gcuj7MyjgMvQziTeOAvb4undoyord?= =?iso-8859-1?Q?8ekzGFiQgJDwpzHxdY0b4Jp3t2S7k0bdPNuFN/qvok70ICvqlzhus8f/7j?= =?iso-8859-1?Q?oc291Ub1CGn9C917OmAbK8YXDXIqsKtOfF7YEEImzhlG6ENP+XZYAMUZXV?= =?iso-8859-1?Q?1J6lUMGxj5sFDRCQKszhmLA14nhLIhZfaF3MeTUmldv/GSQzo8Dnw6AYmR?= =?iso-8859-1?Q?2YT3xSQ28g1G2jVal56n4Wsruk3H09m1k4OGch1WFVRaRlb+qgjLDiG140?= =?iso-8859-1?Q?FfGaL3JPqY5E4WqK9/pc6irC6n2H4Gh7h1XEi9ev+M0DjraAHuwHzyDOBM?= =?iso-8859-1?Q?t8WKqqWM0frEyRnxM0g3Q1nKDFDNTqKSbYX5vbDpf0CIxLR/jU+g+/JEZz?= =?iso-8859-1?Q?l3BjURtzhvBqDyvPWst94sBv45oqIpDKrCzhkCON7ZImvLJ1ZXKPbmq5M2?= =?iso-8859-1?Q?dj5bNFoKXNwXLFvHdb4ReLlPDSUy4t4kOz+ojy56XI2cqvbEuJjovxqpDH?= =?iso-8859-1?Q?f2i+J+VNgdt1m0bUU0WF87eIHgetEJyunyHtEZzTOIYMthzcoHZhjSzM8a?= =?iso-8859-1?Q?4M63Mj9JcfcObmwMYJG+zUhZ+vEOEwCQzHpYXuOGtie2/YpkAGs8538OJz?= =?iso-8859-1?Q?2JYuqIpIvmOGVuPpYKVBLfoPA1YBAEkgYhYjwQk1ZicwPE9qwbkDG9M71U?= =?iso-8859-1?Q?dgP7KRSCMEdIsy/ZmlggSs7lo9aZREHjr2l5ik2AbT+UY7zQbzT0HBMfTX?= =?iso-8859-1?Q?7/xXuUIwtKlV5y5X3SmSN+3wX3bUoDSfhScxbv//58WHps3l0cr+RKEnnS?= =?iso-8859-1?Q?sNxc43ctRwDGoftpVSlY8OLxX+1+H3Eq7lo5f70py9SeElVY33w78HDy6+?= =?iso-8859-1?Q?NWPnOPRapg8Fhhz1HmscB7WG+EmtsR94T6lmfS0fCsN+lRpsIw5VWPv1C1?= =?iso-8859-1?Q?Cl/AtQX4uv?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(1800799021)(376011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Mkl/6hP7B/tI886cvrJmqPpBjCwg/GOmBo8r/wr6dzFXmV1h/Nt4ZuaJve?= =?iso-8859-1?Q?dlCGqU/TthYrQiAEFM4Lwz5qCcpkLdHABC1+vqfG8UEWYZl4YWZ+seMQyG?= =?iso-8859-1?Q?eXMtpfdsFI/rbrY4eu4cZptLi9Xu/I+IyQW2/ubtSQThSpNplAndFHaRj8?= =?iso-8859-1?Q?e/hYtSclfoUOc0MF06KQ4TVpKcJa3cnDqY2X0rai4u42mZj78WUThmHRGN?= =?iso-8859-1?Q?WrvkJlaYcRgJpEWShAXks1kmMxjCy6a5Nhxctk0Y9zTAdz6cz8KLLzXVXT?= =?iso-8859-1?Q?g7euxpF611W0CLQNvFLTvZtQPBe9dMd2fNQX4OjzWpmxeZ6l90BK/ef+oA?= =?iso-8859-1?Q?z+EqDJhCYC6ywydtSHgrZje8O2DzUwQSJ1firxC0QlYpc527aMz+x1oH0J?= =?iso-8859-1?Q?zTK0YJeFvUFg6nMtG+K96YtYuCMg18yM7aFXmbjt3kQwKF0n5+ptt/NLId?= =?iso-8859-1?Q?VplLLYAZfT7CeoHMI36vOqbxeCswNOxHGsmwBtHmD/MrjftD7RZmgh+mUJ?= =?iso-8859-1?Q?hqzSn+8rsGi6eSGA+uWKJ9XmV7MVIUV+5Y9/rFmcCdmG5Dux/jK3WYa4Za?= =?iso-8859-1?Q?0ELJIxMAaEYzl/VTzn/6mRxEa5wLOGmwU+pezaY3Ghix/qiK5Ez39R3q+o?= =?iso-8859-1?Q?/YC5NVgH8XVnxJhC8BPTBUy2gTbHa1Qw1L/Jfzbcw7Wv5ZGUDlS5xOuQ3y?= =?iso-8859-1?Q?evhugUlVtAcoEGL5WcuB0jKgs1cVENWMCp8MEg4HH5fuo1OZN5pK/rAuu6?= =?iso-8859-1?Q?dJ8AZd5TRSdT+ONn65tlt3gNAwE6KqSZDuCAV63DZfIALosLB/QU/1OrXE?= =?iso-8859-1?Q?nnRHvQgRYR57HF3/leENpU97vrTejpR2QIBZHq/mn7nUzjurUt4Z1IEmyh?= =?iso-8859-1?Q?rWOth1jef+3DVkr5IHQMEBp1fgMFI9ohpgFQ/5d5g268/TeJQu1T1pJtS5?= =?iso-8859-1?Q?pO1D6V47cEv5O2IaK+EIsFQ8HICi+1cWa7yEyCz87AVDny2e3Lq/9Z7+k3?= =?iso-8859-1?Q?81CARH1XB6qjVohFMeT1OjrCuClAIMszU+oFltJmPKtSLPU7WK9YtI2IT5?= =?iso-8859-1?Q?mbTVxLn3zqa71Ay31TAsXUbDBSgCFdXeK3vxsGkuiu0nQhPMzBKHR1F3Uu?= =?iso-8859-1?Q?81yCm4pDZgTuw4Mwts+xyIm4PHb/hWwYmLp+IzUsuEOU2NSY6re5rjMwcO?= =?iso-8859-1?Q?tvXK5Bu7SSjTx5oR3lqUXmy6+mpKA8lR8yjWZSd/FXZH0SeB+mBNaDa6vy?= =?iso-8859-1?Q?KkBqtWS+10K4AylddN8TkyOCVsb6x/f183wZZmC1WwPyfAbWrZYERle8hc?= =?iso-8859-1?Q?hh9WoYquDfczlNXYw7mHuw9BsGIkaVtA+5nYbbJrrqBd+mM+rUq5yb2KCt?= =?iso-8859-1?Q?QTzf5fs2kxDv4kw5VsFNfO+LMDimnldbhutjDsiI0oWCHA43ntdGIrFjG0?= =?iso-8859-1?Q?aFxC97RbkF2PrGdE0Ta4ewoMiLoRFHSmE4m6rIAeKlYcfu6Qk5Y7+GhNQm?= =?iso-8859-1?Q?X4l+iCVuJUHppKJlN209Kkyzql9F3QjY13wGTD5KceFKrAMZ4pBQhcKur1?= =?iso-8859-1?Q?P3YfjSnShv1mw+F7Z5lhQVnuaJVGBRybW8HQdPnrVkb9qpiQyd0SAeDqI7?= =?iso-8859-1?Q?iCejpf5+5fcOO2hQ9jZL6Prcrr+Sfsj1OAq64NyEddfC2XG96lO4LEJQ?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ad66315b-3705-4acb-c253-08dc8f9996b2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 13:21:40.2978 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c4/kUIJ47IimiJBfcPISZHxuAY8TcCmpoeS9+7ncaKLYJUZngBkuOdNUh1o6o4tn+mYl3Ug/ggh5rpmC/Qxk8wzz+0oKr2cqPXUe5mTP1bw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5782 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 10, 2024 at 10:56:00AM +0200, Morten Brørup wrote: > PING (again) for review. > > Many applications use bursts of more than 32 packets, > and some applications buffer more than 512 packets. > > This patch updates the mempool perf test accordingly. > > -Morten > > > From: Morten Brørup [mailto:mb@smartsharesystems.com] > > Sent: Thursday, 4 April 2024 11.27 > > > > PING for review. This patch is relatively trivial. > > > > > From: Morten Brørup [mailto:mb@smartsharesystems.com] > > > Sent: Saturday, 2 March 2024 21.04 > > > > > > Bursts of up to 64, 128 and 256 packets are not uncommon, so increase the > > > maximum tested get and put burst sizes from 32 to 256. > > > For convenience, also test get and put burst sizes of > > > RTE_MEMPOOL_CACHE_MAX_SIZE. > > > > > > Some applications keep more than 512 objects, so increase the maximum > > > number of kept objects from 512 to 32768, still in jumps of factor four. > > > This exceeds the typical mempool cache size of 512 objects, so the test > > > also exercises the mempool driver. > > > > > > Increased the precision of rate_persec calculation by timing the actual > > > duration of the test, instead of assuming it took exactly 5 seconds. > > > > > > Added cache guard to per-lcore stats structure. > > > > > > Signed-off-by: Morten Brørup > > > Acked-by: Chengwen Feng > > > --- > > > > > > v7: > > > * Increase max burst size to 256. (Inspired by Honnappa) > > > v6: > > > * Do not test with more lcores than available. (Thomas) > > > v5: > > > * Increased N, to reduce measurement overhead with large numbers of kept > > > objects. > > > * Increased precision of rate_persec calculation. > > > * Added missing cache guard to per-lcore stats structure. This looks ok to me. However, the test itself takes a very long time to run, with 5 seconds per iteration. One suggest I have is to reduce the 5-seconds to 1-second - given we are looking at millions of iterations each time, the difference in results should not be that great, I'd hope. A very quick test of the delta on my end indicates variance in the first couple of results of a couple of %, just. With or without this suggestion. Acked-by: Bruce Richardson