From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41D0D45492; Tue, 18 Jun 2024 17:20:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7E3D40DD8; Tue, 18 Jun 2024 17:20:03 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 63D7A402B4 for ; Tue, 18 Jun 2024 17:20:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718724002; x=1750260002; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=95VyJK9TWrrB10GYVlJ0JhM+FVJmhDEH2S7rbAMTT0w=; b=aJDXob3bU1BqPN9OojMq5bjYhzJAbOGbexWVI7v1OGpEpbiiXr40NggU BKWACvr26gbSUOxEd8gH6VbH9yWgGvtFiRJ3zcTa4QJweQvlABUFybGIb QW8nMJNL9AwAAhHrKVbSTVdCjH/5CLzERW4IAxPdoEpBWZd4RmYnifgWq Qc+BsHc7aX9mL8jgVcvlqhbmoxXbGHIsh7Zlmxdi7wKbzZtGSxO8bl6vn H15Ob1ZMMNOOFwkStl9P58uRw/RqFARXr7e/VKC/eIXFcYb8ci0JK1HEX o7s3gFamaxRY0W7E/YOdwXJnCeepQNBP8QpS1KgohzVRSLOBuhananyeu g==; X-CSE-ConnectionGUID: 0ugeqf7jTse6OjQWR2jt7Q== X-CSE-MsgGUID: oGoY1ekTRXaxYtwxQoEk/A== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="15327429" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="15327429" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 08:19:48 -0700 X-CSE-ConnectionGUID: j3/PWE3TQiumY4CueV/w3g== X-CSE-MsgGUID: +NKXvQN2Q5++ibHh7QdDZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="46511080" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jun 2024 08:19:49 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 08:19:48 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 18 Jun 2024 08:19:48 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 18 Jun 2024 08:19:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mImiYOz3ajSmnd3D52IWlUV3/jl9vq/Csbawv2qZapjAmr+9wULkpGhUdPjXJzutJIOsIOnGd/0ol9Izuvd6RINq27spL8peRudYTb2ElRiFF7/nJvE360LS4PN0ykv2UXbW9HcOoxFyM5LkLdXGVncGxIGl8ZP+g3kfMO4OfyJSGhehMLh/G4lVPaMsrsvQQq6mNoww/I3I6LT0hS2Vf3qN1aBxGfOL+He+v+2LokC8Qm8O7E47tIQ+8BsTxZazkptch71ofTjbvEKqXz91dCpDpqrJb9/UDtYrq9m1jNvUk0DgUFOuI5pXv5h38Ox+iV0sBtlSHNv3MVGPJvC16Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KJfTnbTUx0SM/1At0TB9ESx2QkCxDr+6XUrbR4cvC8A=; b=k0BsIWRmWaoIiB+eZoSjNgMCSNNcq5/OtsVJjEBmcEpIlR19jTdRnmVOL0r3hKWgw5wommDw0Z9/qZB0aYSvA5TsB+APthpHTXUQ4ey1PxsmXRXQjBg+z/xqmbR7FQLx2FOqnwAdz6+rZXXN4jtyNTeWrTZ+IhfSw0hxLX7pMFq3jqg53sorD5G5X4xBOcC6b9E3EXe5PXTQLOarxGON1OjNAQfe87kmc/4hSH9jFJpliH0EsoV+FfpnczePsbEIxd2WZUGCAfPE3Lik4fTcG0Wn0otgi4qeJQ4MPc3TFQwCLDdYy4fUz6k/QezCkHlVOVwZAXgkkXvafbwRtnMR5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB6398.namprd11.prod.outlook.com (2603:10b6:8:c9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 15:19:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7677.030; Tue, 18 Jun 2024 15:19:43 +0000 Date: Tue, 18 Jun 2024 16:19:36 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes Subject: Re: [PATCH v2 057/148] net/ice/base: get rid of enum ice_status Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB9PR02CA0007.eurprd02.prod.outlook.com (2603:10a6:10:1d9::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB6398:EE_ X-MS-Office365-Filtering-Correlation-Id: d8a302f9-faf2-4b8f-3d11-08dc8faa14c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8H7aaFIih7Ilgp2hn9p/97/asW3Tr0OkoVJTykvg6DKIo9Abs22Hr0Z5VT9W?= =?us-ascii?Q?aonGZJuY5rp62Ku+RP2/C+xxq8XK8zB8kbHG0N3C67WwPuzi+jzU1mtNexoi?= =?us-ascii?Q?qnQKiS3EjWfNVQAEBddU3fy20In9F6Ud6/zmmR8QrOC/ql0O88svqwwvr4ZG?= =?us-ascii?Q?uLXXzuQhaey/A35tH/EnKK87bHH75aDu7Gksr1dAN8FyFA4D+q/z+DTe93zB?= =?us-ascii?Q?CxQO6YgJlFguLCvC/R/B7ovl9kCrQqjouwCrT4dUsUlyXVrt35WKd0CXjV+6?= =?us-ascii?Q?4B5r2NSy+hZA6hR9ogbpxynr+63HO8jI0SwKyCoFcNHCMDSI97iL0/hi99BS?= =?us-ascii?Q?3HXLV3fRxPX+tSfieBMy5tIAr3EG5m19GjhzgzuEWgPSmvp4INP69TpS92kl?= =?us-ascii?Q?fKWMsLI/1h2eKIMpfYVtNMshWon+V+ICt8jWnN+Pz3uCeywEG7XOv33ABDA6?= =?us-ascii?Q?0D7jhv6CgxoCZNrZcOZOaaC2LPQLaeUx28tNjwu5lA+HkdTyhCazkoxSzUAh?= =?us-ascii?Q?2H50XBdZuJA10MRilJjpXSUtspbv0LCgsAkOlem4tFATgcNw5COgbKv6QUpD?= =?us-ascii?Q?UdC42XeC0UDKvK6QhkGPNYQGj46u8zQkVx6vO/BvvEV2SGAZHHiioM2mitgB?= =?us-ascii?Q?MJoljzD4ZMBQhI6740jB6o7RwSkRrLjG2lwdofw5xl9sgAklWiqxvhFfJ8bU?= =?us-ascii?Q?wc0Lxl+Y1qAdWc8gRs+uytn1wWZiHVbOIDNpkIPtz+baEGT9KCRmuD71nM5+?= =?us-ascii?Q?8Bw6C3Rdy1UAcHj/2tXHKHGNK5hjtH6uMDMRcxQvtvkzMrpSSGbqQg88HveD?= =?us-ascii?Q?/wWL8TSFTpev42NIOvAwObeu1fqkdDARB9oV3qSZdUuq/CYbxVuAqDNlaGi3?= =?us-ascii?Q?umEJ1UahwzyMhocRZAWZoQfMHy8AShGtVLX9BhP0hCDhpzIniL6uZJyqjOuN?= =?us-ascii?Q?1QojuWXQ9Z5yLecJQHO3iuFwf1pGKdC9c9jQ0qr7etKHyOwpFgeopXypWu3K?= =?us-ascii?Q?8UxJl6Qp/fP+u4KsSWmhLfhKVfgceny2pmXX3dtqi8/oPuQQZZR8R/prJEWm?= =?us-ascii?Q?LcbjsGXWDH7BI7uN1IBaaLElr4Kys1nnhZq6xAZ+UZL043IrlowHCnWOzzF4?= =?us-ascii?Q?5ZB2POhOFz01fvXC9dHDtyBEVkYaRu8/kcOM39ofJ3fCG2fz412lyyuxf2rK?= =?us-ascii?Q?OdhsnpH0fw0Xm/RFt/1XHEFIAsZa9Dpm1s3MG/jZAHkJp7Gc8zmQzT8yj2dg?= =?us-ascii?Q?4qRVPRjZ3AKLyCbpCCK6/dI6UOyGkYZL9MNn3/W4Pecq/zEFcRhzg9/bQlN1?= =?us-ascii?Q?/OPa8i98y5b5esjdljU/wpBQ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z4gRmGcfr4I8VcMofbKxewREp6iOf6lKZ2v18UzD4sVEaeQxAC0IBaUpMaj2?= =?us-ascii?Q?uWS9cOIn9jj4k/+WHFLPjoxoci40LsurzepOvCYPqG2XF/ZziXJ7DGAxpyvo?= =?us-ascii?Q?8O7nLfsZYgYwQ8FullqdrZWL2KcNewhzBsrpKRNiFxbB/J66hvCvGPjcXc26?= =?us-ascii?Q?xkEU5vXppwssHJZ2TbMlr+AO5uRO8YgvibFK1s6NVIl9OvmnJF3SMj8+itY4?= =?us-ascii?Q?9yFyfyU6z6aDFZNo6o3389WnPp1rxR7bYGclJhSVDLCJrtJOqWt5SuKP+5dq?= =?us-ascii?Q?QhwnKZAQzDG0rZhiT0GRAVWAGou10tqkyONqsTUYJq0xs+gWMDIiQ6jNhcF5?= =?us-ascii?Q?Ktlzc65nSXswVgoqU74od1rrOooNu5jUnKye1qYbyLJh6ZxjbWW88p1D2Ujc?= =?us-ascii?Q?MuWoVe8kJ7SirUPCWveJ1J/zfwBppt4P4864sdAUCzKCMv7rwNw5LuBNaE6w?= =?us-ascii?Q?83IPwrhRZQpkTxHKfhlWQ3MmRiMvl5QWHiGG0BD/61aZKZtSzTANA0qXGKn1?= =?us-ascii?Q?qXP2ZHNhS2hLcjpIlX9c809t7KxL+yY4pNiJSKU97d5qUiOfowU/g63VFORG?= =?us-ascii?Q?FvQB2eRZaBFQibsFDYXSXy3IfyIYK9VcttccfM278yxp1+xb5njkO2ci2ZzO?= =?us-ascii?Q?mSP1V6hS7kARvG1a8qpv0My0BNTUuu3EeM89mLc4+HB4rJ93bNubW/OGcC9Q?= =?us-ascii?Q?8RE8GqccP1tMLP6vYLIIV/hP++aTqU/+Woh2bOAQ59U8rUKeluSgav3LrTbH?= =?us-ascii?Q?7950LrKruNGOKVZWkxasN3Z9LUfoOfehUgiSQxA0o9fYEHbWKfcO7EoZLQcK?= =?us-ascii?Q?i7d3J9lupdTHR277YagC5TvRBVHza1SUKa6ID/GEFmhFPvNlUff6IYb4c9P0?= =?us-ascii?Q?NdDZ3fZVOkcHh72W1BiBtnAfMXlDbIaqo5qix5cMuiGGvcRxUEiCMvv9XZZ5?= =?us-ascii?Q?A+/xbtjD1J7I7EzPl0g1a5QIDVYTJNrxeZQxYiRRNZ/Dzo0yCkW+DXzu4pEv?= =?us-ascii?Q?46d+InvBCVrUlDr6Wwc2Ml4RQYQbyV2DZRM4OkEh0tyQlqGa/FSgF6V2HukQ?= =?us-ascii?Q?/jdl7E11UU78hsgLq+fC/d+0SSE9YrAs4VYnmKFAxyXFeP6A0+1+Ig5DRG4C?= =?us-ascii?Q?RE3p0fhtr314Rn0e0W9lBZFPk8WdHV7MnX1z5XpMbDdYclKu8uA5EjXAawJS?= =?us-ascii?Q?0ZdAlE2lMPQC7DG+rHcbgFqmOSU7t6es+1bbz/AqvZHNRtOyk1hXANzpr9XL?= =?us-ascii?Q?i64aiitB0N+6Syw5cVSBJ+1ERi2osRewmbs6Bwoo+hRC2PJS6GXibn14x9a0?= =?us-ascii?Q?HEpOkIz9WVteB0phQf2Cq+Rci7Y/r716w7tZdW0lohM5llvLtpGSySaF1WaZ?= =?us-ascii?Q?/do82sVekUhWOM7RR7FndNMvkE4EcQ8kjkp7X4TgkeLoKDZMOsoQxVEo3aS6?= =?us-ascii?Q?8z9aszkyWofr4ptQ1V7B1gwbn80gf8hLY/mC4SsXFQyCSF2ABjcixSXlnLro?= =?us-ascii?Q?7DtbKjWA0BkXEUea10Fg2IeUERVzmmvLJLEC+0Qb0Gc38nh7vUSQkOigMZTr?= =?us-ascii?Q?DsltCigLuTPANymEzCH0x+Ob7eWRhFPnc7X15gOh9Gf30TeiPY7Y4rtmsQxS?= =?us-ascii?Q?og=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d8a302f9-faf2-4b8f-3d11-08dc8faa14c9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 15:19:43.7178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NUHJYU4wQ+4M5FZEvKFx0rdxI0bS48bUYtgQ9UeXLaZ9g0/Sr5UXfMFewk9YJ+PreFE9TXQHF9ON2yljF9NwnrUA6zn6Avq1dgDAwEIVI+Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6398 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:00:51PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Replace enum ice_status with int. Also replcae ICE_SUCCESS instances with 0. > > Signed-off-by: Przemek Kitszel > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_common.c | 12 ++-- > drivers/net/ice/base/ice_ptp_hw.c | 93 +++++++++++++++---------------- > drivers/net/ice/base/ice_ptp_hw.h | 20 +++---- > drivers/net/ice/base/ice_switch.c | 20 +++---- > 4 files changed, 71 insertions(+), 74 deletions(-) > This looks a duplicate of patch 1 of the series. Rather than having two patches removing ice_status, can all instances be removed in patch 1, and then avoid adding new ones in subsequent patches. This will also remove the previously flagged build errors due to type mismatches of int vs enum. One suggestion might be to rename "enum ice_status" to e.g."enum ice_status__" as part of patch one, meaning any subsequent use of it as a type will trigger a build error, while still allowing use of the individual values from it. WDYT? /Bruce