From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAEEB454AA; Wed, 19 Jun 2024 16:42:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C200840291; Wed, 19 Jun 2024 16:42:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 33A4040289 for ; Wed, 19 Jun 2024 16:42:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718808157; x=1750344157; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9hwLcdkUX6hZFMpi1fwm3Tgb/o6p/Nqa2oLt5STOeJA=; b=W2qVS2JV5mwEntPdmswX9f+NgAGSm8LluqEHdwIO0uJey5YdC8+9Qd4P CwZPh2usPpFXP39ZTl5QSIxMOwF9FM2kVlQ3EL2l18cKL1mw2fRPqzMmD J/1VENuE9qljfj40xQHSQXBvzedZWMW9R/xsN1NQG2oRbM/fiwAKRaJd5 E9kD8PpAvQGiHrh7yM/d6oa8Po0QYFQDd65g0Ac1ZUvc6NcRekn0A7Xuy IhyQDINVeMZeu/NNl+pAEGH8HrnYS6oHhg2uzDXLhGoaiTJnqixfkm8vT bhrapONHnkhlq+OcjzyxQQ/0Ky/kv6nEu1IhQteDtPb2RNFeQEDXw3ZaX w==; X-CSE-ConnectionGUID: h1NoRcRfRAKLrJeEHfb/6A== X-CSE-MsgGUID: OHN7ldYeR6uMKrA9jNmgsA== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15464747" X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="15464747" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 07:42:36 -0700 X-CSE-ConnectionGUID: R2R1HXALQsW3m0wOSVXbOQ== X-CSE-MsgGUID: 5jfRWU8nSOCowv71wqDz2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="41796825" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jun 2024 07:42:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Jun 2024 07:42:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 19 Jun 2024 07:42:35 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 19 Jun 2024 07:42:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VLUc5dlTu5I+wLjwYoGwr4pg2Ms/NYM/0L2/QWEV1i9cEdzoEu+AEwtuYNk5mv0XHTpeLBycWI3zPo2WRAOnMHmXLM+Z2TdQ7nM5o1/FpfDjX2+fTD4K8CglK6b6l+cR6/hUx70L1QXzE+l0TKW218VswnL33VCTsFibo4LLk1VsAz8NC/GybynkalpXiD0e1DI5sAdL6rlXL2+R4ctGSGpqIuqVCsIzVJtROJ7zMsw3ctljhzTd34LQirfQsdmcgn5pZT/uQQ+BWqhcQ64R/K3qp2/xbLCiJlfLB8UTlGWRtsdz2sjsbqolFNO7yGXlCsy0EJdsf3jqrOTc4FLytw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PI3mceLGbNr5LhhuPzx7KdYQH6YrhHn+zxRtYA8qSNU=; b=PADIsbIU9bhZtqaJhMQTKeWjwg35ntAcH8jAKh2jyvx0KOSTk+I30I7IxxZC/f6So9q1z9tV2fLOni1r2ZQJx4wZzCaq9hDiXKRf7ZTSaoGoKKyNSsOaKHMMOGHtWXFecg+vniucumHniML3HmvOZx6zWNvUPp6AG2ZRrlaEl/W0aVxiVfW4HU5/L4ipm9pbY0a0g6iFU/AsD8g9tdJ7bYbyfbABc7Cww2ISXMZQxxPYTfMUFDBNTy2IuyuIsKUrZd5LhSxJKhH9Y0vu3r5y9KcV/faHkiuRcr9JsCesil0XEM3ZE4h3HGWB20Gub71lyLJ3AaNA6vj4jF69loDWLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB6922.namprd11.prod.outlook.com (2603:10b6:806:2a9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Wed, 19 Jun 2024 14:42:33 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.017; Wed, 19 Jun 2024 14:42:33 +0000 Date: Wed, 19 Jun 2024 15:42:28 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes , Siddaraju DH Subject: Re: [PATCH v2 004/148] net/ice/base: update phy config during link restart Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR04CA0027.eurprd04.prod.outlook.com (2603:10a6:10:110::37) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB6922:EE_ X-MS-Office365-Filtering-Correlation-Id: b1d00952-6076-45f8-6a0d-08dc906e0da5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|366013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9qxoxT9H/AUMMTOEu9gFQ3CqKKqRC6u7Pzm57fcdKHL8nFMAF8B91j6FcBHo?= =?us-ascii?Q?ad8kBinLpahJ12XbtV1ZClmgvInfx6CWIhs0AE4UTlnYNgi67P+uPcE2e6eh?= =?us-ascii?Q?XI0GRv0LVgJePv4XCwL6GEuTldEzwgzeS1vj+48jOW0K0zRliHnelPxSCqC7?= =?us-ascii?Q?BnH64WHZNAFMTSLqb12L6ULCyEf6hbbS+mSKNPpKBADqw2pH3Ucg+faV0ysQ?= =?us-ascii?Q?zyLuWY+rSiz3fJZP6T2O2TqCcDgQyNJhHZSsdA1Zbba1WGnrY80YNqdCF6L5?= =?us-ascii?Q?Zjxko0R965njKkA3wLKpXYOCjqo9eqzgBEwvCb0sUdp/rtZefnmqif/kkiwj?= =?us-ascii?Q?GCOP+oYchPNihVwZJJZvNqzQNx4xgReORE3cSycPD9qJm22B1AmZrVVNMY7k?= =?us-ascii?Q?fbMrLRjCX7b9zQNa6qQoX/dWUnmVw7PyP0VwAXUZbj36fBCIBRWCCZ0a8pQG?= =?us-ascii?Q?ddrfO+xXJVrfAgy328cJF0c+fMhGqamIYtVhXrJKkIkkifOvbWOq6S3mOu9K?= =?us-ascii?Q?uYf4yGLaVoYanIYNdpSVXjorpRv4KJ1QWjRzNJnf0TsWYxe1ftPiTK1q37SH?= =?us-ascii?Q?JAL9J0AtN2GI/Z4wDDqy+sojrkYZSQK00sKG3evz0k+sERtcugGDtw15bvId?= =?us-ascii?Q?9vA4Y8ymDyJgXZFQXw1kOLqwVIkzajwx6YW0wLkDrut92ijZI84+lTrqEhGN?= =?us-ascii?Q?Nr9I9VKHkWFNd++6ewNwU96l4n05vBlv7dpTYTwmbCU7hfKvyn0LdKavDGyh?= =?us-ascii?Q?iNaCXoO6U2qDcknS//o7pJ8nWfTOOsiOnLzd9jM104D0hbYmXQlHmCIZSaAY?= =?us-ascii?Q?vb3hSgm2FWShcKtyAatBuQyYCxLFwW09uxVrN/l+B3Mt1k3AnylQB8LLmSmU?= =?us-ascii?Q?lH5UmueyGnKVXJtk2RqHRF7b7aHGmpChrv6tlYrw6sTeClgxMsNdM0pcV9yg?= =?us-ascii?Q?nRqvIpBt6xkTenA89IjR8SayobA051RZKkfmRjtJ500XsImf6mSw70q26my8?= =?us-ascii?Q?1ycgki9OuSKFBdRmFbxbO//tQ4fpyP5xt1VGs3TjYhMPHSsZAW5lWMmRXRi9?= =?us-ascii?Q?5SmYIdX4YQGZBLxD122sRUjKSE0CawhimQQnh60dPZu1Q2KtnW0Wgswhv0ur?= =?us-ascii?Q?IlEUptLnAZPODsDiu+vba8Ikh053Jd89tGyY2Vt8HiCTNB0VyUpcgusMDM+/?= =?us-ascii?Q?alLzccE+Q6zhte7+Vd0re+sNxYsRw5BCy/JTY3P768Q2umpsa5AJ4iKqtQ/N?= =?us-ascii?Q?Rq+jKnMuzK/FbNtEE3y+MahpA+Z+ESGyCEqMhHcltcGn6M4sRv5I0SWIYsPX?= =?us-ascii?Q?oJ9puMZQdZwPPQFVHohhCmR5?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(1800799021)(366013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XQ4alh5p52BO3A1d+LVJxlwgb2j4jKmh6oRfdeapI7dZiixZ+UCIW5+DRdHn?= =?us-ascii?Q?+QpB69M8pCw5aQnu1YoSpkwvL0r0gl1+xigOzqYo3gCxj4ErgGsm/Jc4+dsc?= =?us-ascii?Q?x6LRKavaTZxyUw+r5SzNFZgvPWRMzZ9lRzk/jCCQ3wJJKAlKdie9lCBAnCeT?= =?us-ascii?Q?Y6qDVfMqaFimFbKW+kN/335VrfrCSjgyqtGIsdBOj2kt+d4v4sUwUbD54Qe8?= =?us-ascii?Q?PXJfu+OIaxmD361GDT6+8jf3qx7DQsv7uQvac06rLLE9qLWyY9FV3wPBP7VC?= =?us-ascii?Q?XwQo28KsBYlxpbxfRiOw6t5/F6ioksL9NILYvKGoGKwvd+ibSYCW7MQPb/Ip?= =?us-ascii?Q?9dlmX3kt2r5x2RKaqOeZuOr2BF5tFhJu/WGXMZQe0gtrggMheYWrf7isKwa5?= =?us-ascii?Q?nH7FbKneoV81EGuMN7dVfwlM74XB2U0KIYO72wty0fa0iMuj86bk7A5JA2ve?= =?us-ascii?Q?lRRsKCQO0oSa6zJHsAoumlm1sDljOj7n9kL59ACyVh725Vy4daEYySupG7Lk?= =?us-ascii?Q?IPlnOY5lYkEQ++ibgcBTzh9HRIF8li2hyuuGdekTSBbakVv40sQ6kYjhmb4z?= =?us-ascii?Q?wQdCQQv9yoM6U+vZUK4NwDlgD7PCdue8VuAsJW+Ao0i8xOpaf6oUQgYW+Uos?= =?us-ascii?Q?3wo1o69zz6qSrPIoIrz3srLOCMjgg5JRFhitbQ6mMyuEzhCZAWBd0aDd6Qf4?= =?us-ascii?Q?w8E/5Dd3Uk1kErYUXFRhFzOneiVi4kA8VdGIJzKZKDSuW+I9PUIwrotCnwrF?= =?us-ascii?Q?8MtEIt2YvL6NZuEr922HFJdbIWo1zLBW3c2RiG80SYEhs6FsbZks0XSoplQV?= =?us-ascii?Q?wA8w+tX5Xx/Wzuo+KbXBnpIPDp50F/DIba2zaH5K15fpVG9RK4LSe4QsHp9Z?= =?us-ascii?Q?XwokktdW8aR6UbGD/abjc+5qUAE7WKSoOrUNddMOcjGocUuVelJzHPprpR/M?= =?us-ascii?Q?HUmkxTQCx8+aCEsC2TlhHzT77TwSBVVpAA6QPGsL3rkYkiDe4odt6iGN2Fw/?= =?us-ascii?Q?EOB8VQgNiEWNrN5Iy6OOK3MigzmwD3QYKEtAYt6ncF12pNrGjP/GYr/khysA?= =?us-ascii?Q?+SHLn0+vZBDD89M8W792JgnWpsGECz+Tl8XrHpHJ1frmhXxB4Wi8Xl7/UY+n?= =?us-ascii?Q?zQxHumBueceTxscIvKw/yEw+x6jAPJoebkMCLUwY47KOCAQO17Auk3EjDzos?= =?us-ascii?Q?yf4xHgrcpS2KBY26BvBsuRAN2WHsy7v9B5HqusnStUozsjwqySpSTICBu4S5?= =?us-ascii?Q?NE1DNumEjL0mmh7fgdnQSuYWWRtCchLOK/9LO8D8rBSEeB8inMsJd5mO3mMO?= =?us-ascii?Q?VWUSgMdAazxbQDf4imv869kQsYRSK6H5/CF/0OhFgWFmBon+ELsS/Y6oKht3?= =?us-ascii?Q?yjQBBP8w5friToqyhprfU/KIMH3IWTG4PbEwaeXS3sFKWIwxndQiEdPt4WIE?= =?us-ascii?Q?6lMIjF3f+YO3tZwzrdxTIY39z7FyHTDHSDSANgzxidlIQprwDYc3LJLTH8Qh?= =?us-ascii?Q?rHvd892koRcUC38cO2xdi+KW5+fIrApPw9q0kPpaFyhL7dD5dZuPYtNTsN2d?= =?us-ascii?Q?1x8dyA9xvqNaDlnhsMQjdnEYKL+RcFwC/Cj2qLBTPlf44+Nt0QLcUjtf8s64?= =?us-ascii?Q?iw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b1d00952-6076-45f8-6a0d-08dc906e0da5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2024 14:42:33.1937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H/vwc8L+rLOM6NPvAxwY1mRUrU3vKKIze/d/m2teRZIv46SY4ATVHtMO0Hi28Nue+OKtwcD1BJ0FL1Wxm7XWZF9u8cS+1/Ixvouzp5onIxk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6922 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 03:59:58PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Update en_link in curr_user_phy_cfg.caps on successful execution of > set_link_restart_an operation. > > Signed-off-by: Siddaraju DH > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_common.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c > index 2eb3084dac..1d666b7708 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -3966,6 +3966,7 @@ int > ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link, > struct ice_sq_cd *cd) > { > + enum ice_status status = ICE_ERR_AQ_ERROR; Here is the first re-introduction of ice_status, AFAIK. Is it feasible to avoid re-introducing and then later re-doing the conversion of it to int? > struct ice_aqc_restart_an *cmd; > struct ice_aq_desc desc; > > @@ -3980,7 +3981,16 @@ ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link, > else > cmd->cmd_flags &= ~ICE_AQC_RESTART_AN_LINK_ENABLE; > > - return ice_aq_send_cmd(pi->hw, &desc, NULL, 0, cd); > + status = ice_aq_send_cmd(pi->hw, &desc, NULL, 0, cd); > + if (status) > + return status; > + > + if (ena_link) > + pi->phy.curr_user_phy_cfg.caps |= ICE_AQC_PHY_EN_LINK; > + else > + pi->phy.curr_user_phy_cfg.caps &= ~ICE_AQC_PHY_EN_LINK; > + > + return ICE_SUCCESS; > } > > /** > -- > 2.43.0 >