From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 830C5454AA; Wed, 19 Jun 2024 16:55:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72B1742708; Wed, 19 Jun 2024 16:55:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 534BD41149 for ; Wed, 19 Jun 2024 16:55:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718808922; x=1750344922; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=oVt3Wkp2T/By7ALOaUSfopJorg1mQu7gfzpWFyxRQPI=; b=gAnlXF3geX+k29spVE3WYFXJM9iRfiDmpej6YGz2Lqzb73x3SoMy79j2 Pedq9Q2KF5x7k048o4VVJ29ClBql2bcUYoHhqgw5/qdkNKq8UKldMhaPR UZsplVSQvwGWHVtnaVbHm8IBAYF1jsZOpJObBZAbRRTXdsJjBDZz5MMCX T+02qqT1mu42fle68K/PYXkrkOf+JQ9wfJv6cgN2XO1e/tEWBZ69pnQCS Jkb/HRASfVYgQeZf5qyhsZRKkVzBBs6qMLm9hrlCQm+RVrSHKVpe3Ce4x 7IQiKAd+h8lNwdjiK3pu+Tmuc17M65pRdfcwDowU0pVfcNtPkf9nKZh3l w==; X-CSE-ConnectionGUID: rLHgFEIWR2qA6LugSv7u9Q== X-CSE-MsgGUID: 0++vNrqWQhmxndkB0yoVCg== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="26345103" X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="26345103" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 07:55:21 -0700 X-CSE-ConnectionGUID: hFFwrBXNS9i9vhdN865XPw== X-CSE-MsgGUID: gVJl4LcmTYSdZP3/G4HqMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="47086405" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jun 2024 07:55:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Jun 2024 07:55:21 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 19 Jun 2024 07:55:21 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 19 Jun 2024 07:55:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yr3Hq+X/Cv9chMD6X7hXwnfFfXq4CmYhw52n71pcj3Vog9uGGMVmHvTt5Hjb/gO9day3LChSPIfKKODWKWIuzcmL0qQfYAytdtXXCaodTTAehBRlyEUlggWIPVs3KJYnP3s8Qiw6BeZxhjz76wZtJxLb7UNP3idN8Wb96H7WzXDO3RyiEl3zzErJikx0Dw1jY445rxqlYW6VrLCuZ+bQVGEo4/WIO8K+GeHU18CP1PXwk058MAIp+jPN0eE4sPK1mhOQMTKH4MYVDYeToasq3g+N7PUIYbRkVaFipfKRtZ+hhGq7xs6pBWHbKwdqcc8jegXKE7fk4rbPbK2HXOuzjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ymhjIm/DDA/eQdy3vMhV151WjQZE5TMf27+HPwcV+nY=; b=Zqw+x8gvKA8Y1BJ0uoAdLjaNb8j+yAO7FUtWXrPbwBJGCgSxqjQoOc2GKYzf02n1JWxBTy1MDl0Up8Ye73fflMDmp3y+hn98hXQ0ElcxzZgvujIfMfbBk7o2p1aAFTPpAnpd8nq8MAxn9QOvOQT6CRZmaU5sONoTXjddvEahoo5eRHQuOOMQQbLjGtm+GzxRHNDFaWqpnbWJDA9NuP8Z7cln77rODg48D5ObEEMuVl3L3RYbWnjtko+IdGkIspg+eyyWctJcNjvKDdpTkLHvcYOfJCA1EJ3hCyfxst2gqGNJYNxg7sXHRSRflS+i91zoEm+qRLgTMjsbhevE6/J7WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7830.namprd11.prod.outlook.com (2603:10b6:8:f2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Wed, 19 Jun 2024 14:55:11 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.017; Wed, 19 Jun 2024 14:55:11 +0000 Date: Wed, 19 Jun 2024 15:55:06 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes Subject: Re: [PATCH v2 012/148] net/ice/base: clean up __ice_aq_get_set_rss_lut() Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU7PR01CA0045.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7830:EE_ X-MS-Office365-Filtering-Correlation-Id: 69c3f632-0282-4bf4-8dff-08dc906fd19c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|366013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8LOEK+VgeIYYXizY7BHYjL+8oYRDrl0EgoIbYa2jx0vjq6qbY2ncMacyfFA3?= =?us-ascii?Q?sttuIk6ZdvIEkcU+s4ot6mKhowCTv+gJQIDoV4iXaKLka/NQxirB564W1fRL?= =?us-ascii?Q?DK5hU23K/7VK4q05OW6zHlEs6EuMAZ5c4waodxddiRoKdqW1oTtGoGR5oKX1?= =?us-ascii?Q?uJxizvwHwF2tM+64HaTCiMIGgMrjAttZKj+hgs7IoBDEUlJOfVL2/xCim4Iu?= =?us-ascii?Q?K33zcUtSAl3Cmtdg2s2ltmWshrUkkC63C1wvk/BY7lJzXDvmnRmHyqRBdEJZ?= =?us-ascii?Q?pBfoTu24vXPcqUBHm0/PCoFukDBatj9bIoCes8uHp7HN9tAP3/9xXsDI7GYJ?= =?us-ascii?Q?kuJ+6kVK1oXdGuT8z+hj6swAy7GY3OQBHgeKlGsOoRoC7RY+94vxwuNrXMAb?= =?us-ascii?Q?Y28LmXhEY+N09jFtQIVq8ca5c755GwuuVpX7hk7DdfruUr5TQyRvKTtlQQNg?= =?us-ascii?Q?M2V1Xpt35ou1RkkHX1rU5vJ1Ykl7NyLkMKYH16xMsa2EkwtFCVzPmnJOOaZf?= =?us-ascii?Q?Clag9Y/jKOYGLb1pqTFfVLMTsbZ5JXjj9GijW0q0R3DCS3L4dkIj2o+UPCP3?= =?us-ascii?Q?PqBh/7oraqJtbRmPU9L9YCCodL2QgPFdiINmaIfPypFh4x9OxplXkRC7C1UB?= =?us-ascii?Q?b50PVTqIA0II4so9kBAvmaNa+wTsWTRtNhUwU9rfztwnjK+8nVnj0XrSjyKF?= =?us-ascii?Q?blt81SVDig2zOWjpvXXokqvnGGHzfngNDs4iiAoynbY3bWvR8VvPIQHQIIgV?= =?us-ascii?Q?E3YjUquLk6EyKLgUQtsquFzYV0g43/6chE1RN/bQLX9clkJmbwrambsq3vgn?= =?us-ascii?Q?HVRPznhDCq7AruJhazrrqAYNNzC5zetq+keYkWgv3Pp2s8eljutOLjLtysun?= =?us-ascii?Q?ljzEQojcURlIspaotqMiu4gcqmABK3DFD4/+fLg0QETXdossuucajWZ2KClk?= =?us-ascii?Q?ruqZAIhEzuHV8IkZPTZyIzS6hMkrtugw4HjsCooyCDCx71uDObUdMPXqh3vd?= =?us-ascii?Q?nke1DpSsoOwEpt7b0zaniKF3Yru5YQhIS0+X5uM5jAuqml32MnrrPjyA3y+l?= =?us-ascii?Q?J47aC0nmVuagOZ7pp4cugeNn5v30Qnip8DmUiGM4bcu3nxTWG2PIe35MzJD4?= =?us-ascii?Q?AfzvXSTknrNPs+jtrspueE3RU4c7yXNUyjFR04F+BYTzcB6wzhGA+zhxR44L?= =?us-ascii?Q?H0NdBohPVlbBr/+p2yddaaUnMzPWmgBCuRcEe7632UZ/+PbEXiMxL2t41miD?= =?us-ascii?Q?RTRj6y4RXRUhnP1AsgVQpF6RYLqn5pCjsZW18Xd/Mxrr68YA7eHk4Jv2O93w?= =?us-ascii?Q?21WmVr2DtnR9I5lWnM/sRzaH?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(1800799021)(366013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FZ/O8sS6FvQkUPFjAGuYHbK9UpNBwWc4CJMhGTRsPz33iWmIkdnO2m+CLmah?= =?us-ascii?Q?2tnfhRotZkyinb/83F6JHti8mGnVqQpfbW3D9VKRcDCyM6vnPJ9Xxog334D3?= =?us-ascii?Q?r1WKx7X6qyoh97IoDuAwffoQTwTQwPBYrQeKr2K1L3ofSLACj3sQkRJEVp/l?= =?us-ascii?Q?4mN8BeOWHW13YY7DvgcHpcQLe/6M4aQUhcjyWkZ31TuT9KbwMCFnH7UNSXBm?= =?us-ascii?Q?bcEMIGtXyPfALIPoUaA4XB9292PJ4sfOiWLih3V6eV2HHJGe1VkNXCzOysNq?= =?us-ascii?Q?Jbr3JKla2rME+U8xlzWn8vjfEy82ywCdBny801z6onIxQ2RsiDbw8oURxyzj?= =?us-ascii?Q?g1MFSZ+IU0g413rkrVMo0qmnVtBDbSsro3DQtoNvNk2G+dl+mU1BhumOrXiB?= =?us-ascii?Q?dslnvb2sZJcKWrKsirLr0GZ97abxJwdE1hwGXqeX4eYTZLjG8Z1urjfwfDGZ?= =?us-ascii?Q?ti0NXiayR9G/S8s/R7X/WFNLLB9ESSoS3uOU8o8vChEYYXndg6pqQgvl0GVO?= =?us-ascii?Q?FllA63/FcJSna35XVTa6i+2RZIxx61ZhUi9h8H/jmf/ot/JsWX0oMrQec/UV?= =?us-ascii?Q?dTIDrX9eb82mcYBYTooD/ks16lFFGp71xCwna4F8MQ66sNM9heYOirGVUEdC?= =?us-ascii?Q?mtsloA2lcugLM3FyfRczqpcDZ6Ca3bS32o9xzOYGNgGJrB83+muyFW/C7s85?= =?us-ascii?Q?yNEq5tL9O/0XZcnBlyj1TWxvVNHWTGazoTcNrf9FejsHIV8oujKDUC1wRb/t?= =?us-ascii?Q?NrHlMpya9cI/q2VM8LBjK4GJ0JcbRqbEDSt0j049AuBiiiNKOB1Nb5ixkK+/?= =?us-ascii?Q?Y/ZD4lMEaiRfpoJVOQkuW1pubjc+P5uhI0DVy5Jn3PBddyHN/f7ODbAwBXlt?= =?us-ascii?Q?Q3pnjj8yphUQF/kQQlgB1SNeLH0oF/+Gw3zcAYiSNREN/9dyQHCP5Hcu38o3?= =?us-ascii?Q?gBbzypSNyH7lLLkvPMPA+OkFTqTL9ICZ391sI7ebQBfz8XDb2uavzABYEuyH?= =?us-ascii?Q?QH+JNBBK87JjQ0BPYil5a+wNMNN8Od+6hXBK7rEypJQ0xr037eXV8OtHE1Q7?= =?us-ascii?Q?o8c5A5rehysvCAC83E4TFK2EO/TF7odtuoIqauHmiZVqdfWxq21QfPbbJDap?= =?us-ascii?Q?GJ2TrdoakctK2+txVmWOG+VrOfCeqHywdJ6w/PKvZ41/7xNMVnrw1EVAFrP9?= =?us-ascii?Q?yFdPTbd4FUbr8WOEEwlVd3FI4dKCynn5NDJZL/rK/3/2gsNPsYlud9JH8obg?= =?us-ascii?Q?eYqDhZ8qhoIUaAAahZAxZbsa6usmjCD63cng6ATYhMzDYSZZuilaCEizzJPE?= =?us-ascii?Q?olOsKrbSAwF5sVTW2L9ZIakU6HXv4iI1DrfGtsc8o9QNHrSFRH68GL8cOL4/?= =?us-ascii?Q?CYsiDuH05M2CfGJ1NlUpRlDKsZQOVhi5uRZXKuaFDKA3p4+XqINf7LVLVBlj?= =?us-ascii?Q?qQtzdbyGtmD1oT6btAQuEaV1ijUOEOTSp8JS7zfVt0/ahc4OlnP6qS1rAqiF?= =?us-ascii?Q?xbdPceyG1yLnC3Q7cuYLKXOdyEcjCvUIKrT5Uo3YN2wFRiWmNrc1Ue+bhKx/?= =?us-ascii?Q?n9hEXlUHKzIQS1lBYS7hrKX6Bj6lvDJf/yKlTNtFTiMrKsrX/aAy4FtyxPdD?= =?us-ascii?Q?nA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 69c3f632-0282-4bf4-8dff-08dc906fd19c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2024 14:55:11.3200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a5y7D7ROydh1pfvAIuzp+vrPPrxBYP3+Ko10mRjmPPEz7J00XNLJ+2gIBRV600/j1R+kN2wDtlm42vIOmxLQzKTgWll24sfn9qRasmOUqys= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7830 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Avoid use of function names in title. This could be "improve RSS LUT function", perhaps? On Wed, Jun 12, 2024 at 04:00:06PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Refactor __ice_aq_get_set_rss_lut(): > get: > - make use params->lut_size only as a size of params->lut; > - return LUT size via params->lut_size; > set: > - remove option to set RSS LUT smaller than available > (eg forbid PF LUT sized 512); > both: > - clean up code. > > Signed-off-by: Przemek Kitszel > Signed-off-by: Ian Stokes > ---