From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6B0FF4549E;
Thu, 20 Jun 2024 12:31:56 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E749940612;
Thu, 20 Jun 2024 12:31:55 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12])
by mails.dpdk.org (Postfix) with ESMTP id A0A8B402D0
for <dev@dpdk.org>; Thu, 20 Jun 2024 12:29:03 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1718879344; x=1750415344;
h=date:from:to:cc:subject:message-id:references:
in-reply-to:mime-version;
bh=X1fdW4GU4yosfbBWLWuaUdfHlUmbbT8wk4q0S6gSlM4=;
b=abhmM99ylR+jQwegNlCgPb4ssagSYLNng8qlB/o2Blkb9ewJowW47z2K
8fPyLS4u1ljm90DzmtuunTpPaHTBu3eUK6jaKs8SajcK4OEcIf7pG6zoU
knGO2ct6KhtGLR86q5STE5ZR9mAspa72eUtXW4G7LIfSgLFLFheZb98p4
XDn1PFsAGG4DO1BSfJrGVVOz0pz1+/znzywdWbM2gjA93c/V/GmwMzEs4
7ZvyqjodYl+tAbkAt2BQKNRQbNCXf6su1QSJSYLV7iaxm+nwdUbSUUds4
R1553fg1/Tzt6PgQn6GShuZHxkYZXn9zl3DuNAeM79qpq/5bq0Pb/s1Sx w==;
X-CSE-ConnectionGUID: ALqpL2QtT/mo6VsqSIemOA==
X-CSE-MsgGUID: XpyUWLcCTU6bJxiFGr0cpw==
X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="27267544"
X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="27267544"
Received: from fmviesa001.fm.intel.com ([10.60.135.141])
by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
20 Jun 2024 03:28:55 -0700
X-CSE-ConnectionGUID: vyS8IpWWRbSLoxk3e4fz8A==
X-CSE-MsgGUID: bgXN/QD4R32nKES+FUwGjA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="73406027"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
20 Jun 2024 03:28:54 -0700
Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39; Thu, 20 Jun 2024 03:28:53 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39 via Frontend Transport; Thu, 20 Jun 2024 03:28:53 -0700
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100)
by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.39; Thu, 20 Jun 2024 03:28:53 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=OxAx1L/LzyOv9OLSqV7LBHafS8+wtEtTu/N5zJ2nsAW/Z7YT0pivDvSDwUm+oV3lEK0VC1VoOTJ4UUS0KXt4kNLRmZtLtxOHiIW67sYtmSw67rRU80h21lmIFCv6Bs8JhdzVpe8dSsORqbiwm4KkP5tLwt2GPt4ajnCWTqFdIilg7iPorm6D/GS1XqCBkd/O50M6/bhRiAx9Xe6Wn0ag0i+8WMXagHTRvXA165n4xf+d12XU7UZvL5erMLS+KUrzDTp1iVd8VjpwtwpEuGkivnRmSURznRpiORLMWO/X6K2YEFqw1OdxCL0rukixuhMXyEjl54lAFLB1PoJRCLco0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=6WdmsPjeCNFDgTgcmT/lLp0pcFGHN3bAYG12TqKTQ1Q=;
b=iDJJnQ1HDVEthxhTa8f9h2IR3FypTO7gLsXV/NGCBg67Yc0WINcMQtlLeO6302YIgsuncPKFtQXz1z3L133k2zeiP2yDPd+zCvjSOZaxS47OByWaasHSqHAMvMH2unp9vBS2KCc2RyY9S91/QLDFZbcVFMtUeVbLMb1igy2vH7EYiLGSJ/NjxrXrnwiF2wIh2VyWnfHphyqK5hQseM1jdDzrWmz22c2hF++pj0d996Q5wcBZ02zzb3xhVzjcdtCpTevwXS90XwNrU2oCRW29RfrPOL2N7GMwoVj8vjDn+vSCv6AYbycnDNlV7FEITB6DudLhRGWZ1xq82VWY8HBu5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17)
by CY8PR11MB6842.namprd11.prod.outlook.com (2603:10b6:930:61::11) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Thu, 20 Jun
2024 10:28:51 +0000
Received: from DS0PR11MB7309.namprd11.prod.outlook.com
([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com
([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.017; Thu, 20 Jun 2024
10:28:51 +0000
Date: Thu, 20 Jun 2024 11:28:45 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
CC: <dev@dpdk.org>, Ian Stokes <ian.stokes@intel.com>
Subject: Re: [PATCH v2 037/148] net/ice/base: fix NVM feature check
Message-ID: <ZnQEXeDy_DcVlN87@bricha3-mobl1.ger.corp.intel.com>
References: <20240430154014.1026-1-ian.stokes@intel.com>
<cover.1718204528.git.anatoly.burakov@intel.com>
<d8391090af88ac37f2b18ae189492b8a934bcdf1.1718204528.git.anatoly.burakov@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d8391090af88ac37f2b18ae189492b8a934bcdf1.1718204528.git.anatoly.burakov@intel.com>
X-ClientProxiedBy: DU7P195CA0016.EURP195.PROD.OUTLOOK.COM
(2603:10a6:10:54d::23) To DS0PR11MB7309.namprd11.prod.outlook.com
(2603:10b6:8:13e::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB6842:EE_
X-MS-Office365-Filtering-Correlation-Id: 969db825-5d52-4dee-7bd7-08dc9113c760
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|1800799021|376011;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?OmHx+hnemclmy3+JDW/275eCgPSc3tTaHjavb9nWGhj4QZKj09m/pYccDwyj?=
=?us-ascii?Q?/orEtZNUIC14kQIGqf8z+zFhifCMyZ/QWEHMlG+iwa4ijp5EHhV5/QufRJ4L?=
=?us-ascii?Q?kKjnpaPwm8N1TdXG8Akt0JorVsDJc1Sa6vctyqZLZhjNn4GvQbMy/G7c3+FN?=
=?us-ascii?Q?Fx2L9e2vQEgtewdS7QbyegUTh+WWGDMfGHAYEX7RqfMakqdU47kvgR84/uhL?=
=?us-ascii?Q?d2YQ+NjA1ZKqL+18Xmo5aoylwK7LM8/xrdTq35191KDktSH0RXCrlCZ9301Y?=
=?us-ascii?Q?4D8dzTKm8hkd12UJ3iJkia/Igan8NueuS4CMBZHhCA4Q04WkuMgmx78fVEkl?=
=?us-ascii?Q?+Rv67NwHM9dGy9jZODZ1VDlbfmJFaZkh/ljG1STsLiGTK/TGzzUvh2jR2UxW?=
=?us-ascii?Q?MtcA3qe0j8P/t8DLJk2jdekpUXCC7uIt9ESNwrzdIjSQGerW0kU+eoir9wkp?=
=?us-ascii?Q?wJVQ1Nq968p6iHFO8JqSQCDQXsulS2UfGCtDxpA1UHb/M2P1FIaHxosc9MS1?=
=?us-ascii?Q?k8cjf4DfKfNo7dqjr7EN7wR1YGSvf80pxGXJRf4H5g49ARwcFHxHdv2m7OBg?=
=?us-ascii?Q?gKItrRLYq4PiZUxYNiBvmswbwIA2m/AXkGoBVcIeNtCLXe12tNclJOPpm6tI?=
=?us-ascii?Q?5ieprpa/4FkxD1U7WiQ5932W5rCHU+gEBPt/tn6MzWm63jYCncbOQ+xuYjtQ?=
=?us-ascii?Q?HrHMZUgpV4HCBPNIOCDz3s2nc3NbUNVlzvm6TQVo6bzD/45X3SMHHjSJ8z/W?=
=?us-ascii?Q?elCzpMBGnn440hzuZj5WEFgT1zh1yfESmFZhDbVlEgJnh63C9xupDPr0kY11?=
=?us-ascii?Q?bsgC3GesxE+kRQLtGfOBhsnZ0GUIx2EpOf4zIq8J/wuSmoL7SOpe3rJC4OPL?=
=?us-ascii?Q?2fRZAZ4ii7vE8sU9q8wbGSFMb4obrYDpU69GPdZPIno1X8ZrF5UnbF7f0zvM?=
=?us-ascii?Q?nAev7rL4w1mI7tJSq6jGfj/hT3WphNScNcBUK0toPKOgn+EqYaybA5GFgsjO?=
=?us-ascii?Q?Z11PP35rw+ywqXn+0FNJA5zpeJWBR6XtBD1eD/4o+KNblzCSzQYrPNpvDz7/?=
=?us-ascii?Q?x3uBAKQgOemgLHaFfll2aZcouozYYtkHJrsV7uy4J4q0m+XrCs6/8dGihAVU?=
=?us-ascii?Q?H+gFM4R7PuoKIJZN1sBac3cLpK+q1uxd6YJ5DW2iXL2IVzkCnhcQz76nWLTK?=
=?us-ascii?Q?LvpQtAjHxZZuidpLmuF3kHUskKdyKwAuzip6Pr5lZKMaH24PEvYXN8m4S9i0?=
=?us-ascii?Q?9ly0xO2JZWBkPHl734xdidveoALxCcGWGmkYrP1KWUA6n98ZDsb2cDy1kGY0?=
=?us-ascii?Q?kW5eqzyPULD5lGYbn5R+CbL1?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230037)(366013)(1800799021)(376011); DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cxQN8PPuyYM4DrCdJJBSkActLIMb78vMzV8fh7X/xMLPADBTtGZmVmfy7s3c?=
=?us-ascii?Q?LqLr+WxnmIIvKU4yMIe/mXFfCvcJoctEwm++FlVdRkR/SFzhhOSP5claXtyA?=
=?us-ascii?Q?WnlqUfos2ddb1BN29V9LzPVIReT/rN7q4raO+BJF0MZkt6cXebwI5F3ZP9tn?=
=?us-ascii?Q?rh1nJL0M+6inEWxiMbM63V1ECyOJmThm4GQKDUxf3Av/Zi7nzAq8vYYlmG/l?=
=?us-ascii?Q?xJtLiqo8kzPNL9H9C73cLsXyiodXYX1o0xu8FBBKx2SWi/27vPqkGK3QfyGx?=
=?us-ascii?Q?C6wUu2p0X+4rJDur3SaBJtQA62EPlIVaaurpKoA47Yhx9XPqct6/ZVRaOkhR?=
=?us-ascii?Q?xNmsN9z/uxN1Wzkl7jtj1XvT0BOEcquXQ1rXJBSeWXP/jDg1xO9Uc1GjZW2t?=
=?us-ascii?Q?qKouA4MXx9RGh1SlJDYyrpB+zEbGDQIMBAfioYK1bMiKHtpQkUGZ28NCjjrk?=
=?us-ascii?Q?Os3ih7+RuuIBKr9p1nR3WSrE+SlOCPmyGoxZ3KWcICTW3Ahal9Y8kDmjnGsE?=
=?us-ascii?Q?vDajvmnPo/XdL4AbSmMa7DhZ42RZKRydQsMB0gINRnIpOd15uq6R5uxmaTaK?=
=?us-ascii?Q?2eewNuPP3Xxc6rGicOZFPMdfHtq9sii2SlXBUAHL/79GpZ99YpZ0IT2hR9WS?=
=?us-ascii?Q?yLtkREewnimjEAMod1uxcasOSUv/J3LH7RJpxJrYHmmdReg30K7zrXgQi6Zr?=
=?us-ascii?Q?QbNzFGxznsCU9mQQPebbsgwgd6vDI93n2d/VZ0cujwZEnBgXxjqWpZw3Luf/?=
=?us-ascii?Q?ldmS6tutiBb10IUco3mNXveGmosLHfauAm2a7XxBUC+E1E/PI/JyKzEZNlrg?=
=?us-ascii?Q?p/7NihECB4dfB1vWNodnwhk0tYo/cQlbH1sCCDUW/g/y2Y/CYDj6e4C9i7Yp?=
=?us-ascii?Q?y8WEv5DHBHFFpAz4uytp/OC/hgLNOkhLhd1znXE1o2x7qJiql9L2QpVDH6zP?=
=?us-ascii?Q?fIuhdoGhtOfcISo67CCGArbCyu/DG1pn8rorTgBIXO0NnvJTGSS8qOHk8xMp?=
=?us-ascii?Q?hayKT+oTjaM71icxl159WawPgmMihKgR8t8kBPkIqpVPX5xlM6M5ru4x+SHx?=
=?us-ascii?Q?Y5FjbIBp12v0mZel764i3MLvA1cbC5Mv0lQ8AKbFt4JfXagBY0sscDvZf0a4?=
=?us-ascii?Q?zjhQvN9lZwQxgx56BBKaVv4RYqWZs/yVhZds7Spfj7bZJKlUJ4nBqlweM/p7?=
=?us-ascii?Q?0N5j5fVbRODtEzmapQ+Q6B+KFqnG2zZ/1CHt2T/qj7wkV2Cz2wF3Q2i2MkqA?=
=?us-ascii?Q?Hm8sT8YPlJ9OBMeb0uuGyYW9ieNtYvmoJxgly1ZL5tIHKM4xwjMlfLQWBd/9?=
=?us-ascii?Q?uzY1vPyrN/aXXefw+JXDs8fEoKm6XNs1VhX4to7NQ8ljaQU4IJjbfzZyECf/?=
=?us-ascii?Q?FzW31qV9FXdcHxW6tvOjW6E/GoZYxqmtdBQia1WvzaZXibPU30TU3zoc89qk?=
=?us-ascii?Q?lAsBhYDG1gClQWrP8j1eW7YQWf0CO6qT6tyl88G5wYxqCp2Rth9BwFicVHkN?=
=?us-ascii?Q?5x4j0YEnVc/OJelwMuzoctDaOerJqrCO2ZwWE18arV1g64qpRNYeL2jG725d?=
=?us-ascii?Q?FkAO1U0l+bjfRw0GMy9+W6F3jA+qIn7sJeHh/3KnUIm9cRsj6O+xpdt1jMgN?=
=?us-ascii?Q?9w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 969db825-5d52-4dee-7bd7-08dc9113c760
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2024 10:28:51.7143 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6m7LpdSCMTCiOAy+g06uswLQQcToXZ/riBGqAKmAFSFa/MvUVBfiNYoq6k0jIFP4ASHPyn3E3QWf1O7uymvZSaXJy0soHQwF6ioOP6rdf9k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6842
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Wed, Jun 12, 2024 at 04:00:31PM +0100, Anatoly Burakov wrote:
> From: Ian Stokes <ian.stokes@intel.com>
>
> Add defines required by NVM feature check. Although not directly used in this
> patch this change is required in order to better match upstream.
>
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
> drivers/net/ice/base/ice_adminq_cmd.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h
> index 6add57d797..89f565d09f 100644
> --- a/drivers/net/ice/base/ice_adminq_cmd.h
> +++ b/drivers/net/ice/base/ice_adminq_cmd.h
> @@ -131,6 +131,8 @@ struct ice_aqc_list_caps_elem {
> #define ICE_AQC_CAPS_NAC_TOPOLOGY 0x0087
> #define ICE_AQC_CAPS_OROM_RECOVERY_UPDATE 0x0090
> #define ICE_AQC_CAPS_ROCEV2_LAG 0x0092
> +#define ICE_AQC_BIT_ROCEV2_LAG 0x01
> +#define ICE_AQC_BIT_SRIOV_LAG 0x02
>
For defines like this that are just for alignment with the base code, I'd
merge to a single patch, or into other patches that add other defines.
Similar defines are in patch 40 here, so at minimum those can be merged.
/Bruce