From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D96C454A8; Thu, 20 Jun 2024 13:59:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCF25402D2; Thu, 20 Jun 2024 13:59:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 4C847402D0 for ; Thu, 20 Jun 2024 13:59:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718884795; x=1750420795; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=BgawUWGGJIthh23DFnErQpTEkOpztLVG11r/z5JiCwI=; b=R06ImqUEp4pQjD3b+RTqmEqzxrFD9Lk1TLCtMWzAANe0Sq5bPnoHxjxQ D9GqY90Z9yLa+K/nOywq+x2DdFXAyG9Ilexu5PiusUw1HLcL8r/WWfhqe P/vHcsFIjrHl7YtC9NvxO9DpZ/uDy9GyPCtV1WUs2E/JJxFPkEkXFID6S miwYQKmxl6GhWkUsywGIaXWuCr8z9XDdkiGpWgphfyEx02cpUPqooe+LZ HLUOa72cifud8oACpdqCc1tyq+NiaJQOt/l9TQPwEWkpGSVCcKdzngV0k iRlMFkmeCQB+BpeiK9v93Ob7COV9KzMvq5eNUy0VzysjYGUpHW2CXWPoY A==; X-CSE-ConnectionGUID: 0QG+hV2JRseFwlWHr8Rciw== X-CSE-MsgGUID: LMoqdzyyQzCr7PjTvzbzhw== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15828629" X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="15828629" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 04:59:54 -0700 X-CSE-ConnectionGUID: UGzIiGANRVaW0gVqIqmm0w== X-CSE-MsgGUID: QBLA1rIxSrapiodqA7YQ9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="65463490" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Jun 2024 04:59:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 20 Jun 2024 04:59:53 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 20 Jun 2024 04:59:53 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 20 Jun 2024 04:59:53 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 20 Jun 2024 04:59:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3BUw92UpuwKhDTencve/iaqLHDoSAjc7B8iNpH+N2ZACNeDKob6kj+lCENOT+fHvBTtPqUH/8AmtWgLtcOpqPu8Oy42u8GWhFHrgeY3lj43FILtHto7khvczj1XLYOnQmn1P9cIvx/wWTYBmDSNgZ0tQeQx92mALi8tVoxXsyfbi078OfARtV95fSPB4UXdB9BhVkZX7fmATKdYnjXULPhGUAiuFyRreu4B0/3F2gz3tvKIvK/VEcB6wiEMhcO8BtBockOoK6v81t8rYCcV444qXPu2RdnhfiMfNMD5j+7Ds7bBDrH3WdMlmdcxJQ8sJPMOdgMYs/Pb6xSBXOZIsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lBMwh7Uh90f3cfgjVmMcifS+JCZFL3rudX9lhGP+Ubc=; b=Imvgdz2rYsNRiM4pCso7b8WvdI7fbyD2VK7501a3e45wxdTGDH0VV0GvaagwHfBvZ47E5t4FnJSv/uyrjtv3RsLjdY+KfFT84hWWwjLoo1VBVUQEhgePgRhC6luPRI4d+2MUD8NVuIPD+N0vXbDWUao2w3JKxz2sMWQKh0NTFEN/Dc6ZZXyx09i8xuWYzklyC7q1DgRdio73V7FCm86lQzZUPeV4/grwfdf/e37HDF3vsr0C2l0d/KOXHDXaFUrjhEQY5QFgRv8SpGrfc3mPWL8iBdWxgYp1KtNP884vX6kBjgqLtnGVK+EuddvIPNSEIC2FezJMrA3RiH0OE5jDBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7841.namprd11.prod.outlook.com (2603:10b6:610:121::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.20; Thu, 20 Jun 2024 11:59:51 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.017; Thu, 20 Jun 2024 11:59:51 +0000 Date: Thu, 20 Jun 2024 12:59:44 +0100 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: Mattias =?iso-8859-1?Q?R=F6nnblom?= , , Morten =?iso-8859-1?Q?Br=F8rup?= , Stephen Hemminger , Abdullah Sevincer , Pavan Nikhilesh , David Hunt , Vladimir Medvedkin Subject: Re: [PATCH v2 1/6] net/fm10k: add missing intrinsic include Message-ID: References: <20240605064945.369310-1-mattias.ronnblom@ericsson.com> <20240620072452.420029-1-mattias.ronnblom@ericsson.com> <20240620072452.420029-2-mattias.ronnblom@ericsson.com> <583971c8-a87c-4c5e-8d33-2b75df58a230@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <583971c8-a87c-4c5e-8d33-2b75df58a230@lysator.liu.se> X-ClientProxiedBy: DB3PR08CA0001.eurprd08.prod.outlook.com (2603:10a6:8::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7841:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b980169-04a8-421b-9471-08dc91207d52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|376011|366013; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?V/0grzcDtU7JFuh/cqKIBBmoO02y27t+FJgi/in6JygqVIGg6O9G1KPi7/?= =?iso-8859-1?Q?/GdKTQoexFVtktq3WA4yaExA5KsTfPAAnptRHEm1eFfgKMZLoEIIMvEBRZ?= =?iso-8859-1?Q?bwuOl8xtpaCLuhfpCT7JyX7/+xTKljbh/Z36nk0cWeM4xkigmfbO5RA6RO?= =?iso-8859-1?Q?RdXJIzS/0CfLOw+EZfrnlMMR5HPe5IUmt7XotqNJ8y6BhqyBxPwQ1Cijet?= =?iso-8859-1?Q?JkPcQCYWKLZ2v5Nr09XNwteVj6cj/9G8CLWGS3YoQVdqHxabOBuWqijQxW?= =?iso-8859-1?Q?jwB0PPm40EUHIA0oTRQMV8GtTIYoB4yCCEY9E90RgnV8hrlI7VdONcJSPO?= =?iso-8859-1?Q?8MA2HwcvfucAK9ekfp5juC1Kn30U9zxu27uDfvzoXvTEkBX99ZOGIk97s0?= =?iso-8859-1?Q?gy+4qp5RpyTpmAOO/JK5bBaHtEP0XyyjshZLgfRgWzJoEaS4kWF6DXtv5W?= =?iso-8859-1?Q?J3KlqaFhkEjUOx+EdxrNBVxySqv/DvMEac+kpGdKFcwigED+ZWhjCBMKQT?= =?iso-8859-1?Q?l1/Wr9tVKcBMh60B/o9EcbysrBLkbq2d+gEshRdyyBPHVXxjXwc2s/rQCd?= =?iso-8859-1?Q?PgdIvgfXJh1nyX0YsS4S+6WQa1hczyYsuk+VsW24Uyn0Yeqge6zSUk0xso?= =?iso-8859-1?Q?PSBJpHYXLozWGatKQ8DQmhvadvC0NPFaO4Ozvu5SC/IBrAGegi3v9ja6Pi?= =?iso-8859-1?Q?yZYyKcPh7aDb3gSbXQ3b3IsUypB13MGwO0UmvON+R68p+TLHei2aRysAYb?= =?iso-8859-1?Q?lO/TBYAFEFuusRDGozNsQsNVumNPbG4XoJh+I+UWo+mh48m7PXJtbuGsnC?= =?iso-8859-1?Q?uw5Q0T3IohU1Flr6vbP9LJ+Uvs6SsxQMtmb/OCecxKu8dp0bxfdgMv0K68?= =?iso-8859-1?Q?Gh5OfsoII7Zj7L2ELM7/0Xntaao/gAJMfYPG9MgiHIN2ALPJQYXW0hmBcv?= =?iso-8859-1?Q?urmuqBbZwL0a2VB0oQ2RolSD02v5BkukVYjh0urS3zsx6ImO90TrV2h3pz?= =?iso-8859-1?Q?RjSszesN7/dPRSzuray4ujJsAg/H+VCTW9It7yQNEKVBbeMmOuUtCk6OYW?= =?iso-8859-1?Q?FY5CCEyqtufKMj4pWSYl74nCRb+PmtHzjDtvDi75px4DK+ovUbkGO0wwt5?= =?iso-8859-1?Q?lSxMCTIjaXvpXAx6OFkqfZnHlEiVYGqf/KfY+FToHCm2qwVlT9/uwer2ZP?= =?iso-8859-1?Q?cYaNa9rFZF767khj20/2Pxqq5+viYH6h27KToXybSHyNgGFEdkyU222Rsa?= =?iso-8859-1?Q?uMjHu3HUP74J5gYEyNN3e2pfiSOrpuI0A7U2yIA9lQMV5/Va921QGK2tL9?= =?iso-8859-1?Q?mbF3vAW7C+wTW6maQ5sJbGIIU/2GT3wh0H7O3eqwIeh2h2KkYtLE5BN5sJ?= =?iso-8859-1?Q?9WBY6S7eAJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(1800799021)(376011)(366013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?DI0g0iULkZVhbUtgymO44bt7WCZWS0CfndcpjcCinzaldXHISh2/raQSG/?= =?iso-8859-1?Q?BFy/qxAZGDUGjurpJqbBlW5YQRc8F2CGSsxowP4tHg4GPAQGcs27F6Ka1X?= =?iso-8859-1?Q?1WoD2QFBglB676fvPm5mMS3pi3oet0yTs6qf/9MBizjtJZCnriSreNSrLA?= =?iso-8859-1?Q?+5iSvTL0RnreMnGht97qZDyHAZ2yDMbNWwU/MXDhyzskoXlgxoBAaABVAD?= =?iso-8859-1?Q?u7bRSderGz1Jlrz6bD3kSw9dE1A3fJfDYXBVTE01jzvyITxHSwKoAVfIkl?= =?iso-8859-1?Q?VULaPa+e6cC6G7MFLNZdh2JWJNpZMKD7IxXWtzXJDMn+ukcRDB114Hz/iG?= =?iso-8859-1?Q?5TKmlCf8YZXBq94J4oVexb6PxoPdrYa/3P5hXSa26w1wm0BVu101G1KCep?= =?iso-8859-1?Q?89NONNIA3nUEV8A0/jOD1RNIT68NUZvLjEc5HYxGv7iit5jFEPZGDs8YLc?= =?iso-8859-1?Q?ySMd3UH+7RceKM6bKKcgqGuHVfTjjPb+S+eW4C4YpxjVw4iS+OhO9Y9fwO?= =?iso-8859-1?Q?HQMEqjZyMrzyUEOB89OKVNmt89BLOHLU8oq4g2ctGvcP6EFU3QP+7Z+9PI?= =?iso-8859-1?Q?EkDj/A8BGqbHVwFMNFTcUn9yFiv70Ge+9PVX5c/GpiBydEo7UuW4J+H/vU?= =?iso-8859-1?Q?ZcfggAUT02/r1pftSCnnx+iV0ONJqa2CuxdrWaQxew0KhHecuIlpmP95hO?= =?iso-8859-1?Q?bCg9hgWVM9cS267uN8Sn9UqvCnzZEbcUkfTweZIyswuQxLbMDSr86ydVq8?= =?iso-8859-1?Q?xQBcGdzo0QLULs+X3VFLvLptE0rpWeg/z7lJAuoZ+TU5tV6A3l05eolZmp?= =?iso-8859-1?Q?d5B+tB7bmMzvGrRrEqoYyOqwIeOzUtriBbsrtSmfV4qoPU162v4e61BygV?= =?iso-8859-1?Q?tzkzRFzzHijVpPyjaBlpo+ttq1KPdCFnv5wnl2ToXKeB6tJxRX+Chl82kk?= =?iso-8859-1?Q?dEBZWgQtMAxoASYKNSzFG7NyBPSXjnOf9B81nlqzCa67JoG8QIz/Yxp5kb?= =?iso-8859-1?Q?ssij280bk+jVsKF6l8kJwOD/N31YfWFLxQau8eIsAKpfqJELhJ+deBwzo5?= =?iso-8859-1?Q?m57klTJ6qltSqm3w0osjRrRwhaLwsDABMvePZnKDSj96rHD6ijCPlY1/WO?= =?iso-8859-1?Q?43ZOHb/wYTlIMI/Z2LVuYvcPE2+bJV7IhAYHDC3ozw77tEbX6FA2AzjN/N?= =?iso-8859-1?Q?9u8IqMesy2BhQmhw5y3GgztWqjuXKhurqkvcJEm0ID1eQQH0pyGP1Cworj?= =?iso-8859-1?Q?IdJV1RKJYBhX9bBPh44DPjK0KLcc5U6jk54XEo2Lln4sVwBO0GoRZSjVT1?= =?iso-8859-1?Q?RxmchMfnuznZINbVVGY8XrXgSqoXdFu2k/EANFNdM3y7xIJgvd0pWDAkjU?= =?iso-8859-1?Q?U1YmPAvNbqM6KSbR53JMOauZTCdqVXHNNHc4T6Bash6/Biqe/U600hCHTG?= =?iso-8859-1?Q?DOND2VJHDv+mqd6n844+tnCwrDz9I+ZXUjZz3zN4R/7O1eZZJIeJvP7u+m?= =?iso-8859-1?Q?FceywetCP59iLDNGYZWqdTJZIPqZRAwZEnvNPKl1l1QWZc744Y7DALVP28?= =?iso-8859-1?Q?4v0C26vlWGfJNn3D4yMWMxax7Yyh+yjOee/gmYboaYKK9FW6Uckhyncbt9?= =?iso-8859-1?Q?GzgB3hSPz5FXu5OagQC2GRgfc8JVgg1WoRPeH98NdRIubfDWY2uVaxwA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b980169-04a8-421b-9471-08dc91207d52 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2024 11:59:50.9426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w/C4C0yo2SIQQ7dEEf8EljgKAf4PhiSi+36DKUJjC0tnF3D95hq0zhUO2l7cUZj/P5P3qhPEN6ij1coQGE15sX6qxBiEc4MYuRfXnO+kl/M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7841 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 20, 2024 at 01:40:42PM +0200, Mattias Rönnblom wrote: > On 2024-06-20 11:28, Bruce Richardson wrote: > > On Thu, Jun 20, 2024 at 09:24:47AM +0200, Mattias Rönnblom wrote: > > > Add missing include, to get the _mm_cvtsi128_si64 > > > prototype. > > > > > > Signed-off-by: Mattias Rönnblom > > > --- > > > drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx_vec.c > > > index 2b6914b1da..d417b31bbb 100644 > > > --- a/drivers/net/fm10k/fm10k_rxtx_vec.c > > > +++ b/drivers/net/fm10k/fm10k_rxtx_vec.c > > > @@ -10,6 +10,7 @@ > > > #include "base/fm10k_type.h" > > > #include > > > +#include > > Beyond my ack of this patch, a small suggestion is to just include > > rte_vect.h rather than trying to include specific x86-intrinsics headers. > > > > My ack remains with or without taking on board this suggestion. > > > > /Bruce > > I will do that, and hope it will magically solve the > _mm_cvtsi128_si64-on-32-bit-x86 issue. I was looking at that, and it does solve it in my testing. There are a lot of drivers that have just "tmmintrin.h" included. Changing all of those to rte_vect.h allows 32bit to build with your other changes applied. /Bruce