From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C6E9424CD; Thu, 20 Jun 2024 14:03:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CD0E42E82; Thu, 20 Jun 2024 14:03:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 64F97402D2 for ; Thu, 20 Jun 2024 14:02:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718884977; x=1750420977; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/912H6q54r6+oN2mJvaqkSpPuXiIfbgTKu0u8dt4gAM=; b=GjtwZr7P6wlDnXGPgpGDQPLL4eHytljSSCipdqByrWTUpYoQgICcdRW9 hW9hp6EB4oEOHp3KU0JETm9bNB6djRuZbWmuwGCE+8luDDpJ3GpQQcZo0 +5+VN+H4GPpXXHzaIiXMAxE8mXK7GpcGgVMsp5j5dZhGMfL8HIgza44nt zzLAcGs0ptRYQ92dS5tepyinEfu1Of9uGB0Fqu6xREw4XO57x2ZYVNEwI ONVJ7kO91sqBbUxE0oZzU18d/rPrjhbetdFFY1rhfTzIDHGTWCjquWdSl srMW6gm93nrhAgJ/fBI5D788w+mH4KJW+QC8wpiWa6zBkNawwTnnKNEoF g==; X-CSE-ConnectionGUID: tKGRVVp6TKe5yk1IFmza5Q== X-CSE-MsgGUID: iSAVin5BSumakR/fyWztlg== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="19631774" X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="19631774" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 05:02:54 -0700 X-CSE-ConnectionGUID: PdbLFN/CSk20szswXSLzww== X-CSE-MsgGUID: fhmsRrwyRu2bBMzprsE17w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="42315180" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Jun 2024 05:02:51 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 20 Jun 2024 05:02:51 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 20 Jun 2024 05:02:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 20 Jun 2024 05:02:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MvfUloaUjEfxlJNC3YZjZ9/wWXhAdnOI4SPoz1fhkRkPNtqWcDk2j4WavqxeDuhuHA0PlNmB8nUy3oDPBZsUjQGfVuQtz/54beV379u/gTiGpL/RGjV0RMomYYAjSIw8YZEK3bxGxOOSFs7ddagu9vGKWV//sdeQOWuZ2WcH9n3OBvGBwwXSG59AvZdMgt6tCuQaQxVupJY7iL1VeFtPdLc8UEbVFvVWdgb7pi7sqAoILMK4oQF214oBfAS+2qpfD0jBmaqWbqg1Hn8TiSH4k4CuHWUAiTqCgMK4TmPfwYcLavcT4LyFoVH3zqA0O4Ogcx+nSyFiyQfso2H4URrSUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mjKfLKHZ+lIaE+lC0QwiAl2m2kz7e91pgA5SQrvxtDs=; b=JJnyOVyfevXU8C31yxaRB5eHdFfKiPwjiIcPimk0UEZ1DrNwfJjXtOGckj7DL1vR8Row1VmbbDyNk7bqFZEcX4wlc8nOfRD5kKLvzBRtApyK91Pca4vwhigJPTRlMlnVWuo/nx9tl1s+TvTW/0CxAwEIoGHXs9xS6rvAjv3gkTD0UNh7tzLpEQFaoFAMV+Pxb7XtQaaSAQpPHx3ZKkx1fPpIcIbbA8SO3QQA733lh5FnwRCOO0GkaWGcYYdz4i4PV09wdrYEZGGQcPTCoWsD4p0h8VtwISf3CPLtjoGlAGhQrXxURvC77toDhHplrsfigcsuQw8lxY8uV7Xh3iZrHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7825.namprd11.prod.outlook.com (2603:10b6:930:71::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Thu, 20 Jun 2024 12:02:48 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.017; Thu, 20 Jun 2024 12:02:47 +0000 Date: Thu, 20 Jun 2024 13:02:42 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes Subject: Re: [PATCH v2 047/148] net/ice/base: added informational message for NAC topology Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR04CA0018.eurprd04.prod.outlook.com (2603:10a6:10:110::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7825:EE_ X-MS-Office365-Filtering-Correlation-Id: 0dddbce7-b2a4-4dd8-1cf5-08dc9120e6c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wTRj1egIOJkL0mKDLbLn6nXnYpyQNmqyzaFB3WqvUR8PCjsbnBSlpwQi6veM?= =?us-ascii?Q?9Wpq4Kf0uFcf5+U1WUXO56DR4GCfC0gBkN5ncHpcgYABz3E8G2DG8W8uiLXs?= =?us-ascii?Q?E0DaMpNsIZSf8uRGFp+UlUm8t12PLXsyxRUkg+GeucQABmCKgRJuXF9c6G3x?= =?us-ascii?Q?pC9ZvsL9LSREQT7wXMuUEUMEatIcZ1zj4vdDVvqPKY9pA9jD4U2kv2LC3Som?= =?us-ascii?Q?lfU2WRshfDm06OBadgp49aKA8Bfzk3DzFsFrnayXT6NMWWIqQ0Xh6A+WAdAD?= =?us-ascii?Q?cYCTN8ZI43bUxVmJGhCFxAa6a0RECCSoWXMJtV2aPV5c5L8mtlrBbBxu+CO2?= =?us-ascii?Q?1l+88bqnsgfY5ldeb6EsYGk96v+p22Df6J8w8osS3cuKlUG3VsD2GndqEIS9?= =?us-ascii?Q?EwWZRXpdKFEX3vXMuT0YT0HBWPT02VN+b3pJivg8Gfqyi+i/nx+51suA+E6K?= =?us-ascii?Q?D3xreFvTXCLZ2e3+DbJlrutS9lR7iEb4MbuJQrO1+vksoonSLa/JJpemsiNx?= =?us-ascii?Q?CRkkkOle4yQFT9KaZK2wRMcXmYVRYL3QKu+ej21FEFaCCKpM5I1A5lt7uRl9?= =?us-ascii?Q?+gUQHRaFVAVPyWd5EIyCUfVYAhv9mG6HY2zRBavkHefzZvpMBkgGL+F6l3rO?= =?us-ascii?Q?v7gCVlB32lwT+QlupV6q/PA30S6E6AbNqthtrTsQd519VrNCs2QVKKxER9nZ?= =?us-ascii?Q?Uvlap/fh+M/SXXl1SHomVVcN9vfLJvWK8fwNRgougMD6cWfAhPEDwn/ZjikC?= =?us-ascii?Q?RQU1Mu0xisyQ/WZme7qOhOGxOPRq+zPP62PnZQzzN/XEz87ongDO6iwC+Y6I?= =?us-ascii?Q?z+L5W62mvZTy8qA/6dLlWeIkFqudzz+TvCCqp/3UrFNxqGs+cJFYrahYyktd?= =?us-ascii?Q?XP5siFOmdEGipmHrxTo0tGfkzQMZMjWauFgah37GqbMDVnDPAXXn+b8aXak6?= =?us-ascii?Q?oPgAjMCtPpMB1M1BcOk7gWUMo09L/9juQAI0NLhnnB1GIRl7VUD07r7Nt+vw?= =?us-ascii?Q?Df6i7Wf9f0BisUo+GzvmCNfjHj0DFxyucBaNAMYe4f9M+eU35C5Mbq8DaqWt?= =?us-ascii?Q?ChYiIJxJZ1zH5uxlKgdm3gg19mA/OSYNknCYTxS8LLijGvNZ8n5SB1vDxBx5?= =?us-ascii?Q?JKzLyUiQZgfmg00ufXFMhNokZQspI9jbmoTycHLxfmTVDBf+NJKCgdX8oPMm?= =?us-ascii?Q?xPa+G6M0QhHvXS5BHBSS/LCjkSf7F58esFlOWQYGyfkg7O6SmyDfdt29SK96?= =?us-ascii?Q?5mTY5nVw73QzVDd2wYUJ+A2biQzZylqJDv4u12aqySM5pfLsJBFTNa9DjB8+?= =?us-ascii?Q?Poii7kfKMbEu/3KDtYOtAJ1K?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vYySKXIpClqujsXv43NYndV7uSOzSqVaVdJMtVD8JzRqkDguMWEsbAVzeiT8?= =?us-ascii?Q?l8StL+efjVDJa3ziFXCBPMMYUYqz4Jq8upv7GKWCORyBjeBJ9SKx2lmDuzyA?= =?us-ascii?Q?vwJdcDVG/XRxGgciNK5bHHNrtzZ+rRYLHtC/u87AjT2FPNaRBD76q5r5pKVE?= =?us-ascii?Q?fV3Rn2IbbIQjk3x+O1g5BOyEfYelZMgAPkxCaDyyIP6XseEHtSkqmzcfXkDP?= =?us-ascii?Q?Xw29sAP9uAwtZMsrsZeVtcVRqZWu6wGVgpGuRJIm7zBOPn4HmLGa5Eua2xRj?= =?us-ascii?Q?3aYCvSaPmegImPRJaDKl76RdUtr1y10cwRO46jn6vkfXGQwyKfcIFGxxQnsj?= =?us-ascii?Q?qe/vbRpkfjvxsn1sTwbC6xSasb1yH/7B3spNL6PMwlPLU1JtdDjL5qUxFhb4?= =?us-ascii?Q?fCpqJ++PTHCCpYHo5Zv8kfxnarPT9bWwBtYBQW9F+gjQcV6HOM8YDYenPpQM?= =?us-ascii?Q?Iprijrn8zUcI5DodjhPVMoOHhWgU+pQdPJAB+gr8r1pqu8yvUxm5/16XH0qm?= =?us-ascii?Q?3mHpYdOH/UVLRxMeXB/FktmFbEv3ToBEVVZDuZ1PD86Nuts0jmOcC52AWBtT?= =?us-ascii?Q?ulKUpv/BmGxYiJUyryxWNXYdcdDj1WEav0KVgGA6xi525nAeQxU/UpopxgNe?= =?us-ascii?Q?lwrgizYuXgUlN/KefVndhs7hX/ooMOGtOnKscQlXrHU3dbAjMnBeuedDQGGo?= =?us-ascii?Q?iErWReTmZfbzXhX3n+P1zzBAbjPL8dx37ZREp5+UnTj0KeAc5ZRhK217WHWS?= =?us-ascii?Q?j8Wbx9UdLK7EYSg99hXl54l6jYux5vyIT+1OSxM4dGOBiniF5N7b0ckcYSYP?= =?us-ascii?Q?x9XFqNQlPFas48jAgpdziUHtoTtE1YH2MgHk3d5DAehUjFlTGutdVEhBKpXk?= =?us-ascii?Q?0ikkJnKSPxIm9oASd6pZlJ4bKvMdxAbzM4aKkbS5NnTrMvt+Re8C/RhDc2Fc?= =?us-ascii?Q?L2dgsBpF5xEDnpYuo7f67rhev+SmDj0UD3LKjfFAe87k9nLZh+l6acw718SG?= =?us-ascii?Q?I/RB/Va69kODGED+FxZZ9ikcpuuHQxv/EScD8wyQMiPyFr7DeyBPGt6DlwB+?= =?us-ascii?Q?BkadG5uroaHx64lt80RSbb6Fv4bg17GxAX/rYl7KlHpF8rVR7Ip5AyGpMrGS?= =?us-ascii?Q?Vs6ef5f9Uwv6/96S9OHUAP8dbDREqzuRHX9ud7o5mz/vT69swqmOnwUCA8gs?= =?us-ascii?Q?E7g7rA2AtuBsUkIqL65tWRGdbxSLDsfQqky2u2WQ+wDijEyO1JFXbElT6118?= =?us-ascii?Q?LK0u92ugnBp96c5lyfxlnkBLYoRdbJAAAc/ZoOsTZ608DbXu04nKfoAJP+Hl?= =?us-ascii?Q?00+0mQnwGeMwt42r8yHGIK4f8rzZ3k9vyvGzQEEFTswNvoKqg6CK6RZmcM20?= =?us-ascii?Q?dOD6bKDak6rk0ny9pm79h2xPMzwY15UAeNvcN9lGG+zv/4q53/xFagTKmAoi?= =?us-ascii?Q?bAfrlbkrb7Z29Pcv3jcsAJzbX87DD2pNbMV84rnribhPOccuieW9/FGuOXwa?= =?us-ascii?Q?GzL3ts3yJC31yKEQ+JpZqXuhZgSYW5tTourBxIHyHWSQ37XU2fzqYAKpGYZu?= =?us-ascii?Q?zXUJ5eR0xPGDxJFXQ0+AOXKlXkWiKT9dZbLmJMZjvYe/lQ8ZLF857Y1ttK5U?= =?us-ascii?Q?sA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0dddbce7-b2a4-4dd8-1cf5-08dc9120e6c5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2024 12:02:47.8491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GH00W+c8Hp1zn8iXRkygP0Wvk/opysM55KgvFYsIMq79eKRGDpoSqRfgll+J6JkKBcxfupqf/Nkm1MVB4juKYerquupImgP5ZCLmF4gFWGw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7825 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:00:41PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Use proper bitmask to verify primary/secondary mode instead of whole 'mode' > field, which also includes other information. In the result, for Mode 2a for > example, 'secondary' mode was always reported which was misleading. > Commit log is not accurate for this, I think. Commit title alone is probably sufficient for such a simple change, or at most a one-line description of it. /Bruce > Signed-off-by: Prathisna Padmasanan > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c > index 45fea193da..62c68b6d73 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -2886,6 +2886,10 @@ ice_parse_nac_topo_dev_caps(struct ice_hw *hw, struct ice_hw_dev_caps *dev_p, > dev_p->nac_topo.mode = LE32_TO_CPU(cap->number); > dev_p->nac_topo.id = LE32_TO_CPU(cap->phys_id) & ICE_NAC_TOPO_ID_M; > > + ice_info(hw, "PF is configured in %s mode with IP instance ID %d\n", > + (dev_p->nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M) ? > + "primary" : "secondary", dev_p->nac_topo.id); > + > ice_debug(hw, ICE_DBG_INIT, "dev caps: nac topology is_primary = %d\n", > !!(dev_p->nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M)); > ice_debug(hw, ICE_DBG_INIT, "dev caps: nac topology is_dual = %d\n", > -- > 2.43.0 >