From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0485C454B7; Fri, 21 Jun 2024 16:03:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E903D4026A; Fri, 21 Jun 2024 16:03:11 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 29C6540265 for ; Fri, 21 Jun 2024 16:03:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718978590; x=1750514590; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=wYtlLmJPfHsjlilVe53qfR/DYZok4pEfyuqdpqqsnJc=; b=Uyjxl5Cs5hxf4KVccD9hANWPEqvk7asY1QyiqgzGjJgyvzGMJBFSHl9a ONh6YQZ//abrPNBdRsDkjjF1M/SVIS4P57cOG4MEF1lYLeL6jr62jev+b QX+mff7wc4SsxK1e3Gp4aVFoNrXYDpCFRhxlFlggvTNgSxWDQlFb8JHIJ 1VIIRGeA5NB89YZK8Bf9XkHAwedCdMPK5IBEpu8jHG1kLTays4EgtlaUb gnRjmTWhn2shudLZHshfx9f83bFHNH9y3q+zx0imDxMmKrrPXvfcrCr/d 9CfE0rpiksiAENKa+9hlgoF2JhuBzNDRFVHLM92NEpVAfQlS1qNw/pkNL g==; X-CSE-ConnectionGUID: 5EQZvp2fT5yFp0eIMp3o3Q== X-CSE-MsgGUID: odmFuxR+TEmzeEm55MSTgg== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="27418816" X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="27418816" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 07:02:25 -0700 X-CSE-ConnectionGUID: JsDAPLQES1yZVA4dL/I23w== X-CSE-MsgGUID: UOVbwzEcSXuqaEYhoBzyzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="80110237" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jun 2024 07:02:25 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:02:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 21 Jun 2024 07:02:24 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Jun 2024 07:02:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/4DgEsVogCjDzjHL87b5ik9WFAWGtFDWvNWYX2q3C4UsbnjPYjdg7Fd20Jsp7/uifx+2zpe+Elnwpk6K4vsVwbup92yGNXOZSEHQh4h6wFfJ3PqYXQPqz1QCs8lZJpuODZEu5Dku+RzXB17An90TJQlKcHgxlT17mK5OawwW/gpyD90N5s9N6a/ZJIvFInhjbGPHgYjP0gKcESrxb4gXagOgJaTtdHPAhhauwU7l2PhdGB7ktA/fkqzyvyLHkK0oKMFbcIvR6K5j6hBWQRj7ku+GUJsOW5fTJmKPnuSrVsv6W8t2bDyV4mYHaeZGiwfiJ1hIWSFgQHaPuN5xioyfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WOowJLW7GBzTRCmf/xZd1EnXghZGoANa0X5JFeY9ag0=; b=hUpGC2+Rv2P+/Bguk0vrVuAAF68TYIjb8+3ClATeXujslb7vjzCtNg/Hf9qqB5ofvoF1UW5l8WQ8DLWCLB9dR6LQyHQomQVglVxyDBwzuZ5hmN42LS/sYjhyOz5hKqbexfQ1F4h7lWVnU56q4knkj9xC/I0GDStmSgBeA2Mj3/wIarEL73KfidKxtrfmyqKZy3xPsV/VZSw1CCY6r4OWHYUcSLLvoXoVDDwqMFQtP4DEoj6ojbh66m+Jy6ZzMDXdUoX8k8ChuzXxa5zzNou/dHnf4cCAXMEb6MyHWyqn4tZwu62tiU4p7uWRrxQ0PlnKmVw3lvr/6/AM45xeDDT1uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7976.namprd11.prod.outlook.com (2603:10b6:806:2ec::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.24; Fri, 21 Jun 2024 14:02:15 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.023; Fri, 21 Jun 2024 14:02:15 +0000 Date: Fri, 21 Jun 2024 15:02:10 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Subject: Re: [PATCH v2 126/148] net/ice/base: move code to common headers Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> <36990213f3f4afc163f20dc4fd8778244b7ac364.1718204529.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <36990213f3f4afc163f20dc4fd8778244b7ac364.1718204529.git.anatoly.burakov@intel.com> X-ClientProxiedBy: SJ0PR13CA0062.namprd13.prod.outlook.com (2603:10b6:a03:2c4::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7976:EE_ X-MS-Office365-Filtering-Correlation-Id: 98602913-0a30-4bdb-c348-08dc91fac195 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Q2Ghtz0SWpAe/j/1U+YDyWRtAEfhW/3tnoe/CMSiT7FPciZ3MKIsUF0TJ6Ak?= =?us-ascii?Q?c+UZGya+1+1w3SNW3dRTJjcMjIO+ttv19ENXQKyNzGRWIavjH89o/+S8gO08?= =?us-ascii?Q?ob2aOrCxNMXf5CspaBvrxFMBhrxJqrCS7eJ1Co6EWO8RdyVbWnnXr0vKUvJv?= =?us-ascii?Q?/z2DxfYz5e7yyVURd9Z4lvVJPDBsrwex5QkLv/VYTnIbJMZKbBsZG3AyodE0?= =?us-ascii?Q?i0Dc/zNXFNyoy5MNHGob9FnXpQEzi6FlRAYxEGaUSw6YbU/X52n2ISFNenz3?= =?us-ascii?Q?lyDI+ijC5Q8lote+Tem1axYdutZEuPNKamde/WzhlS57uxyAlo8UpErurIEM?= =?us-ascii?Q?rJIRJwggjcxhvXVHiQpcOgCqb1w5m8DxKJnuQ2kTQWYIYzwfYTD9wLh9o2K3?= =?us-ascii?Q?6hJYVyeiUIpbGWHw3j8GDw4Zz890QJEpIP6j4HLdtUJyPJ2qGEv5JD1Yu0FP?= =?us-ascii?Q?y2h7sLlzPpGStMyzOl4LCh5/KqOVjsHOIVVgkRSWmn0m5suelKhuNrFFK7GX?= =?us-ascii?Q?xhwyMUwB4iI6XLqwWeRyMlsyJd0zsR8Ikp2FVMLRfl50QDcQQAXR0UHmopyt?= =?us-ascii?Q?up+R6YgiWvZgIice4zbESVc051roojEBPPwVwfZIIosNPCZRy9NnviNc7VWz?= =?us-ascii?Q?/N2TxoenHa+5RunIxS4Hv2Dz3e/A4vceCnGpS1+fsDnbrzcMegJ1/GvDVy9G?= =?us-ascii?Q?Ut+0Cl3N5ih5Gu9xImqZgch898mu2bnBmnSYTC10Lwfsl/yL3GJTI5gibznF?= =?us-ascii?Q?+ASGtnk1wsn/o44Rc41SJSN2d1aD0ATh5zA6lAmGvocy2p1wCfJqoxEMi0W+?= =?us-ascii?Q?qipR+nPkbpQyami5l14lZJCyU7dq1VWtPBiElJ/sxr5I0jRAZuvT0/UujqjA?= =?us-ascii?Q?dHyESDvLoj3vhfR//EfbOiJO6rGL4RY2Tl5cTNYPStmFqaaOwHomLcVwuwyX?= =?us-ascii?Q?P6w1XvUBpzBN7PB8xIgfwDgXFC5+aH6X58xul5+YGgXVoEMo8q6SAOoahDZY?= =?us-ascii?Q?FqJH4tUbpjjhl9cluhYxunGfXH7L37Q0iqpviezpxKvnBLyN+NwZ9W9VcpmN?= =?us-ascii?Q?j5eCELeCFz212svoXZe0eKuPGWJr0bhyqpC7r/VowrlGzd6LM7pYyOzhhIUn?= =?us-ascii?Q?dkWiJlAfObMduxPhvcMVCIFF58dXwF85rewCQGiS0VUAU+klLxYm9iVRYUvL?= =?us-ascii?Q?xnFMOlzq6VPFzs/gm0+fIodLZOC2JwnVt6fZJrVx3Z31apg5e/9qkgdm6tby?= =?us-ascii?Q?ejc5Iw9kzGw3ChGKn+FhZR+EUK7A+wMahtyhmYvrFBIhXNT07NlWGI+3LF2d?= =?us-ascii?Q?Ju2kNyAPieEKnhjxXDbHghjw?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qTLvMkAUu9KNvHPxsu97adNiZeJ1HBIqRrkFEhzMd8MX5ao7+NubxLOBO4RH?= =?us-ascii?Q?2J0mM1tDM/UC8qP2XDz6u628qFQgMiXZ9LgJCXPlFhnNicIVLPnTCgoILX5Q?= =?us-ascii?Q?qrQRyapBDMa+bTeeacz2tUWq4gEA68IjLakuOVsFkQ0ZO0c5AUsB2diBXO8T?= =?us-ascii?Q?PHdIDSMJv7EOktuxdoJhKFAqHNSni6huT0PK9X6Vh1jA6C9oENp1FD/QLfC0?= =?us-ascii?Q?QtUD4zBQbHtyAsQ2jkCVIPMgDlMNAe+f97LM7pBad7cAuut6r7Dt0S/Er+Lu?= =?us-ascii?Q?CbV+dHf1VWlMOuGr/HoC7v9kzXhi+r06cGVUakw5qdSyFk3nNhwdnGZDfVqA?= =?us-ascii?Q?r59x+5dKhxRUFrCFRv9i56q5P2/FRd8llMs57CoGUvg4fuqPZc7EFOYgrja9?= =?us-ascii?Q?QLFPBVm16yXFPUo77Yl8CqbkGjBegaN8qP/FUBZpxpz5h8Nr7lJLmNB3BegZ?= =?us-ascii?Q?FtgXKqvE0KeGK4HRNuxHScbxNHMnPWcoWbjNaSd4OjNuPFXu1wwPm2vnZMw/?= =?us-ascii?Q?dRs5z6bvoOSrR/3p2YGpBuUU4RqQ2l0/YmpmGbHR9LhiGCKDEJcKyswAj/LX?= =?us-ascii?Q?xNpUKibUVaVxA/lO7HfYeQArOpFoDKwU9TJ3Vwg210yOxBIonO5UK2bo6BYT?= =?us-ascii?Q?7YDswCFcsoq73fpiFwkjYr+le0x5LihBzS8oljr5Cqv5Puj/3TENsrL1ydQU?= =?us-ascii?Q?iI0xtau8OJy4AZWmLg23E9AKRWCTWYxcda6n6UjUZdY/EGGuyOEdXSI8KU7M?= =?us-ascii?Q?fNo3eIqYi39yswZz4jOcmDhcgkhY/teLOvlAphienaKjZFIoEIN8XEWaO76c?= =?us-ascii?Q?+4cglN+/HGlYSFMNGc56UCaJi2Z1bZk9S3Lrr+oDP51HzV/v0ZEmdE9l/FDP?= =?us-ascii?Q?+7SYZRS3w/s2NKcwnU5Ls9sytYlo0Rgf4d3e9yM9BBDrG5U9W1QNp5rKZbnX?= =?us-ascii?Q?4N42dozToMsECTh6cchDOU2YMfpoy5St+X16YJ/JzE5fDpxM54e3XlEDnUal?= =?us-ascii?Q?hDzZcdFVf4yr5PYMo5ZyT9M+P/pTow4ECNM5/RbKpbVZgALZeq8K0HwTGWZo?= =?us-ascii?Q?AnMTuhyZx4XBt0iMh5oALWPmJjfEWR2jkU7X2AZjpawrsjTtv+ov/2Wd3qtT?= =?us-ascii?Q?4jpc+ai/OYnZMkDRvpn3TLhnt/SgmLjh6uPunywiG5WzlaEzgdk8tefflIBi?= =?us-ascii?Q?k3ZrToH2WxkzA+CoHBFS9iZ+6Ek60ykZ7EW599wKLg2l57yE+8pNmx+Y73YC?= =?us-ascii?Q?TdRDxvd8PEAGaDRqD5r27vjHlmxrcoVFVLNNarmhFVpBvs9Lqs7keFCfazqt?= =?us-ascii?Q?uvyZ0HG+dj3YM0/XkBv9+xZ3pczYVk5798EO3yCO7Es46U2rGMoZyKX2xLaP?= =?us-ascii?Q?DqRx7W377xPTDPs1rdAKV9+dUi1fKo7Mg3j+Zvy31ffw2+apI/9YBBi2hd8Q?= =?us-ascii?Q?m9qfryRxpSSttUs+6pXD/DvGgzq3Sx+VZORkkJUrF1BZ+C2sgh7PFVz+mCJk?= =?us-ascii?Q?0TCJ5wKOjDKqaAMRPcH8Aq7L+YUDNicJVSL2WNBhP76pzLauvN7IGp+6wGg3?= =?us-ascii?Q?TcokdC4tLo/YgsQUrqLe58SXm9mHfEloEjKRnMQ2L6d1keNedNGD5Ok39dW6?= =?us-ascii?Q?6w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 98602913-0a30-4bdb-c348-08dc91fac195 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 14:02:15.6509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hAo+hncx4kSXVNVYQfyUntl29TQgzdicTetTMHyOg7SusIiQysfzPgMLAXNnAEEY5XpOUvsf+3Co9yO+t23YPLanU1uPZblcK8ZahphvASE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7976 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:02:00PM +0100, Anatoly Burakov wrote: > To align with upstream release, move some code to common headers. > My reading of this patch is not so much moving code, as making functions non-static, and as part of that putting prototypes for those funcs in the headers. /Bruce