From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 227D2454B7; Fri, 21 Jun 2024 16:04:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13EF142E8F; Fri, 21 Jun 2024 16:04:27 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 744AF4026A for <dev@dpdk.org>; Fri, 21 Jun 2024 16:04:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718978665; x=1750514665; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ixdxMRTnFn5HJwyh0ptKNYBJgx1j+bAophryPinf208=; b=aWwbZvqkTcAM7xDSEQR6GcKP0SyzXt4jZIJC9QwogzrJQTVllBzKDRTM 6VZkXiRXUf39JaX4Jm/pDmmfVeD3H35P99rI/lCikLOUpeho+N+n/qzxc P+/xrXHw+sXh6ZXmXl2gTY0UE4qn7WuKkkA4J7GoCsdcQxn+V7mHRzLAo CIc4TIBKn4oxPjiADHTfRkNsaUqCekvvuUPZqyxBxG7AYkBABIsZEYiPj YqxDAlMccng/uCLdMmLPWgaLR5AGek2ycfGoEpTLG77/JLR4HnWY3Up24 bmlOb3y/ovgmHAeCGqrUp7OsOmfGY2NgBgMtRMWyJOvCOuRrj8VbSVmoU w==; X-CSE-ConnectionGUID: i8bx5P0gS0Wsf+UQ5k66Rw== X-CSE-MsgGUID: aldCZzXRRau9jWp0/UmXMg== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="27419218" X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="27419218" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 07:04:05 -0700 X-CSE-ConnectionGUID: QKP/zzcBRYiE7Ifp5NAOrg== X-CSE-MsgGUID: EX/fG4h6Q2Kf26vHD1ASFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="47122016" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jun 2024 07:04:05 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:04:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:04:04 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 21 Jun 2024 07:04:04 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Jun 2024 07:04:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMBcWw4gUstaAGqWmru+DBpIuSRqhcr+ly0N2bqKf5ugpkgaKiYNl3XObAvWXb7c7jlhZ5eV6hWTS/1QjJDKyhB6jMtr3Ng6Tz1/FtVcgT7SXDx/nI3Q9CsBuPC2Iqjhof0BofGAR43qLreUrv0dRJCMi7/GUZCyZgNbVTlgLCYNtrNlMZ+BFeztwHPz4QaVElSCmIaZ2jPt+E3E0ToZLhnV50WV0E1ElQwY9XKan0tDKYmaljplFKo4ShT8HZl+6XAAoTCv5jHJy3ihpknx/POH952ecLJkfWQREnFxnZgFsaQn2pfISiXuqvZOFl/r5aUweEk9cLuwXQV6TgAsMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h2h4eU6Y3FGtxphG3SQcXU5kjDEBkaJGdYVLcER6dB4=; b=CO6fJyHxmk83rgIsibmRd+gqZwUFNJKf1Ez7KjZ/d5/mOyAbFl0+fGuIUn5mVlpr23CYjnu5qsUPH3uoUAvwdtWViqug/paN0THsX3/mHYe4zv9s59GMcPLYToDkXpfbFv26r6Hgo6Iu7cjcJAafu9Jqn+O5zW3/H6u4yRhaxmI90ITG17Mn3/uIYMYzbjkFIX4tfbzXBGFdFuxdVmRr5yh6R+8dUAGMx4tb0G/ONX6Ql72PJhc0Z9eacMJB1jPuKfTrLitIfhMTz5P1YywwM1L+JuqACNa1Pzv+1t1VySp7sdHDnorGP76lQe30DkDffWH3XZVCCBYFXRdCVXpmWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB6527.namprd11.prod.outlook.com (2603:10b6:8:8e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.22; Fri, 21 Jun 2024 14:03:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.023; Fri, 21 Jun 2024 14:03:53 +0000 Date: Fri, 21 Jun 2024 15:03:48 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Anatoly Burakov <anatoly.burakov@intel.com> CC: <dev@dpdk.org>, <ian.stokes@intel.com> Subject: Re: [PATCH v2 127/148] net/ice/base: make some switch-related functions static Message-ID: <ZnWIRMp0sFOpoynq@bricha3-mobl1.ger.corp.intel.com> References: <20240430154014.1026-1-ian.stokes@intel.com> <cover.1718204528.git.anatoly.burakov@intel.com> <1f7944d01b8e6150230a2df5675126f67d12c346.1718204529.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1f7944d01b8e6150230a2df5675126f67d12c346.1718204529.git.anatoly.burakov@intel.com> X-ClientProxiedBy: BYAPR11CA0088.namprd11.prod.outlook.com (2603:10b6:a03:f4::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB6527:EE_ X-MS-Office365-Filtering-Correlation-Id: 331f214b-4aad-46ea-674a-08dc91fafbd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|1800799021|376011; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?w2EIy8ywIuNe6ZJyG0mpm21PrSDOIyEzPE9JMtZUtEYOF6BETRoAySTwNHGg?= =?us-ascii?Q?qHkEVLJcBvGzJcCc9oubjeKxguw0j8dUtqUZUzZ3Fzgfs2vzEU9MqIU66YKF?= =?us-ascii?Q?5u3MsZuwq7oM1qJWInLcq5auB4vBDw9xiZjC27I3drlm2eoPfy8JXhHBzAL9?= =?us-ascii?Q?FmGjQb/uLEaPWtSbLFJhR93RPCxSXyvAnLP8t6eI5aA03/Fe84KAdGen/ngU?= =?us-ascii?Q?SUFADnHvhd8CKR6yANp3Fv8LVkuw52twl4Vkr/wUiYEakajiTgnJUMrByy+e?= =?us-ascii?Q?jcvHgB8KIdROwI7wVVW47Do7zGFmYK08kPYWclJzlIOtD6SghpF9T3lwcNqk?= =?us-ascii?Q?qn/o+rbXiZuwyG6tsjDGxzmOyOEaq57YfMFAKCwnPTndJ3n1r7BtcDxf6E03?= =?us-ascii?Q?sG0M2jj2TdeKF0pJ7UbYv7dRUGTPo4XlmhQPLjptLDRFNSbcRAzkr7ai6qdB?= =?us-ascii?Q?AL/0LQSifO94SKnk1mKDfYkwIRgsooB1CJIM8tKvGXYJ5FBYqLyVEn0ozcIn?= =?us-ascii?Q?sCaIEeOCqi2pPx/lVBwnHpTRdVgJFlBGCpTW4i1DTONsUhcb46X0s8BwbTsL?= =?us-ascii?Q?GUiIh+4ml5RgMceW1IPhAtYhskB51Oa0IHqDFXdLLEjuCl150fCN8ZQMJlso?= =?us-ascii?Q?uPa8OOxM6o1fyMT38rTS+uqQiebzk6/xN2C7MtJtVYPg/j+wwSuDTaL3kQcI?= =?us-ascii?Q?JPeum4qPjXJVwluR+luzPszpWyBmRO5hOVZIVqjt2NjD/3dh/hBQS40XSjjw?= =?us-ascii?Q?1uB5H/xR0cTAXktKJXybC5ZHtsti21QxWlaXys4QZKWSWq1jEgvApz5Q+Ibu?= =?us-ascii?Q?bmW3zVE8DjvfEZPltJBhAd77JF1VgWVHNOucCkiHxJcVetLcEfbwb/j7G/QO?= =?us-ascii?Q?nUAhneuGL/XzbP3hplomYtvvE8rvPQ7NLZbbepHW9oABrhgge8FSToOkQIfN?= =?us-ascii?Q?HyQU6JNvxV8BQJGay7io3bZs7Vd2JU+lSjNIqZRtQVwyxfYoCCkY6EQsjVgm?= =?us-ascii?Q?qB+i47L7op++nSM/PdD6xEk1A0fP0v/kdqNbQLU07f40yeC10eC5CrbufKZK?= =?us-ascii?Q?ZJdyyeeUopTB5STLdfRcyYmK92W+XL+hsDmwqMyXs/MPfL6u19UUxswjdijz?= =?us-ascii?Q?/fZws2UnjuNnkBMio+qW0nGzcbekojQmvaqOLma2qdZ8Mol8NeFTb6PFGpGl?= =?us-ascii?Q?VEMzJlaWF4X0MahSa2ROTGAITzQPrAnA3XJE56ZObveyZEG4EmhxhJ41bsSF?= =?us-ascii?Q?bvVupEoRNB65idif56vyVPDKZLJPg1+5bXGF2Rii0ZT3YSTZoCTL0A2yKP9Y?= =?us-ascii?Q?OCJ3a36PQRReTNzEc7XYFmT9?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(1800799021)(376011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U+rRH2l/b9EDodxE6sga5Y602RxL3siMRrYeH1YCK9WvrgODKA9GiEm+9b8o?= =?us-ascii?Q?xa0ZNHb31IaP3oU1g7lmE27LrmHZ6CdDv6PvLinR7qs07oPYlwa339W/CSfA?= =?us-ascii?Q?Wr2sB+Hiv8DCpfht4+5OMjhkiXpTebFLmATOZrVrRggDd4zp27fwrTHgOaDR?= =?us-ascii?Q?nVSwbNd640Rf86s3D1M3lfiV2RoaFbftKIDSSFj3sq2KQkwjF8NbN6eam285?= =?us-ascii?Q?SFf/X+uzc+dYDn/rvNVxvRjoD9UHjd5jlh+swa1XR5HONg0/BwF3qBcqu/x6?= =?us-ascii?Q?GxGbOyFYep+Ao99UkLwoPEb2x0RrJLlh9Vmdwy9cbssUbKYpuKOuPQs5h5R7?= =?us-ascii?Q?JmXrrROA6EsdKJP4sgnvc07fBpCkCHTL6rFjsHrXOnDFerG2cC6ifRIorg/n?= =?us-ascii?Q?G+HwGx6KgLumntjAfZLV5N69J7eCKA42TOepu5yAl1yKHjq36wSpsolbc6ax?= =?us-ascii?Q?ZrbOl+TcomjD22N7c8zsP8yd+/xdwTIMvTgsi9S3GdAKuFIjRpw/285lBa+2?= =?us-ascii?Q?SBJ1IIt54PGpjmfC3/m16ztSkWSz8ccixEZ+TBrAMlaAzPUghUf8xZSkAzq3?= =?us-ascii?Q?Kp4p8e6mlIRNKOu0PoQWsQgNlOcFG1zCdvTgZIKAQGfwBduJTSAnPyoPSdUJ?= =?us-ascii?Q?mC9tzoc9EfeCvvtwTf85Nt5xVKa60aXiepjraCnfuMOb3eXDbKmnonHLG1SW?= =?us-ascii?Q?eA9pPxqDdtkuBiljfEp7sK9yV9gXoNcyMSbWcJtJYKc0b9nvIMWTuKlh5Gm5?= =?us-ascii?Q?srMi5L9cK/M4v3GqM+Ike0fe2qDe72yvS6O6QpoYRF8OzUbOA2kjLlcAAIem?= =?us-ascii?Q?7Cwvfl7LyOfNm7x4N+HhGnGK6mIFKX3yiRHhjCoXjjWiJe0u+3dYctKMZXMt?= =?us-ascii?Q?spHrDdGbceBMipt7CWQ9A1IIZPwKCpExMvHGO5XM3TddnN13ad67UKYCCvCU?= =?us-ascii?Q?m842HcJNSDU/UadkNQWcHmU5QDyZ72qMX0XHlEv9UTKYzPpTbxaP/TqjTJ1Q?= =?us-ascii?Q?j6ybTwDYqtMp9XojvEXU9ZyWLP7DOSmvASvwcR+YNCxbpER5fOr4rgkj37xM?= =?us-ascii?Q?XIG/IL5c6jxF5AiRU3elH0fECNDfKjdMDUrEMBa17Z1HJQJ28mWFXoHLfRkc?= =?us-ascii?Q?fIGCVO7fggF8cszlh3O06njxoy9+WnsZDxprZXBipfMtH8yvb5IyLr/nyezV?= =?us-ascii?Q?qvgWaGfUu9d6nd4TCh7FLnJdWBmQiP2wN1BcYW3jkLOgtxMJkCn2RkRofOvQ?= =?us-ascii?Q?0FpqHxuqf2j/Y30AVkzgSzCztk+IK3moWTrm8AzhkufGUEWEnpWv8nLIYWNF?= =?us-ascii?Q?Zim0H0bumCL4fNxv9NwCOWTbFE1uGq9IE1vbggbmDVtTNWxdIiLoNylKMxsS?= =?us-ascii?Q?e0IOe6ZB16urbnX+lyIxxugkweJs9M/2WQumEXSkE8pPaCodAp0g7HjWDXda?= =?us-ascii?Q?obdfnrTWS3XMXplB23nBngTZUxEMnaRNZYNrq/hTabyKKgNgBqjshcIWUoD9?= =?us-ascii?Q?xKEwJIK6j04T+IZehplpKuu8sK8WEDGVtqnhwwC/NYbMZvowBSYK/u+0WrhB?= =?us-ascii?Q?8CPLaR+miGY1PB8xVifDNYhrBIWt+Mqe0qOrDGwSqiA7yzBlOTsKW7hEkHhX?= =?us-ascii?Q?kQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 331f214b-4aad-46ea-674a-08dc91fafbd1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 14:03:53.4374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /MUTa2Mv2iv2PjPh3mmQlhLtIQutqki9Ny3Ok7vKvI6/KDcHBRETYy+YqXywY7RM0GVLjMYdyVGLOSHpODncuJ+cuFhwgJrNHhWSgmODWPQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6527 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:02:01PM +0100, Anatoly Burakov wrote: > To better align with upstream release, remove some functions from > switch header and make them static instead. > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> > --- Not sure about this, but I wonder if this should be squashed with the previous patch to have a single patch that adjusts functions to be static or non-static. If you feel it's better to have one patch move from non-static to static, and the follow-up move other functions the opposite direction, that is fine too. /Bruce