From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EEDF454B7; Fri, 21 Jun 2024 16:40:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A8CB4026A; Fri, 21 Jun 2024 16:40:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 2412540265 for ; Fri, 21 Jun 2024 16:40:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718980833; x=1750516833; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=AdLn8ay2T8BbsDUcMyi98sxBJ4+eJn7hjKuR/GCB3Bw=; b=WouM85Gxu3MFi88wo45th0MGvWZl/Tt2SJ44Jf63C62rI2w5o5yYEimB dCVWiFaEe0IKtWfv35cuNIM3ieaGJKEi4Fum7ZkJhqe68z0lypQ84C++n jSL2U94b3LuFi8AXhxaVrXlG4OXPy/Mxahin42k+kuLfDLZpUhYkKGM58 5MsAI5InfiiHUiHCdCV0rz6+3twJQmYrxaLpBPerEVVHvD9nMCg2Ds8Yb Ts6KwQl6ehM/0uCBELqlkvT/Fec/BxV/xS2wMuatezrrFh5YV5tZj5upp YwV2SLV4m10WDFO2aAoegGl/krfNH1hd6qEVdGnLCUkDZCKUbTB5BtVsJ Q==; X-CSE-ConnectionGUID: pBLb6+0hTp+olZr1NBN3kA== X-CSE-MsgGUID: TeMeode2TAqspVfSjXmIMg== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="15772945" X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="15772945" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 07:40:32 -0700 X-CSE-ConnectionGUID: lO+POyC3RhOJ05pgadP83A== X-CSE-MsgGUID: 6tCtztCIQiii88i4h6E3CQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="43292241" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jun 2024 07:40:32 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:40:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 21 Jun 2024 07:40:31 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Jun 2024 07:40:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=erawyU1oLKLK1q2kgAlBxZGpBhmdKYUmwODpG3Uxc8CC2AzkMKkRHZUC6J2J3RCGRHzeFUiNXhMtqm5aehV1G5FzS/CTtkzldcdayd+rEaFw+m1MV9r8Q6TzxvJKbuamkMkZNJkt8rcDErIesHcOz3y4scfoBpQxaf2vREowGSutYfUSaUJS5DxtQ8YTRegESC7XiPCTpLgvC2haBV2agyMI9gULLj07SXn6gyBp0RsSCTPsmuGrcUVD+o+JqQU9mlvXqull/zJHbcsfl8Q7xtBcs+oJ2ELqN3BMiEJ/kgXzBC0NczjYlMVUCDxK776ysQs9qVHZLLS6NtInO6k0Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0jf931uG0I/Ao4xGlbGkStT/vz3QHLWCPHk7hvBX7Cw=; b=dqhDeJE4XA7D/4Jf/Yg9EBoQyjbrMxhmoHBFwLGrMGV+pfPpnjywIoCKx/DT82qwKqOHw/0hiww36P9tBDXdC6zaij+AzEXqmctR8/WCJRirDs5++V28a/3ACkkWSsDhbAAMQKR+xHreh18PaSe22Hg8GpGoF8WFsdZJlBQRem/JdSCDbP2vhb+TIrrBficDyBBTqodYk2H3qSdl12k9l4KX2nOGQfKpDuTu6AAHy7gkJA9ibX8iD3PoKadnx68sFiM1x9GCbJl0xCohssS5pyilcMSnOsQvem+yG27jskmHNrJJu3e2rDKvI/zUwRNQGI7h7F1hqGFmql2JYyDfzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7651.namprd11.prod.outlook.com (2603:10b6:8:149::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.21; Fri, 21 Jun 2024 14:40:29 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.023; Fri, 21 Jun 2024 14:40:28 +0000 Date: Fri, 21 Jun 2024 15:40:23 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes Subject: Re: [PATCH v2 133/148] net/ice/base: fix memcpy type Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> <500defe440e5659dba20f19896440181d1aed178.1718204529.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <500defe440e5659dba20f19896440181d1aed178.1718204529.git.anatoly.burakov@intel.com> X-ClientProxiedBy: SJ0PR03CA0197.namprd03.prod.outlook.com (2603:10b6:a03:2ef::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7651:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c3b195c-a0ca-4b18-6742-08dc92001857 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|366013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?M0xjpeQEomLXgg+WzkzSjmymWQ5pepogyOkrpZaSCyg0ccmeArL5tjT7QMGF?= =?us-ascii?Q?mE958oz9pwdnGiu23WTakYMR0l5zXv9kEjZdJirPp4JCozaWiDHXXdg5yOGW?= =?us-ascii?Q?awfJ2TuVFQ7o8SRpYeQ4H60IzBbhd3cN+GFazlU6O1Hz34SWP7MdiFyJstET?= =?us-ascii?Q?HVnnWFTngwzYwkxs9RSwaFnooPla/17Z9MHG5zulgGBtfycCx6jGCqmcmR8C?= =?us-ascii?Q?eo507Ha/HePsuktVHKB8kCUDF7iULNuY8nMyHHJd0sJG5laiPZlp2fsUyMjL?= =?us-ascii?Q?X1iP95uqZBgMWa4ThkQVE2w6uHHm7+T5W6cUmoXkGtP+JvaE8QHwszRKuN5l?= =?us-ascii?Q?dnKGyJzxdVLLXtUbHZJF44TvcSKU949c3PGLBcQvuMN4ZKV3U45yX8AiRJc4?= =?us-ascii?Q?rKhAxuAoSnfRkl83skZyVb0NYwJcqIxH7pqivYLspz63YzIBIqDXfGHOuuYW?= =?us-ascii?Q?fK5/Hv+i+mmFJiVwZKUzGNrw94vls3RHlq20AwtF/flxXaRoQYbFSX8ZDgvH?= =?us-ascii?Q?uzuyeVYNKjWoLzftV9rSIRuwVB5b54qQ5x697zr2wp6sW/CJ7IWLoT1FLCyW?= =?us-ascii?Q?7f/Cgm2Rbk6qBQCZazNGEb+FpX6N8FBn4dos4ZEpZTcO2kL6QJphDbsmLWdN?= =?us-ascii?Q?A43K/xZquC0Mxwk3lm6YK75h4UrV5QhkZa1YWQr1kP4VWyvt6kF0uzCtxcKO?= =?us-ascii?Q?3MdBrZxMQyRa0wnLZKNWUZe20Ha0+qf8RIZGBVwyHYz2mFw85EgMdsOvETyl?= =?us-ascii?Q?rl8XSb/cjjTbA3p9flPY6K/tI7VxajK7697rmi0u17UIddnKwGu/XykB2dbg?= =?us-ascii?Q?GoAHb2f+XWi8QSqzU8flhSbb8JXeSzavw8UNSK5Dt+FydDOC3J9bOH5OIfZr?= =?us-ascii?Q?Flf6fwAlXWK2ssoB0XMoFxwb8rnOchn2fpgEOxpTEaF4ootIprMEgQF4bbSC?= =?us-ascii?Q?OlAe1LOjEiF4PY7k75utOz7oB+kJlWUN1mhrxZD/PZT1XokqT9BB9dKtdoWN?= =?us-ascii?Q?mCcNY2cNCLLCAh2zYtk5qwS16KA3yPKmFigTjxkZfTcGjoxVcqiHVq+dOL4A?= =?us-ascii?Q?fHc7St4PA5SH0FuD28VfR0/BTvvAKzflpu8t7wpdvPF1r5QoUMPx33qQWGtq?= =?us-ascii?Q?qpCix1W80KlK91mBU+1DQa8+N6zKl2scfwdq8HCK3xv8JthRimbVKDDSmlU2?= =?us-ascii?Q?jsw/71jsBHDYZO/B0qRxZNov2ZZi7qBi+naxche/VjVofcTGoo0KO03k/zhQ?= =?us-ascii?Q?UKgn10zJQlEsdRZ3hp7fF2lAboSjO8r8s8nwd7wTvohjJSlNI87m3mxPLDfE?= =?us-ascii?Q?Pgio972RDbODW4WM2+c69w5h?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(1800799021)(366013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ydbwaimDlnIYiQuCyxQ3FZP42C1O3MMLZXJndi0xrt9nKyyhzlXYVVCJNgfw?= =?us-ascii?Q?6ZiEcaPCKEdDf2h4PBWn882unA6GKVNqX6TXik6Yw+k9/BLKCAzkel5KOK6p?= =?us-ascii?Q?unPKjxhcZd3kI3f9jefdqMROVQId/ixP1UgtzXQCkjsuvVplt/SXEZmI7L1d?= =?us-ascii?Q?x7u2FX/oRxKT8t11CEF2pdBAl6rL8Tn2FfHpwrPPXbTtiYKleXXg0tqp582/?= =?us-ascii?Q?PITWv/pgm/ekjgHgtyDSaR2a2eMv+X9eWN/XQZx71Ltj4DlhTfBZ394ICQ4J?= =?us-ascii?Q?0Iy1XamkMmiitoFM/rIuxdNqDMSgVFp8G9mpYyrcOgTSlGD7Bd2YAWMQeFzX?= =?us-ascii?Q?fUT1aJOtzhpJtqJrtJSi26lx/+hbnwVyGg2TZCYcj8g0NBYfCfLhykb5de0j?= =?us-ascii?Q?L8af8Q29PvQzYxA4LgvK+R1S46TvHnp00c3OOR1nQQgtx8kLBCzTR5P9O4UE?= =?us-ascii?Q?m4Tb4ZBJBpkNvM/A37ebWBiqr513P0j51E3lKgL12BPlF1yoI1AKMLKxFyzZ?= =?us-ascii?Q?iFeOYaJ/4xqpjrM3hGNQOD9aFw8UsrGYCzbulm9kqmLRGuwwrWlIIlzdeZvJ?= =?us-ascii?Q?kdNzY8lj3u8LBvyYdR8bv2g89o/urgv1YXeRl4P6+w/1XtISY4qKToPIttc4?= =?us-ascii?Q?mj7VlhOz39vBKe7TIzB1zsirPPiNSUzbjgz6Zg+kYlnW1/7lZW9C9Eg5xRTk?= =?us-ascii?Q?OeB9jiKUa3xDro8xBckUG0xdQKhhVHjq8ZnOwZa82ER2FZpdDONoyJEKh0BF?= =?us-ascii?Q?gRch44UwZLrCQOe/YxQ6B0Hz+X2X1/I04cmPgitxnY3f/3WoLTXnj0iRQo4/?= =?us-ascii?Q?+mOGHdQHDWclqi1AFmflJ24BqnR/SO5BVfi03w07kVMvCf6mYh0QUa0lNG+Z?= =?us-ascii?Q?dUEUo34BY5z/fn6SwTVgfuY8VzG10NTFKb2dFLjDagH95JpfeCU1XenQgW6A?= =?us-ascii?Q?O/7pbnCXoeS/3EzES/S9Ux38MZ80v7DV8foYN4helP4EwR+BB0mQ3ATjqslK?= =?us-ascii?Q?Eon924/TMGu5VWOC7+bSu0s5NJBDI3/zoV2Srn1EhcbdDfZHjBmsIP/3xMzv?= =?us-ascii?Q?GgPnkmqOY4UTm6mYtzwIKXB8vnsbdZWbNJe3uUr5K4IL+0k/Ub+mTIHJdl/k?= =?us-ascii?Q?HhQkzQTMgwWL9t9tPuedbO6Kpsf17iOK1K0DeapwkqVLWboCPj9oDA9zVgkq?= =?us-ascii?Q?uJFXzWjDATYAgZTSrj/LJ4WWOvI8CiBmfKhYRvThiOGZ5F0FQOjHp/6XXzpl?= =?us-ascii?Q?FaSynI3Cw2Rwxdmvlb8Rkgv5lm4d8R79dKhhhlb0QCoxUX8D1Bw0T4s2Ijwy?= =?us-ascii?Q?RTYPfLnIKTU1vZxX7AbsubzrHLOV5osWJo6h1d1kcVxG4ZaeyTyFGoOygpEN?= =?us-ascii?Q?ap00Ve91R/luJUI8bi8Uc6Up2gyAaccWnk3oLBxxs0QHMUHWQjsUKT2l+X7k?= =?us-ascii?Q?W6dB04JJPQMZBwxa427IXxpvPRQU0C9QjDqsExzDRcSgb0ubORLmj0tiT9jl?= =?us-ascii?Q?t33onZQya1AEm0s3hjHlBzYTVe3BqhcBXOsguisoxL/zsuiXXiRnD+pcibBy?= =?us-ascii?Q?mbAK0sIqCHwrVzlvbZpuRB/q8lvht73O8pxmA+eRMsmOFWYImSzw4sfC1VWn?= =?us-ascii?Q?RA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1c3b195c-a0ca-4b18-6742-08dc92001857 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 14:40:28.8308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b8+IPXBtH3hYcdup3suv9QXZtbrKNo2+R4inIOA2AVdOpTJpwaCFMta5MzY60+ejLarKKf+e9wzENlf0MAw5LJvPQrPZ5rBzlcZWBZwIQeA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7651 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:02:07PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Modified function ice_aq_manage_mac_read so that ICE_NONDMA_TO_NONDMA memcpy > type is used when copying MAC address value from AQC buffer to hardware > descriptor. Since (in case of tools) both locations are in user space there is > no need to use ICE_DMA_TO_NONDMA memcpy type that was used previously. > > Signed-off-by: Stefan Wegrzyn > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c > index 9991be98a4..df827c26e4 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -380,10 +380,10 @@ ice_aq_manage_mac_read(struct ice_hw *hw, void *buf, u16 buf_size, > if (resp[i].addr_type == ICE_AQC_MAN_MAC_ADDR_TYPE_LAN) { > ice_memcpy(hw->port_info->mac.lan_addr, > resp[i].mac_addr, ETH_ALEN, > - ICE_DMA_TO_NONDMA); > + ICE_NONDMA_TO_NONDMA); > ice_memcpy(hw->port_info->mac.perm_addr, > resp[i].mac_addr, > - ETH_ALEN, ICE_DMA_TO_NONDMA); > + ETH_ALEN, ICE_NONDMA_TO_NONDMA); > break; > } > return 0; This change is similar to that in patch 92, consider squashing there. /Bruce