From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0294F454E4; Mon, 24 Jun 2024 19:56:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BF68402DD; Mon, 24 Jun 2024 19:56:45 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 09E19402AF for ; Mon, 24 Jun 2024 19:56:44 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 4DE851D7D0; Mon, 24 Jun 2024 19:56:43 +0200 (CEST) Received: from isengard (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 66C8D1D81D; Mon, 24 Jun 2024 19:56:42 +0200 (CEST) Date: Mon, 24 Jun 2024 19:56:41 +0200 From: Mattias =?iso-8859-1?Q?R=F6nnblom?= To: Thomas Monjalon Cc: Mattias =?iso-8859-1?Q?R=F6nnblom?= , dev@dpdk.org, Morten =?iso-8859-1?Q?Br=F8rup?= , Stephen Hemminger , Abdullah Sevincer , Pavan Nikhilesh , David Hunt , Vladimir Medvedkin , Bruce Richardson , anatoly.burakov@intel.com, david.marchand@redhat.com, maxime.coquelin@redhat.com Subject: Re: [PATCH v4 13/13] eal: provide option to use compiler memcpy instead of RTE Message-ID: References: <20240620115027.420304-2-mattias.ronnblom@ericsson.com> <20240620175731.420639-1-mattias.ronnblom@ericsson.com> <20240620175731.420639-14-mattias.ronnblom@ericsson.com> <1751466.UtaOMtURT2@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1751466.UtaOMtURT2@thomas> X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 24, 2024 at 12:05:53PM +0200, Thomas Monjalon wrote: > 20/06/2024 19:57, Mattias Rönnblom: > > Provide build option to have functions in delegate to > > the standard compiler/libc memcpy(), instead of using the various > > custom DPDK, handcrafted, per-architecture rte_memcpy() > > implementations. > > > > A new meson build option 'use_cc_memcpy' is added. By default, > > the compiler/libc memcpy() is used. > > > > The performance benefits of the custom DPDK rte_memcpy() > > implementations have been diminishing with every compiler release, and > > with current toolchains the use of a custom memcpy() implementation > > may even be a liability. > > > > This patch leaves an option to stay on the custom DPDK implementations, > > would that prove beneficial for certain applications or architectures. > [...] > > --- a/meson_options.txt > > +++ b/meson_options.txt > > +option('use_cc_memcpy', type: 'boolean', value: true, description: > > + 'Have the functions of delegate to compiler/libc memcpy() instead of using custom implementation.') > > I suppose you propose this change for 24.11? > I would prefer getting the option disabled in 24.07, > so we can run tests during months before enabling it by default. I think I would suggest having it included and enabled by default in 24.07, but that is too risky perhaps. Having it included in 24.07 and disabled by default would be the conservative option. > This period would also help to make sure it is compiling in all cases. > Please could you enable the option in our compilation scripts? > > I'll give it a try.