DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/tap/bpf: fix meson warning
@ 2024-06-25 17:06 Stephen Hemminger
  2024-06-25 17:17 ` Bruce Richardson
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2024-06-25 17:06 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

Meson was warning that run_command was used without check and
the result of that will change in future version.

In this case, the command (uname -m) should be checked.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/tap/bpf/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/tap/bpf/meson.build b/drivers/net/tap/bpf/meson.build
index df497948e2..35d7438c74 100644
--- a/drivers/net/tap/bpf/meson.build
+++ b/drivers/net/tap/bpf/meson.build
@@ -44,7 +44,7 @@ libbpf_include_dir = libbpf.get_variable(pkgconfig : 'includedir')
 # The include files <linux/bpf.h> and others include <asm/types.h>
 # but <asm/types.h> is not defined for multi-lib environment target.
 # Workaround by using include directoriy from the host build environment.
-machine_name = run_command('uname', '-m').stdout().strip()
+machine_name = run_command('uname', '-m', check: true).stdout().strip()
 march_include_dir = '/usr/include/' + machine_name + '-linux-gnu'
 
 clang_flags = [
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/tap/bpf: fix meson warning
  2024-06-25 17:06 [PATCH] net/tap/bpf: fix meson warning Stephen Hemminger
@ 2024-06-25 17:17 ` Bruce Richardson
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2024-06-25 17:17 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

On Tue, Jun 25, 2024 at 10:06:52AM -0700, Stephen Hemminger wrote:
> Meson was warning that run_command was used without check and
> the result of that will change in future version.
> 
> In this case, the command (uname -m) should be checked.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-25 17:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-25 17:06 [PATCH] net/tap/bpf: fix meson warning Stephen Hemminger
2024-06-25 17:17 ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).