From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 135DE45501; Wed, 26 Jun 2024 14:20:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03D1343363; Wed, 26 Jun 2024 14:20:47 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id C7D9B40269 for ; Wed, 26 Jun 2024 14:13:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719404012; x=1750940012; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=IxSax2Z6kSjB2Ep8T329/O7J6rCGAA3iJ30Xl2vIQ1U=; b=OU000TYowrB9tZNdF7bdS2GGO/lI1rnKK57sk7ty8JhG8DsGA5I8LT5/ AHje5k6pMdjrOjgQACzr4sANcE0u8dK1IYl0de5iztBOhIeXPyQomeTgC i4CkjUMuNzuJhTvSZoLvtKwyi8bSnfLTvIaJnVQkM/JN/QwKp5y5YAI16 CyBKsqW71YsP0DfX5zwD7ltpJ/LWWeKWII3kmqNhIq2iGCto4VHd7nt9i gXm0w1+PgqJ2s0H85RdwEfuvCeTXS+cTWtYsfVSvyzCQV/8+bgw+yR1Z5 /uySzv9ToeqmWuRAySjZ7E4Dc92CDWkwsqRiummKoH1efSnjlVihfysix w==; X-CSE-ConnectionGUID: 3KalpRPjRaS+W5usqM9LCw== X-CSE-MsgGUID: KkNhno+UT1KwDDtiyBDGnw== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="20287048" X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="20287048" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 05:13:30 -0700 X-CSE-ConnectionGUID: EyjIAyj1QZahhk2MqXvjng== X-CSE-MsgGUID: A6ms2QXARUy0oJR9k0HF+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="44634208" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Jun 2024 05:13:30 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 26 Jun 2024 05:13:30 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 26 Jun 2024 05:13:30 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 26 Jun 2024 05:13:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQzWlUJ0GSoVgHgoT1H0Wzdm6fcKaZtbpqvmpa6fQKIZqmUexGKwSIHW9Sbl1DJKCVqCoufRiDaM6Sud4Cp9vSi7u5J+sWHfJOoD7ozbNTmGuuiiOcJ/swdHCU6pl4Bd1YHTZUF74pGeRx7lFKi8dLT94MEhJN9bfRqBmqJ2Tq8D8/0Gty2V7Ji29Q0Ab4t/BvoanQXmA+3Rg8MTAyIGvELaxaV36INAwza8cXEtgHU8YVfgjFPz6KjcxJz6GTxl8APG/VOiOtsoOGsPC2Rt8b/wH7/waADAu9LfAgChKI0CdKaYX2POslq+xchLc5W9JeY8nMP+ODkPz/kKRnpZ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yf2n8zgSBgFtJyWva6BVC8SXLR8vjxs/pWS45gVRFBY=; b=Ejmvjbu9BqMpdZHJv49kOnes23OvUF/MUblABjtW6vGdLcKj21W7N5E9kUv24Q8I1yVBD2aOL/5hpWZyKVVWs1yvpotDIf75mExn6g784XUCOn5/lY6vPV2m41cH1G5R/E/KrGm18j1Li+dZdUC6fNQaC9mutWSTugSkOEYUmRT2AuAyTF31Uxamp5cAv6jJlU8KlHbx6VObnzwXmjMgrLZg2qWNGEEPDzsAGxEPn/lqXicZyHvBOrR1asH84wMcAMzvorsW9Ni53rGU/2/lS5KtdK5vrOVY41svDbPoeYc0Sf9UmMDDXACwygKYtfAenYlHXWPlRImhY1N/+tYqpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW6PR11MB8309.namprd11.prod.outlook.com (2603:10b6:303:24c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.26; Wed, 26 Jun 2024 12:13:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.025; Wed, 26 Jun 2024 12:13:24 +0000 Date: Wed, 26 Jun 2024 13:13:19 +0100 From: Bruce Richardson To: "Burakov, Anatoly" CC: , Subject: Re: [PATCH v4 093/103] net/ice/base: make Tx and Rx vernier offset calibration independent Message-ID: References: <0051908f-eba5-4ec2-a3de-952b1528ab53@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0051908f-eba5-4ec2-a3de-952b1528ab53@intel.com> X-ClientProxiedBy: MI1P293CA0021.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW6PR11MB8309:EE_ X-MS-Office365-Filtering-Correlation-Id: 258f8550-6e4f-49e6-8429-08dc95d960c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230038|366014|376012|1800799022; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YZbbLlhipOX1iLTyVGb4V7GUoAfNE914wcUEu6x5TWtyWNXJ4a/dYxBmyvs+?= =?us-ascii?Q?VG1n10yRnu79N11qgJDMQ6Zl7el58dPfU1TbttU8dRSeDjRZkbQGCT+ZsGDz?= =?us-ascii?Q?Ft8Dlr2kvWBLVrVsFrq3RGqY0DCTKhMgbVbYsr8Tld5sqAZp6Vfoxdc8srQa?= =?us-ascii?Q?ePkIeqFPpvRLTFJVQcXwBYF64AIaDnm5GZZva7Pnt7y3QzB9t2Fp51tHGLKr?= =?us-ascii?Q?URaB8XAAbxIBtqgu/LYAHo2g8SLQs9eHYzXcoH4AfJIcVXXTPdRCMI3XGM9B?= =?us-ascii?Q?XCZBKTJH2V5ExSm1QlwYW8Rtny0RzGk2nV+Eg4BJW7fpg7Q6j3uj0lhSSxyl?= =?us-ascii?Q?1HnvEPZGnv1xykCvfs+PtZfYUXYYw7nc8WQF1sgMG4rhcWk+QILNiDl+b7S+?= =?us-ascii?Q?WGCzmeHCUDkojl/3nownQxRVSq8X0Z/FcFHwpQh0I1px6Dz7JKWLwgcw4xUf?= =?us-ascii?Q?H14g4SJhAKq433fD5AE+CRO+03bLNmJONNA8ZcIkEf5ZLJHKblHJL/kgkHqF?= =?us-ascii?Q?QUgwN6C03E/ZkSSm7uN+Hx0Py8QieGizE//iIyEOUWtuMKNFxAdGOTBpGMmZ?= =?us-ascii?Q?lQQmcoTqd3gVzUcvDAKTIE4evYb4xyeWEw8OO/sjqD1pSpqqFrA+uPqA70xG?= =?us-ascii?Q?2TWjMck+H2rGojZE7pREznzz0fC7QC7XEiMxeIjoQ1JwiibNcMb45OmBq8uZ?= =?us-ascii?Q?TpsUQUJU7p0k5AkimsyyAcczIGXpNa4DJXIlV2iiPiSi/UcYwUV3yajn/hBG?= =?us-ascii?Q?Z3Iout6e9tIHOZR0vrv3HUJ9wyxf6Ot+RnWswZYTksNWlbeGgi9hu4XkLoNe?= =?us-ascii?Q?7K/dv4MlZWZH/aHS7CVU04fdjqQfiaGoLrBALJXKSr0To7FrpPgrxkL9xiKZ?= =?us-ascii?Q?3MZKmG+ezmrHbzOXgCATOzLCKOdYUuxcqwpOzOtTVppFPVzxYhtY4qJqlB0e?= =?us-ascii?Q?MA7kLWfn6Fyb9rD2V2dqacf/xe0IRB3cEYmEvXGRgtII1MKw4mE+3pyeVKBA?= =?us-ascii?Q?IdhDwaBFc1tasQucIk+1aonm7VOgWUpVI9V7E8w8ZRwjOwzjSwcgYotdqlgY?= =?us-ascii?Q?7BJ2tQ3ee3Lld9xDqVPcHW4PwXx3yOBTKSa5bXswkoLiF9vpERSzFmiLRRGc?= =?us-ascii?Q?q9O5B/cknZV9hkIgFEta/QrQQtHGHvnDnHMlpOb2lW6ih/H9ghRsx2g8FD/l?= =?us-ascii?Q?f1UCIU/GNpurh6l1Hm9eTt7eJIheGoU6w22/l24yRCjREEbuEo5dDqZf5DGP?= =?us-ascii?Q?9bd9FYpDcjxQhA+jJylJ5ACvTAd8bEyJTZvAMFpBJXJ1oFFmTfiC/qqnc7YT?= =?us-ascii?Q?hSBRQz1BixXQHhoAdFq/UBX/?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230038)(366014)(376012)(1800799022); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yDYqY1/4kPgzIZt8FWk9acm8YyPMaqZWgv0EZXZgJTGBUyrBnEZ8IOUxHnO8?= =?us-ascii?Q?CmI+ijUJ9bvnaDk78cQvFy7RFocvEk4XqFkCegHI570Iin7ZbHAynUXvTFLx?= =?us-ascii?Q?HqWut3Qt5TEOPltBQqwVkqH1aT0K0O8ech+cMumTenmUVKGVSGAlHZxGbcMf?= =?us-ascii?Q?19s5mjsIG9601seq6ROE3uXGRQgA0F+8DDLdbaVTBCnC15HcAqvaxQ1kXVCX?= =?us-ascii?Q?zfKEghwLyv8pLgMxxhYyDbSAWoDOUx15Hr9eXloqUyA3XiHMzAIle+PoHKlZ?= =?us-ascii?Q?5zQxK+8aEL6LR6PfVfVV1byHJA1h29Iv4YDZ4tXhjg9TWW2CFJK3lXkHVaRF?= =?us-ascii?Q?+pNOEEyXDoVrsVR7eWnGkGLJaJeMScpVhaB/r7xgjcEV+DqrmwAtV8ayAAHu?= =?us-ascii?Q?zfg3yf/+eXnWZa+t+v6XO7ME2x8UMoOphT/+K3Eef3mX/AVlovcJHI6+4dbb?= =?us-ascii?Q?lYVWWrPfrpsB16D6WMX3RcgJk14PIt4Fib1R4+bMFocwu8djJaF+Y1MpWGQI?= =?us-ascii?Q?YbuVzgEEVD5m7SmJMrxtF7I/f4nl/hlJVXPxcik23K+xNdBCMIJlmdfRx8e0?= =?us-ascii?Q?03QvIuIC7dAoM8s4PrIisbDaY/vG1KRnKO9I8ILTRo5IguJdC4w2HNRYDkP2?= =?us-ascii?Q?hd/9fG64tXYfkSafnJtDIkG4tmXHJKNz44xzWoRu8PThSCh2PYs6UKBYi/y9?= =?us-ascii?Q?WbGNS9xi7nQRb3FA8ADluBAQcBX9Bcqd/ISK4iJw51oqZfGk6LTN21C52Zxr?= =?us-ascii?Q?6FC3v3O8nwMKkpaRGyX/Cv6DLw+0uju6LhYiTaVQzB2WatHg2CeZHgk7pSm5?= =?us-ascii?Q?icaLMql+1tKKNX3R+89mg+3IyiK/uJfliC54zVhvKvuvmS9dRuXvmUnJ8U/y?= =?us-ascii?Q?HQvaqhxUPmXf+oLcXZOVL+RXlffJSSefyNiZRnteeif+CN9qlAUuOYSo3mHq?= =?us-ascii?Q?kVrlk8FM/qxJnLfkbu5m/um1EAyxgPeDAK3tusOrZ038hkZmaAxCWD4J0nph?= =?us-ascii?Q?Z9OI4LYKj5pP6+OWVQMPj9WKKES9lyOHPYNSgb3HTDc1x0xCTI0HHf7lFhPq?= =?us-ascii?Q?mHmSAG5ERvKH8s8gU1XgudLSgYpYtRSKxGhm1t/zwFkWxvYF53U03Sdf2N+l?= =?us-ascii?Q?S7wG9hFmje8GXRxm2OsuoMYkO4CgHUSkmVsRt24nLw7pa1C/DRkRPtF43XOV?= =?us-ascii?Q?8PyF0xQKpQAPOLsPIuBx4LkZHjdAx3VVBclyOY6OMArSszdieuzf08aM4ns/?= =?us-ascii?Q?kbHakLDpdA5upG5wvxSaaeaMpsN++KCcqeVL1ZdMjSp3UWB884KS0WI6rOYT?= =?us-ascii?Q?tGvt7x/882Dn0k52bjsrzS7/Ulr1jYKeYE2ueJpRjfTl+llJIBb7+ulT6vv7?= =?us-ascii?Q?Ri7bnYpF7mboskMdUCUd8uA9/5boy3yW5SU3qGWDCgkaD1EneyAtUUkpF8af?= =?us-ascii?Q?VSqI4k5hKYtK9zdM7CznZjr5xjJRwfsH3a05y4Uzo3//EbXtTklbDx1SSWBM?= =?us-ascii?Q?VpB2V9cW/XPfviY7af5HQ6iAD+7cDhO7dZp7415i6qmgoNn/TmCs0gSEWHoJ?= =?us-ascii?Q?zPO48iTTbuGYaXyxRv40oisxzwLM/aR0zTpzatomdKte1P+RYL+IxHoFyxOd?= =?us-ascii?Q?EA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 258f8550-6e4f-49e6-8429-08dc95d960c7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2024 12:13:24.6000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BANYwTb5DW8vjTVjcTjKIJK762WVod+necs9+7tbByVwThPfJ2uKilWpBD6hpKJt9SjTi05geBG5PUWNZcfjHTTt8FGD5cCmdA+Q/hTYef4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8309 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 26, 2024 at 02:11:32PM +0200, Burakov, Anatoly wrote: > On 6/26/2024 1:42 PM, Anatoly Burakov wrote: > > The Tx and Rx calibration and timestamp generation blocks are independent. It is > > not required to wait for both to complete before programming the offsets. > > Instead, we can program the offset for each independently as soon as they are > > ready. > > > > Modify the ice_phy_cfg_tx_offset_e822 and ice_phy_cfg_rx_offset_e822 functions > > with the following additions: > > > > a) Check the relevant P_REG_*_OR bit first and do nothing if the offset has > > already been programmed > > > > b) Check the P_REG_*_OV_STATUS bit to determine if the offset status is ready, > > meaning that the hardware vernier calibration steps have completed. Return > > ICE_ERR_NOT_READY if the offset is not yet read. > > > > The driver can now simply call ice_phy_cfg_rx_offset_e822 and > > ice_phy_cfg_tx_offset_e822 periodically until the offsets have been programmed. > > > > In this way, the Tx and Rx blocks will be enabled independently without each > > waiting on the other block to complete. This can enable faster calibration on > > some setups which have a low rate of either Tx or Rx traffic. > > > > Signed-off-by: Siddaraju DH > > Signed-off-by: Jacob Keller > > Signed-off-by: Anatoly Burakov > > --- > > The patch has accidentally been submitted with incorrect authorship > information, please amend on apply to being authored by Siddaraju DH (from > first signoff line). > Will fix all such minor issues on apply, no problem. thanks, /Bruce