From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [RFC] test: remove dead cfgfile tests
Date: Tue, 9 Jul 2024 10:21:31 +0100 [thread overview]
Message-ID: <Zo0BG8GYgx4v1U3Z@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <2738480.mvXUDI8C0e@thomas>
On Tue, Jul 09, 2024 at 10:57:55AM +0200, Thomas Monjalon wrote:
> 08/07/2024 18:55, Stephen Hemminger:
> > The tests for the cfgfile library were never built since the conversion
> > to meson (in 2017). Remove the dead code and files, if someone wants
> > to fix them then they can be restored later.
> > See commit b5dc795a8a55 ("test: build app with meson as dpdk-test")
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > MAINTAINERS | 2 -
> > app/test/meson.build | 2 -
> > app/test/resource.c | 276 ---------------
> > app/test/resource.h | 106 ------
> > app/test/test_cfgfile.c | 334 ------------------
>
> As far as I remember, resource tests are different of cfgfile.
> What is the problem of building cfgfile tests? Many errors? Which kind of error?
>
cfgfile tests use a dummy config file as a resource.
/Bruce
prev parent reply other threads:[~2024-07-09 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 16:55 Stephen Hemminger
2024-07-09 8:57 ` Thomas Monjalon
2024-07-09 9:21 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo0BG8GYgx4v1U3Z@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).