DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] dma/idxd: fix failure to configure a device instance for DSA
@ 2024-06-28  5:34 Wenwu Ma
  2024-06-28  9:27 ` Bruce Richardson
  2024-06-28  9:54 ` [PATCH v2] " Wenwu Ma
  0 siblings, 2 replies; 8+ messages in thread
From: Wenwu Ma @ 2024-06-28  5:34 UTC (permalink / raw)
  To: dev, bruce.richardson; +Cc: songx.jiale, Wenwu Ma

In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs,
DPDK needs to write a correct value to this file when configuring a device
instance using the dpdk_idxd_cfg.py script, otherwise it will fail to be
configured, this patch fixes the issue.

Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
---
 drivers/dma/idxd/dpdk_idxd_cfg.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/idxd/dpdk_idxd_cfg.py b/drivers/dma/idxd/dpdk_idxd_cfg.py
index c0c833ade9..9ca4c4d76c 100755
--- a/drivers/dma/idxd/dpdk_idxd_cfg.py
+++ b/drivers/dma/idxd/dpdk_idxd_cfg.py
@@ -104,8 +104,10 @@ def configure_dsa(dsa_id, args):
                  "priority": 1,
                  "max_batch_size": 1024,
                  "size": int(max_work_queues_size / nb_queues)}
-        wqcfg.update(parse_wq_opts(args.wq_option))
         wq_dir = SysfsDir(os.path.join(dsa_dir.path, f"wq{dsa_id}.{q}"))
+        if os.path.exists(SysfsDir(os.path.join(wq_dir.path, f"driver_name")).path):
+            wqcfg.update({"driver_name": "user"})
+        wqcfg.update(parse_wq_opts(args.wq_option))
         wq_dir.write_values(wqcfg)
 
     # enable device and then queues
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-07-09 11:14 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-28  5:34 [PATCH] dma/idxd: fix failure to configure a device instance for DSA Wenwu Ma
2024-06-28  9:27 ` Bruce Richardson
2024-06-28 10:08   ` Ma, WenwuX
2024-06-28  9:54 ` [PATCH v2] " Wenwu Ma
2024-06-28 10:25   ` Bruce Richardson
2024-07-09 10:18     ` David Marchand
2024-07-09 10:22       ` Bruce Richardson
2024-07-09 11:14     ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).