From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3328645695; Tue, 23 Jul 2024 15:57:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B85F42D7D; Tue, 23 Jul 2024 15:57:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id F23CA40A75 for ; Tue, 23 Jul 2024 15:57:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721743076; x=1753279076; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=PWsdXQl+WAJJPlPXNVd+bER3wD7tkuJApDbP0Sg3f2w=; b=aM32bN7DgqL8kdTtLsk1TaC2bBgyHflv+dZFRbUQNJnkI9LqXzCEJF64 IkZacvHjtH3H7oF+Caf+B2jphfHFdOYETejslIpl+sfs2G/zJqbOmo/E2 EMBEHKhx5megWo42CP7mesn/9vedPjt0i1fXqnn65GNON/n1wPm5mglRT V+JEcLcpDPV5fFslI81Pr61kXHOuZaC+/+WRwMnv+NeqcDu7QjsLwHQ1b NDT2Gldre5e1eil26P19nx0jClA2AkKVTAECUTtis9VlU2R3dD4o5tUQG AITVEYVyh4/T9/gs+q3Y9MqF2BlpL8NvLBi1462nk23EeDtQxiLX8OmJu Q==; X-CSE-ConnectionGUID: a5Lsyu7OQ4KJ0nHLXr17kg== X-CSE-MsgGUID: Tj8CqoSCTrqAjhLIgY93aw== X-IronPort-AV: E=McAfee;i="6700,10204,11142"; a="19217906" X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="19217906" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 06:57:51 -0700 X-CSE-ConnectionGUID: XBr68D9gRHSH8n4mQfSfuQ== X-CSE-MsgGUID: bQcALdJoRF++VzREp003Ow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="56396542" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jul 2024 06:57:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 06:57:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 06:57:48 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 23 Jul 2024 06:57:48 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 23 Jul 2024 06:57:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gSSMPYyYw6K8K3JalR9ei/JsMCHYvQ8ivELKMUOpdDpMluIRhwtWw1YRCDGZfyhZLKQ+ndJknxrh16PY/xSoVaxjwO1HWBPK++u88NJdGG0M4p+GmKzzbqA6vUm41Wg7GF/P2+ZAwzTBXsY5/MUA2rN4ssoKiHv77D0n9kMlB7KL98ATy5+02uAqi0TpO5py6xAHbkDEi+nzGE6H5L1l6SXTC6lXj1ccxtPcarxhpSIcWbyUkLevb4bMmZ4lc9jPgbe4BrN9A8VK84vl9ExsfuEk9TCw7vlzVLIiWzC5/0wNJA23+wilLOWwKQpdb/lQVM3oz1eCvS9cg6v1KQNysw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=171IvXOPCeU8dHqCUyKeOHdJ2EtjdeYl9zjIbBosr80=; b=mF7OZUbtRTA3D4gnyJkL6IQagHzHczdzPi1Uob3wcXqQxrPTjqMN1SwiICMlBhy7nYvpQXRIIPKruasuHKPD+iLLxesPWYDUv26Hs/id+bDClgLUdc9aJa/Jq0etM7mWh3LlXAw5FN8ededimVKWjt1kzNqwLUq9buW9YJ9vx8l/64SbEFQv3fVseuaO8I5Ngup4FsKq/v1Tc1awkE/G5UFOIm9kjZhFXlv6ZR1FvdK4OlJAhLr4cMk7ONAU4XuWJpI2BXupfWM9ut2/rwnebArlU4LvISwHoTv9JzmqWEgQHRbE+4aeOL4MKo2C2eyU2nW8bnOKTZeLNTOtOvvPoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4961.namprd11.prod.outlook.com (2603:10b6:303:93::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Tue, 23 Jul 2024 13:57:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Tue, 23 Jul 2024 13:57:44 +0000 Date: Tue, 23 Jul 2024 14:57:39 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Paul Greenwalt Subject: Re: [PATCH v1 1/1] net/ice: fix E830 PTP phy model Message-ID: References: <1f6ca9415c22415fc73d7bd72f220e09b5f79025.1721740015.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4961:EE_ X-MS-Office365-Filtering-Correlation-Id: 3aa93a8c-3bb4-478b-2d20-08dcab1f6d0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WlEItsktMBmK+Te5zQIQBgnlq6vNMtwFO2dZVqeWvxqUrYh/sX7hWO+mQCJr?= =?us-ascii?Q?FaDahWz+9mC+mmfqbNASH0Cu7sgws7+YRUMjehe+NUzQpC72EIPZ29Ejw+LL?= =?us-ascii?Q?4FS9lQMAHIcmxd/De5wtz9BO6ZJGUCkW46GynTrTXV4obVMEAIv6mWOgueDj?= =?us-ascii?Q?UzUv1Gu/FwABnNxPHr9knPnQbRyAjxrxkEYC7bKNzxOnFI2p6770tx75vaTr?= =?us-ascii?Q?S6sUsOtWsz9LYXU0efy+H55P3TbhPtePNExvqLYLRjjhdWltf2sXYW8yUzZ6?= =?us-ascii?Q?U6Ls0HjKU0C1QDTNwYD8D9ExYRjs2aUTl3yMlta8OgPXtEqcv1aIQn5MtzpW?= =?us-ascii?Q?sjPRrfmn46bBEmyU+e96dOF1ElIdlS4o6smyIBgHVNzZB7AH3zeC/jIVS9bO?= =?us-ascii?Q?t7qp97KbqqHzdypOa8d3/ki7+WzW/2s3YKAnhZeRnOYWnrNBMtFlNyxIm2Ij?= =?us-ascii?Q?8sQID5gIobgsXCyGH2K3cdR0KBsTVpHlK/ChteW5PkQaY58bYoMChlKs4JkW?= =?us-ascii?Q?96l/c0cVspuYr/HzHBq1hrhGK1wR0ko61iSBN110zP1zHClXcLYAKSxZL/MD?= =?us-ascii?Q?duPp5mVPfPhA9nVYJvaNLkTgysyAbBDanavFjp2aaAyALOvdOIfngx3ZdZaV?= =?us-ascii?Q?Hru7AMFmaQ3aQY3UWbuwwRxL5FxZgPs5vpmuBXtioyxRPkJboDhIBmQ1GAXg?= =?us-ascii?Q?YZ4+UgE2op3uWRXI32ojMLWm6uBABqFpk8SHIGm3mvSAwK2BLiAKRFgbRcjW?= =?us-ascii?Q?Nx+LqRnCTZI6la2HbZkt91rRykw2xPIC9um02DlKbxjZ0/71nJSopjVigbcb?= =?us-ascii?Q?EI+/T91XRdQ8/sTF7oKfKYwKcifBbedWgftiaqgOquTN+gop0DpaKkx30zjY?= =?us-ascii?Q?lbU5NzT563SbvsHOYGHqk03A1JawSwiBdJ6SYzzgJIZny5Ix1CQxor0Lt1tP?= =?us-ascii?Q?/0vF8JNd8XYNJ+678NyZXVRJEfYWHfyZncTmt/e4rlV68TQsWv7UgRDTlpBa?= =?us-ascii?Q?rIAZCifwjP19N0BXJp5BjGa7GeewmwvX2uLb4wX96WbGWOt5LndYfqc7fz6C?= =?us-ascii?Q?9H27o3lEL+7u8REBs65t9CEskcwMcmiVYfd+zcvSaRxzXjojqBGW0u/xSV3h?= =?us-ascii?Q?8z3Lox94lm4FOwxGvqTgJJSpx019hmvlgikh7oSXf14LpAdeqMI5V5nfh0Zg?= =?us-ascii?Q?3flWzuFkp30OXMJ0UKb4W0DbsCZmIP5xckxkhshDF4zEFvCtzFk59ZbZkYTW?= =?us-ascii?Q?KJMJj92baXdVdhd6+RJCXm37spU+TNaE9XHz7m9nd7tAgx/w7gKxU26Jq2Fs?= =?us-ascii?Q?DkTVgI7WSNgPDjZRf5W6yAe7TMbDi7LantlLHQmC8UmoLA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cCRWpjWdRI6pPNvETj6xHy9rb3x4R8Dxr3xwL/IboFuLgtfWMtsmhRGi+WIO?= =?us-ascii?Q?ALU6vO+DadNTPMV+Ie6CdO3/bLV6g49OXhHcYaHfRthDjl1XemvMQJt6waVb?= =?us-ascii?Q?JHeE68FBlF4kVpV/UW/mPiH6rTgivUoeO7xdtCh8iSySzGytgAMJ8/LqtYJl?= =?us-ascii?Q?U3IU3aB3UCR5lEuEkAV7qa/WWdC5VkBZQTK7waMqlXyu1mGeYpy7ge0JqnR6?= =?us-ascii?Q?HOZ2TrF6Vb8qPfTYXiNsxVOzTBUzhuEZmircQwn5d1bRI/TBpSPk491F+x7W?= =?us-ascii?Q?stIplO6aNLCnv+4k1vKYRP/OgivQHQRUK2HqOlu8HWKWTMQBmaMclG1/XQ7d?= =?us-ascii?Q?hS+3mCKbwzh0X+GG3pWPXHAYxUJ++I5pChYiz4+stqpSRTcB3BIx+pMNTbvR?= =?us-ascii?Q?aoRiNo22u89xFlQQZ86GV8S4O+AVJE9HdneQiMX+v4Ey4ICFAN2mVhTTeN2N?= =?us-ascii?Q?IM+An0fRM4O4sq6BGwZUIGbvystYa1qisg1Qelky4t57IQXSIzB/RUn19w9K?= =?us-ascii?Q?tHdBTqiGX4LygpFj1MoUvxZbBLaY/Q4YeZ4BuYMcO3BeL2MqUTpxQRzhwauP?= =?us-ascii?Q?kq59fzAGWlXOBfgosBCDBemlo/ui5hPzOhBxVJg4qi3IcLwcIkLpDg6n9Rxe?= =?us-ascii?Q?GwX6mDXmyAAOjhSz9YtGRvfZ7wZQ2w/zG1qFtYQsWxoSEhHIXIm91c52aj6d?= =?us-ascii?Q?DsE6gXNunWAV+Kn+mZ7MetUfxJ3I7w/60gzbYU3QNwtFyTryAFFf9IrBz2Kx?= =?us-ascii?Q?nTyRF+CW0Z0rcRa4zTALonBEKYNmTcIPSU31lYXfbXrk0LvipzwKjMO90DS1?= =?us-ascii?Q?aoPpNE+HIlVzHEfnt1hBWM+1TRKzDFGUWdenkzzSwGu2KAoi0+RoMz4e4zVz?= =?us-ascii?Q?oRO9UEdJvhZVhNjrVaQ8m9c8eQbLTz3bgPboYMYavbY3utOAsPITQwxq4m9m?= =?us-ascii?Q?dACxx2wYHtDz6esaU8US091x7lvix2A3qSwGhpQCnky352Kat3BDGArt+H37?= =?us-ascii?Q?xc5DdrdXLLYKxejEdMdgh8NHEj+iqfoGhLdN1964PTSbNYH6Nc2OplUrIS/X?= =?us-ascii?Q?fMiVMiiyDaOMx9brqF/HhwA5Cw1iUiHjUV/u/yuu9Qk6fpGXOMSkB+SwcmTJ?= =?us-ascii?Q?ApMu2/nYWpq92YnbNad/iyQfSl5B3J9vqjI0Af3qS7Jd+rT1ATU3xp8f85n6?= =?us-ascii?Q?coAJc3CD5awQ9sTR3sIDgoeX2ogl0w0QZOm4cuCmutf9ZOtAnbkL/cmmITIa?= =?us-ascii?Q?3j2vUJSIhuwjU3s3woiFVgnPLkQCgKw3cj0YfVtSeAUBdNV2FW1ydeglU5DX?= =?us-ascii?Q?vWx7hh18633O7hySB9DCMChTwSJ484Et70zJRoVa0V0tvesXr6dXl3QEFn8U?= =?us-ascii?Q?udqUS0zMTvcl+LxTQJFJJ9mXEUWwxqpy6jDxAYuAfXouL476+KdIM3EZ+iyx?= =?us-ascii?Q?06EGUk0rBOFef869+pY1z8xBAQd63tFpcpYspO09s5r31WybJDWFbFTLrplT?= =?us-ascii?Q?q+WU/ggi9HJ8no1hbH0vs8GyG/IhKHi9DqUhKRZ68tCSFok06vxt+T50ZROe?= =?us-ascii?Q?w70TQpRCcVEUvxk8gv+jRmYmGKDNIMIL8p7V84sYPOAOUNoOyDwr+RIUateV?= =?us-ascii?Q?kQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3aa93a8c-3bb4-478b-2d20-08dcab1f6d0f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 13:57:44.2948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IOF2+XOc1rrBwaOsrbJFUC0oxuhDAaDGApIRKDjq6u6pZpf4RBXLRPsdJ/2sGSO+plA3aa3ExkkXoPTIO5yqNm6G1nAAdFW+x4GpeJsAnsQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4961 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 23, 2024 at 02:17:22PM +0100, Bruce Richardson wrote: > On Tue, Jul 23, 2024 at 02:10:56PM +0100, Anatoly Burakov wrote: > > Currently, we manually set PHY model in `ice_dev_init`, however we missed > > adding case for E830, so for E830 the initialization ends up calling E822 > > code instead. This results in incorrect phy model being set and having > > several downstream consequences for E830 as a result, ranging from a > > stray error message from attempting to start PHY timer, and up to > > inability to enable timesync on E830 devices. > > > > We could've fixed it by adding a case for E830, however there are several > > other missing bits of initialization (such as `phy_ports` field). All of > > this can be fixed by replacing manual setting of `phy_model` with a call > > to `ice_ptp_init_phy_model()`, which calls into base code and initializes > > the fields appropriately for all device types, including another option > > that is missing from current implementation - ETH56G. > > > > Fixes: c3bedb7114f2 ("net/ice/base: add E830 PTP initialization") > > > > Signed-off-by: Anatoly Burakov > > Reviewed-by: Bruce Richardson > Applied to dpdk-next-net-intel Thanks, /Bruce