From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04EFE45692; Tue, 23 Jul 2024 12:54:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A443140151; Tue, 23 Jul 2024 12:54:11 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id A9BA740150 for ; Tue, 23 Jul 2024 12:52:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721731970; x=1753267970; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=cDskG0bzzbPP2iYUq4Cfz+UqBYrny/U4ZftDHpfF1lc=; b=SkowR+LdEEEknQiRbtnE9mirIs2JUvkbgVMTulUGPo2AwPSmsBQc/q6N +Cbc4LIRKA2YxqEBRPMXzS0LyL0QyBG5ugnMo6lQe6SpRr648Q4RR2OLJ U/OPoq1AIP9bamM8mX3U22QncLKOPlR7gDRLM8FabnmLMXDDJLql/ZBF/ zix1eANKpcRus+5Ua7Tft0cNEWSXIXaaG1x9iDkhCHmFib/snobmipxKM 6jhvNFBykKAyCC4Y76IJAS8JNKmlZRw1cjK+guhX76CkfUzType+D1rja JcPAHtmxoCyB4RJJOOD2G/c+Ljk/VZ+WcitMVeK5EDft7v4FSnKeSBq3C Q==; X-CSE-ConnectionGUID: CB3xWidKTC2cWp+IXrSO8Q== X-CSE-MsgGUID: +Tqx9rBQSnCEY0AOT9A9mA== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="19313086" X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="19313086" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 03:52:49 -0700 X-CSE-ConnectionGUID: cRGAvWSHRCa0KuyhTUejEQ== X-CSE-MsgGUID: /2flCz6MTGCZEzzVHQ9uGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="52208484" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jul 2024 03:52:48 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 03:52:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 23 Jul 2024 03:52:47 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 23 Jul 2024 03:52:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lqAsV3aGfWdYjIOIYWwYDBA677ASLe2q70KdJJs6cgdoaWvz0m1cJTIPiyV1R/SIUqRkYpyOZzqfwAPdZTWGu2kUj2xBm9aK8bnJkDrNQP1MlZ4tc9AsR+w3VB8+/DTkABwexzKh9umHcF6LaK0AVxsChAp4m+ia0Io1g1D+NDtfYTe1W+uAO4SS7lm9Cpxo3spW6EUAj3TxNucCRTMiBpTsMKY2hl6H0TQftSFRnlVEEr9ppp+kIKBQUdTC0SLcnmDQrQmpT6vdr44eXFuGWHQKxI+6TF+u+jrascrKlt9OiCac2sH6ib4WZHcT5UGb5+pg9zyIWIsyF8RBHO/58w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MlmBn5cldM1smhJ2FdfBAGnhv7tVIKBE+Vtul8zXtpw=; b=FwfOJC+PXoRQfaZjPD1GFlS25VDx5hzy20U4JVMt+8Q9+qB7RkgKLJ89W7VMThOxGzjIEE7PxPBUlBb2/PL5PVKT8AUDfozNLs0KpZnNC4d04KC12au0jgdzNBQPgfo0Q/GkdlrZ9nzekzeI9GYykgcJqZHARmR+AFBZ4zpDxaZCzkkN91VHx30PDhQatfeXY0yW1Ryo8ko/SQyHKlnlXbg8/nm5065FP+8+qRHnKAEEMGF5f3nq1cSN4/X/Wdga532HTNpNIJkF58AkfrifG6ap41U2GrG5fg1I76Ybex5X35SBNCFS8Bxq7/QUPjtcjTbd4CS03mrZc+8pzaMh7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CYXPR11MB8691.namprd11.prod.outlook.com (2603:10b6:930:d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.17; Tue, 23 Jul 2024 10:52:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Tue, 23 Jul 2024 10:52:40 +0000 Date: Tue, 23 Jul 2024 11:52:35 +0100 From: Bruce Richardson To: "Jiale, SongX" CC: "Zeng, ZhichaoX" , "dev@dpdk.org" Subject: Re: [PATCH] net/ice/base: add retries for reading NVM Message-ID: References: <20240723061915.249540-1-zhichaox.zeng@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB9PR06CA0020.eurprd06.prod.outlook.com (2603:10a6:10:1db::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CYXPR11MB8691:EE_ X-MS-Office365-Filtering-Correlation-Id: f759c966-18a8-4611-5852-08dcab0592dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uoARRa348SbqGq+SsUQeEeYQJkI2in20FGyNNPxDHnhInF+hn09NTcQXGXnA?= =?us-ascii?Q?tZBv7WEUiFTiB5jP+8O9xj5ut/GhgIg3gTC6f7aTH/PbtyXHDX17WlCpuhJP?= =?us-ascii?Q?QmyGww0zXoWCdBPWeFc6UDM6YdkT5WCcBkMCbgq1gTU+tuEJJFKsz1Ko8Mky?= =?us-ascii?Q?rWd8uJE+iWyZFqSaURVIGm56MQ3jyOpaEOtAIQnARzNXSIReJYU/8XVOu3gg?= =?us-ascii?Q?0ZcT86WHutB7xeXII2OzgzZZiQIBcrj3bypsbklPN5UV0BdlDf1t2lO4DEZv?= =?us-ascii?Q?FBGoDprxOGIEQyt5jqdb18eF5FeRCDl3mb+hlTL6wj8eZFPn/BDn+og4kwGT?= =?us-ascii?Q?/2Be6Vjk8Zmt5wIO0SxW4esTyAgVDNYep8Cpmp3TIMeQGT/JWTxzxOFC5o/1?= =?us-ascii?Q?KnnOdgYnKhnVYbhani5jxDOJ6FTbA3A0j/rf6gN2am/rutylHR6SBAxCl+Jz?= =?us-ascii?Q?sY7vlVK5y1gnvihFDVl6Aek8I6K4h+rB8hlC1/+rUyOoPWPwWLiCUd7Ra45k?= =?us-ascii?Q?RMiABcbLHmOv0H/XHSpqe0dF0sFufbGScfDk1LAM3/+0pHH7m0yncG5UYd3/?= =?us-ascii?Q?O2zmoZCTI9rBgW1B3+egBRmo5Nr1ADbcWIKrZJsB4G9MXez1C1OCMT3Vo7wL?= =?us-ascii?Q?hQzGReFH7jnMgBEHdkyq6ywrGg3jFWnr18r0lfz5qhyTjM5jyseHNiMVmAli?= =?us-ascii?Q?P9UlJIa5lSfttpVsD2KifyOq16ex++1iGdDXeeRHvcBsao790SLqWIg6TGFP?= =?us-ascii?Q?dTQIH0ELDvnVsDnPtfwUvaDv+Iz81x63KFB3FysdzipWcZr9EyWjHkA7dDty?= =?us-ascii?Q?RDMtgy8KdjkcCtm1MF9qjkcqkUnj4e29yHQom+xy7wA/ZFyVdvtXgil17Rg9?= =?us-ascii?Q?TYMRdDgOTryyhSOA9ZhosELttuvmOr5D6CQxolnSWQVb8vxJYJICA1iZ+7SS?= =?us-ascii?Q?Ia6XpaUTa8L6BcAcRxZQMs8FjyqQ3r7Mqd8frKPeRDhuxNVyy1XixxZtRcyH?= =?us-ascii?Q?CCZTxeythkVONaMwWzBOCbm4CpB4SQkTqNfPfHBgQvLbPTmtftZr84uA2vVD?= =?us-ascii?Q?FOMH5xji0CU5NLDv4QkSO8vo6j1MrHwl6DM0TJO+dKntbLSBa+PKp2CuHdkJ?= =?us-ascii?Q?e1EffSoQFJI1QlY5wFGWO4x+zSt8+ehlQk67ogSsoX0OWbNIk57LGXdLyMa1?= =?us-ascii?Q?08mp2PahNC7solXsOIAhZRKAweJgTtW7qJFz4htT8MJEB2dNoEccJjBldoYi?= =?us-ascii?Q?LTnudl9pgbom4cBakfDI5Iq35K3AIGXNwytYJBvZMlrTALdnDgOuOiH8wcPi?= =?us-ascii?Q?7UjW4UMbZ0uwJqbToFrXdRcr67BMkFqmT0UEuADbBGpCKw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5a6SpvPzcmsOHLNxS1HzUyAJTCRqXaoK37Z5MQXDRO/SpXvGzDIFiHLZLOv1?= =?us-ascii?Q?MzwgFq6k7JlzbW3O9uQvAuFFZoNHvnFUzmbQW44ICEnHTsEfgGNSN6ekZ6TM?= =?us-ascii?Q?2HeFTjYqKMfe6Om65/xUImMdfEXKFNj54jnZMbMfN6xGOWJrIwOslhgC1goD?= =?us-ascii?Q?tanDvzTNbbrF9aCZJzaM7qas0OI5UTqZYzQ+8TJZOjr3HUZS1ttOnpMFqS8d?= =?us-ascii?Q?/id2TXE4jdFId6MnRxSP7+qEvqFhE4uYMgMvpAl0iGLta4lxv2x4+d0iDqMY?= =?us-ascii?Q?vFmrIDDwMLjJmCgQgfbbxm6qC0GWgEDQ3wFeGexp/Zvps79vtyXNuRWAb3eP?= =?us-ascii?Q?cUASKZMRb60uzp7gLvTrPp+14xpmqA1yoO6RZ4r5gQXtllAjObP47Y+biATW?= =?us-ascii?Q?WfLaaudtinxLFq+kPWZSRu6y/Cjq2IhLIeeFXsSYh0JVa5cC7I2N4iZUXsKf?= =?us-ascii?Q?8VkiTaNBA5HuPSrH3RrJP8AJ1QY/0bi2fAVhEungt6XRr1qJmIAVBR3y0jlM?= =?us-ascii?Q?/cXnFcare28YIAg6u+T/TmiB9kaaO+toCXXCGu6YEDKDbDkmN15yiofBz2EH?= =?us-ascii?Q?pkn7hVUhk5SeGMOach+6oQJmA2Q2AIXXxcE+ntZ/pybWTSl6bZKj7RFp6Esm?= =?us-ascii?Q?iAI/D3ViJLA6ATFU1fy6MDDKm/GuttQ/ESVaRjiXmOEPlAGONdAEnQs/6Z2G?= =?us-ascii?Q?gig0dAXAJiLd/EIzJHAGBz7/ewpIW1jtzzpjBBDJQK2KXXrBhc/IfMoq5Oh/?= =?us-ascii?Q?+6JZS0gw4whDePWNFVKV8kU0miW3Mq+mPTkhZNenuFxxqJ2dKo2CmaNRpaik?= =?us-ascii?Q?9afG8jMpS3pMOzgZa09iSbmoAtz32P0wojINPgM1qZAFzcZne++geLUmFI/3?= =?us-ascii?Q?ttZ9RLnKKfuoHBiFIK8ZsxKuOfNHzsJMAWw66PD4iD/lnbQErBysJCHSRTVj?= =?us-ascii?Q?hRQc9EuYOES6JNIu11j2pFnIjDogLmS3koHee5yR5O4NEYjc9c+7gTytGkHm?= =?us-ascii?Q?YMOLFKKrbpa5es+LQR8ANy9Wh5y34pwMOaIKFb0MZlfuoseP+4PezVhhqcEI?= =?us-ascii?Q?dqkWpAl5zftejBo1YoK9pvuTdfQVqP8B08wWLD6/DoS2RyJiWriISfeyp1a2?= =?us-ascii?Q?oNtygHCkbl5sAxjyK3AsINtRXBFF2zboZbnyfgh6B91mFLRri4JjJtrwCZ4S?= =?us-ascii?Q?Td1+HdacOfoMIG08VEBvh9G9Lg9mM3C8bhmGfa74PnmF5evvCwvZLz1+Fquv?= =?us-ascii?Q?6LFb3J+g+8q6fMZHUwZTjLUvXzIUFlcjNb42fNq5do0/+KKMFUGUD8ZrbGnH?= =?us-ascii?Q?xIOnDVLKu3o4QRTObBLRQcY3fXwIFQviAoPp/fDfyhbvnQf0d0UrSviOX3a0?= =?us-ascii?Q?gfS3MFJ+/czHGDVVvlphApX0toxlRtGif1QOuAMhHhVR1nMR7+ihVlUEg9aX?= =?us-ascii?Q?9is0BIiGUYGn+xjJFbTLGuaZuRQgZzBahwc0QiYUUsV5p7fXsqofHGu4bR7a?= =?us-ascii?Q?U4t6qmr3KrwhEUcSzLXjSYxjWgC0Z6QeM8cnevYdlXhxE5VJivwRm9c9eHGU?= =?us-ascii?Q?Z8l9oveWhe8G76DBRe2emAOe7Z5J05mtnXmZqP8+LgpdcxZHLVq2SROnKm9R?= =?us-ascii?Q?6A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f759c966-18a8-4611-5852-08dcab0592dd X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 10:52:40.8073 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L7/bkDKKppmpIFfJlOGD9D9jvG4NG+g3pEQcSc1rfBwFyaqvpAX2lIjX+aRxtIVt2nyQppxNT22WrNhaVeSCUCxPS+UMy7AF+VYJ+2XMkZo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8691 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 23, 2024 at 09:07:32AM +0000, Jiale, SongX wrote: > > -----Original Message----- > > From: Zhichao Zeng > > Sent: Tuesday, July 23, 2024 2:19 PM > > To: dev@dpdk.org > > Cc: Zeng, ZhichaoX > > Subject: [PATCH] net/ice/base: add retries for reading NVM > > > > Reading NVM fails in some scenarios, so synchronize with the share code in > > the kernel driver to add retries for reading NVM. > > > > Signed-off-by: Zhichao Zeng > > --- > Tested-by: Jiale Song Pushed to dpdk-next-net-intel, as a bug fix with fixes line: Fixes: 2516684aed7a ("net/ice/base: extract logic of flat NVM read to function") Thanks, /Bruce