From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] net/ice: fix sizing of filter hash table
Date: Fri, 12 Jul 2024 10:34:11 +0100 [thread overview]
Message-ID: <ZpD4kydsWz9qJUig@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8xFKj4tY6NtL_pk+RyWobOw4SYJH1YhpKviQAadLai-LA@mail.gmail.com>
On Fri, Jul 12, 2024 at 10:40:02AM +0200, David Marchand wrote:
> On Thu, Jul 11, 2024 at 6:57 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The hash table used for managing the filter rules in the ice driver was
> > dimensioned to a hard-coded 16k, which is insufficient for holding all
> > the filters supported by E830 HW.
> >
> > Rather than using a hard-coded value which may need updates for new
> > hardware support, we can query the NIC max filter support from hardware
> > and scale the hash table size based on that value.
> >
> > Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> I did not test it, but on the principle this looks fine.
> Acked-by: David Marchand <david.marchand@redhat.com>
>
Applied to dpdk-next-net-intel.
/Bruce
prev parent reply other threads:[~2024-07-12 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 16:57 Bruce Richardson
2024-07-12 8:40 ` David Marchand
2024-07-12 9:34 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpD4kydsWz9qJUig@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).