From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Vipin Varghese <vipin.varghese@amd.com>, <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Xu, HailinX" <hailinx.xu@intel.com>,
<konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH] app/testpmd: improve sse based macswap
Date: Tue, 23 Jul 2024 18:12:11 +0100 [thread overview]
Message-ID: <Zp_ka0exZkqPPaWS@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <2487809b-ab5e-450b-8d9a-11d3fa32af96@amd.com>
On Tue, Jul 23, 2024 at 05:45:57PM +0100, Ferruh Yigit wrote:
> On 7/16/2024 7:37 AM, Vipin Varghese wrote:
> > Goal of the patch is to improve SSE macswap on x86_64 by reducing
> > the stalls in backend engine. Original implementation of the SSE
> > macswap makes loop call to multiple load, shuffle & store. Using
> > SIMD ISA interleaving we can reduce the stalls for
> > - load SSE token exhaustion
> > - Shuffle and Load dependency
> >
> > Also other changes which improves packet per second are
> > - Filling access to MBUF for offload flags which is separate cacheline,
> > - using register keyword
> >
> > Build test using meson script:
> > ``````````````````````````````
> >
> > build-gcc-static
> > buildtools
> > build-gcc-shared
> > build-mini
> > build-clang-static
> > build-clang-shared
> > build-x86-generic
> >
> > Test Results:
> > `````````````
> >
> > Platform-1: AMD EPYC SIENA 8594P @2.3GHz, no boost
> >
> > ------------------------------------------------
> > TEST IO 64B: baseline <NIC : MPPs>
> > - mellanox CX-7 2*200Gbps : 42.0
> > - intel E810 1*100Gbps : 82.0
> > - intel E810 2*200Gbps (2CQ-DA2): 82.45
> > ------------------------------------------------
> > TEST MACSWAP 64B: <NIC : Before : After>
> > - mellanox CX-7 2*200Gbps : 31.533 : 31.90
> > - intel E810 1*100Gbps : 50.380 : 47.0
> > - intel E810 2*200Gbps (2CQ-DA2): 48.840 : 49.827
> > ------------------------------------------------
> > TEST MACSWAP 128B: <NIC : Before: After>
> > - mellanox CX-7 2*200Gbps: 30.946 : 31.770
> > - intel E810 1*100Gbps: 49.386 : 46.366
> > - intel E810 2*200Gbps (2CQ-DA2): 47.979 : 49.503
> > ------------------------------------------------
> > TEST MACSWAP 256B: <NIC: Before: After>
> > - mellanox CX-7 2*200Gbps: 32.480 : 33.150
> > - intel E810 1 * 100Gbps: 45.29 : 44.571
> > - intel E810 2 * 200Gbps (2CQ-DA2): 45.033 : 45.117
> > ------------------------------------------------
> >
> > Platform-2: AMD EPYC 9554 @3.1GHz, no boost
> >
> > ------------------------------------------------
> > TEST IO 64B: baseline <NIC : MPPs>
> > - intel E810 2*200Gbps (2CQ-DA2): 82.49
> > ------------------------------------------------
> > <NIC intel E810 2*200Gbps (2CQ-DA2): Before : After>
> > TEST MACSWAP: 1Q 1C1T
> > 64B: : 45.0 : 45.54
> > 128B: : 44.48 : 44.43
> > 256B: : 42.0 : 41.99
> > +++++++++++++++++++++++++
> > TEST MACSWAP: 2Q 2C2T
> > 64B: : 59.5 : 60.55
> > 128B: : 56.78 : 58.1
> > 256B: : 41.85 : 41.99
> > ------------------------------------------------
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
> >
>
> Hi Bruce, John,
>
> Can you please help testing macswap performance with this patch on Intel
> platforms, to be sure it is not causing regression?
>
Hi Ferruh,
We can try and get some Intel numbers for you, but I think at this point it
is better deferred to 24.11 due to lack of discussion and analysis of the
numbers. This is because the numbers above already show that it is causing
regressions - in fact many of the regressions are larger than the benefits
shown. This may be acceptable, but it would imply that we shouldn't be too
hasty in applying the patch.
Regards,
/Bruce
next prev parent reply other threads:[~2024-07-23 17:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 6:37 Vipin Varghese
2024-07-23 16:45 ` Ferruh Yigit
2024-07-23 17:12 ` Bruce Richardson [this message]
2024-07-25 12:47 ` Varghese, Vipin
2024-07-25 12:52 ` Bruce Richardson
2024-08-21 14:38 ` [PATCH v2 0/3] " Vipin Varghese
2024-08-21 14:38 ` [PATCH v2 1/3] app/testpmd: add register keyword Vipin Varghese
2024-08-21 14:55 ` Stephen Hemminger
2024-08-27 15:32 ` Varghese, Vipin
2024-08-27 17:39 ` Stephen Hemminger
2024-08-29 8:14 ` Varghese, Vipin
2024-09-03 11:52 ` Konstantin Ananyev
2024-09-06 13:02 ` Varghese, Vipin
2024-10-04 5:04 ` Ferruh Yigit
2024-08-21 14:38 ` [PATCH v2 2/3] app/testpmd: move offload update Vipin Varghese
2024-08-21 14:38 ` [PATCH v2 3/3] app/testpmd: interleave SSE SIMD Vipin Varghese
2024-10-04 5:08 ` [PATCH v2 0/3] app/testpmd: improve sse based macswap Ferruh Yigit
2024-10-08 1:12 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2024-07-13 15:19 [PATCH] " Vipin Varghese
2024-07-15 15:07 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp_ka0exZkqPPaWS@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=hailinx.xu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).