[PATCH] power: don't disable all cast qualifier warnings

[PATCH] power: don't disable all cast qualifier warnings

[Stephen Hemminger]

Only in one place does the power library need un-constify a pointer
and this can be done by casting to uintptr_t first. Better, to have
the warning enabled across the rest of the code.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/power/meson.build          | 4 +---
 lib/power/rte_power_pmd_mgmt.c | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/power/meson.build b/lib/power/meson.build
index b8426589b2..2f0f3d26e9 100644
--- a/lib/power/meson.build
+++ b/lib/power/meson.build
@@ -30,7 +30,5 @@ headers = files(
         'rte_power_pmd_mgmt.h',
         'rte_power_uncore.h',
 )
-if cc.has_argument('-Wno-cast-qual')
-    cflags += '-Wno-cast-qual'
-endif
+
 deps += ['timer', 'ethdev']
diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
index b1c18a5f56..6dec282054 100644
--- a/lib/power/rte_power_pmd_mgmt.c
+++ b/lib/power/rte_power_pmd_mgmt.c
@@ -664,7 +664,7 @@ rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,
 	 * ports before calling any of these API's, so we can assume that the
 	 * callbacks can be freed. we're intentionally casting away const-ness.
 	 */
-	rte_free((void *)queue_cfg->cb);
+	rte_free((void *)(uintptr_t)queue_cfg->cb);
 	free(queue_cfg);
 
 	return 0;
-- 
2.43.0

RE: [PATCH] power: don't disable all cast qualifier warnings

[Morten Brørup]

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> 
> Only in one place does the power library need un-constify a pointer
> and this can be done by casting to uintptr_t first. Better, to have
> the warning enabled across the rest of the code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Agree; disabling warnings should be avoided.

Acked-by: Morten Brørup <mb@smartsharesystems.com>

Re: [PATCH] power: don't disable all cast qualifier warnings

[Thomas Monjalon]

13/08/2024 08:11, Morten Brørup:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > 
> > Only in one place does the power library need un-constify a pointer
> > and this can be done by casting to uintptr_t first. Better, to have
> > the warning enabled across the rest of the code.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> 
> Agree; disabling warnings should be avoided.
> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied, thanks

Re: [PATCH] power: don't disable all cast qualifier warnings

[Bruce Richardson]

On Mon, Aug 12, 2024 at 02:56:09PM -0700, Stephen Hemminger wrote:
> Only in one place does the power library need un-constify a pointer
> and this can be done by casting to uintptr_t first. Better, to have
> the warning enabled across the rest of the code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH] power: don't disable all cast qualifier warnings

[lihuisong (C)]

在 2024/8/13 5:56, Stephen Hemminger 写道:
> Only in one place does the power library need un-constify a pointer
> and this can be done by casting to uintptr_t first. Better, to have
> the warning enabled across the rest of the code.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Huisong Li <lihuisong@huawei.com>

Re: [PATCH] power: don't disable all cast qualifier warnings

[Tyler Retzlaff]

On Mon, Aug 12, 2024 at 02:56:09PM -0700, Stephen Hemminger wrote:
> Only in one place does the power library need un-constify a pointer
> and this can be done by casting to uintptr_t first. Better, to have
> the warning enabled across the rest of the code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>