From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 716BF45877; Tue, 27 Aug 2024 12:00:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C7F4402DD; Tue, 27 Aug 2024 12:00:17 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 60FDB4027F for ; Tue, 27 Aug 2024 12:00:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724752816; x=1756288816; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=LQZR8khe0NkC/wVxjDFWP3+nN6/PFUokBJSfDtKYmfQ=; b=TbL1xm8G6DPttgZ1HtUka6L0pJwKwKejJhNDCvVKEoLWGLXqwGl21pNd slOCEBiL7INbaOcjDwugeEYOkAvx+FgRrZxyNX9ddMkhqZ8dY/Rn+p0o5 E/0s+2Z6YEAjn05s8MQcYRRUKRAEuX9zvTk7hBoUU1KyHpcXi3VaVEPgh 5XPD6kGWzYRpsG1jW8CpDKk8aSzPuUeoBWRrE+bfc0p2Jdl0VYxPO+VXZ udfSzQj6VwleUii9DP+rkyfp1ywP6RVwwRGtcTTPF2mesiLg80Z/IPWkA B5B8CQBpvy2waYJu9H0iqVldMqyhdjN3puRoHWa0AxyOKyqN8K81f2KIZ g==; X-CSE-ConnectionGUID: m0GYENOzSRCU/WAtU0GSVQ== X-CSE-MsgGUID: WwOmnxCqRvuM2CmS+ahKKA== X-IronPort-AV: E=McAfee;i="6700,10204,11176"; a="26985874" X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="26985874" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2024 03:00:15 -0700 X-CSE-ConnectionGUID: ozBlqCcyTx+ALE8VOMQfQw== X-CSE-MsgGUID: qjifZyw4Stm7QcaVQRyksw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="62510099" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Aug 2024 03:00:15 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 27 Aug 2024 03:00:14 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 27 Aug 2024 03:00:13 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 27 Aug 2024 03:00:13 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 27 Aug 2024 03:00:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vTsibRRAR+gPlWRvQQ0IyjlMKjGRip01/E16+/KD+PswbM3txRQrz7g27mPchwxzNPyFtrDkEvJyTTZscCYllIlI1ydXnmUilqgz0F+nPPw6upHaDMDX8ioYhwEUNC+9luYgQnIXpdfaWoZuVOT8LFQ2RtK1rs71zARdWX5W+rao0pGDlaI7i3in1HOzix5ahzLaaNBxsC3bI8T5VRfPC/wSdQYS2ZuAvO35LMmJz7uviprB3VjQvbS/nd8tPOC3rmU+W+vRXSLSvgEwXdOXXgItKm4Ucg3c0LTW6BXjCHeyaqD6HZq1LSs8KHBVw6/MWSls2Os0pW3jJxxNbvw94A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D9kxY6vIZ3XuHk+zPR6nGhIbvhYykLAH7NftaSWuERo=; b=w4L4fqV0onMlY223YAqU4qRM1uWiMp7OPfUrRykTRPxV/9H/oGPDe0NkU2SM2EY/B9m3dFhr3S/7msf2ChBU6qB8DQO8tCxTeH6rbI7mc6iBzTyB3lJVvu0mf5g8KP6ti8HXuR+ScJCv/b5Pn9ovRH+OzI0F7eKHGBte6XItQZNvmzEA448UweK1v6NOWQ79u2rC4HphtVkLXWSd40ZoSrfElNlkNakaZmPqs+0Rk9Gqa+WLPVgeJw8RWlb26AmcmjsCkg7b9JCaITrKlm94bg2RIXBqL+gOI8Hdv8Y3/S5gAh9AggWEwV9L6xFJfdjuW3H9v6xCBa8cnwGgNbLQMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5245.namprd11.prod.outlook.com (2603:10b6:5:388::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Tue, 27 Aug 2024 10:00:11 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.021; Tue, 27 Aug 2024 10:00:11 +0000 Date: Tue, 27 Aug 2024 11:00:06 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , , , Subject: Re: [PATCH v3 01/12] net/ice: use correct format specifiers for unsigned ints Message-ID: References: <20240822185346.221885-13-soumyadeep.hore@intel.com> <20240823095650.349785-1-soumyadeep.hore@intel.com> <20240823095650.349785-2-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240823095650.349785-2-soumyadeep.hore@intel.com> X-ClientProxiedBy: DU2PR04CA0078.eurprd04.prod.outlook.com (2603:10a6:10:232::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5245:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f61581e-b6e7-4fa2-d6b7-08dcc67f0a36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DiN/fULBYo2/Q95Zg6jhO3bjaj/D0TpRu54Fax4WlqcQTy4Q7hEykKAZy97Z?= =?us-ascii?Q?CYsaLwdpMwdNmiquWKOb0Ld/325zq267pnnwWKI3TCDj9H+LQpvrFPOhxizc?= =?us-ascii?Q?WoKmSmmngfi6IRhzkvN/VBfMmY7yQEc7elUpcTdygHxjzH6OJT+hQRQhMBrF?= =?us-ascii?Q?7S+tkYKH5Pn8krrhsgQl64jfDPurcHscBK4sYoJ2uEvvgrMYut+nP0vtpZDx?= =?us-ascii?Q?vBXMwt3ac/OH3AdTsv+xMoeFJxoMGc3QyTvtRFdISG9T38cLTC1P5GnwWzm/?= =?us-ascii?Q?qv2bmD9/cIoy0cSkRoP8FpE+mm1+iVwEK5eZzrYG8KVjALVphgrhrnZCkP28?= =?us-ascii?Q?ufkq43IsJm5v9b8n2W9jhzrtU0rFf5yHGr7uI0O2VhDiMiXlRg2TL48Z9n1T?= =?us-ascii?Q?zlR/FoKjlexjoFg2VfQ76gKbE8fVB4apDGud5L1E8x8ZpH2nzFBIlvk1M5XK?= =?us-ascii?Q?q7FN58xz8Ls3D0VK83bTFvlzh+JzkysyMUCrwbsN690Csb20hCQMWXeut0WQ?= =?us-ascii?Q?po3+lzo9TZRlAlVNPzUzWCS7z3g7RzJOqRsYay3eVPoPhZBzy9QExiWt6KOA?= =?us-ascii?Q?tHmSetYwuW1LNQ04rBcz+EZSyC40VM/9F/SO1KiNIhHFmrzo8n7MFVA1bADK?= =?us-ascii?Q?xsBKGTrCuoGy5karcZY+xi4e1Jb939sJ0vjycnTsRKQs1jAa/iQlvfqmD+1v?= =?us-ascii?Q?Ji219qCffZGDOUQWDzkFLkNMde+jawey+BBh5UtVvRmBVub/fJOYJ8Giuv4K?= =?us-ascii?Q?b+rdVdcxrdq5CuWeBPxCGYy6Ut5Xmsau5z6tnkiDjY8cxJvaH0mIww4A8+8R?= =?us-ascii?Q?pZOXUcUlVy1OsSyLad1d/30jlDwK3ZEmTomRPfWOVAeopF8vNyW/TeLbX1uh?= =?us-ascii?Q?zMvdLUOvtESUguBFmqFUuLo4FyEMO3Dnr/ng6fej4MOFzS5wcTtfFeR7xAQP?= =?us-ascii?Q?vQPNLAdnIIeUHuMO9qn0TPWpFT2WnobrI6HVYSwubDByHMCHyg8HGCgcUpsi?= =?us-ascii?Q?AE3bKn15MIVJICaF1l/BSP2Mt80T0VBOvQbq+VlLDitaWHbxhZh8YCA6kLJC?= =?us-ascii?Q?YKAh9Bb3BtgidRmOKVVeXV9a5a8leEdEFtZ56rk2fs6Yogcv+jyKAC0WAxVZ?= =?us-ascii?Q?QuZ5+KqbRik62lhauljqvWk5g/59YvHWBapYsy99zgRPpS21jEMIrkhblc4n?= =?us-ascii?Q?Ib/YYwy9yQ8/9f0iUgUTm4Dott+duIaJHAwItCBm/KtVrLA5jGiYpzIBs+gL?= =?us-ascii?Q?/dYWhnpOr2cpktFFYC8U1mfr4YmSk/aWmRIfGmPTaNJO/mQVRRzCsrllia1z?= =?us-ascii?Q?gOz6l7zOLdt7mNaHv27v97zEVTNS3ZFKzFZBTtEp2CDjtQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z6QFdiGmNVyZFId/lWizBY7DirByaxgGKMYSdb+gAIyVycH2+XSDJX/MUC2U?= =?us-ascii?Q?4+I4xJTOnS2VqA3b1B8IJqxOrIIVidELsH8SJt2vHYu6e1lGttWeSpUOLRIS?= =?us-ascii?Q?jfcFR6PVprqqZDDu91bcQpOyZUXzpp6ohHKCetDMNXMW/abn84EAnDsupXH9?= =?us-ascii?Q?P846HSFz5dhDp0jMEvpKc3OEIBclQIgR52bL3NCjmi0FEIG1HgsjkMPRD/Ub?= =?us-ascii?Q?08LbF/U0Bba34AUSizsfK7o3sd+JdyDDRzvwofOI0DE7tx8HvHWAuBHQEhfi?= =?us-ascii?Q?DgRuZicj1Ves5iHX2JIBl4+YPvGcRiEve4pSvEPsexTx32x3bT3Y+EIkseoR?= =?us-ascii?Q?PRx/6KXeR6gEiIi49l+Ts2HkXcqX3ZnBr+vkEgyLCyVTywwERagNmFJbmK7y?= =?us-ascii?Q?VzT4RvHPQBSRRz4J4KVvD3gcN6G+4gN5m42ueviwuieY4lGlk6k1AVvTEhtu?= =?us-ascii?Q?sB2SkdmZE+pmLNxaSOTnzqdUdBAUnyuYwU+3Kr2mDa9P367jOdrWg2FS+Ii8?= =?us-ascii?Q?RFJcttNolPR/7lhF8nTZJaVT+qdjN6PA5SS+dS0+va38WTc0k0wP9cNdKAMo?= =?us-ascii?Q?BTR80ilpSGh51Iehz6w7Z4G0Rr1JTloF5/Oljmx6neWXoHA/BcTd1su4pigf?= =?us-ascii?Q?N+HywIY65Z6dXYfrY8RU7QjLnJxdUqsaeU7ZL1VvCtH81SdBrGb64wYYSO0n?= =?us-ascii?Q?Dtcu/8GmCF7zyejroDSaSTRfqRVfBlAElPBleDSql2lOIK9XKuvQoJsLCJBD?= =?us-ascii?Q?AjOuxjVEZTkdFING/dVHOTmEyBSuKkleVJdY1h/h8EfaqN/mDfwrhxjHK7iw?= =?us-ascii?Q?N447xZ9ORUc8RUt/Vu5tzeTBRVk/ScuwdwqtD/PWqNQb7rev7x14BDB3KuCY?= =?us-ascii?Q?tESD/X/ZcbEmNj3eAT0dC62/l4WspulMJ5mMy/ps5FLgPbdVeAhrqGnDez33?= =?us-ascii?Q?yhzugB+QyK0TpQCzGSqC9e5Kd3EVnV5R8JfsBZH89XRimadIio9M0t3CtLxE?= =?us-ascii?Q?l+Yup2qUkx/vCCo4et0ofxupKjNKvyR0Ywnbk3C5FI9cP+yWcGy1j31wuDXg?= =?us-ascii?Q?rOdoK/KCi9PqU94h0rn7Wfz1OnmkFAXTsirgja2E6Snv4qjkE83w4veHLP/R?= =?us-ascii?Q?sYXVTYYlLGre34i2Cjirb7+ME3BBUwtWt9wH2RypfLrPZzksH2ZfHaAQQDcF?= =?us-ascii?Q?Obz7cPV6tbH7hbW5qvzGYgZ4O5C+qbjWaDa6IfIdYotDcKyq8JCcLrboC9Dr?= =?us-ascii?Q?bLryC6UyK22Guta5VxwvQAhLyXdYCppGL/Ipg4v7MEWYpvGbKvCgzCZfGS57?= =?us-ascii?Q?cR58Qphv2EGhEHuHnhyzvYes9sr1d2FtQtIZt8mIZKEISEveAnXZYVuCT/Zb?= =?us-ascii?Q?n3QP/ISVphE5EzSy/pxARykCllsOFaGRdBHH/3y0pzkkcRLlv4U0KW7uEV24?= =?us-ascii?Q?JmM62p//xC8QXcB3uPdA/3qRKDmipoWg5wmPV8Q9OWkVuQ/WGU6WWxpo8qIE?= =?us-ascii?Q?gZEYfVjVvob+Z4eyeNtAEXq3OH8jK79DK1UmSPS6mz+jL5h4Gm3ECqerwKkp?= =?us-ascii?Q?5aS6YSHUHlrPj6RPOuA3WPDHIoD2s7JiQftmURhriH7h/ersyeUYUp9RdxXA?= =?us-ascii?Q?lw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4f61581e-b6e7-4fa2-d6b7-08dcc67f0a36 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2024 10:00:11.6980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +yZYQ0zako0s+29fy/y3Ji51G1AlNec21XikaYM0/Oq9Dek6fJPPY2oJB2ILUxAZrqUJjbWFqJIwXnyKxhER9VhmaoIMHTcRRvKZF1js0Bk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5245 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 23, 2024 at 09:56:39AM +0000, Soumyadeep Hore wrote: > From: Yogesh Bhosale > > Firmware was giving a number for the MSIX vectors that was > way too big and obviously not right. Because of the wrong > format specifier, this big number ended up looking like a > tiny negative number in the logs. This was fixed by using > the right format specifier everywhere it's needed. > > Signed-off-by: Yogesh Bhosale > Signed-off-by: Soumyadeep Hore > --- > drivers/net/ice/base/ice_common.c | 54 +++++++++++++++---------------- > 1 file changed, 27 insertions(+), 27 deletions(-) > Since this is a base code update, the commit log prefix should be "net/ice/base" rather than just "net/ice". Base code patches tend to get reviewed slightly differently since it's understood that they come from a separate shared source, so we are checking for things like patch split as much as for code correctness. Therefore we try to keep such patches explicitly marked as affecting base code. Also, please run checkpatches.sh and check-git-log.sh from the devtools directory. It allows picking up more patch issues, such as in this case a missing mailmap entry for the original patch author. In cases like this, the mailmap entry is added in the first patch from that author. Thanks, /Bruce