From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C737445948; Mon, 9 Sep 2024 11:01:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 981AD402BB; Mon, 9 Sep 2024 11:01:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id CF0AE40299 for <dev@dpdk.org>; Mon, 9 Sep 2024 11:01:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725872498; x=1757408498; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=PFXPmmeRU5/6Mpl0WQKdl7T+ITk8lhsaGr7E7PbBb/o=; b=YbFt+2QbNEvNNfup8cuvJfzUh5lRJP/cGwtw5ZY1qCYl6ExJr3/cB0tb 1j2GXyUfq+9HAbXoxJcKMxYnFMcg41qctwaQCZ9oERMZ2B4V9fRK3J59p 4Ww+TiGR+ia5qOiJG2MmD3NLcUencrFvyL4KqItIULwcXFtBCQNubMGaa 7T4dFMC0NiDLGhqvXJg4WBwAnsGei+B3YpEVNZDlxqq/yluQyeJoqjYdi +K2omirdgzoflj0fK24UO1t0jbtZVTrppo/1xbdGmY5tFzqriZagLDUkW ufhYwoqqivblc/F1LmSDcg4zqELAPtaOgknXZSZrKGEK5ZHI4XdRL+y3s Q==; X-CSE-ConnectionGUID: oOkrgrBvR32+ebo60tbzSA== X-CSE-MsgGUID: 83W2kHSaQtqt0qjxZb3LcQ== X-IronPort-AV: E=McAfee;i="6700,10204,11189"; a="24715103" X-IronPort-AV: E=Sophos;i="6.10,213,1719903600"; d="scan'208";a="24715103" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2024 02:01:37 -0700 X-CSE-ConnectionGUID: GWJ0rzBISLG36ZC0VOoE+Q== X-CSE-MsgGUID: AUVAWksNSj2dsVt1Go5xAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,213,1719903600"; d="scan'208";a="66317971" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Sep 2024 02:01:36 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Sep 2024 02:01:36 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Sep 2024 02:01:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 9 Sep 2024 02:01:35 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 9 Sep 2024 02:01:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i9TJm9PRolTihL76kzr5j8uXiYHJCt+9NTlrYv6/XRlzFtYKUN0F6y+LhlyKIGSvmt0+LiWm84YS+DfCqf1x89aqc+AglCrppTx+1ghsnUqFdQ8U4tHHWCf/0pzMXrfZ3IqQk74vmRdtMA4Qbdkcrkcei7kqPGnPu6wkB0qPc/kPc6O+ctW58dDOCrn/ZDEs6SN/99U/pH/jNiD+rD4kHgS4+UiO+0HpuznKLcX0061swZx3l5MXPdd108361CC3DqGbKpT7/PUvMu9hE8BSwe63zYktacp44Z1AQDj4erl4jFb9Rs6LpYWSvPzeXC4utQOL6lEMJKWuVwBp0V2CUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W8CtejXP8wM5ARlmYNpjgcyZhLQH98J3sePUErG15lQ=; b=M72xjog0YnEvmg4YfyjOnM5kNs1e1NnDHJGVkEw5yE2O1o7ijTJGePgXI5IWsOdU5tKNKnI+P+40fjxwWVdjOpzjpoqFzGiHVj0lSF0ZjNtGiHf2RHmlSJOqvHdBmDXHtLukOFo+Vmbvg791A73b6pD4KARI0MHsEIVcp6vKSvvIt+b/BUjooDr1oLzFERNqXgYSifpFVIejZk9NRg1Meg9mP44VftgDnI8KKiNNTSDX2Y4+rKr4vkWIDEbUnIMw9pNSe4DMX+JO95B/ytWuF1AMQZT5crig/v01B420ixZr0+vSYTg/UoMgJw3by8HgNLk4Lvjn4lZeHElqydjCnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN0PR11MB6157.namprd11.prod.outlook.com (2603:10b6:208:3cb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.32; Mon, 9 Sep 2024 09:01:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7918.024; Mon, 9 Sep 2024 09:01:29 +0000 Date: Mon, 9 Sep 2024 10:01:22 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: "Burakov, Anatoly" <anatoly.burakov@intel.com> CC: <dev@dpdk.org>, Reshma Pattan <reshma.pattan@intel.com>, Nicolas Chautru <nicolas.chautru@intel.com>, Brian Dooley <brian.dooley@intel.com>, "Aman Singh" <aman.deep.singh@intel.com>, Akhil Goyal <gakhil@marvell.com>, "Fan Zhang" <fanzhang.oss@gmail.com>, David Hunt <david.hunt@intel.com>, Sivaprasad Tummala <sivaprasad.tummala@amd.com> Subject: Re: [PATCH v3 1/8] build: split dependencies into mandatory and optional Message-ID: <Zt65YqwqjTUqy15Q@bricha3-mobl1.ger.corp.intel.com> References: <20240730145508.551075-1-bruce.richardson@intel.com> <cover.1725462264.git.anatoly.burakov@intel.com> <69a7b78dd7cb91892620b129ac5cf3a7f7e09e2b.1725462264.git.anatoly.burakov@intel.com> <ZtsXBEO194J0_q1p@bricha3-mobl1.ger.corp.intel.com> <4490f52f-88fc-4b43-a29f-803db681a619@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4490f52f-88fc-4b43-a29f-803db681a619@intel.com> X-ClientProxiedBy: WA2P291CA0009.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN0PR11MB6157:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fe7742d-286c-4054-2e46-08dcd0adfe33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nsn9o43RAQ1Qv2hz5EC4zRofdoaoURkZpQpWQJws5X8SRdGkZOmWbE6csASH?= =?us-ascii?Q?tGnRosp1vL4u4S5dR1hHRbnN40ymMNONzNnyuUmB05TXgd+qoBtqfIpp/H0M?= =?us-ascii?Q?TeUVlL7YHyytRKQScGczxGcMGxbSA2zBXTBp6TFod5wlVzRxGuFeTztOsF7d?= =?us-ascii?Q?IJxfsS+ZMZcrq09LCqFt+WZIQLb/9E+73M1ASx2cAWhhwT3FGWDZW4K1xaZl?= =?us-ascii?Q?P5gXbdTStek4M2FWW0/RjgdGVTOjikPzI5xbkBJ7pdGcPfoEVK5ncyjt4Hji?= =?us-ascii?Q?8SB9ZrlVG4EHZVtEhklK/HX4zRtMaUHIT9UZPwL1IvJ8wvJQ64kambagSCNj?= =?us-ascii?Q?wlD7CZRLYEJKq8UiBaNs9W+1j4/xS+LSiZ/ppljk1rqxXtRJ88dyCRWP0oXF?= =?us-ascii?Q?WfJ3C5fAwZ6eTuDnv5yDmshOxlSNEzXvpaNJBLGmawGF5d9fznzq4Z/dwjTc?= =?us-ascii?Q?CkZO+47ecVx6PEj8OiJ+O8LMP5pXYRdhHedRr90JP4JZL3l6oaOut+VQxxrQ?= =?us-ascii?Q?1Jj28Y5eU7qbpjiN+EdzQkl+MZZXAw01kys6BGJz6BHRDfTBdNmCDLOaEEHe?= =?us-ascii?Q?FyEOlrYuv4ZfLnjR4SladxulgIw4BpL99yQemiF0edWxoBQEbx32x4NKNYko?= =?us-ascii?Q?6h7UgwY6V9zIm99aLNrg82QVfTEVeMd8VN6AxH92f14DEX9RrQi7tsvfZsI5?= =?us-ascii?Q?pKbszsytRk4MikDGV7relEjIMv0nfJdz+UupZzDKasSUm7PFEvxyoBdQ7sCb?= =?us-ascii?Q?azS/3kD1Mzuj1HMDj86WgpODWaNE6MD+AwudloVkff79ni+eG8UJAs5pnG2h?= =?us-ascii?Q?uS0/EbjqW9L9b74zGrRtbyIqL3QfYhaBTqZ9YGtmzajeijdeqaVUaan5Grjn?= =?us-ascii?Q?LlHPXi7lbj4lW9i7zQhjHTE3Tb/f//A1kDF24Q3COUggIgN311aWVPNu6usc?= =?us-ascii?Q?4ZE2a6VvlLtITmLzH1Csa9x3kdXN7GaxdwgTw7Se9oHUlZAQNR915d2fqV6j?= =?us-ascii?Q?bgZp7qb/nbxbM9bTIeoYV+W84Xkp5UCax/4kR3wWiTsuUzUcLPzsiZXvHzUK?= =?us-ascii?Q?NchXDuWZsbwBxxHC02YnC5tM+/vJzxLLi4cmfgV8HiOdy8lII4ixTfek0xB0?= =?us-ascii?Q?7GN4bNQn9firj2pMs1TJhvk7De28bbUsTtTaRFM/Yxp/kzu9LaW+M+rAGYDl?= =?us-ascii?Q?x0Mm2jJNICLkyH7BRBlhhpraoxH9T6DIt/iKeNAXK6L1seTxjT3AHfcQx07P?= =?us-ascii?Q?Bc7ctPyJQvL5bXdFnJyNA9cwDxDItLmMgO6iC7lEjNiO/JY66rh4NEp43xAC?= =?us-ascii?Q?ul9DthbYYGVl6ftDyeVo51yesMmzHMVLTitg60F10tN09A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NPsY/jdk6xZBO7jMv1UXBeCGiHGCl/dW91Yre1vNJRsxOGfEjXLXDv+iRlss?= =?us-ascii?Q?AVL8wrJFSjnHDycGBRYdt0pgy8fv/BHZTESmWWF6iUtPGCicH6j9Xwynuvdq?= =?us-ascii?Q?TzKllRdbPdxD4+K8VTTkWM8s1c6hlzzXmBs7yCuwxZQehXUUSJEbQhcnwGBJ?= =?us-ascii?Q?HWfRfj8SSclBTUs8nXfLHTA1q/bUs5JRG/cmDHUrqQVK1OZJuwJkef1zzJu6?= =?us-ascii?Q?TTWAcB1ZLp2+sbiPjPO7kMh+qkq656ThdCUKqX9zF/9fAVCXh01gKUjJ0ULZ?= =?us-ascii?Q?i5hsSvM3JgXfmBVagI5+bmgAuH1JBac0MDCH6MThCe4XpGCxbAtt5qa8EFHs?= =?us-ascii?Q?V0kHfCgAygb5Ijamgse6DTP8LJFBGtKScG8d97PE91L0DV0SRaA2QZQD0hWp?= =?us-ascii?Q?ulaN1Z5Xkw+jmoz+LlTePNw2LNsWWOnlNKEWPo73E3V49i6d5FuzUhfCGbmb?= =?us-ascii?Q?tCpZ4Uym0bS9kZf3VG0cwMsythXQMamYLrBTqVZofeShHK9OASrH1C+LROIb?= =?us-ascii?Q?XoRaKsHedxlcGBLCWD13cto0xV42zjsmIEeYnJsxvUgG3POJm7C5XJDISO3H?= =?us-ascii?Q?jimbX9BEwKwBeh9Lz3M5mu3tDfRALe7G5I/dCX9rl893WqKqDrzyXjTPv+Lx?= =?us-ascii?Q?Hi45MNsKXjE0qEJp0dW++0w/Je5GSyJmKA1cvC+TLTC9YyyZKV3f9AQpGfQD?= =?us-ascii?Q?3AyQ2iUWqzOZ/lQ7hexa9ViqK/lxhht9hX/0hvafnvYmATtUpl1tKhr2v8k/?= =?us-ascii?Q?RqMje2wzTVyPRIgQn63qkoGRXWS9yAJ75GQwQ7zyUiQVdYkSi/AxzPJPjieg?= =?us-ascii?Q?HH6yUV6oo0olaluVAL/T0k2l6f+yt7zNLpWiaBm6j16uReIdfJ1qrUVz1U9r?= =?us-ascii?Q?nBwEPIWaXG3LX59Fp9SHsDKx83Dt0n6OoQEt8PHLGSPZ0tvRZ7hrswA/TwOl?= =?us-ascii?Q?k+t1muYMcafngw4GG1cyQtbGlig341mGO55IMNvlxheqVnURhcxchLnofv9i?= =?us-ascii?Q?/O/MahuKrNB5aZNV0vKWWm9fgANFMidKbq/qwcukMklXyCyIbaP6soaGLPEi?= =?us-ascii?Q?xRffO64Nab4lGZ3uXIAfkQzgZOH1c3kCevoHGHW6U3ZVkyyVLMSNlWNt4nuK?= =?us-ascii?Q?18q0b2s3yuEEYCuwaN0cHTdPTvaTzZmRP4pTZHwaFhzbrWqbXCiWF/L4LFLE?= =?us-ascii?Q?YV+AHeExMHdxvyVd+a7S3/ny2PqkYMCCpHRYTEy/tu01SCZO3rt/dLIy1qdZ?= =?us-ascii?Q?icPuAEczeKT0FR015VXfkJ0qGCJbsiak1NxhiWYnuCttzW7DTK20kzfJEx+K?= =?us-ascii?Q?9cmS5NJFWLabKkePrIc0eikbXBoe1HgV8DEMaZyIjnc+BDo36EWu1TG3kNDD?= =?us-ascii?Q?oxb3SRxMiXALw3UNoZjTGU/0XZV8kg1O6udYRLoPBLlHzoTPO5FAI/HDckzI?= =?us-ascii?Q?dZZoMgZMPIhZib7O1Qc1fzoj2xxuN3Veue0IcIoBg6OYYE068OgU5LSaXKnZ?= =?us-ascii?Q?FHwGWrKFL0OO85gtvN6k5FW9MDyeJ0zof08VsK3j2CbHMqrucphztcnhnL5v?= =?us-ascii?Q?4t2ZwRSd9Anq5PAJLqbgmK369vs41jtxoMp42KyUMbXZnV3OHmaeE2ys9QYa?= =?us-ascii?Q?VA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe7742d-286c-4054-2e46-08dcd0adfe33 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2024 09:01:29.4660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2Ovoljq628y3tVbZ39os5saGSfswIcc8amgBYKyP+V9oYssf8DzChpCxR2kb721KvgNMg2YRu4gdWMPc3QEas28n9rC7aSpoGqf414tmT/4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6157 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Sep 09, 2024 at 10:41:25AM +0200, Burakov, Anatoly wrote: > On 9/6/2024 4:51 PM, Bruce Richardson wrote: > > On Wed, Sep 04, 2024 at 04:08:29PM +0100, Anatoly Burakov wrote: > > > Allow specifying dependencies as either mandatory or optional. This does > > > not change anything about the build, but it is useful for tooling to know > > > if a dependency is required or not. > > > > > > > Ideally we probably want to merge the support in this patch with the idea > > expressed in [1] > > > > /Bruce > > > > [1] https://patches.dpdk.org/project/dpdk/patch/20231220142152.492556-4-bruce.richardson@intel.com/ > > Hi Bruce, > > Please correct me if I'm wrong, but doesn't it essentially do the same > thing? You're adding a new loop over optional deps, while I'm simply > extending existing loop to iterate over deps + optional deps, which would > achieve the same thing? > > What does that patch do that this patch doesn't? > Your patch categorises the dependencies into optional and mandatory but doesn't actually change any code flow logic. My patch doesn't do the classification changes in the individual components, but changes the higher level meson.build file to do the checks for optional dependencies and only add them if they are present. That is, it removes the need for individual components to check for the optional deps themselves and add them if found. /Bruce