From: Bruce Richardson <bruce.richardson@intel.com>
To: <dev@dpdk.org>
Cc: <kaiwenx.deng@intel.com>, <stable@dpdk.org>, <hongbox.li@intel.com>
Subject: Re: [PATCH] net/iavf: delay VF reset command
Date: Tue, 17 Sep 2024 15:31:27 +0100 [thread overview]
Message-ID: <ZumSv12P6XlU-ACF@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240909110356.23757-1-bruce.richardson@intel.com>
On Mon, Sep 09, 2024 at 12:03:56PM +0100, Bruce Richardson wrote:
> Commit 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF"),
> introduced a VF-reset adminq call into the reset sequence for iavf.
> However, that call was very early in the sequence before other adminq
> commands had been sent.
>
> To delay the VF reset, we can put the message sending in the "dev_close"
> function, right before the adminq is shut down, and thereby guaranteeing
> that we won't have any subsequent issues with adminq messages.
>
> In the process of making this change, we can also use the iavf_vf_reset
> function from common/iavf, rather than hard-coding the message sending
> lower-level calls in the net driver.
>
> Fixes: e74e1bb6280d ("net/iavf: enable port reset")
> Fixes: 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF")
> Cc: kaiwenx.deng@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Tested-by: Hongbo Li <hongbox.li@intel.com>
Applied to dpdk-next-net-intel.
next prev parent reply other threads:[~2024-09-17 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 11:03 Bruce Richardson
2024-09-17 14:31 ` Bruce Richardson [this message]
2024-09-20 11:01 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZumSv12P6XlU-ACF@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hongbox.li@intel.com \
--cc=kaiwenx.deng@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).