From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5588A459BF; Tue, 17 Sep 2024 17:45:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4606C40280; Tue, 17 Sep 2024 17:45:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 5AABF40261 for ; Tue, 17 Sep 2024 17:45:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726587944; x=1758123944; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=hIdHjls59/fYmLIm6VLLJAlFGw7nvlHHGXe+uR02cKg=; b=VEvwIJ08Sq8pzpetrKReBUpVmXmHbBCfFu1FharDedQXqo+8mSc3xd54 6UjguavoKRX2i89LVHv4pcZNDQTTpIJHNdiHEsk4hhULKFKKvX7OfAHzW +ksudJ6aCCng1o85d5PkrBrfkFadjckKnqUihxmPDc0uO9D2OUBKTasA5 9LEfHi4OdToF6tfXPiTu9sCrZzlaEPP1bOlgM5I9EQ+FQOLPsTRu72rYh OQI8TYCqx2/muFT+O2ZrkKyU3scB/Wvgqxlp52bGXxIUrbaToSGxrHCmW lZq51bPbeLPo/drIuZLwhKaKiQIePZq41hxTYpAc01cGewvA5OBpUsW7b g==; X-CSE-ConnectionGUID: ztn+Lt//ROGsko79hX2Wsw== X-CSE-MsgGUID: kEc0E5mzTCKdyrFAyYmjEw== X-IronPort-AV: E=McAfee;i="6700,10204,11198"; a="36035146" X-IronPort-AV: E=Sophos;i="6.10,235,1719903600"; d="scan'208";a="36035146" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2024 08:45:43 -0700 X-CSE-ConnectionGUID: 0eHvWQm8TKuvAghKOBhgyQ== X-CSE-MsgGUID: W8pPCVHfT3KYO0D+QCdG5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,235,1719903600"; d="scan'208";a="74212104" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Sep 2024 08:45:43 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 17 Sep 2024 08:45:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 17 Sep 2024 08:45:42 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 17 Sep 2024 08:45:42 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 17 Sep 2024 08:45:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w1yywu89bFSmijjyJR+ZR0XDy0A9bkOF41DEQMApufIzWTLDhpHa85H4Jcun78tic19HfLZ1xgkt+VRwZ5b1MO9PyyPSkwwz0Lg9XRaBoSmaII59+Llq1PVu+J8G5fcTSLy27iHIViHi60R046YQe72kXToOJNwyYPG620sZHRFkIY4nDQFUwnn2M0H/PlxEtPO+U3/ud3naq8a8JuQcXcNUPAk70BWM4e8StbDGq1tZYeV+GOywfXLr/GiG69Kh9xTdXEJC/ei+P7uWissELPmbcJaBb0EitQeRTBDRT3xsgwHbcgvQ9o3e4P2aysYLtXJs5wEylaULMuhoA2Cj0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wF1ZVSa2DC2aAVjX6OpEPOFfD+nvMM1R1WaGDIbRmoE=; b=ST4ycNli950nBK80131KOq6v1sOrZxb5VYy2S7v2g5My9dO1ys9+Yq3dCbd+RCtTsSw+15Syp/X7bhCZ64/kqJdGqq90Lev6qQyinIBWypbq2kP38tOoRq2rtNYh7xMq1bWJTClESBO1eteiH0tq66SYmOFwUPxLYaijW9O6LTEMb/97ARUwG47ebMZzF2Dtp7cpg9oiLwb94aAoQog2xVjjHo2twKPDeF3zPiwLF8yyekRb61w0IV98xyldLoB0FXJFHxHYonACVIkEms8pNco08rWYshcdDuN8S8NM02lu8J1aELDSwYvb8Z4QtDsPMm/oAKXMAqGC0CDyiyNtKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM3PR11MB8672.namprd11.prod.outlook.com (2603:10b6:0:44::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.16; Tue, 17 Sep 2024 15:45:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7982.012; Tue, 17 Sep 2024 15:45:40 +0000 Date: Tue, 17 Sep 2024 16:45:35 +0100 From: Bruce Richardson To: Stephen Hemminger CC: , Thomas Monjalon Subject: Re: [PATCH] devtools: fix false positive from checkpatch Message-ID: References: <20240917153421.6552-1-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240917153421.6552-1-stephen@networkplumber.org> X-ClientProxiedBy: DU2PR04CA0348.eurprd04.prod.outlook.com (2603:10a6:10:2b4::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM3PR11MB8672:EE_ X-MS-Office365-Filtering-Correlation-Id: e116874a-256c-4dcc-f6d4-08dcd72fc7fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qKerGOPT4S3oDXkE977vVT8XCbmnjsnLC1BJDuh47B/Ewqnhb4QUyXGS5G6m?= =?us-ascii?Q?G5G/WGiCH9yBwuPHSJuxCy9xYtijviW1cItk4YzIZmlv+g4q2qpBxBh3OG63?= =?us-ascii?Q?mYxpeDbR9iwY09e6Xx5JTEeQpwgy3p5dSxalnINv8MHd0+edROyekXqqnwO7?= =?us-ascii?Q?ZmWxYZeF5nDP2pPqwecsQfaACUwubgxNqjjORAyNOZKcjmxWmJgu4WvMy3Of?= =?us-ascii?Q?FZILNMXrbSwic5wWcrNjz/V71UjCaDEKl143q5Od+WgKDegl9L5H0XylQuPD?= =?us-ascii?Q?LxJKenGRxktoYwDRvenCGwWoQCDh+BZfe+ue52PbvuoCKlUtAXOhzKFHwdfE?= =?us-ascii?Q?0CvSpeMIoPIiNQ3T/xbg6wHgcnUcBHYC1JJTH/TqSzr9HNEzUI+EdoB/VYya?= =?us-ascii?Q?uvHZIQpG/kAhYHziIZ0oCcJMEbSTr12JrsYHkIHs26kiB/G74u5D8BqxSRRp?= =?us-ascii?Q?FEap+xNpH3RdYKBB/rvh6Dfz7qbQUHJa2W1ZwlJopyQIAGogxKw9lXUyQIVB?= =?us-ascii?Q?QFF5pTxv2OXoAZodCy92IMB1R6O3vosm3N3KjJxw3tPX7LxMyokQiApCWqS9?= =?us-ascii?Q?F0dZuVfhkumF1730p2w/JxpcuWm2Dk7ExEBlbfTJBWPPi+40okzjmspd2gQp?= =?us-ascii?Q?CvXA1K0MwJMSEP4/p9G+PWHiPYEbul5LhBsJWIocnvMMNx3I9YdQUm3kZt0d?= =?us-ascii?Q?EEdEkaNNH2bdelKeMntlXizZvzsP9qcyOUaOACVmV7i6E9/ZJ8BD7RI/BuIK?= =?us-ascii?Q?trqewQDqQii0/TgJrA+DcQZx8QIFXHTTMI4w9xsul+TzAejd0BJzEtrZvAlJ?= =?us-ascii?Q?bmfYKWz0sRVGzuWW0hJJSt+6w8aUX5JGxlBB904CtzoLF3j9OfQ4+3U2X4o4?= =?us-ascii?Q?efQnoIkXeu079lBAUFpGgX+48OWhQJCeMZ7btoHRVkzNd/c7m437bBOINzkm?= =?us-ascii?Q?TV4ZAtCdXOlHCdYGpjgrNvCxacLj0SSBPOYCtfP8WHxAzh281M5xuXIZIShU?= =?us-ascii?Q?CeubhTwyvd0K2Mu65+pk0xGM2k9fh0rER0SzX/0XeitSLRXjvOAZftp2k1EK?= =?us-ascii?Q?nxKsDYF0DSbuWWygLfQLisZxM+sjMuFrQ9WiFuZ5l942yEX5/4Pr9L9OK5bv?= =?us-ascii?Q?oXYs5ZQDJ575Ot5U6WfNjA/kqzDydz00+Zb6rW3D6M9UIg2YjCo9VJCbvurY?= =?us-ascii?Q?9moRHO2gatqYdQZJaBwb3P0tg/M7c7fd1QeAYkEyU59RcANAyV9wpJKuyJM2?= =?us-ascii?Q?nHzWDoSxy735rJ9yYmo1fATaqlD6ZufXYMsxbDNAlBhD/oxNPysWIroYo7ZZ?= =?us-ascii?Q?vmPDRXp+RPc5rpNM3gkyeVs1aSzUPqXk92hVv/E/IITTjTClgvHNeRa9d8KW?= =?us-ascii?Q?c9tIfsY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JnIZyHAh9TqjWMEMp61ai0t5lF1ayYkrU6MSTgfSO+zwXjiMvGozgae+UY+i?= =?us-ascii?Q?MUpU0ZchbWb3UM7QS++dRyy7gjPnPBCemLWLUE79bId6YiNNRVBEzWneNTOg?= =?us-ascii?Q?9BxRE5O7Shtda4Twog0vNuy+n/VfTqDhUVCiXdoQB2SBc/0cF6POzPX9a2eq?= =?us-ascii?Q?ATb+Xm2GszcyLwcpIsfel39tsm1n+qtwPW3ijryYcpS7LK7kAftJVfG7bxwT?= =?us-ascii?Q?SnFqSikHEdfLnswLXfSDmBHc5uHYys41shEyRW5RkSAab3pRIeUyHAQdkSXj?= =?us-ascii?Q?bbTf6SGwuwRJZjZ+LyDDU2yTX7Z7QZ+ra62EXWwx/cci6A++fQcag1X0zt+o?= =?us-ascii?Q?f0bNBVSLWzANLwUxBaM6RhVeHDZnmZ8Ze+G+B6UeJJfN2C4Os+O8WHOVcPJd?= =?us-ascii?Q?naQUX5BdBi/N+3gT9Kbp5fnwNIjEM5wDCkTfMqQrekW1ACN92fCEIe+NSrmx?= =?us-ascii?Q?o2VDODKS6EQ8x46MpVkaHImzDyeq/nsSLMBvat9hOzPDJRIu29i9W9yABlgh?= =?us-ascii?Q?/SUaLyYkS6Ubag6zqRvXgjhX5dD0B/StasCjKtaUp03Q9h0OFk5l5D+Hw2C1?= =?us-ascii?Q?+4RsHYJLLgBGipW67ZZqV+aBfmVt1YaJ0MrLUFW8gMUyrGwBzqhUtZpxPQfh?= =?us-ascii?Q?zdz6P+X8Wrdd5aRpq9ueSlRVEmeg12xMxj8XMf7rsTcCAKJELeD/pvBxBVVa?= =?us-ascii?Q?JHLHke6cwv9FZ2x8YJlJXWhw0eo20tsa6bYdqenkWnnDkjKzJq5fdQB6gK4E?= =?us-ascii?Q?FLMF9kYy1DRE0puldXr8VrEKFlmR7AOVA/1wHednryAoj5dz3spLK5jV+re9?= =?us-ascii?Q?1F0+QOBn5Vk++f8mU0wxEE+gAjzBuzFGKMeoRbpwcBTQi65uoIMXwypNVkXQ?= =?us-ascii?Q?puHCaH2uuJ8SzoG3wreZRcVGw+8c9JmH93IEkaiIsFDfh1Oa6gmIsoP+yHu2?= =?us-ascii?Q?LzL3LlqmNoFYV1EQmHFo/xIMrTQXUJjenQWn0X5hQqPe0g2DEhtsoh26zGfU?= =?us-ascii?Q?Ahf5INdxTg2rplx1o68/KW0KXUgBOk1ec0D3fWsHuI1U07o1X53Xw5xYKaUW?= =?us-ascii?Q?ArmrOMOW0+mE3KexQN258iws5C1tq8woqrh+409pEDmyfZE9l88CObbKO5/h?= =?us-ascii?Q?UTDWmVVdnYgAhSk7gPGSRGfbCajbGcgECLFGSbghYISaD4mi+if/L8V0uIYi?= =?us-ascii?Q?9vrEaXecgBO+ITRKT4fZTn7xtkwUx8Ydt1azJxphdRE75PcNdNDMUKw26LhQ?= =?us-ascii?Q?yL1T//uw617kFzmfjsY1eUAsKQ6sgGibhZQYGNtJVX6r4eIGm467KTjInlfy?= =?us-ascii?Q?6byKlzvnBd43MNI9ycSdyt1k8W4wrP25YcHa2ag5bs3dJ/pyW2sAsdHmDI6D?= =?us-ascii?Q?/SseMBJy6xRudubKz8EODhUSXlMV7FphFrbZbfIKTpliOURB7jgKklWmGBU5?= =?us-ascii?Q?WKK+7QDoNON13BEsfoBdkb1cF8ljPyC+eSMhmAyjnfylQac0FsnpXzAz82TG?= =?us-ascii?Q?j3YbqgF+5TqG+x8otuB7Gg9yMFNUAgKYmdcWV2icDrSQKRZfPhwkUo59rkoR?= =?us-ascii?Q?dtwiWaAp4JjawjzhSvoGxYHc43XRrk7jZc3cN2ccauIWYPyxWoa7okFHwlOP?= =?us-ascii?Q?8A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e116874a-256c-4dcc-f6d4-08dcd72fc7fe X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2024 15:45:40.0955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ovdXoBbRRaIYaMG/ddHJ0bReSlZcS5zvBm4kjA5mz2f8WCCEDspNIckJhZSAwFqsS6yRLHSg3ALSNYsszrEi9bUL+N4ZxFnQUokuorTaMpM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8672 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 17, 2024 at 08:34:21AM -0700, Stephen Hemminger wrote: > The codespell dictionary has "stdio" in its bad word list, > but stdio.h is often used in DPDK code and creates bogus false > postitives from checkpatch. > > Also add a check to the parameters to build-dict.sh so it > gives usage error if parameter is missing or does not point > to the codespell git clone. > > Signed-off-by: Stephen Hemminger > --- > devtools/build-dict.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/devtools/build-dict.sh b/devtools/build-dict.sh > index a8cac49029..96786d2c53 100755 > --- a/devtools/build-dict.sh > +++ b/devtools/build-dict.sh > @@ -6,6 +6,10 @@ > > # path to local clone of https://github.com/codespell-project/codespell.git > codespell_path=$1 > +if [ ! -d "$codespell_path/codespell_lib/data" ]; then > + echo "Usage: $0 " > + exit 1 > +fi > > # concatenate codespell dictionaries, except GB/US one > for suffix in .txt _code.txt _informal.txt _names.txt _rare.txt _usage.txt ; do > @@ -17,6 +21,7 @@ sed '/^..->/d' | > sed '/^uint->/d' | > sed "/^doesn'->/d" | > sed '/^wasn->/d' | > +sed '/stdio->/d' | > Seems a good idea. However, why use "stdio" alone rather than using the full "stdio.h" header name. Do we expect "stdio" to be used much in comments or otherwise? /Bruce