From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47589459C6; Wed, 18 Sep 2024 10:27:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 334E042E9D; Wed, 18 Sep 2024 10:27:33 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id EDB014029B for ; Wed, 18 Sep 2024 10:27:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726648051; x=1758184051; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=h548msJFVx9Zvk7vFurkrKGfZh/BbkjarqVkRQFHJEs=; b=Foo6SRJM17om7RMJdGgzTRaIJ3lDIJV3HLVSWYM+oDrnl4NsFJynMjRb 2z94p0oA+zxKPSJXU6+Z/HHdHFf/unvnO6zbgEnE7OcnQZ1JaFzh5hHpn majerJR4JWeRTuqEoLXynrWjEOfaYTKgssEBN3JqXJC25V77vPtfr6j9t lBC02N0S86VU0ShMLkatt8sF3GTfJp6DdwzxdbCH6P9A7IPXSW4H3GX8D 7hSgtJpOxmBYrduivS4OqKILT3sa9dV7wr+kT0y8ez/lJEpRwD4Mg1fnB AWOdW10Un75WU9w1DcsDfJizB/foaSfj+cdKvXU7ltVWKF4boeUUML1SZ Q==; X-CSE-ConnectionGUID: t2ApcRWcSfS5tvAfipzcMA== X-CSE-MsgGUID: nie3Y0b8QJ60q8HTCCaX/g== X-IronPort-AV: E=McAfee;i="6700,10204,11198"; a="25364558" X-IronPort-AV: E=Sophos;i="6.10,238,1719903600"; d="scan'208";a="25364558" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2024 01:27:30 -0700 X-CSE-ConnectionGUID: TfpVjv25So6V2m4KnKLUKg== X-CSE-MsgGUID: Xl5ftp/gREampSYFQaJ6gg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,238,1719903600"; d="scan'208";a="69464865" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Sep 2024 01:27:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 18 Sep 2024 01:27:29 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 18 Sep 2024 01:27:28 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 18 Sep 2024 01:27:28 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 18 Sep 2024 01:27:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B46EIgICXnShgtYG23zNmrMhffGbDyrbhg1bDBzSqExOSaPW04qFskXLelkejz0wPYTRyfpZLasIYBWPBEbpgckRO+eFnh3eUmRNrKvia+vcrC1mV9+6sQV3ZtKIvNQlydgZvGewsaBktelXk0Y0lgCt6Ka5BNPTbTPllMQ5igB+1uJVneqgChIsEHz+tLvo3oKwLUWQfOfDBX+xCXQbpmwbRhpuLJ9HjAQaosLdo/Y24ty/fpVcP0xVLHO4U3sH6NzIyE4Wxaaywf3+FH423QygCpzEvbf4Mf+dRvnC9SwepuUXF8I7Su71oALo6ZMwIBxwrvzSUX1n81DQ/TGucQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/JY803ByyNHeM2xRAdfNLzv7emNW98tfq+LFN5L0tE=; b=DvWq6PSKPsPoP0YP/ovyGsx12Fb7hUJ/LF2nM2r6Fb9NfCIrDEMXII5OrhcX0l/I/X1d4ufOojaj3vtdkQ+SRVXaeuDf0l7F19LV1X2msbU5xzmPQEXCsGTBOAue4r68NX825la1/UYCV/yVoP6OUHCxX7bvn+XJTIgh5NSvJG4k1gMF848/tQvMUZmQjIkBvfzCpqqs50IXeGFelkRQAzK3mMrJsAdPqYwEhWmiPmobXbiM8s1IX+CHQwLiPyg5exW8U5bxTGQLUFdGJRuekZ78sAJIE0Hn/DoAugpqSnVdyCRmg4Teq75PCmBW4AvRzp4BmYTRgCDyP0wikxAOMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7971.namprd11.prod.outlook.com (2603:10b6:8:122::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.16; Wed, 18 Sep 2024 08:27:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7982.012; Wed, 18 Sep 2024 08:27:27 +0000 Date: Wed, 18 Sep 2024 09:27:22 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Subject: Re: [PATCH v23 00/15] Logging improvements Message-ID: References: <20200814173441.23086-1-stephen@networkplumber.org> <20240918045830.3798-1-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240918045830.3798-1-stephen@networkplumber.org> X-ClientProxiedBy: DU2PR04CA0332.eurprd04.prod.outlook.com (2603:10a6:10:2b4::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7971:EE_ X-MS-Office365-Filtering-Correlation-Id: d0fd69df-50d5-468a-b9ea-08dcd7bbba77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vTm/Oj7Mb6dedz3UTujE9QDILSD5KWGdaTThu4/d2aID/D/QtujBqZGHlBgf?= =?us-ascii?Q?630vxJfVMUkRa4LiYP1G0xtBPZ2EHL9QojR9zllEi6BMKJh7T+W4LYG+ACXY?= =?us-ascii?Q?rNddkobsc2+sfPmClG1FDyVzFKezCXCkbCzGxw0NMw16dKb3kGwVChfHVg0f?= =?us-ascii?Q?h6hygnwQgcAlyKRWlRn8cUtii3/0ZdL76i9iOiFSyrn4TrXSczyfYIKw8/1Q?= =?us-ascii?Q?UsG/TOF+jwtGvHBkhDxhCUBdVFjVbOWVplAeoxJbFd2vjpH8iinVAh907Y3Z?= =?us-ascii?Q?Wae7qj6raH7hZbIV4AYPCbH9p7+WEx8723gSKwjpwPvaYyqZuycXK7ymIjNO?= =?us-ascii?Q?hkS5CiXv4sueGQbZa5ZxZQBaeSslJ+5pPZdeX/Sh90Yb1lktbutrT/XfTfP9?= =?us-ascii?Q?ubKmd2LDjRcmXI+4OsQ2DTuHR3wYvrkyqXfA5USFMMGVGIxAts56tMYVDHdq?= =?us-ascii?Q?KmL2hRiy0kkgbU8BMVpbcx9DNKgRQ1GyFVPGT3k7hxJ0d1Cu0Qi+ha6pAQZ9?= =?us-ascii?Q?J3e/teJOifeOSk2Y7jHZOQCzKitz14xSJOqHmQh0k1EOt3S802nukr+bEojA?= =?us-ascii?Q?DkZNenGeJLlwQV3xa5R5R4Y4fg2smCLkU/5W6rxM1S6sG1GZGKbkcizsDoM0?= =?us-ascii?Q?KePX7fX9nJrxmI4iYfFWc5m/fUh5vDAhcTy0cS37lVHiKBTOVimYvezjd1aA?= =?us-ascii?Q?XhHj1PUCxBIqPPvxz/XQ6tWmvBQeaBdsjTNf2rv6hFiigv6MVHlpPc7GuI+z?= =?us-ascii?Q?5gh92DeuNC1vQp+aBI/GE1UFCu9b36j00L3++NFGqoqwPVpbuNJpcWgjd1ye?= =?us-ascii?Q?08N1KDjqPRgKFs0EeZLH8iry/zDe/IyT+8NCgVVlf7cTFNEkjSD0mQMEI9ij?= =?us-ascii?Q?w8MQxCxRiZPykENP/SkW3c83jE9fdJ+XyMaX4//NMPFoTkn+6BMBR62BcBJP?= =?us-ascii?Q?wimnQ9SDWGQ2je5EKnQ9Lme54ZsyBqqntj2862LngJ/pDsaqoRma3PqQ7PlB?= =?us-ascii?Q?46B4kblT2XhwoFz7ojfbir57SkHHTzyNGcxl4pa50NP1fDaw4bGbhVZHkjKy?= =?us-ascii?Q?/kwAkSflh8f95OGxHs2sb1DsBoUvVZIGvwRqz0eqthXsudTMF5ZBNyd3lNCo?= =?us-ascii?Q?EM5oBHQA5CrVN/dv+VUaus1TBQJkJhP8xFO3e/BKFB+/KShI83qoX1Jndqb8?= =?us-ascii?Q?cTHPP0WeYP3qllPdC6jgJ35bFNGayjy5T7Df3YqQDd9jJX5jxzO2GVyza9T/?= =?us-ascii?Q?57cT/Hl49e8ZceHRwk0JxmNFwUDqabWCJXuqlrJGUdB8XYPpEKnc6+WDsfwf?= =?us-ascii?Q?I6wEXohTysdgyH0Lw73ryS1uR/W/slHCKxWBFDgq0X0VuA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v4i6JJqLucsdoUVtlRvkca+PhimF72lpO0bZXuk1fnxl2FqQA6NxVp1m8rcY?= =?us-ascii?Q?6y5xfxFcMNAjel9kLOYBaaSr/jepOpavtGTzihDQ6O7WIRcN+m38ZIgdC5tc?= =?us-ascii?Q?qjjgwg8fcbPtaDK15o5nL6UUSuIt7EEpKtGqb7qAyYKgFc2ZdQlr6o60h9uD?= =?us-ascii?Q?rBm4DTWgxjJhmG5K8B0YK8iYAnzppyi9qZ0DxE5IVn0KTYXD4A4WYF2FBuBK?= =?us-ascii?Q?kuCru3BE6l0ahcbTWEpXTUR0LL/G//8+qUqqMVluX9Bwrv0zANzlBiZ7PmaQ?= =?us-ascii?Q?uBmXuJ2Wko5iqygc/Piv5CZnRTGes3EtPKCjmk1CvbTay7U4RroibVOIr4vo?= =?us-ascii?Q?4HA9SqBlgWqu1c05Jyd4tdtYhWTvKUuWZwZszn+ci705X03B94jLTw9fCDOQ?= =?us-ascii?Q?7HoCtmO6uxLSRcvuT8QMCO2rp7DbqKX/fjNTLWGo1GkAjguFzTOYrgBenHfs?= =?us-ascii?Q?owlJKt+G7XOKN4Eu/yikqXA6dJcDN7bq85C3+cX/BSLPU+HmCE/EORLfAyML?= =?us-ascii?Q?BgZ2r1OnV47jp6R28QJ+TzgRD4z67P0QSezWZeKgMnKT/yyfL0r8/J0WkKvD?= =?us-ascii?Q?4815fQrui9qkj/6GGDwEmD49mqaJm9yz85nQ1pSBUYHgDVXcYRhiYFeRMBlu?= =?us-ascii?Q?jhH/ZKXLarW5El67keqMU6U7OCli005POO2vN8pawrbal/Oz4MxJsjQy86ea?= =?us-ascii?Q?LE17W0KMkGTQSFaByi6UQC3g2zJBP0mME0LXCijbpfcUXWBgyjhCo4EkNugs?= =?us-ascii?Q?WDxa5bLuFC9Id2J7cykmTJUsztALsZHdLve7H5bWAokhAEwKvo3ucXp9DHtF?= =?us-ascii?Q?DiYvfzWCp1R7jXpUgQTAaT6fTTlgBV/Y7qak89uBgF6ofe/CxFR2ehTZYgCR?= =?us-ascii?Q?+FSwVVZ6HSioLooFA6RaAavJpMVyj3yJDs1RJJVDkQei6/xzsDBL6QzqI6xt?= =?us-ascii?Q?/IHtiNdBUMyh7NonzoXZq5AEYOG1/HKFVLAbqHknYdMEP7E+YZ3Qqb5GpClB?= =?us-ascii?Q?zBRmNzrz2fcjyw28oXDQLSmYnGkE8N0Lo9xOa7DLvONpIbuR2ftEAJ30PaTp?= =?us-ascii?Q?d2AbL7d56KHKbdR1wkpcHlzBSeuNQ1H6JIP8yi7NOuXjLqZej2+D4opMrPNn?= =?us-ascii?Q?KFsRcAIThCh8sXnHFNurJX11yYt85zHRAwlKJr9NflA3PiH6Sfrqv2qFV6jV?= =?us-ascii?Q?5H4qDhRWq0FzAz2UDoW+3i1gkiEF3O3DIuZzcDrBfNd11eqAgYNkGKAYvH8u?= =?us-ascii?Q?/w9vuGO+Ow+c+UgYR1iC8qA/zXP0zGJbIeZnI2yI5Ib0hh6HYjtoq7eK9ipv?= =?us-ascii?Q?nMUddnAgXdPepYLzoDHWOXz5psLwXXMQnYpK7+y3fnoJj8CHGzSTkIoEow/e?= =?us-ascii?Q?svIPKeiAW62qEBEisddlACC8ttZmr6XtIY9LJJp43MCMQkxodq2mgbDOtDki?= =?us-ascii?Q?Bf/E0G5v0XX/ZPJAkaYKZ6vHBcMdYcW/ZMFyiAXuo3/KSRVKayHKOr6b6KMg?= =?us-ascii?Q?e3ond2g/tyl+QFAFOssA/++tQxk5z+VBZNIx35JVB94Fpt+cbxPeURYg/p3g?= =?us-ascii?Q?VUqpR8K7S8vIMqMn2a+4etuX80QCqy2J6EHpAsoA1x5a59D1ffwtqtD7oCGY?= =?us-ascii?Q?xw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0fd69df-50d5-468a-b9ea-08dcd7bbba77 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2024 08:27:26.9480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GhWCbuXXPWhtKlPamdPhhoxO6ZFwge08sfdFdoBg4TdsLFpCnIC6NnxQdQThrqkeHz7YPiVJqwGcCN66nXPAZ+uV6koHXMRkbWc+jboMPjI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7971 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 17, 2024 at 09:56:05PM -0700, Stephen Hemminger wrote: > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output. > > * Putting a timestamp on console output which is useful for > analyzing performance of startup codes. Timestamp is optional > and must be enabled on command line. > > * Displaying console output with colors. > It uses the standard conventions used by many other Linux commands > for colorized display. The default is to enable color if the > console output is going to a terminal. But it can be always > on or disabled by command line flag. This default was chosen > based on what dmesg(1) command does. > > Color is used by many tools (vi, iproute2, git) because it is helpful; > DPDK drivers and libraries print lots of not very useful messages. > And having error messages highlighted in bold face helps. > This might also get users to pay more attention to error messages. > Many bug reports have earlier messages that are lost because > there are so many info messages. > > * Add support for automatic detection of systemd journal > protocol. If running as systemd service will get enhanced > logging. > > * Use of syslog is optional and the meaning of the > --syslog flag has changed. The default is *not* to use > syslog if output is going to a terminal. > > Add myself as maintainer for log because by now have added > more than previous authors. > > v23 - simplify and fix Windows and FreeBSD builds; fix #ifdefs. > Change from defining stubs to using inline functions in log_private.h. > > Stephen Hemminger (15): > maintainers: add for log library > windows: make getopt functions have const properties > windows: add os shim for localtime_r > eal: make eal_log_level_parse common > eal: do not duplicate rte_init_alert() messages > eal: change rte_exit() output to match rte_log() > log: move handling of syslog facility out of eal > eal: initialize log before everything else > log: drop syslog support, and make code common > log: add hook for printing log messages > log: add timestamp option > log: add optional support of syslog > log: add support for systemd journal > log: colorize log output > doc: add release note about log library > Thanks for the cleanup. Series-acked-by: Bruce Richardson