From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84FD345A6B; Mon, 30 Sep 2024 17:57:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F51C40608; Mon, 30 Sep 2024 17:57:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id D026540430 for ; Mon, 30 Sep 2024 17:57:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727711855; x=1759247855; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=G0S+VAiHUwh3rZl3Rx5xDIGKM7tZFSyl0X8BHWh3Z1w=; b=WPCOkbWyamwtK9z7jrB5JVYJ/HkJZpu6DSiAH3KYPtlpxtdKef5jnQlP oK51ioKPvsoEomsUc476cUEVnukMc/SmMDlBSvt8VMjSA44ZGWfq2U2Xn IJJDcNNXjhitE3ExBPSjsX01Ehzs0a9ebHmPjtCf6JrVJchO6RS6OGgmm ZrMiBr0RaDKvyMFVKkN4OIXAJqZUQbNjVbZCpxia+tt7AUvTKv2Lq0K6+ iI2J8Vz3ZrSIte4BVx09r5DD3tTXvNXfHy7CAdp90/y15SMtPNQqN2p2f i4GaIZS5DeAuo0qt1SvZ/NBdxPXpOyIOwBMXpycxisUF+GvPCCNfxSg3c w==; X-CSE-ConnectionGUID: 9F5E8Vg8QoSITXfdrrqYyw== X-CSE-MsgGUID: 5pUMPzqORTe0i/SLnb9Nrg== X-IronPort-AV: E=McAfee;i="6700,10204,11211"; a="30511400" X-IronPort-AV: E=Sophos;i="6.11,166,1725346800"; d="scan'208";a="30511400" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 08:57:33 -0700 X-CSE-ConnectionGUID: sQKsqVuhT8mC5yXT5VkQ1w== X-CSE-MsgGUID: TZRkSDZiRxmV6sr9itjk7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,166,1725346800"; d="scan'208";a="73467244" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Sep 2024 08:57:33 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 08:57:33 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 08:57:32 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 30 Sep 2024 08:57:32 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 30 Sep 2024 08:57:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e2xBHnqwXX3s6LfnhGKTszgxl1Us997bnDozjfbrlB3TSLlZse+uCJmRtIF71Vdj6VItMD3CfeWwfmle6igAbjyCg0Hco6kjkH9QhldkG8Mc2c+L9N/CMTe/yxvdxbauBPntziQ2XntZpWm+r/l+OFQXOvejg0CrUlkMxhXusZnjgUbLelO+K8guMZvUyM1keNqvFv89Z7fJfCEwZgjQrlOpmQUpxpb2tqvU6Gt/CmDZ5CvJD8mROjtm/gapCSC4ga7RgWWZQk0qkcua6QSlPxJnURSiCNYCDCbs6cbxlelNxEyCltWbn9qOP8QfzHFr/hoByRAnPtkflAuU5J44Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BjTgQ8+5IGo7WN1tcl/Fj/ZzccDl8XwazUxq//iEkbQ=; b=snuJzV82X/lcKyDmBUAngZO4wgqZ/gFjz7X7DnY2g7jidJWtFbXm12DJJOMK46Ybl6M9aqVrSzByGP+t8JYWoHuN7c6qiUWlbyVxUs2YcXmWyFq6whhlYpLAr/tVnRCJtk7F7eiKIkS30v2f+Sjv/m1xbNEfb+h3trkkIuPiNxlMM2vaJCaPYjHFndtWkswJf/1hrOdLnkCwkNXggNLYTCIdfJ4hHgsnonPvGC+DcdL/EucIDXTh+n5nZeYZVmjMVu4NHCEga3kMzfN5cm9xB1hv9xUsa17ZRtAOK7gnq0E/5P4fTdmZhu0fpthUHxqae9NEfvzijZVdhJc3ZvY4OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5956.namprd11.prod.outlook.com (2603:10b6:208:387::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.26; Mon, 30 Sep 2024 15:57:26 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8005.024; Mon, 30 Sep 2024 15:57:26 +0000 Date: Mon, 30 Sep 2024 16:57:21 +0100 From: Bruce Richardson To: David Marchand CC: Ian Stokes , , Robin Jarry Subject: Re: [PATCH 0/4] fix issues with using AVX-512 drivers on 32-bit Message-ID: References: <20240906141127.628873-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0165.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB5956:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b076835-e5a7-4f15-7bdc-08dce168943f X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WTh4T0NLY1hsWW5wL1l0a05IYURyRHBDZ0o5eDVDME9HSFdvQTZJME9EYmNS?= =?utf-8?B?cHRGZE5zYnJXSXZZT3kvRE5nOXhwbkV0am1JTUVpR0VJOUFucHdiZXlkVUN4?= =?utf-8?B?L2dNYVdjcEtEUFVySkMvT2Eycld0a1RrSk54eDcvWTFRTFdocUQrKzM0QjZq?= =?utf-8?B?TmlIU21VcHZKYUNibmZLWkFiSnNDcE8xU3BuUUZvOTlXZDZ0akh6U2Z6ZTlN?= =?utf-8?B?QWQzaHFGd3VPYzVzeTdqeSt2UEV3eVN6MzUwVUd1anQ4M055d29IRldyQ3Ux?= =?utf-8?B?NHdQbG8zekVuVWZ5TU92dldnSldpVGUvZll0aEQ4a0tZQllTTDdXdEs3SGtE?= =?utf-8?B?dmRSUXlJYzVtR0pnQ2w0dnhhckYvTVlUZG4zR2lpZ2FTWDVFaG5kTUc2Z05n?= =?utf-8?B?OGc5UHR3enY2N3J1SWtvdjRyWFZmR010TnY2di9HbmgwM1pSdmd3VFh4R1RP?= =?utf-8?B?TGxDWWVUNGZPTjh5aFBlLzJIQ2pXczl3aEx2WjVFL1BwRG90V0l0dkVaV1Rr?= =?utf-8?B?Vm80aWZ3WG9mUDVsY2xsNXBlcXpqdHR2QllHUEtLcWhibzZ6UTZkUmdLcDZ3?= =?utf-8?B?ckhzU3dUeG8vaEdDOENYUy9rMmFTd2U5Qm40TXJaeVJTbEJITEJBVW5YeGVm?= =?utf-8?B?ZkFuU2RkVW9kcjdYUVZENlVKUFR0YlJYNjdaSmtjM1QwQ0szQ0tidjg2QS9T?= =?utf-8?B?NUcrV2s3bGZOeTNoNm5TZ0pobmVoK09hdFVucXRIZ3FYTGNtdmQxdjhWaldR?= =?utf-8?B?NDlVeUFJSUh0QXRPaklTS1RKbE4rbTM2RXNFYUp2Z0hNdUd0TlVnOTVJdmhZ?= =?utf-8?B?VXVrMmJoUjNWTTlmQzFKMTh1d0ZzUThSTk9YQ3hGWlNUdlRQTnJMZzlxZFN4?= =?utf-8?B?U0UwSEliaDhWSzRhVUtKL2puei9LTWxFVTQ4RmUrSHpSVWp5S0R2dndGWDlm?= =?utf-8?B?VTB0aGg2VGliMDd5RTRldy9PcVZHRGR3K0t5SGFDalZMS0VGL09OUlRMb0NX?= =?utf-8?B?Wm16OHhPR1ljanFkUDU0b2R5ZENrNWpXekJGM3V0Z2hPZXJuUytQRUx6dENk?= =?utf-8?B?TEtqU2dQVWZmNjd1Kzduc2p1Y1JoeDBhWGZtcTdqWjlNVHVqZ2tuOEJMbEls?= =?utf-8?B?KzFwajlqU1NneVRhUmdKYnh4ZzJXUGZTZFZpTVpSVmZsT25xajhUbTVLNTdK?= =?utf-8?B?QUt2SGlEZHZPYWw3UDlPUjNYOEFoclBxQkVzSUhWVEJhUGhLTklQMmxmUVdv?= =?utf-8?B?UHVzL3FtTndremNvOUxDM2NGNERmRnVXN1RMVTZFT0NIV2ZCT1lPeFBnYURp?= =?utf-8?B?VDNRTkNKb0NacnBQRFM5YnVhRzhsL3B1cUQydCtlZFZlRmRGQWwrdkpCUWRy?= =?utf-8?B?S1UvNzRhdlhHcEJTRWtIb2hlM3Z6MTBGMzdZUDdrcE9JbWZIb21DdDVmMUNl?= =?utf-8?B?Rkg5Zzd1T2k5ZWp0SStodnJVekR6YlBKbXpnVjhybGtZV1Y3ZEc2d3NFYmVz?= =?utf-8?B?ZWVKeHg1U0NVeDNVMDB5bWNLbDR2Nlp4b0JVU0FxbGFmMjZIY0ZSbCtkVWpW?= =?utf-8?B?elo3MVZTNmhZZitFMk9qd1FHaHlMZGJjMTdBNzlrSGp3SjdNTksrRTVPU3hQ?= =?utf-8?B?VmVML2NNRG1iSnhtSnhBN0lxWmpJSjRRekM3L1dRS3VPRWZSTmFMVEIzUDcr?= =?utf-8?B?Q1BiZ2FScUNCSE0wU2tieW13dUk0d0JVOVUxSDdtM0dRbTE4ejA2Z0lBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmlNaWFvRnc1SldNRjh6aTMyZzc1U1EyUG4zdFhNUWEvZ2VJMzRjV0p5dTFx?= =?utf-8?B?aWxwMktRTTdreHB0RXdNUFE5QVNiTmtRMms0TVB5SHN0UkJSTmRrM3VvOU9h?= =?utf-8?B?L1pPZFI0MmV5L2dtek40ZTB3SjNnTkRmb2lNajlPMG5HRFhKSGJjNkt0QVhP?= =?utf-8?B?UW0rNTcyQ3hJZTFWOFg3ZTlYZTlQRXFmeGl2VHZ2bHBSN2JMTUsvZTJ2RmpU?= =?utf-8?B?aUIwTEphSnRYU3VxRkFHeWJQVE1UTVdUOWpZZXN2R2ZoMDlvUW1jMkM4MjRn?= =?utf-8?B?SWdmWkR1eFJLNTNhWndFSGJkV3YxUVlCTG9yM2tVZWxEQ241ZHo4aHV6TC9M?= =?utf-8?B?MlR1MWNVSmJ5NGxCcHI5NWI4ME1ka295cDRDU3FDdXAyYWlUSW9hNG1ZV2dT?= =?utf-8?B?aU9pYVB2alJlejd0S29HUlVXVGRpMmRhUVhLV3haRmQ2bU14bTNXTitJRDI4?= =?utf-8?B?SGtqa1MvUVU3YTdXL0VjQXVwRU1EZUQvcTdSVWR6cU1qWjZIdmxHcWg3N1Ft?= =?utf-8?B?YjlpWW9PZEFTNHFHQXJ0SWFqOEtVRXNGTHl5bFdkVXFjTnFrV0lTeVd2QWxS?= =?utf-8?B?TnB2SENCZk9vZ2VoUGEycFNPSVA0YXlzRzI0MVhacWJ3MFREQUJuUzAxaDFL?= =?utf-8?B?ZkFicFYzQ0xqNkR1RDUycUF5S2k3RFpnN3pJcjYvRGNMVStYZDUvK3ZmZjA1?= =?utf-8?B?cTVUMWdSSWpQU0kzb1NUSXkvS2duVEtRL3BtVkpiRW0zL3NpTWZ4REhqck0r?= =?utf-8?B?VnFYVmJNRHUyeWZpZGJiWC9BUzhkR004SG40TGdPQ1ZVdmhyTDZwR1dxaXpt?= =?utf-8?B?Z1lVOTJYVEhWaGpVQVp3WmZYWEpKZjYvb2p4ajEyMmxMaWZUdVFaWHRocWsv?= =?utf-8?B?OEN4WUg0M1RSV1ZXZEhveGsvTk9SZS9OSTdDQXRZUUV3RHV4VzZ2YXdub0sy?= =?utf-8?B?UmV1dkh4OFdwakprRytHZGwzcnRBVjFIa3hMNjNZbGkvSmxQaDJnRkhEZ1NN?= =?utf-8?B?OWdVQS84bVJrTWY3NDA2U0gyeEFyQ0QrY0MrZldLUzhyaWcxeGtHdHcrOTh4?= =?utf-8?B?a3JQL1h5UkU2Y0Y0WC9HSWlFeGRERW5FZ0dYZ3dzY2NQRzNNeDBwSFNNRWtx?= =?utf-8?B?MmtMQ1N5SDFsL1NqVW9zZlBKdlorVVFieHRHNFVYbFY2L1ZWNWQyalo2RVhR?= =?utf-8?B?SHRVOGxEcHlmTGIzMjFJbEhQRXo3a05Za2dTNmR2R0J0M2NteGt6ZzdyS29H?= =?utf-8?B?V2ttTU5yQkdlZndLNFlLZGFZbzZNUittWHB5Ny9uZVVJWlRDOXN1eC85MTky?= =?utf-8?B?RG5JRzNuRUZTbThqY2ZwTXRhV2VzTUZFUnRrZzVndkc3elRWVVBneGFRN0tm?= =?utf-8?B?TG9Td2NRdDE5dEtMTDFYODErRDhGejYvZVNJY1BKTDRwcU0rY05hQzhFM0g3?= =?utf-8?B?d3NCQkg5UDNldVR0M0lWb3ROQmI3UHBGeE55MUt0MUpWbFh6YlYxTUhoaVJQ?= =?utf-8?B?R1pwcm5RMzU5WlFwZjZ3Zy9NWDQ2TTBUZ3lHTTc1YVFJOHBrV2RaOTdFQ245?= =?utf-8?B?YysyWEs0djIvYWJGZkJpRmZJNEZyQ29XOFpreU9TTS9WemI1VG1QSENQazNZ?= =?utf-8?B?UzkrdVpCRU4vWkRvbUZuWDVKRTF0aG03YXd1cUw5WkQrK3p0N1cxZEJxSTMy?= =?utf-8?B?MklzbDNpWWRRTFFlSVdyd3dtQ2h1NlZJL3hkU0ZtcnRGWC9MQzhSTTNPdFZO?= =?utf-8?B?OThaNzdQcWw1WmJWSDRFUERIRTZrdFpLTFJBeXdlYTNZTGhSYVduUVpUc1Za?= =?utf-8?B?TjVBWnBjQ2FjQlB6WS9KcmNoVGlKY0pwUW0yNVhqNEVlSnhLMVF0c3FrZ3pR?= =?utf-8?B?cTdac2xYUmtoUGVKYjlqRTl3UFpVd0pZcjY1Vlp1T3BwMmEyT2FKUUtVTkJU?= =?utf-8?B?c3ZhOFlLSk5MREw1WEpzbWp6bHZBQ3BVU1dSUmxrVWtqWkkwNmNaNDhmbHBh?= =?utf-8?B?LzloNjQ4b0ZzamVlam5EOWRaaEh4ZHR1VDRpRE5yOVljS1lRc1dVbkl1MmhW?= =?utf-8?B?WnB2N25RSjhuUzZhSzVmYnI5aDU2WGg2dUdWa0tlUllLY3V5NWM0ZTVzM3dO?= =?utf-8?B?T0FlWkFKQXpZMURjWTBYMCtZc2EzR2tyRjZsUlF6N0RmRG4vcCtjSWpSUmJB?= =?utf-8?B?c2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b076835-e5a7-4f15-7bdc-08dce168943f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2024 15:57:26.2218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ve0CqHTvEm5ByP6D4mOUkfDRQS3Bx7owjj8vc5SCJwBSkW/tEiqe02AFmAJTkqpgVZ213gm/TU+axFhidQyXjE9sDGEEDiO8c3docJDNsR8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5956 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 30, 2024 at 05:38:44PM +0200, David Marchand wrote: > On Fri, Sep 6, 2024 at 4:11 PM Bruce Richardson > wrote: > > > > The AVX-512 copy code in multiple drivers was incorrect for 32-bit as it > > assumed that each pointer was always 8B in size. > > > > Bruce Richardson (4): > > net/i40e: fix AVX-512 pointer copy on 32-bit > > net/ice: fix AVX-512 pointer copy on 32-bit > > net/iavf: fix AVX-512 pointer copy on 32-bit > > common/idpf: fix AVX-512 pointer copy on 32-bit > > > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 7 +++++++ > > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++ > > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 7 +++++++ > > drivers/net/ice/ice_rxtx_vec_avx512.c | 7 +++++++ > > 4 files changed, 28 insertions(+) > > Sorry, not directly related to this series, but as I was checking some > AVX512 patch, I suspect some drivers are missing runtime checks for > availability of some AVX512 instructions: > > $ for meson in $(git grep -l __AVX512[^_]*__ > 'drivers/**/meson.build'); do dir=$(dirname $meson); for flag in $(git > grep -ho __AVX512[^_]*__ $dir | sort -u); do flag=${flag%%__}; > flag=${flag##__}; git grep -ql > rte_cpu_get_flag_enabled.RTE_CPUFLAG_$flag $dir || echo > RTE_CPUFLAG_$flag check missing in $dir; done; done > > RTE_CPUFLAG_AVX512BW check missing in drivers/common/idpf > RTE_CPUFLAG_AVX512DQ check missing in drivers/common/idpf > RTE_CPUFLAG_AVX512F check missing in drivers/common/idpf > RTE_CPUFLAG_AVX512VL check missing in drivers/net/i40e > RTE_CPUFLAG_AVX512VL check missing in drivers/net/ice > > Maybe some flags are implictly available... worth a confirmation from > Intel in any case from my pov. > I think it would be good practice to explicitly check for all the AVX-512 extensions actually used. Ideally, as a cleanup, we should probably check for those listed (f, bw, dq and vl) once early in the config and reuse that value throughout the build, rather than having each and every PMD continually check them. /Bruce