From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94B5945A6C; Mon, 30 Sep 2024 19:52:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 870864060C; Mon, 30 Sep 2024 19:52:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 7CC6B4060C for ; Mon, 30 Sep 2024 19:52:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727718743; x=1759254743; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=i9mqCfVdPSPDhO7zE1WLDuRdpS9c6P/VTEeLpSWEAtQ=; b=ORCogLBcqgQ3myn9b8ncyZzcx4JvXXfEtlDr3yogrUtZjC4/VVu1cqaW 8aSSMZx8RIhRZYBlYBmPKGVwKAluwoWOuKeoQWch1qSC5eQF0z/uQagBV d5Uz7tlIsouB1bIK9wiibc8smzLGF5QfhRspLNmKCUDHW1776pPmixoiO dx70AG63nBZTsRasoFziMddd1HmGqI+iN/q/RfRLZHMhT116boabNDXEn cClk7vi4aBzaGEdpTukPFD13Rlhe859oiVG6doCxwKx+nJ4U9B0k0PfiG u4jDck1ktQ4rQBKa0tuw2kTklnZykpGmx0+IiOIjxiof4c1D8feOtdWAF w==; X-CSE-ConnectionGUID: bBk99c07RdmV2VNu7jZ2Sw== X-CSE-MsgGUID: /1Awh70bQIqr65JSPYrc9A== X-IronPort-AV: E=McAfee;i="6700,10204,11211"; a="29708543" X-IronPort-AV: E=Sophos;i="6.11,166,1725346800"; d="scan'208";a="29708543" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 10:52:22 -0700 X-CSE-ConnectionGUID: FBEd/f5NTi6r2Mon8IkkHg== X-CSE-MsgGUID: 9FlQNsgHSbuGsP0cajDnfg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,166,1725346800"; d="scan'208";a="110875069" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Sep 2024 10:52:22 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 10:52:21 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 10:52:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 30 Sep 2024 10:52:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 30 Sep 2024 10:52:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fm+UAW9zlKSzfVcWOsnV7JzOcxRCxhf2xc4/xlGdLC1/va7qZPIimTaaOmqGAfS0iWv719t4uKM1vXKxjHBlSQcGMQ/Lz93WzVAQhe3os4wIXO/PLSBQv8xFcw7OneuvvnMcd3nvcoRwrY1+o+v/DOhAH4BUoqzfa/qw2CTOPXVqfBnHNWYthjsXzCIEmfa6W51G2H2wsljHgjjNW17PycRkPho+A5UniVDXhrTwp+hMX2xfoEhLxTY9AcKl65vh8z2IfA/4hukocF+fDX6gb5SyC70UmO+vToTz+Ia93M/ef4zIKwASsZiMS0iw3xDvtGW4mebFKVPq7U6mJnoXCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lwrvYrqICwXFLd5D367frr6urg4DfN6oZt0wyyJsm1o=; b=eU1+0sUIZzMBwPpOznmk1rWzJhsPfQ94Z2ov9Vt1Q5WSphHahSf8SH9PqqGvMb6a2kr5aaH33KXeymWbI3qXZeXgQlO9dNSTUZZEebYsTgv1Q1c3ooOK+LrAMv7o/bC1+wmhZqgY7XoIuxJdicYPkiALVkcXUIv6DyCtj8fsNxNlzOZjyDQpQvx98mjktAH51Gmjer02AbYARJLY2Eku7p/kZwDf7wbFktcbyPOPEUmJcvnple+pcXL8HrWbulNe0qMMFGtFYDr6nk5bbtRblXDjjJT45L/e+r5tYWy0llX/f49KALRAP7kf1jAyicDFAwq3OHSXln1R38Ke4dwQEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB4877.namprd11.prod.outlook.com (2603:10b6:a03:2d9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.26; Mon, 30 Sep 2024 17:52:15 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8005.024; Mon, 30 Sep 2024 17:52:15 +0000 Date: Mon, 30 Sep 2024 18:52:09 +0100 From: Bruce Richardson To: David Marchand CC: Ian Stokes , , Robin Jarry Subject: Re: [PATCH 0/4] fix issues with using AVX-512 drivers on 32-bit Message-ID: References: <20240906141127.628873-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0118.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB4877:EE_ X-MS-Office365-Filtering-Correlation-Id: 2576b959-7013-4ae0-1bcc-08dce1789e67 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a3dYQVdsdFRyMjFaQTFTK3g1LzlGMUNsR3prT2dQVjQwSjluaThyUHd3N2I5?= =?utf-8?B?d0tXNnlHUS8ySnpTcXZGOTJaOW1kcFMxQ21RVFJCNWhmdXVlY0w1RWtTdkt3?= =?utf-8?B?ZFFpU0xnem1GUVZlRHR3dmhZbmlSRXRNeTJSWGxud0d6cHNSMk4xempONnhs?= =?utf-8?B?U0xVaUtlR0lrSVRMSWpkckxmVFR3ZFdYcGZNM0F3T1hxNzMyaklSYVBIRUQr?= =?utf-8?B?SG04YzRvTVFnTHNvWnlvdmQrS3dZV0kxUkVsOFpjNk15b0ZDMk5BeXQ1Wlgw?= =?utf-8?B?RlNCNEFud3ZLclhreEhNQXpLVk43U2Y5MU5uV3grTVcrZlNjOEt5RWdOaW9V?= =?utf-8?B?Z0FZc0kxc2J3TU4yZFI3bm9sYlRFSzRiendCa2J0ZEw4YkVicGlnVkV3M0Fa?= =?utf-8?B?RGhvdWFIeFRvNlArL29ObkJzMmNKaE5FR3hiZVJ1RHFBdlBiMHFkRytBdmoy?= =?utf-8?B?YitHbFMxWk96c0JML2xtYkt5OVdxdllTbEZPa3crdDRYWHFIdlZzbXE4N0tS?= =?utf-8?B?YTFYY0ZVODRnUUdyajduM3g3VytlSEVqS0JxTDAxanVpQ1dYSDZWOFdCRG5l?= =?utf-8?B?ZFhxWnJRYm5zOExHd0VkZVZCVGtGMmMwU1dFREIzM29RbC94UzA4ZzhKYUNG?= =?utf-8?B?cUNsQXlVNUdUVTZCbEVmazNPTkFRd0RPKzlKTzZoRTZ6a0VmVVh1WFYzSHhC?= =?utf-8?B?YVJlS1RnQzZ6S0dQZFdlN2I2Vk1JdGJ0M0VhcUtpNWRCSHBMeFp6cjJCcTda?= =?utf-8?B?UGZFYmJZUkFYdjhUZE81a2tacDJYNFh5QnFnZHEydmdjSWlrSXNadVJibCsz?= =?utf-8?B?alZFNkhucDRRWHZseG1aUFpqMWh5enlVMjgxYVZxbVM3QXRMc1BEVm94ZEdP?= =?utf-8?B?ZGJKMHFxK2dnZEQ2MWtmdTJSbHBtSTM1U3ltSEpZLzhGYkdCYURVQnRJMDVU?= =?utf-8?B?ZE9jTnZuakpHZFlVQ3A1c3N2aytneTM0UlBJaFBqanptUkVYVmdWWWNkUzg3?= =?utf-8?B?a1owKzlqUHU5ZTc2Y1dQOXhtTXJDdmp1cE03emNNczNaNEtpcXRUeWpqWEFN?= =?utf-8?B?VTBEbHJ3dlZUTTFnUjRhS1RsOEZBbVlZei80ZW4zdnhYM2FadDk4cnNKM1Fl?= =?utf-8?B?L1lIODVxeDdkWGZiUUkreTBPaGhhUFdOaUhaVlF2NVRGMENyR2tPazF0S3RB?= =?utf-8?B?MHQ2cjdkZm1DejRWNkptNWNJdVF5Skp1UHFCaHF5bGlleE0rWU1OSXhVK0ZS?= =?utf-8?B?QUFJSy81Z3NFL1VSdFlnaDlKWlZ6OW5Wa1QyckFvTExDMnRJMW1NNk1YenlI?= =?utf-8?B?STVkanU0K2gvY1RWam85eVhCV3NSZHp0emRSUjVyZlAzSFlmZEtqTGVzMHdo?= =?utf-8?B?WklOQWt6YjY4WFNJOTRoc1QrblR4Nmh0VVdBKzUvYWpreGJQVkovVTRaMXhJ?= =?utf-8?B?cG9tNmJJQWJqai81K1lMMTUrcUJaZFQ3dkVoREJEd0dodldMM3VIa0FjdFNj?= =?utf-8?B?bWZLUVBySmFZZXdUNWJWdjNOVEJpZ0ZGbThuUHdCVnd6bFhVRUVteFFnekpB?= =?utf-8?B?RDNDU0RpdW1qZDJGSVdNVjNmOXpqR1NwNm5oZVd3Z1lLRVptVWgvK0l0OWZI?= =?utf-8?B?ZWFFMXdXSDBGOEwzVmJGcDVwZkdRS09zRGFCMFFaRXIzNmJtMjEwNlpNa3g3?= =?utf-8?B?TEZEdS9uT1R6dUVldncwbDlMN1h0b1ZEZ2hrOUJpREFGRHpVL1dKbTZ3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0RCZnB3a2xYblR6WW56UkprYWdIMGxodXNoZ2g2WGp6ejhoeHlrZy9iNlpt?= =?utf-8?B?OFRxRTVtNmVvd284eVVNaEh5SytIVFBueEZRM2lnWXlJSzJFOVNseWV1aFBj?= =?utf-8?B?UG8vWHlUVTlhdlVwT1R3anB2emdDZG43QXh3YlljY2U4Z0ExZElXWlNDSkdE?= =?utf-8?B?R2RsN0lzTXpPcUd2a0s1U1oyc0c3UTd5cjNNb2xnZ1hKWGVERVVlRnJ0bnpG?= =?utf-8?B?cmJ4SFFjTXJPLy8xZmVnMkppczI0OVE1d0V3aGVKbFVicjZpblJxS2psQWdB?= =?utf-8?B?ZlUzc0pmbWdtc3hFWllweU9zbjZZVHorbHBEbGE4MFowb25uN2h5WDJXeG4y?= =?utf-8?B?dWxQZXJETFRpdkZmeGdjMlZqcHZPRkJuWkRrbmp4eTluVEtSNVZBSkJFd0ZM?= =?utf-8?B?b2pMQk1Rc0ZhMDJnbHNDakNjM3RTQXM4RmU4bnJNbHRWcUFsWGpkZmh0WVBz?= =?utf-8?B?WE5XVHpDL2NtMmFPVUlmdWkrbllNd2tnMkc2VEh4cE10VzZUb21EbGZHQWxj?= =?utf-8?B?N0ZmT284L2NJTTZVWExBa0s0UGlic0FvTGhJcmtMY2ROcjZDZ05RSHB3Z2FH?= =?utf-8?B?NE9PZW9JY21yd1dYR2piVC84T3NUZ0ZpbVoxM1FWNlhKTFV1ZFhCakZiWkVG?= =?utf-8?B?cE9hNTR6QzRDOFEyNWpjU0NsVGtwNThCazFQdVlKbk1mMXdhTk9naHpVb29N?= =?utf-8?B?WHNFZVdEWnZxREw2ODE2WXlhME55cy9IMmdTdVM1T2hzM1d1bmYxcmFxVnlB?= =?utf-8?B?NkIvL2JKWDdzSEw4OWdscUN2Z2hIOHJqSU92TkNpbFdQK0ExaTU2bURJOVJt?= =?utf-8?B?NGxTaUxBazlZYlRLNE9XVWFlZTcvZGxMYncxbEdKN3dSYmRqTkZXclN2dFpm?= =?utf-8?B?bjdFcHZ1NVVUVXNuR1FjTitQVjlzU3dHWWh4Wk4ycTJqOGlSKzJYTWhtSWFl?= =?utf-8?B?VUNiNHh0emlCQk9uSTVFaE1USGVPYUJKQmQ5MjM2cWYxSjdaN1JNZmU2OWNL?= =?utf-8?B?c3NTdkpHTTZNOW1rSHBHOVFaVVhmb25JNTdMTDEyUWlyYlFnQldNZWYzWDEw?= =?utf-8?B?eGVqOFRvSHUvUThZMEs0SWNleUwwZzZydzloa21Hb1ZvUTEwdTg1MkduNGhn?= =?utf-8?B?clc1bE5lR0NyaE40UHZrWTNrclJVNHB4a3kyRG5uQVdvYjV4Rk1UaXJiRitI?= =?utf-8?B?RWROWmJ6bzQ3ZlQyNlJ0ajhYOXNDcWlzajRxVVk3UWE0M0xTQ1dRbHF2Q1p0?= =?utf-8?B?RDFsd3AveHI4NmM1a2VIWmNyLzJ5a1F4ZWpGMXdSUnFuMG9lNUVBTEhCWlZM?= =?utf-8?B?M1pyVWdaWE1sUlE3RW8zTWE3alVaMTV0ekhmWEw5ZUlNMm8wbzAyTDlPdFpR?= =?utf-8?B?VllCOEI0TU94VFRrRW5WazVCMmxTbkFzQlBXanhlRG5YT3FrTFRhQ0FBWTFh?= =?utf-8?B?cGJoejBoazA3M1NhN1pHZnFxSTRUMkY2MUFWMXRLZDFMdUpMcGpHSW94VHZV?= =?utf-8?B?c0VtZGJqT0lIQ0pkRnI4SCtGbW5ZeHFqNlhjRlRUTHNtT2lNTmtseXp5TWFQ?= =?utf-8?B?Ymp1aEpYdHRRY201MzZXRGZwUFhqTkVqWm1RcUo1UlhHdlBlUzAxbUJ2UTZh?= =?utf-8?B?bmlWY0x6QlNEUFMvNHpqaUlpWjVmQ25yZWJIaWpTYzNQRzF6N01lN0g1a2x3?= =?utf-8?B?NVEvdFEzNFdPK3ZYMTBxUTV2bDlVZzBSbXNFY3AzS3ZWN1pJWWRjWndiY3JF?= =?utf-8?B?M0lVVzJFaWFWNkNycU11U0NXNTA3VTVxMG55THpKUlBNVzQ5bmhuMlgyWk1o?= =?utf-8?B?d3hlRnRRb2hpWTZURlNnQnN0ZHhDUjVnUlZlSUJtM0p5UzVrUjQycnVIM1lY?= =?utf-8?B?ZHpXTGdJazJmYnhEL3BVckZkVjZPK3pGQTdKVWV0Um5oWVkvOFo0UGhFRUVZ?= =?utf-8?B?ek9UVVBqcHUzak5UNGludE5XSzlYM3BMUXFVdXphVGdRMjhXMVpmcnFOUGc3?= =?utf-8?B?ajZuWE1ISEVsVGNMY1A0ZE9UV1hzSkUzTlJ5UG1FMW5GaFpqNkc0ZnFLSTl2?= =?utf-8?B?ZjJ1L0dYek85MTNhWmVGeDVhWGd4d0xUa2QvYzRkTDZYaGVKYmg0YS8xdTNO?= =?utf-8?B?amI2NDBhZHZMbG56eXRUVm8zZkNwb1dKOFNWVlBJNm1kYytxVXg3RVIrbzQ5?= =?utf-8?B?NEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2576b959-7013-4ae0-1bcc-08dce1789e67 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2024 17:52:15.1753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W1Tx9YxM2Ff6R9GKqkkcrD7fNSsLvAOSaYfRpVTreMsaLOo2Hfy6/uSz+EkI+R/mUf6vzET3USuVjdhSzEHh68+L4IY2dMBP3TKiw1LN8so= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4877 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 30, 2024 at 04:57:21PM +0100, Bruce Richardson wrote: > On Mon, Sep 30, 2024 at 05:38:44PM +0200, David Marchand wrote: > > On Fri, Sep 6, 2024 at 4:11 PM Bruce Richardson > > wrote: > > > > > > The AVX-512 copy code in multiple drivers was incorrect for 32-bit as it > > > assumed that each pointer was always 8B in size. > > > > > > Bruce Richardson (4): > > > net/i40e: fix AVX-512 pointer copy on 32-bit > > > net/ice: fix AVX-512 pointer copy on 32-bit > > > net/iavf: fix AVX-512 pointer copy on 32-bit > > > common/idpf: fix AVX-512 pointer copy on 32-bit > > > > > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 7 +++++++ > > > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++ > > > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 7 +++++++ > > > drivers/net/ice/ice_rxtx_vec_avx512.c | 7 +++++++ > > > 4 files changed, 28 insertions(+) > > > > Sorry, not directly related to this series, but as I was checking some > > AVX512 patch, I suspect some drivers are missing runtime checks for > > availability of some AVX512 instructions: > > > > $ for meson in $(git grep -l __AVX512[^_]*__ > > 'drivers/**/meson.build'); do dir=$(dirname $meson); for flag in $(git > > grep -ho __AVX512[^_]*__ $dir | sort -u); do flag=${flag%%__}; > > flag=${flag##__}; git grep -ql > > rte_cpu_get_flag_enabled.RTE_CPUFLAG_$flag $dir || echo > > RTE_CPUFLAG_$flag check missing in $dir; done; done > > > > RTE_CPUFLAG_AVX512BW check missing in drivers/common/idpf > > RTE_CPUFLAG_AVX512DQ check missing in drivers/common/idpf > > RTE_CPUFLAG_AVX512F check missing in drivers/common/idpf > > RTE_CPUFLAG_AVX512VL check missing in drivers/net/i40e > > RTE_CPUFLAG_AVX512VL check missing in drivers/net/ice > > > > Maybe some flags are implictly available... worth a confirmation from > > Intel in any case from my pov. > > > > I think it would be good practice to explicitly check for all the AVX-512 > extensions actually used. Ideally, as a cleanup, we should probably check > for those listed (f, bw, dq and vl) once early in the config and reuse that > value throughout the build, rather than having each and every PMD > continually check them. > Draft patchset for this now submitted to dev list [1]. Reviews and feedback welcome, as always! /Bruce [1] https://patches.dpdk.org/project/dpdk/list/?series=33188